31495 2009-11-13 14:52:45 -0800 LayoutTests/storage/hash-change-with-xhr.html does not need the call to dumpDatabaseCallbacks() 2009-11-13 15:24:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 dumi dumi dglazkov michaeln oldest_to_newest 163538 0 dumi 2009-11-13 14:52:45 -0800 LayoutTests/storage/hash-charge-with-xhr.html has an unnecessary call to dumpDatabaseCallbacks(). We should remove it. 163539 1 43206 dumi 2009-11-13 14:53:59 -0800 Created attachment 43206 patch 163542 2 dglazkov 2009-11-13 14:58:30 -0800 Will this affect test results? 163543 3 43206 eric 2009-11-13 14:59:51 -0800 Comment on attachment 43206 patch OK. I'm surprised this doesn't require results updates? 163545 4 dumi 2009-11-13 15:01:51 -0800 (In reply to comment #2) > Will this affect test results? It shouldn't. Ben said that the only reason they had that line there is to check for quota problems. However, there's no way this test is going to exceed a 5MB quota (they're only requesting 100K), so Ben agreed that this call is no longer needed. I ran all storage/ layout tests and they all passed. 163554 5 dumi 2009-11-13 15:24:22 -0800 Landed as r50969. 43206 2009-11-13 14:53:59 -0800 2009-11-13 14:59:51 -0800 patch patch text/plain 1056 dumi SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwOTY4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTMgIER1bWl0cnUgRGFuaWxpdWMg IDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgdGhlIHVubmVjZXNzYXJ5IGNhbGwgdG8gZHVtcERhdGFiYXNl Q2FsbGJhY2tzKCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMxNDk1CisKKyAgICAgICAgKiBzdG9yYWdlL2hhc2gtY2hhbmdlLXdpdGgteGhyLmh0 bWw6CisKIDIwMDktMTEtMTMgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9y YWdlL2hhc2gtY2hhbmdlLXdpdGgteGhyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv c3RvcmFnZS9oYXNoLWNoYW5nZS13aXRoLXhoci5odG1sCShyZXZpc2lvbiA1MDk2NikKKysrIExh eW91dFRlc3RzL3N0b3JhZ2UvaGFzaC1jaGFuZ2Utd2l0aC14aHIuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtOTYsNyArOTYsNiBAQCBmdW5jdGlvbiBpbnZva2VCYWNrKCkKIGZ1bmN0aW9uIHJ1blRl c3QoKQogewogICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKLSAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcERhdGFiYXNlQ2FsbGJhY2tzKCk7CiAgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIud2FpdFVudGlsRG9uZSgpOwogICAgIH0K