31491 2009-11-13 14:04:44 -0800 DOMHTMLOptionElement is missing some implementation 2009-11-17 15:40:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 jhoneycutt jhoneycutt oldest_to_newest 163507 0 jhoneycutt 2009-11-13 14:04:44 -0800 DOMHTMLOptionElement::text() and DOMHTMLOptionElement::label() are stubs. 163519 1 43201 jhoneycutt 2009-11-13 14:16:37 -0800 Created attachment 43201 patch 163547 2 43201 mitz 2009-11-13 15:06:26 -0800 Comment on attachment 43201 patch > + ASSERT(m_element && m_element->hasTagName(optionTag)); Please split into two assertions. > + ASSERT(m_element && m_element->hasTagName(optionTag)); Ditto. 164366 3 jhoneycutt 2009-11-17 15:40:32 -0800 I made Dan's change. Landed in r51093. 43201 2009-11-13 14:16:37 -0800 2009-11-13 15:06:25 -0800 patch 0004-DOMHTMLOptionElement-is-missing-some-functionality.patch text/plain 2912 jhoneycutt RnJvbSBjYzE2YTc4OWU0NGMwMDJkY2FkOWY1YmY5YzYzZDFhNmIxYWVlOWMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogRnJpLCAxMyBOb3YgMjAwOSAxMzo1Nzo1NiAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIERP TUhUTUxPcHRpb25FbGVtZW50IGlzIG1pc3Npbmcgc29tZSBmdW5jdGlvbmFsaXR5LgoKaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDkxCgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogRE9NSFRNTENsYXNzZXMuY3BwOgooRE9NSFRNTE9wdGlvbkVsZW1lbnQ6 OnRleHQpOgpDYXN0IG1fZWxlbWVudCB0byBhbiBIVE1MT3B0aW9uRWxlbWVudCwgYW5kIGNhbGwg aXRzIHRleHQoKSBmdW5jdGlvbi4KKERPTUhUTUxPcHRpb25FbGVtZW50OjpsYWJlbCk6CkRpdHRv LCBmb3IgbGFiZWwoKS4KLS0tCiBXZWJLaXQvd2luL0NoYW5nZUxvZyAgICAgICAgICB8ICAgMTQg KysrKysrKysrKysrKysKIFdlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuY3BwIHwgICAyOCArKysr KysrKysrKysrKysrKysrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMo KyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cgYi9X ZWJLaXQvd2luL0NoYW5nZUxvZwppbmRleCA2MDE5Nzk1Li45NmFjNzNhIDEwMDY0NAotLS0gYS9X ZWJLaXQvd2luL0NoYW5nZUxvZworKysgYi9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE5IEBACiAyMDA5LTExLTEyICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+ CiAKKyAgICAgICAgRE9NSFRNTE9wdGlvbkVsZW1lbnQgaXMgbWlzc2luZyBzb21lIGZ1bmN0aW9u YWxpdHkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBET01IVE1MQ2xhc3Nlcy5jcHA6CisgICAgICAgIChET01IVE1MT3B0aW9uRWxlbWVudDo6dGV4 dCk6CisgICAgICAgIENhc3QgbV9lbGVtZW50IHRvIGFuIEhUTUxPcHRpb25FbGVtZW50LCBhbmQg Y2FsbCBpdHMgdGV4dCgpIGZ1bmN0aW9uLgorICAgICAgICAoRE9NSFRNTE9wdGlvbkVsZW1lbnQ6 OmxhYmVsKToKKyAgICAgICAgRGl0dG8sIGZvciBsYWJlbCgpLgorCisyMDA5LTExLTEyICBKb24g SG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKICAgICAgICAgRE9NSFRNTFNlbGVj dEVsZW1lbnQgaXMgbWlzc2luZyBzb21lIGltcGxlbWVudGF0aW9uLgogCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ4OQpkaWZmIC0tZ2l0IGEvV2Vi S2l0L3dpbi9ET01IVE1MQ2xhc3Nlcy5jcHAgYi9XZWJLaXQvd2luL0RPTUhUTUxDbGFzc2VzLmNw cAppbmRleCBhZjdhOGRjLi5mMzQ5NzAwIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL0RPTUhUTUxD bGFzc2VzLmNwcAorKysgYi9XZWJLaXQvd2luL0RPTUhUTUxDbGFzc2VzLmNwcApAQCAtODU0LDEw ICs4NTQsMTggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01IVE1MT3B0aW9uRWxlbWVu dDo6c2V0RGVmYXVsdFNlbGVjdGVkKAogfQogICAgIAogSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQ RSBET01IVE1MT3B0aW9uRWxlbWVudDo6dGV4dCggCi0gICAgICAgIC8qIFtyZXR2YWxdW291dF0g Ki8gQlNUUiogLypyZXN1bHQqLykKKyAgICAgICAgLyogW3JldHZhbF1bb3V0XSAqLyBCU1RSKiBy ZXN1bHQpCiB7Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIEVfTk9USU1Q TDsKKyAgICBpZiAoIXJlc3VsdCkKKyAgICAgICAgcmV0dXJuIEVfUE9JTlRFUjsKKworICAgICpy ZXN1bHQgPSAwOworCisgICAgQVNTRVJUKG1fZWxlbWVudCAmJiBtX2VsZW1lbnQtPmhhc1RhZ05h bWUob3B0aW9uVGFnKSk7CisgICAgSFRNTE9wdGlvbkVsZW1lbnQqIG9wdGlvbkVsZW1lbnQgPSBz dGF0aWNfY2FzdDxIVE1MT3B0aW9uRWxlbWVudCo+KG1fZWxlbWVudCk7CisKKyAgICAqcmVzdWx0 ID0gQlN0cmluZyhvcHRpb25FbGVtZW50LT50ZXh0KCkpLnJlbGVhc2UoKTsKKyAgICByZXR1cm4g U19PSzsKIH0KICAgICAKIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NSFRNTE9wdGlvbkVs ZW1lbnQ6OmluZGV4KCAKQEAgLTg4MiwxMCArODkwLDE4IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FM TFRZUEUgRE9NSFRNTE9wdGlvbkVsZW1lbnQ6OnNldERpc2FibGVkKAogfQogICAgIAogSFJFU1VM VCBTVERNRVRIT0RDQUxMVFlQRSBET01IVE1MT3B0aW9uRWxlbWVudDo6bGFiZWwoIAotICAgICAg ICAvKiBbcmV0dmFsXVtvdXRdICovIEJTVFIqIC8qcmVzdWx0Ki8pCisgICAgICAgIC8qIFtyZXR2 YWxdW291dF0gKi8gQlNUUiogcmVzdWx0KQogewotICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwot ICAgIHJldHVybiBFX05PVElNUEw7CisgICAgaWYgKCFyZXN1bHQpCisgICAgICAgIHJldHVybiBF X1BPSU5URVI7CisKKyAgICAqcmVzdWx0ID0gMDsKKworICAgIEFTU0VSVChtX2VsZW1lbnQgJiYg bV9lbGVtZW50LT5oYXNUYWdOYW1lKG9wdGlvblRhZykpOworICAgIEhUTUxPcHRpb25FbGVtZW50 KiBvcHRpb25FbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTE9wdGlvbkVsZW1lbnQqPihtX2VsZW1l bnQpOworCisgICAgKnJlc3VsdCA9IEJTdHJpbmcob3B0aW9uRWxlbWVudC0+bGFiZWwoKSkucmVs ZWFzZSgpOworICAgIHJldHVybiBTX09LOwogfQogICAgIAogSFJFU1VMVCBTVERNRVRIT0RDQUxM VFlQRSBET01IVE1MT3B0aW9uRWxlbWVudDo6c2V0TGFiZWwoIAotLSAKMS42LjUuMi4xNDMuZzhj YzYyCgo=