31490 2009-11-13 14:02:51 -0800 Allow building Chromium without SVG 2009-11-15 17:09:50 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Other All RESOLVED INVALID P2 Minor --- 1 evan webkit-unassigned abarth oldest_to_newest 163497 0 evan 2009-11-13 14:02:51 -0800 I don't use SVG in my day-to-day debugging and it's a bunch of extra code for the compiler, linker, etc. to move around. I measured it at around 14.5% of the resulting binary size of a Debug build. We should allow building without SVG. 163508 1 43195 evan 2009-11-13 14:04:59 -0800 Created attachment 43195 patch that is correct regardless of this bug 163509 2 43196 evan 2009-11-13 14:05:31 -0800 Created attachment 43196 wip patch 163510 3 43197 evan 2009-11-13 14:07:43 -0800 Created attachment 43197 wrap some code with ENABLE(SVG) 163795 4 43197 abarth 2009-11-15 15:29:40 -0800 Comment on attachment 43197 wrap some code with ENABLE(SVG) Clearing flags on attachment: 43197 Committed r51004: <http://trac.webkit.org/changeset/51004> 163796 5 abarth 2009-11-15 15:29:46 -0800 All reviewed patches have been landed. Closing bug. 163802 6 evan 2009-11-15 16:10:09 -0800 still not done 163806 7 abarth 2009-11-15 16:40:24 -0800 (In reply to comment #6) > still not done Please use a new bug. We try to use one patch per bug. You can create a meta bug if you think people would like to track all the patches. 163808 8 evan 2009-11-15 16:41:19 -0800 The patch you committed for me does not let us bulid without SVG; it was just the part of the patch I'd written that was inarguably correct. 163810 9 abarth 2009-11-15 16:46:38 -0800 What's the cost of making a new bug? I'm the only person on the CC list of this bug. If you create a new bug, then people trying to understand that patch will be saved from trying to understand the 9+ comments on this bug. If you'd like to see how the project manages a task that requires lots of patches, one example is <https://bugs.webkit.org/show_bug.cgi?id=29947>. 163816 10 evan 2009-11-15 17:09:50 -0800 ok https://bugs.webkit.org/show_bug.cgi?id=31522 43195 2009-11-13 14:04:59 -0800 2009-11-13 14:10:40 -0800 patch that is correct regardless of this bug bug-31490-20091113140431.patch text/plain 933 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcCBiL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAppbmRleCA1MGU2MzUxLi5kNzQ0ODg2IDEw MDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKKysrIGIvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCkBAIC0xNDkzLDEwICsxNDkzLDEyIEBA IFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gVjhET01XcmFwcGVyOjpnZXRFdmVudExpc3RlbmVy KE5vZGUqIG5vZGUsIHY4OjpMb2NhbDx2CiAgICAgcmV0dXJuIChsb29rdXAgPT0gTGlzdGVuZXJG aW5kT25seSkgPyBWOEV2ZW50TGlzdGVuZXJMaXN0OjpmaW5kV3JhcHBlcih2YWx1ZSwgaXNBdHRy aWJ1dGUpIDogVjhFdmVudExpc3RlbmVyTGlzdDo6ZmluZE9yQ3JlYXRlV3JhcHBlcjxWOEV2ZW50 TGlzdGVuZXI+KHZhbHVlLCBpc0F0dHJpYnV0ZSk7CiB9CiAKKyNpZiBFTkFCTEUoU1ZHKQogUGFz c1JlZlB0cjxFdmVudExpc3RlbmVyPiBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlzdGVuZXIoU1ZH RWxlbWVudEluc3RhbmNlKiBlbGVtZW50LCB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgYm9v bCBpc0F0dHJpYnV0ZSwgTGlzdGVuZXJMb29rdXBUeXBlIGxvb2t1cCkKIHsKICAgICByZXR1cm4g Z2V0RXZlbnRMaXN0ZW5lcihlbGVtZW50LT5jb3JyZXNwb25kaW5nRWxlbWVudCgpLCB2YWx1ZSwg aXNBdHRyaWJ1dGUsIGxvb2t1cCk7CiB9CisjZW5kaWYKIAogUGFzc1JlZlB0cjxFdmVudExpc3Rl bmVyPiBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlzdGVuZXIoQWJzdHJhY3RXb3JrZXIqIHdvcmtl ciwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wgaXNBdHRyaWJ1dGUsIExpc3RlbmVy TG9va3VwVHlwZSBsb29rdXApCiB7 43196 2009-11-13 14:05:31 -0800 2009-11-13 14:05:31 -0800 wip patch bug-31490-20091113140503.patch text/plain 3805 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4IGViMTBlZWUuLmI4YWVjZTMgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5 cC9XZWJDb3JlLmd5cApAQCAtNTcwLDggKzU3MCw4IEBACiAgICAgICAgICMgQWRkaXRpb25hbCAu Y3BwIGZpbGVzIGZyb20gd2ViY29yZV9iaW5kaW5nc19zb3VyY2VzIGFjdGlvbnMuCiAgICAgICAg ICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvSFRNTEVsZW1lbnRGYWN0b3J5LmNw cCcsCiAgICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvSFRNTE5hbWVz LmNwcCcsCi0gICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvU1ZHRWxl bWVudEZhY3RvcnkuY3BwJywKLSAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dl YmtpdC9TVkdOYW1lcy5jcHAnLAorICAgICAgICAjJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIp L3dlYmtpdC9TVkdFbGVtZW50RmFjdG9yeS5jcHAnLAorICAgICAgICAjJzwoU0hBUkVEX0lOVEVS TUVESUFURV9ESVIpL3dlYmtpdC9TVkdOYW1lcy5jcHAnLAogICAgICAgICAnPChTSEFSRURfSU5U RVJNRURJQVRFX0RJUikvd2Via2l0L1VzZXJBZ2VudFN0eWxlU2hlZXRzRGF0YS5jcHAnLAogICAg ICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L1hMaW5rTmFtZXMuY3BwJywK ICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9YTUxOYW1lcy5jcHAn LApAQCAtNjcyLDYgKzY3MiwxMiBAQAogCiAgICAgICAgICMgRXhjbHVkZSBzb21lIERCLXJlbGF0 ZWQgZmlsZXMuCiAgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS9zcWwvU1FMaXRlRmlsZVN5 c3RlbS5jcHAnXSwKKworICAgICAgICBbJ2V4Y2x1ZGUnLCAnc3ZnLyddLAorICAgICAgICBbJ2V4 Y2x1ZGUnLCAnY3NzL1NWRyddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAncmVuZGVyaW5nL3N0eWxl L1NWRyddLAorICAgICAgICBbJ2V4Y2x1ZGUnLCAncmVuZGVyaW5nL1JlbmRlclNWRyddLAorICAg ICAgICBbJ2V4Y2x1ZGUnLCAncmVuZGVyaW5nL1NWRyddLAogICAgICAgXSwKICAgICAgICdzb3Vy Y2VzISc6IFsKICAgICAgICAgIyBBIGZldyB0aGluZ3MgY2FuJ3QgYmUgZXhjbHVkZWQgYnkgcGF0 dGVybnMuICBMaXN0IHRoZW0gaW5kaXZpZHVhbGx5LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJD b3JlLmd5cGkgYi9XZWJDb3JlL1dlYkNvcmUuZ3lwaQppbmRleCBiZGRjYWMyLi4zODQwY2I1IDEw MDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQorKysgYi9XZWJDb3JlL1dlYkNvcmUuZ3lw aQpAQCAtMSw4ICsxLDYgQEAKIHsKICAgICAndmFyaWFibGVzJzogewogICAgICAgICAnd2ViY29y ZV9iaW5kaW5nc19pZGxfZmlsZXMnOiBbCi0KLSAgICAgICAgICAgICNJREwgZmlsZXMKICAgICAg ICAgICAgICdjc3MvQ1NTQ2hhcnNldFJ1bGUuaWRsJywKICAgICAgICAgICAgICdjc3MvQ1NTRm9u dEZhY2VSdWxlLmlkbCcsCiAgICAgICAgICAgICAnY3NzL0NTU0ltcG9ydFJ1bGUuaWRsJywKQEAg LTIwOCw2ICsyMDYsMjggQEAKICAgICAgICAgICAgICdzdG9yYWdlL1NRTFRyYW5zYWN0aW9uLmlk bCcsCiAgICAgICAgICAgICAnc3RvcmFnZS9TdG9yYWdlLmlkbCcsCiAgICAgICAgICAgICAnc3Rv cmFnZS9TdG9yYWdlRXZlbnQuaWRsJywKKyAgICAgICAgICAgICd3ZWJzb2NrZXRzL1dlYlNvY2tl dC5pZGwnLAorICAgICAgICAgICAgJ3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsJywKKyAgICAg ICAgICAgICd3b3JrZXJzL0RlZGljYXRlZFdvcmtlckNvbnRleHQuaWRsJywKKyAgICAgICAgICAg ICd3b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwnLAorICAgICAgICAgICAgJ3dvcmtlcnMvU2hhcmVk V29ya2VyQ29udGV4dC5pZGwnLAorICAgICAgICAgICAgJ3dvcmtlcnMvV29ya2VyLmlkbCcsCisg ICAgICAgICAgICAnd29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbCcsCisgICAgICAgICAgICAnd29y a2Vycy9Xb3JrZXJMb2NhdGlvbi5pZGwnLAorICAgICAgICAgICAgJ3htbC9ET01QYXJzZXIuaWRs JywKKyAgICAgICAgICAgICd4bWwvWE1MSHR0cFJlcXVlc3QuaWRsJywKKyAgICAgICAgICAgICd4 bWwvWE1MSHR0cFJlcXVlc3RFeGNlcHRpb24uaWRsJywKKyAgICAgICAgICAgICd4bWwvWE1MSHR0 cFJlcXVlc3RQcm9ncmVzc0V2ZW50LmlkbCcsCisgICAgICAgICAgICAneG1sL1hNTEh0dHBSZXF1 ZXN0VXBsb2FkLmlkbCcsCisgICAgICAgICAgICAneG1sL1hNTFNlcmlhbGl6ZXIuaWRsJywKKyAg ICAgICAgICAgICd4bWwvWFBhdGhFdmFsdWF0b3IuaWRsJywKKyAgICAgICAgICAgICd4bWwvWFBh dGhFeGNlcHRpb24uaWRsJywKKyAgICAgICAgICAgICd4bWwvWFBhdGhFeHByZXNzaW9uLmlkbCcs CisgICAgICAgICAgICAneG1sL1hQYXRoTlNSZXNvbHZlci5pZGwnLAorICAgICAgICAgICAgJ3ht bC9YUGF0aFJlc3VsdC5pZGwnLAorICAgICAgICAgICAgJ3htbC9YU0xUUHJvY2Vzc29yLmlkbCcs CisgICAgICAgIF0sCisgICAgICAgICd3ZWJjb3JlX2JpbmRpbmdzX2lkbF9zdmdfZmlsZXMnOiBb CiAgICAgICAgICAgICAnc3ZnL0VsZW1lbnRUaW1lQ29udHJvbC5pZGwnLAogICAgICAgICAgICAg J3N2Zy9TVkdBRWxlbWVudC5pZGwnLAogICAgICAgICAgICAgJ3N2Zy9TVkdBbHRHbHlwaEVsZW1l bnQuaWRsJywKQEAgLTM1NCwyNiArMzc0LDYgQEAKICAgICAgICAgICAgICdzdmcvU1ZHVmlld1Nw ZWMuaWRsJywKICAgICAgICAgICAgICdzdmcvU1ZHWm9vbUFuZFBhbi5pZGwnLAogICAgICAgICAg ICAgJ3N2Zy9TVkdab29tRXZlbnQuaWRsJywKLSAgICAgICAgICAgICd3ZWJzb2NrZXRzL1dlYlNv Y2tldC5pZGwnLAotICAgICAgICAgICAgJ3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsJywKLSAg ICAgICAgICAgICd3b3JrZXJzL0RlZGljYXRlZFdvcmtlckNvbnRleHQuaWRsJywKLSAgICAgICAg ICAgICd3b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwnLAotICAgICAgICAgICAgJ3dvcmtlcnMvU2hh cmVkV29ya2VyQ29udGV4dC5pZGwnLAotICAgICAgICAgICAgJ3dvcmtlcnMvV29ya2VyLmlkbCcs Ci0gICAgICAgICAgICAnd29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbCcsCi0gICAgICAgICAgICAn d29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5pZGwnLAotICAgICAgICAgICAgJ3htbC9ET01QYXJzZXIu aWRsJywKLSAgICAgICAgICAgICd4bWwvWE1MSHR0cFJlcXVlc3QuaWRsJywKLSAgICAgICAgICAg ICd4bWwvWE1MSHR0cFJlcXVlc3RFeGNlcHRpb24uaWRsJywKLSAgICAgICAgICAgICd4bWwvWE1M SHR0cFJlcXVlc3RQcm9ncmVzc0V2ZW50LmlkbCcsCi0gICAgICAgICAgICAneG1sL1hNTEh0dHBS ZXF1ZXN0VXBsb2FkLmlkbCcsCi0gICAgICAgICAgICAneG1sL1hNTFNlcmlhbGl6ZXIuaWRsJywK LSAgICAgICAgICAgICd4bWwvWFBhdGhFdmFsdWF0b3IuaWRsJywKLSAgICAgICAgICAgICd4bWwv WFBhdGhFeGNlcHRpb24uaWRsJywKLSAgICAgICAgICAgICd4bWwvWFBhdGhFeHByZXNzaW9uLmlk bCcsCi0gICAgICAgICAgICAneG1sL1hQYXRoTlNSZXNvbHZlci5pZGwnLAotICAgICAgICAgICAg J3htbC9YUGF0aFJlc3VsdC5pZGwnLAotICAgICAgICAgICAgJ3htbC9YU0xUUHJvY2Vzc29yLmlk bCcsCiAgICAgICAgIF0sCiAgICAgICAgICd3ZWJjb3JlX2ZpbGVzJzogWw== 43197 2009-11-13 14:07:43 -0800 2009-11-15 15:29:40 -0800 wrap some code with ENABLE(SVG) bug-31490-20091113140715.patch text/plain 1416 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzgwYTE5OS4uOTBmNzc1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0xMyAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXcmFwIHNvbWUgU1ZHIGNvZGUgaW4gVjhET01XcmFwcGVyIHdpdGggYW4g RU5BQkxFKFNWRykgdGVzdC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzE0OTAKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5j cHA6CisKIDIwMDktMTEtMTIgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XcmFwcGVyLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNw cAppbmRleCA1MGU2MzUxLi5kNzQ0ODg2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu Y3BwCkBAIC0xNDkzLDEwICsxNDkzLDEyIEBAIFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gVjhE T01XcmFwcGVyOjpnZXRFdmVudExpc3RlbmVyKE5vZGUqIG5vZGUsIHY4OjpMb2NhbDx2CiAgICAg cmV0dXJuIChsb29rdXAgPT0gTGlzdGVuZXJGaW5kT25seSkgPyBWOEV2ZW50TGlzdGVuZXJMaXN0 OjpmaW5kV3JhcHBlcih2YWx1ZSwgaXNBdHRyaWJ1dGUpIDogVjhFdmVudExpc3RlbmVyTGlzdDo6 ZmluZE9yQ3JlYXRlV3JhcHBlcjxWOEV2ZW50TGlzdGVuZXI+KHZhbHVlLCBpc0F0dHJpYnV0ZSk7 CiB9CiAKKyNpZiBFTkFCTEUoU1ZHKQogUGFzc1JlZlB0cjxFdmVudExpc3RlbmVyPiBWOERPTVdy YXBwZXI6OmdldEV2ZW50TGlzdGVuZXIoU1ZHRWxlbWVudEluc3RhbmNlKiBlbGVtZW50LCB2ODo6 TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgYm9vbCBpc0F0dHJpYnV0ZSwgTGlzdGVuZXJMb29rdXBU eXBlIGxvb2t1cCkKIHsKICAgICByZXR1cm4gZ2V0RXZlbnRMaXN0ZW5lcihlbGVtZW50LT5jb3Jy ZXNwb25kaW5nRWxlbWVudCgpLCB2YWx1ZSwgaXNBdHRyaWJ1dGUsIGxvb2t1cCk7CiB9CisjZW5k aWYKIAogUGFzc1JlZlB0cjxFdmVudExpc3RlbmVyPiBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlz dGVuZXIoQWJzdHJhY3RXb3JrZXIqIHdvcmtlciwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUs IGJvb2wgaXNBdHRyaWJ1dGUsIExpc3RlbmVyTG9va3VwVHlwZSBsb29rdXApCiB7