31489 2009-11-13 13:57:09 -0800 DOMHTMLSelectElement is missing some implementation 2009-11-17 15:40:18 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jhoneycutt jhoneycutt oldest_to_newest 163491 0 jhoneycutt 2009-11-13 13:57:09 -0800 DOMHTMLSelectElement::options() and DOMHTMLSelectElement::activateItemAtIndex() are stubs. 163518 1 43200 jhoneycutt 2009-11-13 14:15:55 -0800 Created attachment 43200 patch 163546 2 43200 mitz 2009-11-13 15:04:34 -0800 Comment on attachment 43200 patch > + ASSERT(m_element && m_element->hasTagName(selectTag)); Please split this assertion into two separate assertions. > + ASSERT(m_element && m_element->hasTagName(selectTag)); Ditto. 164365 3 jhoneycutt 2009-11-17 15:40:18 -0800 I made Dan's change. Landed in r51092. 43200 2009-11-13 14:15:55 -0800 2009-11-13 15:04:33 -0800 patch 0003-DOMHTMLSelectElement-is-missing-some-implementation.patch text/plain 3458 jhoneycutt RnJvbSA5ZGMzOGVlMzhjNzZmOGQ5YmRiODM5NzkyYjc4ZGJiYWYwZWUzNGM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogRnJpLCAxMyBOb3YgMjAwOSAxMzo1NDoyOCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIERP TUhUTUxTZWxlY3RFbGVtZW50IGlzIG1pc3Npbmcgc29tZSBpbXBsZW1lbnRhdGlvbi4KCmh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ4OQoKUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgoqIERPTUhUTUxDbGFzc2VzLmNwcDoKKERPTUhUTUxTZWxlY3RFbGVtZW50 OjpvcHRpb25zKToKQ2FzdCBtX2VsZW1lbnQgdG8gYW4gSFRNTFNlbGVjdEVsZW1lbnQuIElmIGl0 IGhhcyBubyBvcHRpb25zLCByZXR1cm4KRV9GQUlMLiBPdGhlcndpc2UsIGNyZWF0ZSBhIERPTUhU TUxPcHRpb25zQ29sbGVjdGlvbiB0byB3cmFwIHRoZQpvcHRpb25zLCBhbmQgcmV0dXJuIGl0Lgoo RE9NSFRNTFNlbGVjdEVsZW1lbnQ6OmFjdGl2YXRlSXRlbUF0SW5kZXgpOgpJZiB0aGUgaW5kZXgg aXMgb3V0IG9mIGJvdW5kcywgcmV0dXJuIEVfRkFJTC4gT3RoZXJ3aXNlLCBzZWxlY3QgdGhlCml0 ZW0uCi0tLQogV2ViS2l0L3dpbi9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysr KysrKysrCiBXZWJLaXQvd2luL0RPTUhUTUxDbGFzc2VzLmNwcCB8ICAgMjkgKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgNiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvd2luL0NoYW5nZUxvZyBiL1dlYktpdC93 aW4vQ2hhbmdlTG9nCmluZGV4IGRkNmY5MWUuLjYwMTk3OTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC93 aW4vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAK IDIwMDktMTEtMTIgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAorICAg ICAgICBET01IVE1MU2VsZWN0RWxlbWVudCBpcyBtaXNzaW5nIHNvbWUgaW1wbGVtZW50YXRpb24u CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDg5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBET01I VE1MQ2xhc3Nlcy5jcHA6CisgICAgICAgIChET01IVE1MU2VsZWN0RWxlbWVudDo6b3B0aW9ucyk6 CisgICAgICAgIENhc3QgbV9lbGVtZW50IHRvIGFuIEhUTUxTZWxlY3RFbGVtZW50LiBJZiBpdCBo YXMgbm8gb3B0aW9ucywgcmV0dXJuCisgICAgICAgIEVfRkFJTC4gT3RoZXJ3aXNlLCBjcmVhdGUg YSBET01IVE1MT3B0aW9uc0NvbGxlY3Rpb24gdG8gd3JhcCB0aGUKKyAgICAgICAgb3B0aW9ucywg YW5kIHJldHVybiBpdC4KKyAgICAgICAgKERPTUhUTUxTZWxlY3RFbGVtZW50OjphY3RpdmF0ZUl0 ZW1BdEluZGV4KToKKyAgICAgICAgSWYgdGhlIGluZGV4IGlzIG91dCBvZiBib3VuZHMsIHJldHVy biBFX0ZBSUwuIE90aGVyd2lzZSwgc2VsZWN0IHRoZQorICAgICAgICBpdGVtLgorCisyMDA5LTEx LTEyICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKICAgICAgICAgRE9N SFRNTE9wdGlvbnNDb2xsZWN0aW9uIGlzIG1pc3Npbmcgc29tZSBpbXBsZW1lbnRhdGlvbi4KIAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0ODgKZGlm ZiAtLWdpdCBhL1dlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuY3BwIGIvV2ViS2l0L3dpbi9ET01I VE1MQ2xhc3Nlcy5jcHAKaW5kZXggOWNhYTMyYi4uYWY3YThkYyAxMDA2NDQKLS0tIGEvV2ViS2l0 L3dpbi9ET01IVE1MQ2xhc3Nlcy5jcHAKKysrIGIvV2ViS2l0L3dpbi9ET01IVE1MQ2xhc3Nlcy5j cHAKQEAgLTY5OSwxMCArNjk5LDIxIEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NSFRN TFNlbGVjdEVsZW1lbnQ6OmZvcm0oCiB9CiAgICAgCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBF IERPTUhUTUxTZWxlY3RFbGVtZW50OjpvcHRpb25zKCAKLSAgICAgICAgLyogW3JldHZhbF1bb3V0 XSAqLyBJRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uKiogLypyZXN1bHQqLykKKyAgICAgICAgLyog W3JldHZhbF1bb3V0XSAqLyBJRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uKiogcmVzdWx0KQogewot ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJldHVybiBFX05PVElNUEw7CisgICAgaWYg KCFyZXN1bHQpCisgICAgICAgIHJldHVybiBFX1BPSU5URVI7CisKKyAgICAqcmVzdWx0ID0gMDsK KworICAgIEFTU0VSVChtX2VsZW1lbnQgJiYgbV9lbGVtZW50LT5oYXNUYWdOYW1lKHNlbGVjdFRh ZykpOworICAgIEhUTUxTZWxlY3RFbGVtZW50KiBzZWxlY3RFbGVtZW50ID0gc3RhdGljX2Nhc3Q8 SFRNTFNlbGVjdEVsZW1lbnQqPihtX2VsZW1lbnQpOworCisgICAgaWYgKCFzZWxlY3RFbGVtZW50 LT5vcHRpb25zKCkpCisgICAgICAgIHJldHVybiBFX0ZBSUw7CisKKyAgICAqcmVzdWx0ID0gRE9N SFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpjcmVhdGVJbnN0YW5jZShzZWxlY3RFbGVtZW50LT5vcHRp b25zKCkuZ2V0KCkpOworICAgIHJldHVybiBTX09LOwogfQogICAgIAogSFJFU1VMVCBTVERNRVRI T0RDQUxMVFlQRSBET01IVE1MU2VsZWN0RWxlbWVudDo6ZGlzYWJsZWQoIApAQCAtNzkzLDEwICs4 MDQsMTYgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01IVE1MU2VsZWN0RWxlbWVudDo6 cmVtb3ZlKAogLy8gRE9NSFRNTFNlbGVjdEVsZW1lbnQgLSBJRm9ybXNBdXRvRmlsbFRyYW5zaXRp b25TZWxlY3QgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIERPTUhUTUxTZWxlY3RFbGVtZW50OjphY3RpdmF0ZUl0ZW1BdEluZGV4KCAKLSAgICAvKiBb aW5dICovIGludCAvKmluZGV4Ki8pCisgICAgLyogW2luXSAqLyBpbnQgaW5kZXgpCiB7Ci0gICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIEVfTk9USU1QTDsgICAgCisgICAgQVNT RVJUKG1fZWxlbWVudCAmJiBtX2VsZW1lbnQtPmhhc1RhZ05hbWUoc2VsZWN0VGFnKSk7CisgICAg SFRNTFNlbGVjdEVsZW1lbnQqIHNlbGVjdEVsZW1lbnQgPSBzdGF0aWNfY2FzdDxIVE1MU2VsZWN0 RWxlbWVudCo+KG1fZWxlbWVudCk7CisKKyAgICBpZiAoaW5kZXggPj0gc2VsZWN0RWxlbWVudC0+ bGVuZ3RoKCkpCisgICAgICAgIHJldHVybiBFX0ZBSUw7CisKKyAgICBzZWxlY3RFbGVtZW50LT5z ZXRTZWxlY3RlZEluZGV4KGluZGV4KTsKKyAgICByZXR1cm4gU19PSzsKIH0KIAogLy8gRE9NSFRN TE9wdGlvbkVsZW1lbnQgLSBJVW5rbm93biAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQotLSAKMS42LjUuMi4xNDMuZzhjYzYyCgo=