31488 2009-11-13 13:53:09 -0800 DOMHTMLOptionsCollection is missing some implementation 2009-11-17 15:40:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 jhoneycutt jhoneycutt oldest_to_newest 163489 0 jhoneycutt 2009-11-13 13:53:09 -0800 All of the DOMHTMLOptionsCollection functions are stubs. 163517 1 43199 jhoneycutt 2009-11-13 14:15:03 -0800 Created attachment 43199 patch 163689 2 43199 mitz 2009-11-14 16:20:54 -0800 Comment on attachment 43199 patch > + if (index >= m_collection->length()) > + return E_FAIL; > + > + *result = DOMNode::createInstance(m_collection->item(index)); > + return S_OK; Can you just let HTMLOptionsCollection::item() return 0 and then null-check the result instead of bounds-checking index? It would be more like DOMHTMLCollection::item(). r=me either way 164364 3 jhoneycutt 2009-11-17 15:40:06 -0800 I made Dan's change. Landed in r51091. 43199 2009-11-13 14:15:03 -0800 2009-11-14 16:20:53 -0800 patch 0002-DOMHTMLOptionsCollection-is-missing-some-implementat.patch text/plain 6571 jhoneycutt RnJvbSBmOWU5N2ExNGQxY2M5NTM1ZjZkYjJjZGY2NDY3N2RkMDJmYTY0NWIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogRnJpLCAxMyBOb3YgMjAwOSAxMzo0ODo0NiAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIERP TUhUTUxPcHRpb25zQ29sbGVjdGlvbiBpcyBtaXNzaW5nIHNvbWUgaW1wbGVtZW50YXRpb24uCgpo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0ODgKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKKiBET01IVE1MQ2xhc3Nlcy5jcHA6CihET01IVE1MT3B0aW9uc0Nv bGxlY3Rpb246OkRPTUhUTUxPcHRpb25zQ29sbGVjdGlvbik6CkluaXRpYWxpemUgbV9jb2xsZWN0 aW9uLgooRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpjcmVhdGVJbnN0YW5jZSk6CkNyZWF0ZSBh IERPTUhUTUxPcHRpb25zQ29sbGVjdGlvbi4gSWYgd2UgZmFpbCB0byBxdWVyeSBmb3IKSURPTUhU TUxPcHRpb25zQ29sbGVjdGlvbiwgZGVsZXRlIGl0LCBhbmQgcmV0dXJuIDAuIE90aGVyd2lzZSwg cmV0dXJuCnRoZSByZXN1bHQuCihET01IVE1MT3B0aW9uc0NvbGxlY3Rpb246Omxlbmd0aCk6CihE T01IVE1MT3B0aW9uc0NvbGxlY3Rpb246Oml0ZW0pOgpJZiB0aGUgaW5kZXggaXMgb3V0IG9mIGJv dW5kcywgcmV0dXJuIEVfRkFJTC4gT3RoZXJ3aXNlLCBjcmVhdGUgYQpET01Ob2RlIGZvciB0aGUg V2ViQ29yZSBOb2RlLCBhbmQgcmV0dXJuIGl0LgooRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpu YW1lZEl0ZW0pOgpDb3JyZWN0IHRoZSBzaWduYXR1cmUgb2YgdGhpcyBmdW5jdGlvbi4KCiogRE9N SFRNTENsYXNzZXMuaDoKRGVjbGFyZSBET01IVE1MT3B0aW9uc0NvbGxlY3Rpb246OmNyZWF0ZUlu c3RhbmNlKCkuIENvcnJlY3QgdGhlCnNpZ25hdHVyZSBvZiBuYW1lZEl0ZW0oKSB0byBtYXRjaCBJ RE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uLiBBZGQgYQptZW1iZXIgdG8gRE9NSFRNTE9wdGlvbnND b2xsZWN0aW9uIHRvIGhvbGQgdGhlIFdlYkNvcmUgb2JqZWN0LgotLS0KIFdlYktpdC93aW4vQ2hh bmdlTG9nICAgICAgICAgIHwgICAyNyArKysrKysrKysrKysrKysrKysrKysrKwogV2ViS2l0L3dp bi9ET01IVE1MQ2xhc3Nlcy5jcHAgfCAgIDQ4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0KIFdlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuaCAgIHwgICAxMSArKysrKysr Ky0KIDMgZmlsZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJLaXQvd2luL0NoYW5nZUxvZyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCmlu ZGV4IDdiMDgzMTAuLmRkNmY5MWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vQ2hhbmdlTG9nCisr KyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzIgQEAKIDIwMDktMTEtMTIgIEpv biBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAorICAgICAgICBET01IVE1MT3B0 aW9uc0NvbGxlY3Rpb24gaXMgbWlzc2luZyBzb21lIGltcGxlbWVudGF0aW9uLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ4OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRE9NSFRNTENsYXNzZXMu Y3BwOgorICAgICAgICAoRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpET01IVE1MT3B0aW9uc0Nv bGxlY3Rpb24pOgorICAgICAgICBJbml0aWFsaXplIG1fY29sbGVjdGlvbi4KKyAgICAgICAgKERP TUhUTUxPcHRpb25zQ29sbGVjdGlvbjo6Y3JlYXRlSW5zdGFuY2UpOgorICAgICAgICBDcmVhdGUg YSBET01IVE1MT3B0aW9uc0NvbGxlY3Rpb24uIElmIHdlIGZhaWwgdG8gcXVlcnkgZm9yCisgICAg ICAgIElET01IVE1MT3B0aW9uc0NvbGxlY3Rpb24sIGRlbGV0ZSBpdCwgYW5kIHJldHVybiAwLiBP dGhlcndpc2UsIHJldHVybgorICAgICAgICB0aGUgcmVzdWx0LgorICAgICAgICAoRE9NSFRNTE9w dGlvbnNDb2xsZWN0aW9uOjpsZW5ndGgpOgorICAgICAgICAoRE9NSFRNTE9wdGlvbnNDb2xsZWN0 aW9uOjppdGVtKToKKyAgICAgICAgSWYgdGhlIGluZGV4IGlzIG91dCBvZiBib3VuZHMsIHJldHVy biBFX0ZBSUwuIE90aGVyd2lzZSwgY3JlYXRlIGEKKyAgICAgICAgRE9NTm9kZSBmb3IgdGhlIFdl YkNvcmUgTm9kZSwgYW5kIHJldHVybiBpdC4KKyAgICAgICAgKERPTUhUTUxPcHRpb25zQ29sbGVj dGlvbjo6bmFtZWRJdGVtKToKKyAgICAgICAgQ29ycmVjdCB0aGUgc2lnbmF0dXJlIG9mIHRoaXMg ZnVuY3Rpb24uCisKKyAgICAgICAgKiBET01IVE1MQ2xhc3Nlcy5oOgorICAgICAgICBEZWNsYXJl IERPTUhUTUxPcHRpb25zQ29sbGVjdGlvbjo6Y3JlYXRlSW5zdGFuY2UoKS4gQ29ycmVjdCB0aGUK KyAgICAgICAgc2lnbmF0dXJlIG9mIG5hbWVkSXRlbSgpIHRvIG1hdGNoIElET01IVE1MT3B0aW9u c0NvbGxlY3Rpb24uIEFkZCBhCisgICAgICAgIG1lbWJlciB0byBET01IVE1MT3B0aW9uc0NvbGxl Y3Rpb24gdG8gaG9sZCB0aGUgV2ViQ29yZSBvYmplY3QuCisKKzIwMDktMTEtMTIgIEpvbiBIb25l eWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KKwogICAgICAgICBET01IVE1MSW5wdXRFbGVt ZW50OjpyZWN0T25TY3JlZW4oKSByZXR1cm5zIHRoZSB3cm9uZyByZWN0CiAKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDg3CmRpZmYgLS1naXQgYS9X ZWJLaXQvd2luL0RPTUhUTUxDbGFzc2VzLmNwcCBiL1dlYktpdC93aW4vRE9NSFRNTENsYXNzZXMu Y3BwCmluZGV4IDExZWUzMjMuLjljYWEzMmIgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vRE9NSFRN TENsYXNzZXMuY3BwCisrKyBiL1dlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuY3BwCkBAIC0zOSw2 ICszOSw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9IVE1MSW5wdXRFbGVtZW50Lmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9IVE1MTmFtZXMuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0hUTUxPcHRpb25FbGVt ZW50Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9IVE1MT3B0aW9uc0NvbGxlY3Rpb24uaD4KICNpbmNs dWRlIDxXZWJDb3JlL0hUTUxTZWxlY3RFbGVtZW50Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9IVE1M VGV4dEFyZWFFbGVtZW50Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9JbnRSZWN0Lmg+CkBAIC0xMzQs MTEgKzEzNSwzNCBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIERPTUhUTUxPcHRpb25zQ29s bGVjdGlvbjo6UXVlcnlJbnRlcmZhY2UoUkVGSUlEIHJpaWQsCiAKIC8vIERPTUhUTUxPcHRpb25z Q29sbGVjdGlvbiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KIAorRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpET01IVE1MT3B0aW9uc0NvbGxlY3Rp b24oV2ViQ29yZTo6SFRNTE9wdGlvbnNDb2xsZWN0aW9uKiBjb2xsZWN0aW9uKQorICAgIDogbV9j b2xsZWN0aW9uKGNvbGxlY3Rpb24pCit7Cit9CisKK0lET01IVE1MT3B0aW9uc0NvbGxlY3Rpb24q IERPTUhUTUxPcHRpb25zQ29sbGVjdGlvbjo6Y3JlYXRlSW5zdGFuY2UoV2ViQ29yZTo6SFRNTE9w dGlvbnNDb2xsZWN0aW9uKiBjb2xsZWN0aW9uKQoreworICAgIGlmICghY29sbGVjdGlvbikKKyAg ICAgICAgcmV0dXJuIDA7CisKKyAgICBJRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uKiBvcHRpb25z Q29sbGVjdGlvbiA9IDA7CisgICAgRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uKiBuZXdDb2xsZWN0 aW9uID0gbmV3IERPTUhUTUxPcHRpb25zQ29sbGVjdGlvbihjb2xsZWN0aW9uKTsKKyAgICBpZiAo RkFJTEVEKG5ld0NvbGxlY3Rpb24tPlF1ZXJ5SW50ZXJmYWNlKElJRF9JRE9NSFRNTE9wdGlvbnND b2xsZWN0aW9uLCAodm9pZCoqKSZvcHRpb25zQ29sbGVjdGlvbikpKSB7CisgICAgICAgIGRlbGV0 ZSBuZXdDb2xsZWN0aW9uOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisKKyAgICByZXR1cm4g b3B0aW9uc0NvbGxlY3Rpb247Cit9CisKIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NSFRN TE9wdGlvbnNDb2xsZWN0aW9uOjpsZW5ndGgoIAotICAgIC8qIFtyZXR2YWxdW291dF0gKi8gdW5z aWduZWQgaW50KiAvKnJlc3VsdCovKQorICAgIC8qIFtyZXR2YWxdW291dF0gKi8gdW5zaWduZWQg aW50KiByZXN1bHQpCiB7Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIEVf Tk9USU1QTDsKKyAgICBpZiAoIXJlc3VsdCkKKyAgICAgICAgcmV0dXJuIEVfUE9JTlRFUjsKKwor ICAgICpyZXN1bHQgPSBtX2NvbGxlY3Rpb24tPmxlbmd0aCgpOworICAgIHJldHVybiBTX09LOwog fQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIERPTUhUTUxPcHRpb25zQ29sbGVjdGlvbjo6 c2V0TGVuZ3RoKCAKQEAgLTE0OSwxNiArMTczLDI0IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZ UEUgRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpzZXRMZW5ndGgoCiB9CiAKIEhSRVNVTFQgU1RE TUVUSE9EQ0FMTFRZUEUgRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjppdGVtKCAKLSAgICAvKiBb aW5dICovIHVuc2lnbmVkIGludCAvKmluZGV4Ki8sCi0gICAgLyogW3JldHZhbF1bb3V0XSAqLyBJ RE9NTm9kZSoqIC8qcmVzdWx0Ki8pCisgICAgLyogW2luXSAqLyB1bnNpZ25lZCBpbnQgaW5kZXgs CisgICAgLyogW3JldHZhbF1bb3V0XSAqLyBJRE9NTm9kZSoqIHJlc3VsdCkKIHsKLSAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gRV9OT1RJTVBMOworICAgIGlmICghcmVzdWx0 KQorICAgICAgICByZXR1cm4gRV9QT0lOVEVSOworCisgICAgKnJlc3VsdCA9IDA7CisKKyAgICBp ZiAoaW5kZXggPj0gbV9jb2xsZWN0aW9uLT5sZW5ndGgoKSkKKyAgICAgICAgcmV0dXJuIEVfRkFJ TDsKKworICAgICpyZXN1bHQgPSBET01Ob2RlOjpjcmVhdGVJbnN0YW5jZShtX2NvbGxlY3Rpb24t Pml0ZW0oaW5kZXgpKTsKKyAgICByZXR1cm4gU19PSzsKIH0KIAogSFJFU1VMVCBTVERNRVRIT0RD QUxMVFlQRSBET01IVE1MT3B0aW9uc0NvbGxlY3Rpb246Om5hbWVkSXRlbSggCiAgICAgLyogW2lu XSAqLyBCU1RSIC8qbmFtZSovLAotICAgIC8qIFtyZXR2YWxdW291dF0gKi8gSURPTU5vZGUqIC8q cmVzdWx0Ki8pCisgICAgLyogW3JldHZhbF1bb3V0XSAqLyBJRE9NTm9kZSoqIC8qcmVzdWx0Ki8p CiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgcmV0dXJuIEVfTk9USU1QTDsKZGlm ZiAtLWdpdCBhL1dlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuaCBiL1dlYktpdC93aW4vRE9NSFRN TENsYXNzZXMuaAppbmRleCBkZGMzZGQxLi4xOGZhOGZhIDEwMDY0NAotLS0gYS9XZWJLaXQvd2lu L0RPTUhUTUxDbGFzc2VzLmgKKysrIGIvV2ViS2l0L3dpbi9ET01IVE1MQ2xhc3Nlcy5oCkBAIC0z NCw2ICszNCw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBIVE1MQ29sbGVj dGlvbjsKKyAgICBjbGFzcyBIVE1MT3B0aW9uc0NvbGxlY3Rpb247CiB9CiAKIGNsYXNzIERPTUhU TUxDb2xsZWN0aW9uIDogcHVibGljIERPTU9iamVjdCwgcHVibGljIElET01IVE1MQ29sbGVjdGlv bgpAQCAtOTksNiArMTAwLDkgQEAgcHJvdGVjdGVkOgogCiBjbGFzcyBET01IVE1MT3B0aW9uc0Nv bGxlY3Rpb24gOiBwdWJsaWMgRE9NT2JqZWN0LCBwdWJsaWMgSURPTUhUTUxPcHRpb25zQ29sbGVj dGlvbgogeworcHVibGljOgorICAgIHN0YXRpYyBJRE9NSFRNTE9wdGlvbnNDb2xsZWN0aW9uKiBj cmVhdGVJbnN0YW5jZShXZWJDb3JlOjpIVE1MT3B0aW9uc0NvbGxlY3Rpb24qKTsKKwogICAgIC8v IElVbmtub3duCiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFF1ZXJ5SW50 ZXJmYWNlKFJFRklJRCByaWlkLCB2b2lkKiogcHB2T2JqZWN0KTsKICAgICB2aXJ0dWFsIFVMT05H IFNURE1FVEhPRENBTExUWVBFIEFkZFJlZih2b2lkKSB7IHJldHVybiBET01PYmplY3Q6OkFkZFJl ZigpOyB9CkBAIC0xNDksNyArMTUzLDEyIEBAIGNsYXNzIERPTUhUTUxPcHRpb25zQ29sbGVjdGlv biA6IHB1YmxpYyBET01PYmplY3QsIHB1YmxpYyBJRE9NSFRNTE9wdGlvbnNDb2xsZWN0CiAgICAg CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIG5hbWVkSXRlbSggCiAgICAg ICAgIC8qIFtpbl0gKi8gQlNUUiBuYW1lLAotICAgICAgICAvKiBbcmV0dmFsXVtvdXRdICovIElE T01Ob2RlICpyZXN1bHQpOworICAgICAgICAvKiBbcmV0dmFsXVtvdXRdICovIElET01Ob2RlICoq cmVzdWx0KTsKKworcHJpdmF0ZToKKyAgICBET01IVE1MT3B0aW9uc0NvbGxlY3Rpb24oV2ViQ29y ZTo6SFRNTE9wdGlvbnNDb2xsZWN0aW9uKik7CisKKyAgICBSZWZQdHI8V2ViQ29yZTo6SFRNTE9w dGlvbnNDb2xsZWN0aW9uPiBtX2NvbGxlY3Rpb247CiB9OwogCiBjbGFzcyBET01IVE1MRG9jdW1l bnQgOiBwdWJsaWMgRE9NRG9jdW1lbnQsIHB1YmxpYyBJRE9NSFRNTERvY3VtZW50Ci0tIAoxLjYu NS4yLjE0My5nOGNjNjIKCg==