31487 2009-11-13 13:43:28 -0800 DOMHTMLInputElement::rectOnScreen() returns the wrong rect 2009-11-17 15:39:18 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 jhoneycutt jhoneycutt oldest_to_newest 163480 0 jhoneycutt 2009-11-13 13:43:28 -0800 DOMHTMLInputElement::rectOnScreen() returns the rect with the window, not within the screen. 163515 1 43198 jhoneycutt 2009-11-13 14:14:15 -0800 Created attachment 43198 patch 163521 2 43198 darin 2009-11-13 14:18:07 -0800 Comment on attachment 43198 patch r=me How do you test this? Is there a way to test it with a manual test? 164352 3 jhoneycutt 2009-11-17 14:35:09 -0800 A manual test could test this, but it would only work in Safari. We don't seem to have a good way to test our bindings. Thanks for the review! 164363 4 jhoneycutt 2009-11-17 15:39:18 -0800 Landed in r51090. 43198 2009-11-13 14:14:15 -0800 2009-11-13 14:18:07 -0800 patch 0001-DOMHTMLInputElement-rectOnScreen-returns-the-wrong-r.patch text/plain 1902 jhoneycutt RnJvbSBiYjkwYjA3MTMwNTk0NTc1Y2EzNzU1YWY3ZjA2Njg1MjJhMTRhMTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAxMiBOb3YgMjAwOSAxNDoxMjo1MCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIERP TUhUTUxJbnB1dEVsZW1lbnQ6OnJlY3RPblNjcmVlbigpIHJldHVybnMgdGhlIHdyb25nIHJlY3QK Cmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ4NwoKUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgoqIERPTUhUTUxDbGFzc2VzLmNwcDoKKERPTUhUTUxJbnB1dEVs ZW1lbnQ6OnJlY3RPblNjcmVlbik6ClJldHVybiB0aGUgcmVjdCBvbiBzY3JlZW4sIG5vdCB0aGUg cmVjdCBpbiB0aGUgd2luZG93LgotLS0KIFdlYktpdC93aW4vQ2hhbmdlTG9nICAgICAgICAgIHwg ICAxMiArKysrKysrKysrKysKIFdlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuY3BwIHwgICAgNCAr Ky0tCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cgYi9XZWJLaXQvd2luL0NoYW5nZUxvZwpp bmRleCAyZTY3MWE4Li43YjA4MzEwIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL0NoYW5nZUxvZwor KysgYi9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTExLTEyICBK b24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgRE9NSFRNTElu cHV0RWxlbWVudDo6cmVjdE9uU2NyZWVuKCkgcmV0dXJucyB0aGUgd3JvbmcgcmVjdAorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ4NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRE9NSFRNTENsYXNz ZXMuY3BwOgorICAgICAgICAoRE9NSFRNTElucHV0RWxlbWVudDo6cmVjdE9uU2NyZWVuKToKKyAg ICAgICAgUmV0dXJuIHRoZSByZWN0IG9uIHNjcmVlbiwgbm90IHRoZSByZWN0IGluIHRoZSB3aW5k b3cuCisKIDIwMDktMTEtMTIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYktp dC93aW4vRE9NSFRNTENsYXNzZXMuY3BwIGIvV2ViS2l0L3dpbi9ET01IVE1MQ2xhc3Nlcy5jcHAK aW5kZXggOWNlNjAwNC4uMTFlZTMyMyAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9ET01IVE1MQ2xh c3Nlcy5jcHAKKysrIGIvV2ViS2l0L3dpbi9ET01IVE1MQ2xhc3Nlcy5jcHAKQEAgLTEyMzEsMTIg KzEyMzEsMTIgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01IVE1MSW5wdXRFbGVtZW50 OjpyZWN0T25TY3JlZW4oCiAgICAgaWYgKCFyZW5kZXJlciB8fCAhdmlldykKICAgICAgICAgcmV0 dXJuIEVfRkFJTDsKIAotICAgIEludFJlY3QgY29yZVJlY3QgPSByZW5kZXJlci0+YWJzb2x1dGVC b3VuZGluZ0JveFJlY3QoKTsKLSAgICBjb3JlUmVjdC5zZXRMb2NhdGlvbih2aWV3LT5jb250ZW50 c1RvV2luZG93KGNvcmVSZWN0LmxvY2F0aW9uKCkpKTsKKyAgICBJbnRSZWN0IGNvcmVSZWN0ID0g dmlldy0+Y29udGVudHNUb1NjcmVlbihyZW5kZXJlci0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3Qo KSk7CiAgICAgcmVjdC0+bGVmdCA9IGNvcmVSZWN0LngoKTsKICAgICByZWN0LT50b3AgPSBjb3Jl UmVjdC55KCk7CiAgICAgcmVjdC0+cmlnaHQgPSBjb3JlUmVjdC5yaWdodCgpOwogICAgIHJlY3Qt PmJvdHRvbSA9IGNvcmVSZWN0LmJvdHRvbSgpOworCiAgICAgcmV0dXJuIFNfT0s7CiB9CiAKLS0g CjEuNi41LjIuMTQzLmc4Y2M2MgoK