31485 2009-11-13 11:57:28 -0800 JSValueProtect and JSValueUnprotect don't protect API wrapper values 2009-11-13 18:09:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned oldest_to_newest 163410 0 oliver 2009-11-13 11:57:28 -0800 toJS strips out the wrapper objects made for number cells in the API, which means the protect/unprotect become no-ops. Clearly this is a Bad Thing (tm) 163411 1 43182 oliver 2009-11-13 12:00:07 -0800 Created attachment 43182 Patch 163421 2 43182 ggaren 2009-11-13 12:07:40 -0800 Comment on attachment 43182 Patch r=me 163452 3 oliver 2009-11-13 12:42:41 -0800 Committed r50964 43182 2009-11-13 12:00:07 -0800 2009-11-13 12:07:40 -0800 Patch bug-31485-20091113120005.patch text/plain 3487 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0FQSS9BUElDYXN0LmggYi9KYXZhU2NyaXB0Q29y ZS9BUEkvQVBJQ2FzdC5oCmluZGV4IGI5MTY3YTguLjNiNjVlMDkgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL0FQSS9BUElDYXN0LmgKKysrIGIvSmF2YVNjcmlwdENvcmUvQVBJL0FQSUNhc3Qu aApAQCAtNzMsNiArNzMsMTggQEAgaW5saW5lIEpTQzo6SlNWYWx1ZSB0b0pTKEpTQzo6RXhlY1N0 YXRlKiwgSlNWYWx1ZVJlZiB2KQogI2VuZGlmCiB9CiAKK2lubGluZSBKU0M6OkpTVmFsdWUgdG9K U0ZvckdDKEpTQzo6RXhlY1N0YXRlKiwgSlNWYWx1ZVJlZiB2KQoreworI2lmIFVTRShKU1ZBTFVF MzJfNjQpCisgICAgSlNDOjpKU0NlbGwqIGpzQ2VsbCA9IHJlaW50ZXJwcmV0X2Nhc3Q8SlNDOjpK U0NlbGwqPihjb25zdF9jYXN0PE9wYXF1ZUpTVmFsdWUqPih2KSk7CisgICAgaWYgKCFqc0NlbGwp CisgICAgICAgIHJldHVybiBKU0M6OkpTVmFsdWUoKTsKKyAgICByZXR1cm4ganNDZWxsOworI2Vs c2UKKyAgICByZXR1cm4gSlNDOjpKU1ZhbHVlOjpkZWNvZGUocmVpbnRlcnByZXRfY2FzdDxKU0M6 OkVuY29kZWRKU1ZhbHVlPihjb25zdF9jYXN0PE9wYXF1ZUpTVmFsdWUqPih2KSkpOworI2VuZGlm Cit9CisKIGlubGluZSBKU0M6OkpTT2JqZWN0KiB0b0pTKEpTT2JqZWN0UmVmIG8pCiB7CiAgICAg cmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8SlNDOjpKU09iamVjdCo+KG8pOwpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvQVBJL0pTVmFsdWVSZWYuY3BwIGIvSmF2YVNjcmlwdENvcmUvQVBJL0pT VmFsdWVSZWYuY3BwCmluZGV4IDIyMDcxODEuLjgyMWFiZGEgMTAwNjQ0Ci0tLSBhL0phdmFTY3Jp cHRDb3JlL0FQSS9KU1ZhbHVlUmVmLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWYWx1 ZVJlZi5jcHAKQEAgLTMwNyw3ICszMDcsNyBAQCB2b2lkIEpTVmFsdWVQcm90ZWN0KEpTQ29udGV4 dFJlZiBjdHgsIEpTVmFsdWVSZWYgdmFsdWUpCiAgICAgZXhlYy0+Z2xvYmFsRGF0YSgpLmhlYXAu cmVnaXN0ZXJUaHJlYWQoKTsKICAgICBKU0xvY2sgbG9jayhleGVjKTsKIAotICAgIEpTVmFsdWUg anNWYWx1ZSA9IHRvSlMoZXhlYywgdmFsdWUpOworICAgIEpTVmFsdWUganNWYWx1ZSA9IHRvSlNG b3JHQyhleGVjLCB2YWx1ZSk7CiAgICAgZ2NQcm90ZWN0KGpzVmFsdWUpOwogfQogCkBAIC0zMTcs NiArMzE3LDYgQEAgdm9pZCBKU1ZhbHVlVW5wcm90ZWN0KEpTQ29udGV4dFJlZiBjdHgsIEpTVmFs dWVSZWYgdmFsdWUpCiAgICAgZXhlYy0+Z2xvYmFsRGF0YSgpLmhlYXAucmVnaXN0ZXJUaHJlYWQo KTsKICAgICBKU0xvY2sgbG9jayhleGVjKTsKIAotICAgIEpTVmFsdWUganNWYWx1ZSA9IHRvSlMo ZXhlYywgdmFsdWUpOworICAgIEpTVmFsdWUganNWYWx1ZSA9IHRvSlNGb3JHQyhleGVjLCB2YWx1 ZSk7CiAgICAgZ2NVbnByb3RlY3QoanNWYWx1ZSk7CiB9CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0 Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jIGIvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3Rh cGkuYwppbmRleCAxNTJiYWJjLi4yYzE3ZWNmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9B UEkvdGVzdHMvdGVzdGFwaS5jCisrKyBiL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBp LmMKQEAgLTczNyw2ICs3MzcsMTUgQEAgc3RhdGljIHZvaWQgdGVzdEluaXRpYWxpemVGaW5hbGl6 ZSgpCiAgICAgQVNTRVJUKEpTT2JqZWN0R2V0UHJpdmF0ZShvKSA9PSAodm9pZCopMyk7CiB9CiAK K3N0YXRpYyBKU1ZhbHVlUmVmIGpzTnVtYmVyVmFsdWUgPSAgTlVMTDsKKworc3RhdGljIHZvaWQg bWFrZUdsb2JhbE51bWJlclZhbHVlKEpTQ29udGV4dFJlZiBjb250ZXh0KSB7CisgICAgSlNWYWx1 ZVJlZiB2ID0gSlNWYWx1ZU1ha2VOdW1iZXIoY29udGV4dCwgNDIwKTsKKyAgICBKU1ZhbHVlUHJv dGVjdChjb250ZXh0LCB2KTsKKyAgICBqc051bWJlclZhbHVlID0gdjsKKyAgICB2ID0gTlVMTDsK K30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKIHsKICAgICBjb25zdCBjaGFy ICpzY3JpcHRQYXRoID0gInRlc3RhcGkuanMiOwpAQCAtOTQ4LDEwICs5NTcsMTIgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICBDRlJlbGVhc2UoY2ZFbXB0eVN0cmluZyk7 CiAgICAgCiAgICAganNHbG9iYWxWYWx1ZSA9IEpTT2JqZWN0TWFrZShjb250ZXh0LCBOVUxMLCBO VUxMKTsKKyAgICBtYWtlR2xvYmFsTnVtYmVyVmFsdWUoY29udGV4dCk7CiAgICAgSlNWYWx1ZVBy b3RlY3QoY29udGV4dCwganNHbG9iYWxWYWx1ZSk7CiAgICAgSlNHYXJiYWdlQ29sbGVjdChjb250 ZXh0KTsKICAgICBBU1NFUlQoSlNWYWx1ZUlzT2JqZWN0KGNvbnRleHQsIGpzR2xvYmFsVmFsdWUp KTsKICAgICBKU1ZhbHVlVW5wcm90ZWN0KGNvbnRleHQsIGpzR2xvYmFsVmFsdWUpOworICAgIEpT VmFsdWVVbnByb3RlY3QoY29udGV4dCwganNOdW1iZXJWYWx1ZSk7CiAKICAgICBKU1N0cmluZ1Jl ZiBnb29kU3ludGF4ID0gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoInggPSAxOyIpOwog ICAgIEpTU3RyaW5nUmVmIGJhZFN5bnRheCA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KCJ4IDo9IDE7Iik7CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q1MzVlZi4uNzQ0MWU1NiAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIyIEBACisyMDA5LTExLTEzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNW YWx1ZVByb3RlY3QgYW5kIEpTVmFsdWVVbnByb3RlY3QgZG9uJ3QgcHJvdGVjdCBBUEkgd3JhcHBl ciB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNDg1CisKKyAgICAgICAgTWFrZSBKU1ZhbHVlUHJvdGVjdC9VbnByb3RlY3QgdXNlIGEgbmV3 ICd0b0pTJyBmdW5jdGlvbiwgJ3RvSlNGb3JHQycgdGhhdAorICAgICAgICBkb2VzIG5vdCBhdHRl bXB0IHRvIHRvIHN0cmlwIG91dCBBUEkgd3JhcHBlciBvYmplY3RzLgorCisgICAgICAgICogQVBJ L0FQSUNhc3QuaDoKKyAgICAgICAgKHRvSlNGb3JHQyk6CisgICAgICAgICogQVBJL0pTVmFsdWVS ZWYuY3BwOgorICAgICAgICAoSlNWYWx1ZVByb3RlY3QpOgorICAgICAgICAoSlNWYWx1ZVVucHJv dGVjdCk6CisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAgKG1ha2VHbG9i YWxOdW1iZXJWYWx1ZSk6CisgICAgICAgIChtYWluKToKKwogMjAwOS0xMS0xMiAgU3RldmUgVmFu RGVCb2dhcnQgIDx2YW5kZWJvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLg==