31477 2009-11-13 09:59:00 -0800 [V8] Fix V8Bindings link error in Linux+GCC 4.4 2009-11-13 13:27:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Minor --- 1 jens jens eric oldest_to_newest 163355 0 jens 2009-11-13 09:59:00 -0800 Craig Schlenter alerted me that my patch in r50846 (bug 31383) caused a link error building Chromium on Linux with GCC 4.4: undefined reference to `WebCore::AtomicString WebCore::v8StringToWebCoreString<WebCore::AtomicString>(v8::Handle<v8::String>, WebCore::ExternalMode)' He tracked it down to an issue with the compiler not knowing which instantiations of the template to create, since the template body is in a .cpp file, as described here: http://stackoverflow.com/questions/1639797/template-issue-causes-linker-error-c The fix is to explicitly instantiate both the String and AtomicString versions in the .cpp file. This isn't a serious issue because we haven't moved up to GCC 4.4 for Chromium's Linux build yet, but it's a good idea to fix this now. I'm preparing a patch. 163362 1 43168 jens 2009-11-13 10:33:24 -0800 Created attachment 43168 patch Here's the patch. Waiting to set 'review?' flag till after I make sure it builds on Win/Linux. 163455 2 43168 jens 2009-11-13 12:50:53 -0800 Comment on attachment 43168 patch OK, this has passed the trybots, so requesting a review. 163462 3 43168 eric 2009-11-13 13:13:15 -0800 Comment on attachment 43168 patch Wrong mime type on the attachment. :) Tools like "bugzilla-tool post-diff" will take care of all the silly check-boxes and mime types for you if you like. 163464 4 eric 2009-11-13 13:14:00 -0800 This looks sane to me, but I'm really not enough of a c++ expert to comment here. 163468 5 43168 dglazkov 2009-11-13 13:18:28 -0800 Comment on attachment 43168 patch I am not teh expert, but I believe jens! :) 163472 6 jens 2009-11-13 13:27:50 -0800 Committed revision 50967. 43168 2009-11-13 10:33:24 -0800 2009-11-13 13:18:27 -0800 patch bindingGCC44fix.patch text/plain 1340 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDk1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMTEtMTMgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg YSBsaW5rIGVycm9yIGluIHVub2ZmaWNpYWwgR0NDIDQuNCBidWlsZHMgb24gTGludXguCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ3NworCisgICAg ICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcDogIEFkZCBleHBsaWNpdCBpbnN0YW50aWF0 aW9ucyBvZiB2OFN0cmluZ1RvV2ViQ29yZVN0cmluZyB0ZW1wbGF0ZS4KKwogMjAwOS0xMS0xMiAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAJKHJldmlzaW9u IDUwOTE0KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNzksNiArMjc5LDEyIEBAIFN0cmluZ1R5cGUgdjhTdHJpbmdUb1dlYkNvcmVTdHJp bmcodjg6OkgKICAgICB9CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KKyAgICAKKy8vIEV4cGxpY2l0 bHkgaW5zdGFudGlhdGUgdGhlIGFib3ZlIHRlbXBsYXRlIHdpdGggdGhlIGV4cGVjdGVkIHBhcmFt ZXRlcml6YXRpb25zLAorLy8gdG8gZW5zdXJlIHRoZSBjb21waWxlciBnZW5lcmF0ZXMgdGhlIGNv ZGU7IG90aGVyd2lzZSBsaW5rIGVycm9ycyBjYW4gcmVzdWx0IGluIEdDQyA0LjQuCit0ZW1wbGF0 ZSBTdHJpbmcgdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmc8U3RyaW5nPih2ODo6SGFuZGxlPHY4OjpT dHJpbmc+LCBFeHRlcm5hbE1vZGUpOwordGVtcGxhdGUgQXRvbWljU3RyaW5nIHY4U3RyaW5nVG9X ZWJDb3JlU3RyaW5nPEF0b21pY1N0cmluZz4odjg6OkhhbmRsZTx2ODo6U3RyaW5nPiwgRXh0ZXJu YWxNb2RlKTsKKwogCiBTdHJpbmcgdjhOb25TdHJpbmdWYWx1ZVRvV2ViQ29yZVN0cmluZyh2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gb2JqZWN0KQogewo=