314658 2026-05-12 12:31:30 -0700 requiresColumns() is confusingly named and also has an unnecessary parameter 2026-05-13 12:24:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fantasai.bugs fantasai.bugs bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 2210216 0 fantasai.bugs 2026-05-12 12:31:30 -0700 So let's clean it up. 2210217 1 webkit-bug-importer 2026-05-12 12:31:37 -0700 <rdar://problem/176908432> 2210221 2 479644 fantasai.bugs 2026-05-12 12:44:55 -0700 Created attachment 479644 patch 2210332 3 fantasai.bugs 2026-05-12 17:46:02 -0700 Pull request: https://github.com/WebKit/WebKit/pull/64801 2210607 4 ews-feeder 2026-05-13 12:24:39 -0700 Committed 313183@main (964d3c053bc0): <https://commits.webkit.org/313183@main> Reviewed commits have been landed. Closing PR #64801 and removing active labels. 479644 2026-05-12 12:44:55 -0700 2026-05-12 13:09:08 -0700 patch requiresColumns.diff text/plain 5799 fantasai.bugs Y29tbWl0IGRhNWVjYmZjNTA3YjgxNGZkZDdkMTJlNjRlY2VlNzI2ODAzZDk1ZTMKQXV0aG9yOiBF bGlrYSBFdGVtYWQgPGZhbnRhc2FpLmJ1Z3NAaW5rZWRibGFkZS5uZXQ+CkRhdGU6ICAgVHVlIE1h eSAxMiAxNTozMjowNyAyMDI2IC0wNDAwCgogICAgR2l2ZSByZXF1aXJlc0NvbHVtbnMoKSBhIGJl dHRlciBuYW1lIGFuZCBhbHNvIHJlbW92ZSB1bm5lY2Vzc2FyeSBwYXJhbWV0ZXIKICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ2NTgKICAgIHJkYXI6Ly8xNzY5 MDg0MzIKICAgIAogICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAKICAgIFJlbmFt ZXMgcmVxdWlyZXNDb2x1bW5zKCkgdG8gcmVxdWlyZXNGcmFnbWVudGVkRmxvdygpIHNpbmNlIHdl IGFsc28gdXNlIGl0CiAgICB0byBjb250cm9sIHBhZ2luYXRpb24sIGFuZCByZW1vdmVzIHRoZSBk ZXNpcmVkQ29sdW1uQ291bnQgcGFyYW1ldGVyIHdoaWNoCiAgICBpcyByZWR1bmRhbnQgd2l0aCBq dXN0IHB1bGxpbmcgdGhhdCB2YWx1ZSBmcm9tIFJlbmRlclN0eWxlLgogICAgCiAgICAqIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwOgogICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrRmxvdzo6d2lsbENyZWF0ZUNvbHVtbnMgY29uc3QpOgogICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrRmxvdzo6cmVxdWlyZXNGcmFnbWVudGVkRmxvdyBjb25zdCk6CiAgICAoV2ViQ29y ZTo6UmVuZGVyQmxvY2tGbG93OjpzZXRDb21wdXRlZENvbHVtbkNvdW50QW5kV2lkdGgpOgogICAg KFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6cmVxdWlyZXNDb2x1bW5zIGNvbnN0KTogRGVsZXRl ZC4KICAgICogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5oOgogICAg KiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6CiAgICAoV2ViQ29yZTo6 UmVuZGVyVmlldzo6cmVxdWlyZXNGcmFnbWVudGVkRmxvdyBjb25zdCk6CiAgICAoV2ViQ29yZTo6 UmVuZGVyVmlldzo6cmVxdWlyZXNDb2x1bW5zIGNvbnN0KTogRGVsZXRlZC4KICAgICogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaDoKICAgICogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyTXVsdGlDb2x1bW4uY3BwOgogICAgKFdl YkNvcmU6OlJlbmRlclRyZWVCdWlsZGVyOjpNdWx0aUNvbHVtbjo6dXBkYXRlQWZ0ZXJEZXNjZW5k YW50cyk6CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr Rmxvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcApp bmRleCA1OGM5NTM3ZmMyNmEuLjZjYjA0NzVjNGU0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKQEAgLTQ0MSw3ICs0NDEsNyBAQCB2b2lkIFJlbmRl ckJsb2NrRmxvdzo6Y29tcHV0ZUNvbHVtbkNvdW50QW5kV2lkdGgoKQogICAgIHNldENvbXB1dGVk Q29sdW1uQ291bnRBbmRXaWR0aChkZXNpcmVkQ29sdW1uQ291bnQsIGRlc2lyZWRDb2x1bW5XaWR0 aCk7CiB9CiAKLWJvb2wgUmVuZGVyQmxvY2tGbG93Ojp3aWxsQ3JlYXRlQ29sdW1ucyhzdGQ6Om9w dGlvbmFsPHVuc2lnbmVkPiBkZXNpcmVkQ29sdW1uQ291bnQpIGNvbnN0Citib29sIFJlbmRlckJs b2NrRmxvdzo6d2lsbENyZWF0ZUNvbHVtbnMoKSBjb25zdAogewogICAgIC8vIFRoZSBmb2xsb3dp bmcgdHlwZXMgYXJlIG5vdCBzdXBwb3NlZCB0byBjcmVhdGUgbXVsdGljb2wgY29udGV4dC4KICAg ICBpZiAoaXNSZW5kZXJGaWxlVXBsb2FkQ29udHJvbCgpIHx8IGlzUmVuZGVyVGV4dENvbnRyb2wo KSB8fCBpc1JlbmRlckxpc3RCb3goKSkKQEAgLTQ4Myw5ICs0ODMsNiBAQCBib29sIFJlbmRlckJs b2NrRmxvdzo6d2lsbENyZWF0ZUNvbHVtbnMoc3RkOjpvcHRpb25hbDx1bnNpZ25lZD4gZGVzaXJl ZENvbHVtbkNvdQogI2VuZGlmCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgaWYgKGRlc2ly ZWRDb2x1bW5Db3VudCkKLSAgICAgICAgcmV0dXJuIGRlc2lyZWRDb2x1bW5Db3VudC52YWx1ZSgp ID4gMTsKLQogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiBmYWxzZTsKIH0K QEAgLTQ2NDEsMTQgKzQ2MzgsMTMgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmNoZWNrRm9yUGFn aW5hdGlvbkxvZ2ljYWxIZWlnaHRDaGFuZ2UoUmVsYXlvdXRDaGlsZHJlbiYgcmUKICAgICB9CiB9 CiAKLWJvb2wgUmVuZGVyQmxvY2tGbG93OjpyZXF1aXJlc0NvbHVtbnMoaW50IGRlc2lyZWRDb2x1 bW5Db3VudCkgY29uc3QKLXsgICAgCi0gICAgcmV0dXJuIHdpbGxDcmVhdGVDb2x1bW5zKGRlc2ly ZWRDb2x1bW5Db3VudCk7Citib29sIFJlbmRlckJsb2NrRmxvdzo6cmVxdWlyZXNGcmFnbWVudGVk RmxvdygpIGNvbnN0Cit7CisgICAgcmV0dXJuIHdpbGxDcmVhdGVDb2x1bW5zKCk7CiB9CiAKIHZv aWQgUmVuZGVyQmxvY2tGbG93OjpzZXRDb21wdXRlZENvbHVtbkNvdW50QW5kV2lkdGgoaW50IGNv dW50LCBMYXlvdXRVbml0IHdpZHRoKQogewotICAgIEFTU0VSVCghIW11bHRpQ29sdW1uRmxvdygp ID09IHJlcXVpcmVzQ29sdW1ucyhjb3VudCkpOwogICAgIGlmICghbXVsdGlDb2x1bW5GbG93KCkp CiAgICAgICAgIHJldHVybjsKICAgICBtdWx0aUNvbHVtbkZsb3coKS0+c2V0Q29sdW1uQ291bnRB bmRXaWR0aChjb3VudCwgd2lkdGgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrRmxvdy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrRmxvdy5oCmluZGV4IDI1ZDVhMDBmMzdlYy4uNzA5YmExMTczY2M2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5oCkBAIC0yODMsOCArMjgzLDggQEAgcHVi bGljOgogICAgIFJlbmRlck11bHRpQ29sdW1uRmxvdyogTk9ERUxFVEUgbXVsdGlDb2x1bW5GbG93 U2xvd0Nhc2UoKSBjb25zdDsKICAgICB2b2lkIHNldE11bHRpQ29sdW1uRmxvdyhSZW5kZXJNdWx0 aUNvbHVtbkZsb3cmKTsKICAgICB2b2lkIE5PREVMRVRFIGNsZWFyTXVsdGlDb2x1bW5GbG93KCk7 Ci0gICAgYm9vbCB3aWxsQ3JlYXRlQ29sdW1ucyhzdGQ6Om9wdGlvbmFsPHVuc2lnbmVkPiBkZXNp cmVkQ29sdW1uQ291bnQgPSBzdGQ6Om51bGxvcHQpIGNvbnN0OwotICAgIHZpcnR1YWwgYm9vbCBy ZXF1aXJlc0NvbHVtbnMoaW50KSBjb25zdDsKKyAgICBib29sIHdpbGxDcmVhdGVDb2x1bW5zKCkg Y29uc3Q7CisgICAgdmlydHVhbCBib29sIHJlcXVpcmVzRnJhZ21lbnRlZEZsb3coKSBjb25zdDsK IAogICAgIGJvb2wgY29udGFpbnNGbG9hdHMoKSBjb25zdCBvdmVycmlkZTsKICAgICBib29sIE5P REVMRVRFIGNvbnRhaW5zRmxvYXQoY29uc3QgUmVuZGVyQm94JikgY29uc3Q7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKaW5kZXggMjJlNGEwYTI3NTMyLi42MDYwMGM0NzVl Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAgLTMyMiw3ICsz MjIsNyBAQCB2b2lkIFJlbmRlclZpZXc6Om1hcEFic29sdXRlVG9Mb2NhbFBvaW50KE9wdGlvblNl dDxNYXBDb29yZGluYXRlc01vZGU+IG1vZGUsIFRyYQogICAgICAgICB0cmFuc2Zvcm1TdGF0ZS5t b3ZlKHRvTGF5b3V0U2l6ZShmcmFtZVZpZXcoKS5zY3JvbGxQb3NpdGlvblJlc3BlY3RpbmdDdXN0 b21GaXhlZFBvc2l0aW9uKCkpKTsKIH0KIAotYm9vbCBSZW5kZXJWaWV3OjpyZXF1aXJlc0NvbHVt bnMoaW50KSBjb25zdAorYm9vbCBSZW5kZXJWaWV3OjpyZXF1aXJlc0ZyYWdtZW50ZWRGbG93KCkg Y29uc3QKIHsKICAgICByZXR1cm4gZnJhbWVWaWV3KCkucGFnaW5hdGlvbigpLm1vZGUgIT0gUGFn aW5hdGlvbjo6TW9kZTo6VW5wYWdpbmF0ZWQ7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clZpZXcuaAppbmRleCAxNWVkMDU5NGQ0YTIuLmQyNzFhOTQ2M2E4NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVmlldy5oCkBAIC0yMzEsNyArMjMxLDcgQEAgcHJpdmF0ZToKICAgICB2 b2lkIG1hcExvY2FsVG9Db250YWluZXIoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCogcmVw YWludENvbnRhaW5lciwgVHJhbnNmb3JtU3RhdGUmLCBPcHRpb25TZXQ8TWFwQ29vcmRpbmF0ZXNN b2RlPiwgYm9vbCogd2FzRml4ZWQpIGNvbnN0IG92ZXJyaWRlOwogICAgIGNvbnN0IFJlbmRlckVs ZW1lbnQqIHB1c2hNYXBwaW5nVG9Db250YWluZXIoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVj dCogYW5jZXN0b3JUb1N0b3BBdCwgUmVuZGVyR2VvbWV0cnlNYXAmKSBjb25zdCBvdmVycmlkZTsK ICAgICB2b2lkIG1hcEFic29sdXRlVG9Mb2NhbFBvaW50KE9wdGlvblNldDxNYXBDb29yZGluYXRl c01vZGU+LCBUcmFuc2Zvcm1TdGF0ZSYpIGNvbnN0IG92ZXJyaWRlOwotICAgIGJvb2wgcmVxdWly ZXNDb2x1bW5zKGludCBkZXNpcmVkQ29sdW1uQ291bnQpIGNvbnN0IG92ZXJyaWRlOworICAgIGJv b2wgcmVxdWlyZXNGcmFnbWVudGVkRmxvdygpIGNvbnN0IG92ZXJyaWRlOwogCiAgICAgdm9pZCBj b21wdXRlQ29sdW1uQ291bnRBbmRXaWR0aCgpIG92ZXJyaWRlOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJNdWx0aUNvbHVt bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxk ZXJNdWx0aUNvbHVtbi5jcHAKaW5kZXggYTMwOTNiYjg1ZTNlLi5iZGI1NDJhZDJhNTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRl ck11bHRpQ29sdW1uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcv UmVuZGVyVHJlZUJ1aWxkZXJNdWx0aUNvbHVtbi5jcHAKQEAgLTE1MCw3ICsxNTAsNyBAQCBSZW5k ZXJUcmVlQnVpbGRlcjo6TXVsdGlDb2x1bW46Ok11bHRpQ29sdW1uKFJlbmRlclRyZWVCdWlsZGVy JiBidWlsZGVyKQogCiB2b2lkIFJlbmRlclRyZWVCdWlsZGVyOjpNdWx0aUNvbHVtbjo6dXBkYXRl QWZ0ZXJEZXNjZW5kYW50cyhSZW5kZXJCbG9ja0Zsb3cmIGZsb3cpCiB7Ci0gICAgYm9vbCBuZWVk c0ZyYWdtZW50ZWRGbG93ID0gZmxvdy5yZXF1aXJlc0NvbHVtbnMoZmxvdy5zdHlsZSgpLmNvbHVt bkNvdW50KCkudHJ5VmFsdWUoKS52YWx1ZV9vcigxKS52YWx1ZSk7CisgICAgYm9vbCBuZWVkc0Zy YWdtZW50ZWRGbG93ID0gZmxvdy5yZXF1aXJlc0ZyYWdtZW50ZWRGbG93KCk7CiAgICAgYm9vbCBo YXNGcmFnbWVudGVkRmxvdyA9IGZsb3cubXVsdGlDb2x1bW5GbG93KCk7CiAKICAgICBpZiAoIWhh c0ZyYWdtZW50ZWRGbG93ICYmIG5lZWRzRnJhZ21lbnRlZEZsb3cpIHsK