31465 2009-11-13 01:18:37 -0800 In testing handshake-error case, web_socket_do_extra_handshake calls non-existent method 2009-11-30 13:54:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yuzo webkit-unassigned ap eric oldest_to_newest 163265 0 yuzo 2009-11-13 01:18:37 -0800 In testing handshake-error case, web_socket_do_extra_handshake calls non-existent method and the following error is raised: WARNING:root:mod_pywebsocket: web_socket_do_extra_handshake raised exception: Traceback (most recent call last): File "/Users/yuzo/src/chromium/src/third_party/pywebsocket/mod_pywebsocket/dispatch.py", line 163, in do_extra_handshake do_extra_handshake_(request) File "<string>", line 34, in web_socket_do_extra_handshake AttributeError: '_StandaloneRequest' object has no attribute 'write' 163266 1 43148 yuzo 2009-11-13 01:19:50 -0800 Created attachment 43148 Fix: web_socket_do_extra_handshake calls non-existent method 163268 2 yuzo 2009-11-13 01:22:23 -0800 Hi, reviewers, Can you review this and submit it if it looks good? Sorry for not catching the bug when proposing the original patch. Yuzo 163269 3 43149 yuzo 2009-11-13 01:27:06 -0800 Created attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method 163438 4 43149 ap 2009-11-13 12:27:08 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method Why doesn't this mistake affect test output? Should it? r=me 163445 5 43149 eric 2009-11-13 12:31:45 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method In response to your above comment requesting submission: You can mark your patches commit-queue=? if you want them automatically submitted. 163446 6 eric 2009-11-13 12:32:07 -0800 See http://webkit.org/coding/contributing.html for documentation of the review and commit-queue flags. 163602 7 43149 commit-queue 2009-11-13 17:11:42 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method Rejecting patch 43149 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11623 test cases. http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header.html -> crashed Exiting early after 1 failures. 9152 tests run. 344.54s total testing time 9151 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 163605 8 43149 eric 2009-11-13 17:18:37 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method False rejection caused by bug 31461. 163608 9 43149 commit-queue 2009-11-13 17:34:17 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method Rejecting patch 43149 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11623 test cases. inspector/console-dir.html -> crashed Exiting early after 1 failures. 9314 tests run. 368.05s total testing time 9313 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 163620 10 43149 eric 2009-11-13 18:04:00 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method False rejection due to bug 31461. 163629 11 43149 commit-queue 2009-11-13 18:20:57 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method Rejecting patch 43149 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11623 test cases. http/tests/xmlhttprequest/abort-crash.html -> crashed Exiting early after 1 failures. 9147 tests run. 341.11s total testing time 9146 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 163631 12 43149 eric 2009-11-13 18:28:41 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method I'm disabling the commit-queue until bug 31461 can be solved. Sorry. I expect we'll find a solution to bug 31461 on monday at which point I"ll restart the queue and this will be committed. 164752 13 43149 commit-queue 2009-11-18 15:19:08 -0800 Comment on attachment 43149 Fix: web_socket_do_extra_handshake calls non-existent method Rejecting patch 43149 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11631 test cases. websocket/tests/handshake-error.html -> failed Exiting early after 1 failures. 11630 tests run. 387.22s total testing time 11629 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output 164849 14 eric 2009-11-18 17:51:25 -0800 Sorry this error wasn't discovered sooner. The commit-queue stops running tests after the first failure, and bug 31461 was masking this failure before. 164894 15 43482 yuzo 2009-11-18 21:24:15 -0800 Created attachment 43482 Fix: web_socket_do_extra_handshake calls non-existent method 164895 16 yuzo 2009-11-18 21:27:31 -0800 Sorry for the test breakage. I thought this test was in Skipped. I believe this patch itself is correct and should be checked in: it just revealed a hidden bug. I've filed https://bugs.webkit.org/show_bug.cgi?id=31659 I added (back) this test to Skipped. Yuzo 166825 17 43482 eric 2009-11-26 21:29:33 -0800 Comment on attachment 43482 Fix: web_socket_do_extra_handshake calls non-existent method OK. 166830 18 43482 commit-queue 2009-11-26 21:34:26 -0800 Comment on attachment 43482 Fix: web_socket_do_extra_handshake calls non-existent method Rejecting patch 43482 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 101. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patching file LayoutTests/websocket/tests/handshake-error_wsh.py 167407 19 ap 2009-11-30 13:37:02 -0800 Manually committed as <http://trac.webkit.org/changeset/51508>. I re-wrote the ChangeLog to make it a bit more informative. 167411 20 eric 2009-11-30 13:45:59 -0800 http://trac.webkit.org/changeset/51509 I don't think the tools did anything wrong here! :) I reviewed a later version of the patch. I'm not seeking credit, just making sure you're not unfairly blaming our innocent tools! ;) 167414 21 eric 2009-11-30 13:49:13 -0800 Btw, if you're using bugzilla-tool for any of this, I believe both land-* and apply-* accept a --reviewer argument which allows you to override reviewers in cases like this where the bug might have a different reviewer than you want the final patch to have. :) 167418 22 ap 2009-11-30 13:54:06 -0800 > I don't think the tools did anything wrong here! :) I reviewed a later version > of the patch. I'm not seeking credit, just making sure you're not unfairly > blaming our innocent tools! ;) OK, I didn't know you actually reviewed the change, not just set the flag per earlier review. The latter has certainly happened in the past (many of use did it, including myself). The reason I see tools share part of the blame is that almost good patches need to be reworked more often now, so reviews get forwarded by whoever gets to it first. This is mostly a good thing, but it makes reviewer info wrong in Bugzilla and in ChangeLogs. 43148 2009-11-13 01:19:50 -0800 2009-11-13 01:26:56 -0800 Fix: web_socket_do_extra_handshake calls non-existent method bug-31465-20091113181948.patch text/plain 1088 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZDI4ZTgxLi4xNDE4YzA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MTMgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeDogSW4gdGVzdGluZyBoYW5kc2hha2Ut ZXJyb3IgY2FzZSwgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UgY2FsbHMgbm9uLWV4aXN0 ZW50IG1ldGhvZAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTQ2NQorCisgICAgICAgICogd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1lcnJvcl93 c2gucHk6CisKIDIwMDktMTEtMTIgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGFuZHNoYWtlLWVycm9yX3dzaC5w eSBiL0xheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5Cmlu ZGV4IGRiYzcwN2EuLjY2NWZmMjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYnNvY2tldC90 ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL3dlYnNvY2tldC90 ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5CkBAIC0zMSw3ICszMSw3IEBAIGZyb20gbW9kX3B5 d2Vic29ja2V0IGltcG9ydCBtc2d1dGlsCiAKIAogZGVmIHdlYl9zb2NrZXRfZG9fZXh0cmFfaGFu ZHNoYWtlKHJlcXVlc3QpOgotICAgIHJlcXVlc3Qud3JpdGUoJ1RoaXNXaWxsQ2F1c2VIYW5kc2hh a2VFcnJvcicpCisgICAgbXNndXRpbC5zZW5kX21lc3NhZ2UocmVxdWVzdCwgJ1RoaXNXaWxsQ2F1 c2VIYW5kc2hha2VFcnJvcicpCiAKIAogZGVmIHdlYl9zb2NrZXRfdHJhbnNmZXJfZGF0YShyZXF1 ZXN0KTo= 43149 2009-11-13 01:27:06 -0800 2009-11-18 21:24:09 -0800 Fix: web_socket_do_extra_handshake calls non-existent method bug-31465-20091113182704.patch text/plain 1083 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZDI4ZTgxLi4xNDE4YzA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MTMgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeDogSW4gdGVzdGluZyBoYW5kc2hha2Ut ZXJyb3IgY2FzZSwgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UgY2FsbHMgbm9uLWV4aXN0 ZW50IG1ldGhvZAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTQ2NQorCisgICAgICAgICogd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1lcnJvcl93 c2gucHk6CisKIDIwMDktMTEtMTIgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGFuZHNoYWtlLWVycm9yX3dzaC5w eSBiL0xheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5Cmlu ZGV4IGRiYzcwN2EuLmM2N2QzYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYnNvY2tldC90 ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL3dlYnNvY2tldC90 ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5CkBAIC0zMSw3ICszMSw3IEBAIGZyb20gbW9kX3B5 d2Vic29ja2V0IGltcG9ydCBtc2d1dGlsCiAKIAogZGVmIHdlYl9zb2NrZXRfZG9fZXh0cmFfaGFu ZHNoYWtlKHJlcXVlc3QpOgotICAgIHJlcXVlc3Qud3JpdGUoJ1RoaXNXaWxsQ2F1c2VIYW5kc2hh a2VFcnJvcicpCisgICAgcmVxdWVzdC5jb25uZWN0aW9uLndyaXRlKCdUaGlzV2lsbENhdXNlSGFu ZHNoYWtlRXJyb3InKQogCiAKIGRlZiB3ZWJfc29ja2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6 43482 2009-11-18 21:24:15 -0800 2009-11-26 21:34:26 -0800 Fix: web_socket_do_extra_handshake calls non-existent method bug-31465-20091119142413.patch text/plain 1593 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MzFkOTZjLi5mMTc0ZjYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MTMgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeDogSW4gdGVzdGluZyBoYW5kc2hha2Ut ZXJyb3IgY2FzZSwgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UgY2FsbHMgbm9uLWV4aXN0 ZW50IG1ldGhvZAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTQ2NQorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6CisgICAgICAgICog d2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1lcnJvcl93c2gucHk6CisKIDIwMDktMTEtMTggIEtl bnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAppbmRleCA3M2E0NDM2Li5mZGUxMDRj IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZApAQCAtMTAxLDMgKzEwMSw3IEBAIGFjY2Vzc2li aWxpdHkvZG9jdW1lbnQtYXR0cmlidXRlcy5odG1sCiAKICMgTmVlZCB0byBhZGQgZnVuY3Rpb25h bGl0eSB0byBEdW1wUmVuZGVyVHJlZSB0byBoYW5kbGUgZXJyb3IgcGFnZXMKIGZhc3QvaGlzdG9y eS9iYWNrLWZvcndhcmQtcmVzZXQtYWZ0ZXItZXJyb3ItaGFuZGxpbmcuaHRtbAorCisjIFNraXBw ZWQgdW50aWwgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjU5IGlz IGZpeGVkLgord2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1lcnJvci5odG1sCisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZXJyb3Jfd3NoLnB5IGIv TGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1lcnJvcl93c2gucHkKaW5kZXgg ZGJjNzA3YS4uYzY3ZDNhNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2hhbmRzaGFrZS1lcnJvcl93c2gucHkKKysrIGIvTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2hhbmRzaGFrZS1lcnJvcl93c2gucHkKQEAgLTMxLDcgKzMxLDcgQEAgZnJvbSBtb2RfcHl3ZWJz b2NrZXQgaW1wb3J0IG1zZ3V0aWwKIAogCiBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hh a2UocmVxdWVzdCk6Ci0gICAgcmVxdWVzdC53cml0ZSgnVGhpc1dpbGxDYXVzZUhhbmRzaGFrZUVy cm9yJykKKyAgICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUoJ1RoaXNXaWxsQ2F1c2VIYW5kc2hh a2VFcnJvcicpCiAKIAogZGVmIHdlYl9zb2NrZXRfdHJhbnNmZXJfZGF0YShyZXF1ZXN0KToK