31462 2009-11-13 00:46:57 -0800 Chromium should not register its VFS as the default VFS 2009-11-13 11:34:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi dglazkov michaeln oldest_to_newest 163257 0 dumi 2009-11-13 00:46:57 -0800 Currently Chromium registers its HTML5 DB-specific VFS as the default VFS in all renderer processes. This is fine as long as HTML5 DBs is the only feature using sqlite databases in those processes. However, as soon as there are other sqlite DB users in the same process (DB tracker in test_shell, for example), they fail, because they don't expect to deal with a custom VFS. To fix this, we should keep the default sqlite VFS as the default VFS, and the HTML5 DB code can explicitly call the custom VFS by name. 163264 1 43147 dumi 2009-11-13 01:04:21 -0800 Created attachment 43147 patch 163308 2 43147 dglazkov 2009-11-13 07:26:39 -0800 Comment on attachment 43147 patch ok. 163380 3 dumi 2009-11-13 11:34:10 -0800 Landed as r50954. 43147 2009-11-13 01:04:21 -0800 2009-11-13 07:26:39 -0800 patch patch text/plain 2941 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDkzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTEtMTMgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEbyBub3QgcmVnaXN0ZXIgQ2hyb21pdW0ncyBIVE1MNSBEQiBWRlMgYXMgdGhlIGRlZmF1bHQK KyAgICAgICAgVkZTLiBPdGhlcndpc2UsIG90aGVyIHNxbGl0ZSBEQiB1c2VycyBpbiB0aGUgc2Ft ZSBwcm9jZXNzIHdpbGwKKyAgICAgICAgc3RvcCB3b3JraW5nLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ2MgorCisgICAgICAgICogcGxhdGZv cm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTUUxpdGVGaWxlU3lzdGVtOjpvcGVuRGF0YWJhc2UpOgorICAgICAgICAqIHBsYXRm b3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW1Qb3NpeC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTUUxpdGVGaWxlU3lzdGVtOjpyZWdpc3RlclNRTGl0ZVZGUyk6CisgICAg ICAgICogcGxhdGZvcm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVdpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVGaWxlU3lzdGVtOjpyZWdpc3RlclNRTGl0ZVZG Uyk6CisKIDIwMDktMTEtMTIgIEFuYW50YW5hcmF5YW5hbiBHIEl5ZW5nYXIgIDxhbmFudGFAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0 ZW1DaHJvbWl1bS5jcHAJKHJldmlzaW9uIDUwOTMxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9zcWwv Y2hyb21pdW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTgsNyArNTgsOCBAQCBpbnQgU1FMaXRlRmlsZVN5c3RlbTo6b3BlbkRhdGFiYXNlKGNvbnN0CiAg ICAgLy8gb3BlbiBkYXRhYmFzZXMgdXNpbmcgdGhlIGRlZmF1bHQgVkZTCiAgICAgLy8gaW4gcmVu ZGVyZXJzLCBpdCBzaG91bGQgYmUgQ2hyb21pdW0ncyBWRlM7IGluIHRoZSBicm93c2VyIHByb2Nl c3MgaXQgc2hvdWxkIGJlIFNRTGl0ZSdzIGRlZmF1bHQgVkZTCiAgICAgcmV0dXJuIHNxbGl0ZTNf b3Blbl92MihmaWxlTmFtZS51dGY4KCkuZGF0YSgpLCBkYXRhYmFzZSwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgIFNRTElURV9PUEVOX1JFQURXUklURSB8IFNRTElURV9PUEVOX0NSRUFURSB8 IFNRTElURV9PUEVOX0ZVTExNVVRFWCwgMCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICBT UUxJVEVfT1BFTl9SRUFEV1JJVEUgfCBTUUxJVEVfT1BFTl9DUkVBVEUgfCBTUUxJVEVfT1BFTl9G VUxMTVVURVgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAiY2hyb21pdW1fdmZzIik7CiB9 CiAKIFN0cmluZyBTUUxpdGVGaWxlU3lzdGVtOjpnZXRGaWxlTmFtZUZvck5ld0RhdGFiYXNlKApJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmlsZVN5c3RlbUNocm9t aXVtUG9zaXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vc3FsL2Nocm9taXVt L1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVBvc2l4LmNwcAkocmV2aXNpb24gNTA5MzEpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW1Qb3Np eC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwMCw3ICsyMDAsNyBAQCB2b2lkIFNRTGl0ZUZpbGVT eXN0ZW06OnJlZ2lzdGVyU1FMaXRlVkZTCiAgICAgICAgIHVuaXhfdmZzLT54Q3VycmVudFRpbWUs CiAgICAgICAgIHVuaXhfdmZzLT54R2V0TGFzdEVycm9yCiAgICAgfTsKLSAgICBzcWxpdGUzX3Zm c19yZWdpc3RlcigmY2hyb21pdW1fdmZzLCAxKTsKKyAgICBzcWxpdGUzX3Zmc19yZWdpc3Rlcigm Y2hyb21pdW1fdmZzLCAwKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtV2luLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxl U3lzdGVtQ2hyb21pdW1XaW4uY3BwCShyZXZpc2lvbiA1MDkzMSkKKysrIFdlYkNvcmUvcGxhdGZv cm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVdpbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTE2OSw3ICsxNjksNyBAQCB2b2lkIFNRTGl0ZUZpbGVTeXN0ZW06OnJlZ2lzdGVy U1FMaXRlVkZTCiAgICAgICAgIHdpbjMyX3Zmcy0+eEN1cnJlbnRUaW1lLAogICAgICAgICB3aW4z Ml92ZnMtPnhHZXRMYXN0RXJyb3IKICAgICB9OwotICAgIHNxbGl0ZTNfdmZzX3JlZ2lzdGVyKCZj aHJvbWl1bV92ZnMsIDEpOworICAgIHNxbGl0ZTNfdmZzX3JlZ2lzdGVyKCZjaHJvbWl1bV92ZnMs IDApOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==