31459 2009-11-12 23:49:59 -0800 WebCore::externalRepresentation should update layout before getting render object 2009-11-13 16:07:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned darin oldest_to_newest 163245 0 hamaji 2009-11-12 23:49:59 -0800 This refactoring is suggested in Bug 30555 and Bug 31393. 163246 1 43140 hamaji 2009-11-12 23:52:52 -0800 Created attachment 43140 Patch v1 163247 2 hamaji 2009-11-12 23:55:13 -0800 Actually, this change seems to fix the wrong test expectation for svg/custom/gradient-stop-style-change-expected . Though I don't know about this test at all, it seems the expectation becomes better (the color was originally #FF0000 (red) and now it is #008000 (green)). 163320 3 43140 darin 2009-11-13 08:42:39 -0800 Comment on attachment 43140 Patch v1 r=me 163571 4 43140 hamaji 2009-11-13 16:07:23 -0800 Comment on attachment 43140 Patch v1 Clearing flags on attachment: 43140 Committed r50976: <http://trac.webkit.org/changeset/50976> 163572 5 hamaji 2009-11-13 16:07:31 -0800 All reviewed patches have been landed. Closing bug. 43140 2009-11-12 23:52:52 -0800 2009-11-13 16:07:22 -0800 Patch v1 bug-31459-20091113165250.patch text/plain 2813 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyODY4MTU0Li4zODc2MzFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEt MTIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJDb3JlOjpleHRlcm5hbFJl cHJlc2VudGF0aW9uIHNob3VsZCB1cGRhdGUgbGF5b3V0IGJlZm9yZSBnZXR0aW5nIHJlbmRlciBv YmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx NDU5CisKKyAgICAgICAgQmVmb3JlIHRoaXMgY2hhbmdlLCB0aGUgcmVuZGVyIHRyZWUgb3V0cHV0 IGZvciB0aGlzIHRlc3Qgd2FzIHdyb25nLgorICAgICAgICBOb3RlIHRoYXQgI0ZGMDAwMCAocmVk KSBiZWNvbWVzICMwMDgwMDAgKGdyZWVuKSBub3cuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv c3ZnL2N1c3RvbS9ncmFkaWVudC1zdG9wLXN0eWxlLWNoYW5nZS1leHBlY3RlZC50eHQ6CisKIDIw MDktMTEtMTIgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL3N2Zy9jdXN0b20vZ3JhZGllbnQtc3RvcC1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vZ3JhZGllbnQtc3RvcC1zdHlsZS1j aGFuZ2UtZXhwZWN0ZWQudHh0CmluZGV4IDAwYjhhMGIuLmY4OWFmYjEgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvY3VzdG9tL2dyYWRpZW50LXN0b3Atc3R5bGUtY2hh bmdlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1c3Rv bS9ncmFkaWVudC1zdG9wLXN0eWxlLWNoYW5nZS1leHBlY3RlZC50eHQKQEAgLTEsNCArMSw0IEBA Ci1LUmVuZGVyaW5nUGFpbnRTZXJ2ZXIge2lkPSJ0ZXN0IiBbdHlwZT1MSU5FQVItR1JBRElFTlRd IFtzdG9wcz1bKDAuMDAsI0ZGMDAwMCldXSBbc3RhcnQ9KDAsMCldIFtlbmQ9KDEsMCldfQorS1Jl bmRlcmluZ1BhaW50U2VydmVyIHtpZD0idGVzdCIgW3R5cGU9TElORUFSLUdSQURJRU5UXSBbc3Rv cHM9WygwLjAwLCMwMDgwMDApXV0gW3N0YXJ0PSgwLDApXSBbZW5kPSgxLDApXX0KIGxheWVyIGF0 ICgwLDApIHNpemUgODAweDYwMAogICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAog bGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBkMWQ5MmIuLmUwMjQzNWMgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMDktMTEtMTIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJDb3Jl OjpleHRlcm5hbFJlcHJlc2VudGF0aW9uIHNob3VsZCB1cGRhdGUgbGF5b3V0IGJlZm9yZSBnZXR0 aW5nIHJlbmRlciBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMxNDU5CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpleHRlcm5hbFJlcHJlc2VudGF0aW9uKToKKwogMjAwOS0x MS0xMiAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRyZWVBc1RleHQuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4 dC5jcHAKaW5kZXggYWYwZDgyNS4uZDQ2ODRlNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVHJlZUFzVGV4dC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVHJl ZUFzVGV4dC5jcHAKQEAgLTU0MSw2ICs1NDEsOCBAQCBzdGF0aWMgdm9pZCB3cml0ZVNlbGVjdGlv bihUZXh0U3RyZWFtJiB0cywgY29uc3QgUmVuZGVyT2JqZWN0KiBvKQogCiBTdHJpbmcgZXh0ZXJu YWxSZXByZXNlbnRhdGlvbihGcmFtZSogZnJhbWUpCiB7CisgICAgZnJhbWUtPmRvY3VtZW50KCkt PnVwZGF0ZUxheW91dCgpOworCiAgICAgUmVuZGVyT2JqZWN0KiBvID0gZnJhbWUtPmNvbnRlbnRS ZW5kZXJlcigpOwogICAgIGlmICghbykKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwpAQCAtNTQ5 LDggKzU1MSw2IEBAIFN0cmluZyBleHRlcm5hbFJlcHJlc2VudGF0aW9uKEZyYW1lKiBmcmFtZSkK ICNpZiBFTkFCTEUoU1ZHKQogICAgIHdyaXRlUmVuZGVyUmVzb3VyY2VzKHRzLCBvLT5kb2N1bWVu dCgpKTsKICNlbmRpZgotICAgIGlmIChvLT52aWV3KCktPmZyYW1lVmlldygpKQotICAgICAgICBv LT52aWV3KCktPmZyYW1lVmlldygpLT5sYXlvdXQoKTsKICAgICBpZiAoby0+aGFzTGF5ZXIoKSkg ewogICAgICAgICBSZW5kZXJMYXllciogbCA9IHRvUmVuZGVyQm94KG8pLT5sYXllcigpOwogICAg ICAgICB3cml0ZUxheWVycyh0cywgbCwgbCwgSW50UmVjdChsLT54KCksIGwtPnkoKSwgbC0+d2lk dGgoKSwgbC0+aGVpZ2h0KCkpKTs=