31458 2009-11-12 23:29:34 -0800 bugzilla-tool should post git binary diff 2009-11-15 21:40:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 31457 1 hamaji webkit-unassigned abarth oldest_to_newest 163240 0 hamaji 2009-11-12 23:29:34 -0800 As we are getting ready for handling git binary patches, let's add --binary option into Git.create_patch() in scm.py. 163241 1 43139 hamaji 2009-11-12 23:30:45 -0800 Created attachment 43139 Patch v1 163242 2 hamaji 2009-11-12 23:31:38 -0800 Note that the unittest I added will fail due to Bug 31457 . 163243 3 43139 hamaji 2009-11-12 23:37:07 -0800 Comment on attachment 43139 Patch v1 Ah, I should have modified create_patch_from_local_commit and create_patch_since_local_commit as well. Clearing the review bit. 163251 4 43141 hamaji 2009-11-13 00:05:50 -0800 Created attachment 43141 Patch v2 163252 5 hamaji 2009-11-13 00:07:02 -0800 (In reply to comment #4) > Created an attachment (id=43141) [details] > Patch v2 I added --binary flag for these two commands as well. 163465 6 43141 eric 2009-11-13 13:14:54 -0800 Comment on attachment 43141 Patch v2 LGTM. 163797 7 43141 abarth 2009-11-15 15:32:43 -0800 Comment on attachment 43141 Patch v2 Clearing flags on attachment: 43141 Committed r51005: <http://trac.webkit.org/changeset/51005> 163798 8 abarth 2009-11-15 15:32:48 -0800 All reviewed patches have been landed. Closing bug. 163841 9 hamaji 2009-11-15 21:40:26 -0800 (In reply to comment #8) > All reviewed patches have been landed. Closing bug. Thanks for landing this patch. However, this patch will make unittest (GitTest.test_create_binary_patch) fail until Bug 31457 will be fixed. I guess we don't need to rollback this change because unittests aren't running in buildbot. I'll ask someone to review Bug 31457. I think I should have set commit-queue- for this patch to mention this fact, sorry. 43139 2009-11-12 23:30:45 -0800 2009-11-12 23:37:06 -0800 Patch v1 bug-31458-20091113163043.patch text/plain 2348 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiODQ5ZTAwLi43MjRmYmY1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEt MTIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIHNob3Vs ZCBwb3N0IGdpdCBiaW5hcnkgZGlmZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzE0NTgKKworICAgICAgICBBZGQgLS1iaW5hcnkgb3B0aW9uIHRvIEdp dC5jcmVhdGVfcGF0Y2guCisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvc2NtLnB5OgorICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHk6CisKIDIwMDktMTEtMTEgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9z Y20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5CmluZGV4IDNmZmEyM2Iu LjhlYTkzMjMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY20ucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQpAQCAtNDUwLDcgKzQ1MCw3 IEBAIGNsYXNzIEdpdChTQ00pOgogICAgICAgICByZXR1cm4gImdpdCIKIAogICAgIGRlZiBjcmVh dGVfcGF0Y2goc2VsZik6Ci0gICAgICAgIHJldHVybiBzZWxmLnJ1bl9jb21tYW5kKFsnZ2l0Jywg J2RpZmYnLCAnSEVBRCddKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5fY29tbWFuZChbJ2dpdCcs ICdkaWZmJywgJy0tYmluYXJ5JywgJ0hFQUQnXSkKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRl ZiBnaXRfY29tbWl0X2Zyb21fc3ZuX3JldmlzaW9uKGNscywgcmV2aXNpb24pOgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbV91bml0dGVzdC5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHkKaW5kZXggM2Y4NmVmNS4uNTUwMDYw YiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbV91bml0dGVzdC5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtX3VuaXR0ZXN0LnB5CkBAIC01 NjAsNSArNTYwLDIyIEBAIGNsYXNzIEdpdFRlc3QoU0NNVGVzdCk6CiAgICAgZGVmIHRlc3Rfc3Zu X2FwcGx5X2dpdF9wYXRjaChzZWxmKToKICAgICAgICAgc2VsZi5fc2hhcmVkX3Rlc3Rfc3ZuX2Fw cGx5X2dpdF9wYXRjaCgpCiAKKyAgICBkZWYgdGVzdF9jcmVhdGVfYmluYXJ5X3BhdGNoKHNlbGYp OgorICAgICAgICAjIENyZWF0ZSBhIGdpdCBiaW5hcnkgcGF0Y2ggYW5kIGNoZWNrIHRoZSBjb250 ZW50cy4KKyAgICAgICAgc2NtID0gZGV0ZWN0X3NjbV9zeXN0ZW0oc2VsZi5naXRfY2hlY2tvdXRf cGF0aCkKKyAgICAgICAgdGVzdF9maWxlX3BhdGggPSBvcy5wYXRoLmpvaW4oc2VsZi5naXRfY2hl Y2tvdXRfcGF0aCwgJ2JpbmFyeV9maWxlJykKKyAgICAgICAgZmlsZV9jb250ZW50cyA9ICcnLmpv aW4obWFwKGNociwgcmFuZ2UoMjU2KSkpCisgICAgICAgIHdyaXRlX2ludG9fZmlsZV9hdF9wYXRo KHRlc3RfZmlsZV9wYXRoLCBmaWxlX2NvbnRlbnRzKQorICAgICAgICBydW4oWydnaXQnLCAnYWRk JywgdGVzdF9maWxlX3BhdGhdKQorICAgICAgICBwYXRjaCA9IHNjbS5jcmVhdGVfcGF0Y2goKQor ICAgICAgICBzZWxmLmFzc2VydFRydWUocmUuc2VhcmNoKHInXG5saXRlcmFsIDBcbicsIHBhdGNo KSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHJlLnNlYXJjaChyJ1xubGl0ZXJhbCAyNTZcbics IHBhdGNoKSkKKworICAgICAgICAjIENoZWNrIGlmIHdlIGNhbiBhcHBseSB0aGUgY3JlYXRlZCBw YXRjaC4KKyAgICAgICAgcnVuKFsnZ2l0JywgJ3JtJywgJy1mJywgdGVzdF9maWxlX3BhdGhdKQor ICAgICAgICBzZWxmLl9zZXR1cF93ZWJraXR0b29sc19zY3JpcHRzX3N5bWxpbmsoc2NtKQorICAg ICAgICBwcmludCBzZWxmLnNjbS5hcHBseV9wYXRjaChzZWxmLl9jcmVhdGVfcGF0Y2gocGF0Y2gp KQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGZpbGVfY29udGVudHMsIHJlYWRfZnJvbV9wYXRo KHRlc3RfZmlsZV9wYXRoKSkKKwogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0 dGVzdC5tYWluKCk= 43141 2009-11-13 00:05:50 -0800 2009-11-15 15:32:43 -0800 Patch v2 bug-31458-20091113170548.patch text/plain 3761 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiODQ5ZTAwLi43MjRmYmY1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEt MTIgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIHNob3Vs ZCBwb3N0IGdpdCBiaW5hcnkgZGlmZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzE0NTgKKworICAgICAgICBBZGQgLS1iaW5hcnkgb3B0aW9uIHRvIEdp dC5jcmVhdGVfcGF0Y2guCisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvc2NtLnB5OgorICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHk6CisKIDIwMDktMTEtMTEgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9z Y20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5CmluZGV4IDNmZmEyM2Iu Ljk0ZWIzOTMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY20ucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQpAQCAtNDUwLDcgKzQ1MCw3 IEBAIGNsYXNzIEdpdChTQ00pOgogICAgICAgICByZXR1cm4gImdpdCIKIAogICAgIGRlZiBjcmVh dGVfcGF0Y2goc2VsZik6Ci0gICAgICAgIHJldHVybiBzZWxmLnJ1bl9jb21tYW5kKFsnZ2l0Jywg J2RpZmYnLCAnSEVBRCddKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5fY29tbWFuZChbJ2dpdCcs ICdkaWZmJywgJy0tYmluYXJ5JywgJ0hFQUQnXSkKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRl ZiBnaXRfY29tbWl0X2Zyb21fc3ZuX3JldmlzaW9uKGNscywgcmV2aXNpb24pOgpAQCAtNDkzLDEw ICs0OTMsMTAgQEAgY2xhc3MgR2l0KFNDTSk6CiAgICAgIyBHaXQtc3BlY2lmaWMgbWV0aG9kczoK IAogICAgIGRlZiBjcmVhdGVfcGF0Y2hfZnJvbV9sb2NhbF9jb21taXQoc2VsZiwgY29tbWl0X2lk KToKLSAgICAgICAgcmV0dXJuIHNlbGYucnVuX2NvbW1hbmQoWydnaXQnLCAnZGlmZicsIGNvbW1p dF9pZCArICJeLi4iICsgY29tbWl0X2lkXSkKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuX2NvbW1h bmQoWydnaXQnLCAnZGlmZicsICctLWJpbmFyeScsIGNvbW1pdF9pZCArICJeLi4iICsgY29tbWl0 X2lkXSkKIAogICAgIGRlZiBjcmVhdGVfcGF0Y2hfc2luY2VfbG9jYWxfY29tbWl0KHNlbGYsIGNv bW1pdF9pZCk6Ci0gICAgICAgIHJldHVybiBzZWxmLnJ1bl9jb21tYW5kKFsnZ2l0JywgJ2RpZmYn LCBjb21taXRfaWRdKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5fY29tbWFuZChbJ2dpdCcsICdk aWZmJywgJy0tYmluYXJ5JywgY29tbWl0X2lkXSkKIAogICAgIGRlZiBjb21taXRfbG9jYWxseV93 aXRoX21lc3NhZ2Uoc2VsZiwgbWVzc2FnZSk6CiAgICAgICAgIHNlbGYucnVuX2NvbW1hbmQoWydn aXQnLCAnY29tbWl0JywgJy0tYWxsJywgJy1GJywgJy0nXSwgaW5wdXQ9bWVzc2FnZSkKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHkgYi9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtX3VuaXR0ZXN0LnB5CmluZGV4IDNmODZlZjUuLjBj YWMwMzcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRl c3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbV91bml0dGVzdC5weQpA QCAtNTYwLDUgKzU2MCwzNSBAQCBjbGFzcyBHaXRUZXN0KFNDTVRlc3QpOgogICAgIGRlZiB0ZXN0 X3N2bl9hcHBseV9naXRfcGF0Y2goc2VsZik6CiAgICAgICAgIHNlbGYuX3NoYXJlZF90ZXN0X3N2 bl9hcHBseV9naXRfcGF0Y2goKQogCisgICAgZGVmIHRlc3RfY3JlYXRlX2JpbmFyeV9wYXRjaChz ZWxmKToKKyAgICAgICAgIyBDcmVhdGUgYSBnaXQgYmluYXJ5IHBhdGNoIGFuZCBjaGVjayB0aGUg Y29udGVudHMuCisgICAgICAgIHNjbSA9IGRldGVjdF9zY21fc3lzdGVtKHNlbGYuZ2l0X2NoZWNr b3V0X3BhdGgpCisgICAgICAgIHRlc3RfZmlsZV9wYXRoID0gb3MucGF0aC5qb2luKHNlbGYuZ2l0 X2NoZWNrb3V0X3BhdGgsICdiaW5hcnlfZmlsZScpCisgICAgICAgIGZpbGVfY29udGVudHMgPSAn Jy5qb2luKG1hcChjaHIsIHJhbmdlKDI1NikpKQorICAgICAgICB3cml0ZV9pbnRvX2ZpbGVfYXRf cGF0aCh0ZXN0X2ZpbGVfcGF0aCwgZmlsZV9jb250ZW50cykKKyAgICAgICAgcnVuKFsnZ2l0Jywg J2FkZCcsIHRlc3RfZmlsZV9wYXRoXSkKKyAgICAgICAgcGF0Y2ggPSBzY20uY3JlYXRlX3BhdGNo KCkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHJlLnNlYXJjaChyJ1xubGl0ZXJhbCAwXG4nLCBw YXRjaCkpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShyZS5zZWFyY2gocidcbmxpdGVyYWwgMjU2 XG4nLCBwYXRjaCkpCisKKyAgICAgICAgIyBDaGVjayBpZiB3ZSBjYW4gYXBwbHkgdGhlIGNyZWF0 ZWQgcGF0Y2guCisgICAgICAgIHJ1bihbJ2dpdCcsICdybScsICctZicsIHRlc3RfZmlsZV9wYXRo XSkKKyAgICAgICAgc2VsZi5fc2V0dXBfd2Via2l0dG9vbHNfc2NyaXB0c19zeW1saW5rKHNjbSkK KyAgICAgICAgc2VsZi5zY20uYXBwbHlfcGF0Y2goc2VsZi5fY3JlYXRlX3BhdGNoKHBhdGNoKSkK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChmaWxlX2NvbnRlbnRzLCByZWFkX2Zyb21fcGF0aCh0 ZXN0X2ZpbGVfcGF0aCkpCisKKyAgICAgICAgIyBDaGVjayBpZiB3ZSBjYW4gY3JlYXRlIGEgcGF0 Y2ggZnJvbSBhIGxvY2FsIGNvbW1pdC4KKyAgICAgICAgd3JpdGVfaW50b19maWxlX2F0X3BhdGgo dGVzdF9maWxlX3BhdGgsIGZpbGVfY29udGVudHMpCisgICAgICAgIHJ1bihbJ2dpdCcsICdhZGQn LCB0ZXN0X2ZpbGVfcGF0aF0pCisgICAgICAgIHJ1bihbJ2dpdCcsICdjb21taXQnLCAnLW0nLCAn YmluYXJ5IGRpZmYnXSkKKyAgICAgICAgcGF0Y2hfZnJvbV9sb2NhbF9jb21taXQgPSBzY20uY3Jl YXRlX3BhdGNoX2Zyb21fbG9jYWxfY29tbWl0KCdIRUFEJykKKyAgICAgICAgc2VsZi5hc3NlcnRU cnVlKHJlLnNlYXJjaChyJ1xubGl0ZXJhbCAwXG4nLCBwYXRjaF9mcm9tX2xvY2FsX2NvbW1pdCkp CisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShyZS5zZWFyY2gocidcbmxpdGVyYWwgMjU2XG4nLCBw YXRjaF9mcm9tX2xvY2FsX2NvbW1pdCkpCisgICAgICAgIHBhdGNoX3NpbmNlX2xvY2FsX2NvbW1p dCA9IHNjbS5jcmVhdGVfcGF0Y2hfc2luY2VfbG9jYWxfY29tbWl0KCdIRUFEXjEnKQorICAgICAg ICBzZWxmLmFzc2VydFRydWUocmUuc2VhcmNoKHInXG5saXRlcmFsIDBcbicsIHBhdGNoX3NpbmNl X2xvY2FsX2NvbW1pdCkpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShyZS5zZWFyY2gocidcbmxp dGVyYWwgMjU2XG4nLCBwYXRjaF9zaW5jZV9sb2NhbF9jb21taXQpKQorICAgICAgICBzZWxmLmFz c2VydEVxdWFsKHBhdGNoX2Zyb21fbG9jYWxfY29tbWl0LCBwYXRjaF9zaW5jZV9sb2NhbF9jb21t aXQpCisKKwogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5tYWluKCk=