31452 2009-11-12 19:09:13 -0800 Fix worker-timeout.html layout test that fails in Chromium harness. 2009-11-13 10:08:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich dimich dglazkov oldest_to_newest 163179 0 dimich 2009-11-12 19:09:13 -0800 In DRT, the layoutTestController.notifyDone() captures the output immediately. In Chromium, the test_shell does the same. However, some layout tests (those that require multiprocess config) are running in ui_test Chromium harness that runs the full Chromium browser and uses different implementation of layoutTestController. In that one, the notifyDone() runs message loop for a while before capturing the output. This causes worker-timeout test to squeeze more lines into the log then expected. This is Chromium bug http://crbug.com/25548 The test keeps active interval firing while terminating, to verify that this doesn't cause a crash (it did at some point). So lets keep the interval firing but stop logging once notifyDone() is called. Patch forthcoming. 163184 1 43128 dimich 2009-11-12 19:22:21 -0800 Created attachment 43128 Proposed patch. 163358 2 dimich 2009-11-13 10:08:13 -0800 Landed: http://trac.webkit.org/changeset/50950 43128 2009-11-12 19:22:21 -0800 2009-11-13 08:45:03 -0800 Proposed patch. patch.txt text/plain 2258 dimich ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZDI4ZTgxLi4yNDc5Njg0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MTIgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHdvcmtlci10aW1lb3V0Lmh0bWwg bGF5b3V0IHRlc3QgdGhhdCBmYWlscyBpbiBDaHJvbWl1bSBoYXJuZXNzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0NTIKKworICAgICAgICAqIGZh c3Qvd29ya2Vycy93b3JrZXItdGltZW91dC5odG1sOgorICAgICAgICBTdG9wIGxvZ2dpbmcgdGlt ZXIgbWVzc2FnZXMgYXQgdGhlIHNhbWUgdGltZSBhcyBjYWxsaW5nIE5vdGlmeURvbmUoKSBiZWNh dXNlCisgICAgICAgIGluIHRlc3QgaGFybmVzcyBDaHJvbWl1bSB1c2VzIGZvciB3b3JrZXJzIGl0 IGRvZXMgbm90IGNhcHR1cmUgdGhlIG91dHB1dCBpbW1lZGlhdGVseS4KKwogMjAwOS0xMS0xMiAg QnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVy LXN0YW1wZWQgYnkgU3RldmUgRmFsa2VuYnVyZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3Qvd29ya2Vycy93b3JrZXItdGltZW91dC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJz L3dvcmtlci10aW1lb3V0Lmh0bWwKaW5kZXggYmNhNWMwZi4uMWRiZWE4ZSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci10aW1lb3V0Lmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci10aW1lb3V0Lmh0bWwKQEAgLTIsOSArMiwxMSBAQAog PHA+VGVzdCBUaW1lb3V0cyAoc2V0VGltZW91dCwgc2V0SW50ZXJ2YWwsIGNsZWFyVGltZW91dCwg Y2xlYXJJbnRlcnZhbCkuPC9wPgogPGRpdiBpZD1yZXN1bHQ+PC9kaXY+CiA8c2NyaXB0PgordmFy IGxvZ0lzRnJvemVuID0gZmFsc2U7CiBmdW5jdGlvbiBsb2cobWVzc2FnZSkKIHsKLSAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MICs9IG1lc3NhZ2UgKyAiPGJy PiI7CisgICAgaWYgKCFsb2dJc0Zyb3plbikKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInJlc3VsdCIpLmlubmVySFRNTCArPSBtZXNzYWdlICsgIjxicj4iOwogfQogCiBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CkBAIC0xNiw4ICsxOCwxNiBAQCB2YXIgd29ya2Vy ID0gbmV3IFdvcmtlcigncmVzb3VyY2VzL3dvcmtlci10aW1lb3V0LmpzJyk7CiAKIHdvcmtlci5v bm1lc3NhZ2UgPSBmdW5jdGlvbihldnQpIHsKICAgICBsb2coZXZ0LmRhdGEpOwotICAgIGlmIChl dnQuZGF0YSA9PSAiRE9ORSIgJiYgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgaWYgKGV2dC5kYXRhID09 ICJET05FIikgeworICAgICAgICAvLyBUaGlzIGZsYWcgaXMgbmVlZGVkIGJlY2F1c2UgaW4gQ2hy b21pdW0gcG9ydCwgdGhlIG5vdGlmeURvbmUoKSBkb2VzIG5vdCBpbW1lZGlhdGVseSBzbmFwc2hv dHMKKyAgICAgICAgLy8gdGhlIHJlc3VsdCBhbmQgdGhlIHN0aWxsLWZpcmluZyB0aW1lciBpbiB0 aGUgd29ya2VyIG1heSBjYXVzZSBtb3JlIG1lc3NhZ2VzIHRvIGJlIGxvZ2dlZCBiZWZvcmUKKyAg ICAgICAgLy8gYWN0dWFsIHRlcm1pbmF0aW9uIG9mIHRoZSB0ZXN0LiBIb3dldmVyIG9uZSBvYmpl Y3RpdmUgb2YgdGhlIHRlc3QgaXMgdG8ga2VlcCBhY3RpdmUgaW50ZXJ2YWwKKyAgICAgICAgLy8g d2hpbGUgdGhlIHdvcmtlciBnZXRzIGRlc3Ryb3llZCwgc28gd2UgZnJlZXplIGxvZyByYXRoZXIg dGhlbiBzdG9wIHRoZSBpbnRlcnZhbCBmcm9tIGZpcmluZy4KKyAgICAgICAgLy8gU2VlIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ1MiBmb3IgbW9yZSBpbmZvLgor ICAgICAgICBsb2dJc0Zyb3plbiA9IHRydWU7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25l KCk7CisgICAgfSAKIH0KIDwvc2NyaXB0PgogPC9ib2R5Pgo=