<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31449</bug_id>
          
          <creation_ts>2009-11-12 18:40:56 -0800</creation_ts>
          <short_desc>Rename fileName parameters to vfsFileName in all DB-related methods</short_desc>
          <delta_ts>2009-12-28 23:10:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dumitru Daniliuc">dumi</reporter>
          <assigned_to name="Dumitru Daniliuc">dumi</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>michaeln</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>163157</commentid>
    <comment_count>0</comment_count>
    <who name="Dumitru Daniliuc">dumi</who>
    <bug_when>2009-11-12 18:40:56 -0800</bug_when>
    <thetext>Rename fileName parameters to vfsFileName in all DB-related methods, since those parameters are no longer real files names, but rather some VFS string tokens.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163168</commentid>
    <comment_count>1</comment_count>
      <attachid>43125</attachid>
    <who name="Dumitru Daniliuc">dumi</who>
    <bug_when>2009-11-12 18:57:00 -0800</bug_when>
    <thetext>Created attachment 43125
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163185</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Nordman">michaeln</who>
    <bug_when>2009-11-12 19:23:39 -0800</bug_when>
    <thetext>fwiw... lgtm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163207</commentid>
    <comment_count>3</comment_count>
      <attachid>43125</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-11-12 21:08:10 -0800</bug_when>
    <thetext>Comment on attachment 43125
patch

ok.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175434</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-28 23:04:35 -0800</bug_when>
    <thetext>Did this land?  It&apos;s been approved for over a month and a half?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175435</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-28 23:10:12 -0800</bug_when>
    <thetext>Looks like it did.  r50928

Note &quot;bugzilla-tool land-*&quot; or &quot;bugzilla-tool mark-fixed&quot; will handle closing bugs and adding the landing revision for you if you wish for script-based assistance. :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43125</attachid>
            <date>2009-11-12 18:57:00 -0800</date>
            <delta_ts>2009-11-12 21:08:10 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>6012</size>
            <attacher name="Dumitru Daniliuc">dumi</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MDkyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTIgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t
aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBSZW5hbWluZyBzb21lIHBhcmFtZXRlcnMgcGFzc2VkIHRvIERCLXJlbGF0ZWQgbWV0aG9kcyB0
byBiZXR0ZXIKKyAgICAgICAgaW5kaWNhdGUgdGhlaXIgcHVycG9zZS4KKworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0NDkKKworICAgICAgICAqIHBs
YXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmg6CisKIDIwMDktMTEtMTIgIFNoaW5pY2hp
cm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE
YXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1Ccmlk
Z2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJp
ZGdlLmgJKHJldmlzaW9uIDUwOTIyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJv
bWl1bUJyaWRnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsMTMgKzExOCwxMyBAQCBuYW1lc3Bh
Y2UgV2ViQ29yZSB7CiAgICAgICAgIC8vIEhUTUw1IERCIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAjaWYgRU5BQkxFKERBVEFCQVNF
KQogICAgICAgICAvLyBSZXR1cm5zIGEgaGFuZGxlIHRvIHRoZSBEQiBmaWxlIGFuZCBvb3B0aW9u
YWxseSBhIGhhbmRsZSB0byBpdHMgY29udGFpbmluZyBkaXJlY3RvcnkKLSAgICAgICAgc3RhdGlj
IFBsYXRmb3JtRmlsZUhhbmRsZSBkYXRhYmFzZU9wZW5GaWxlKGNvbnN0IFN0cmluZyYgZmlsZU5h
bWUsIGludCBkZXNpcmVkRmxhZ3MsIFBsYXRmb3JtRmlsZUhhbmRsZSogZGlySGFuZGxlID0gMCk7
CisgICAgICAgIHN0YXRpYyBQbGF0Zm9ybUZpbGVIYW5kbGUgZGF0YWJhc2VPcGVuRmlsZShjb25z
dCBTdHJpbmcmIHZmc0ZsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3MsIFBsYXRmb3JtRmlsZUhhbmRs
ZSogZGlySGFuZGxlID0gMCk7CiAgICAgICAgIC8vIFJldHVybnMgYSBTUUxpdGUgY29kZSAoU1FM
SVRFX09LID0gMCwgb24gc3VjY2VzcykKLSAgICAgICAgc3RhdGljIGludCBkYXRhYmFzZURlbGV0
ZUZpbGUoY29uc3QgU3RyaW5nJiBmaWxlTmFtZSwgYm9vbCBzeW5jRGlyID0gZmFsc2UpOworICAg
ICAgICBzdGF0aWMgaW50IGRhdGFiYXNlRGVsZXRlRmlsZShjb25zdCBTdHJpbmcmIHZmc0ZpbGVO
YW1lLCBib29sIHN5bmNEaXIgPSBmYWxzZSk7CiAgICAgICAgIC8vIFJldHVybnMgdGhlIGF0dHJp
YnV0ZXMgb2YgdGhlIERCIGZpbGUKLSAgICAgICAgc3RhdGljIGxvbmcgZGF0YWJhc2VHZXRGaWxl
QXR0cmlidXRlcyhjb25zdCBTdHJpbmcmIGZpbGVOYW1lKTsKKyAgICAgICAgc3RhdGljIGxvbmcg
ZGF0YWJhc2VHZXRGaWxlQXR0cmlidXRlcyhjb25zdCBTdHJpbmcmIHZmc0ZpbGVOYW1lKTsKICAg
ICAgICAgLy8gUmV0dXJucyB0aGUgc2l6ZSBvZiB0aGUgREIgZmlsZQotICAgICAgICBzdGF0aWMg
bG9uZyBsb25nIGRhdGFiYXNlR2V0RmlsZVNpemUoY29uc3QgU3RyaW5nJiBmaWxlTmFtZSk7Cisg
ICAgICAgIHN0YXRpYyBsb25nIGxvbmcgZGF0YWJhc2VHZXRGaWxlU2l6ZShjb25zdCBTdHJpbmcm
IHZmc0ZpbGVOYW1lKTsKICNlbmRpZgogCiAgICAgICAgIC8vIEphdmFTY3JpcHQgLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkluZGV4OiBX
ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cJKHJldmlzaW9uIDUwOTIzKQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwko
d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDA5LTExLTEyICBEdW1pdHJ1IERhbmls
aXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgUmVuYW1pbmcgc29tZSBwYXJhbWV0ZXJzIHBhc3NlZCB0byBEQi1y
ZWxhdGVkIG1ldGhvZHMgdG8gYmV0dGVyCisgICAgICAgIGluZGljYXRlIHRoZWlyIHB1cnBvc2Uu
CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDQ5
CisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Q2xpZW50Lmg6CisgICAgICAgICogc3JjL0Nocm9t
aXVtQnJpZGdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpkYXRhYmFz
ZU9wZW5GaWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpkYXRhYmFzZURl
bGV0ZUZpbGUpOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21pdW1CcmlkZ2U6OmRhdGFiYXNlR2V0
RmlsZUF0dHJpYnV0ZXMpOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21pdW1CcmlkZ2U6OmRhdGFi
YXNlR2V0RmlsZVNpemUpOgorCiAyMDA5LTExLTEyICBBZGFtIEJhcnRoICA8YWJhcnRoPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1
bS9wdWJsaWMvV2ViS2l0Q2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1
YmxpYy9XZWJLaXRDbGllbnQuaAkocmV2aXNpb24gNTA5MjIpCisrKyBXZWJLaXQvY2hyb21pdW0v
cHVibGljL1dlYktpdENsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzcsMTYgKzEzNywxNiBA
QCBwdWJsaWM6CiAgICAgLy8gT3BlbnMgYSBkYXRhYmFzZSBmaWxlOyBkaXJIYW5kbGUgc2hvdWxk
IGJlIDAgaWYgdGhlIGNhbGxlciBkb2VzIG5vdCBuZWVkCiAgICAgLy8gYSBoYW5kbGUgdG8gdGhl
IGRpcmVjdG9yeSBjb250YWluaW5nIHRoaXMgZmlsZQogICAgIHZpcnR1YWwgRmlsZUhhbmRsZSBk
YXRhYmFzZU9wZW5GaWxlKAotICAgICAgICBjb25zdCBXZWJTdHJpbmcmIGZpbGVOYW1lLCBpbnQg
ZGVzaXJlZEZsYWdzLCBGaWxlSGFuZGxlKiBkaXJIYW5kbGUpID0gMDsKKyAgICAgICAgY29uc3Qg
V2ViU3RyaW5nJiB2ZnNGaWxlTmFtZSwgaW50IGRlc2lyZWRGbGFncywgRmlsZUhhbmRsZSogZGly
SGFuZGxlKSA9IDA7CiAKICAgICAvLyBEZWxldGVzIGEgZGF0YWJhc2UgZmlsZSBhbmQgcmV0dXJu
cyB0aGUgZXJyb3IgY29kZQotICAgIHZpcnR1YWwgaW50IGRhdGFiYXNlRGVsZXRlRmlsZShjb25z
dCBXZWJTdHJpbmcmIGZpbGVOYW1lLCBib29sIHN5bmNEaXIpID0gMDsKKyAgICB2aXJ0dWFsIGlu
dCBkYXRhYmFzZURlbGV0ZUZpbGUoY29uc3QgV2ViU3RyaW5nJiB2ZnNGaWxlTmFtZSwgYm9vbCBz
eW5jRGlyKSA9IDA7CiAKICAgICAvLyBSZXR1cm5zIHRoZSBhdHRyaWJ1dGVzIG9mIHRoZSBnaXZl
biBkYXRhYmFzZSBmaWxlCi0gICAgdmlydHVhbCBsb25nIGRhdGFiYXNlR2V0RmlsZUF0dHJpYnV0
ZXMoY29uc3QgV2ViU3RyaW5nJiBmaWxlTmFtZSkgPSAwOworICAgIHZpcnR1YWwgbG9uZyBkYXRh
YmFzZUdldEZpbGVBdHRyaWJ1dGVzKGNvbnN0IFdlYlN0cmluZyYgdmZzRmlsZU5hbWUpID0gMDsK
IAogICAgIC8vIFJldHVybnMgdGhlIHNpemUgb2YgdGhlIGdpdmVuIGRhdGFiYXNlIGZpbGUKLSAg
ICB2aXJ0dWFsIGxvbmcgbG9uZyBkYXRhYmFzZUdldEZpbGVTaXplKGNvbnN0IFdlYlN0cmluZyYg
ZmlsZU5hbWUpID0gMDsKKyAgICB2aXJ0dWFsIGxvbmcgbG9uZyBkYXRhYmFzZUdldEZpbGVTaXpl
KGNvbnN0IFdlYlN0cmluZyYgdmZzRmlsZU5hbWUpID0gMDsKIAogCiAgICAgLy8gS2V5Z2VuIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcAkocmV2aXNpb24g
NTA5MjIpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcAkod29ya2lu
ZyBjb3B5KQpAQCAtMzA2LDI0ICszMDYsMjQgQEAgU3RyaW5nIENocm9taXVtQnJpZGdlOjpnZXRG
b250RmFtaWx5Rm9yQwogLy8gSFRNTDUgREIgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiAjaWYgRU5BQkxFKERBVEFC
QVNFKQotUGxhdGZvcm1GaWxlSGFuZGxlIENocm9taXVtQnJpZGdlOjpkYXRhYmFzZU9wZW5GaWxl
KGNvbnN0IFN0cmluZyYgZmlsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3MsIFBsYXRmb3JtRmlsZUhh
bmRsZSogZGlySGFuZGxlKQorUGxhdGZvcm1GaWxlSGFuZGxlIENocm9taXVtQnJpZGdlOjpkYXRh
YmFzZU9wZW5GaWxlKGNvbnN0IFN0cmluZyYgdmZzRmlsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3Ms
IFBsYXRmb3JtRmlsZUhhbmRsZSogZGlySGFuZGxlKQogewotICAgIHJldHVybiB3ZWJLaXRDbGll
bnQoKS0+ZGF0YWJhc2VPcGVuRmlsZShXZWJTdHJpbmcoZmlsZU5hbWUpLCBkZXNpcmVkRmxhZ3Ms
IGRpckhhbmRsZSk7CisgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5kYXRhYmFzZU9wZW5GaWxl
KFdlYlN0cmluZyh2ZnNGaWxlTmFtZSksIGRlc2lyZWRGbGFncywgZGlySGFuZGxlKTsKIH0KIAot
aW50IENocm9taXVtQnJpZGdlOjpkYXRhYmFzZURlbGV0ZUZpbGUoY29uc3QgU3RyaW5nJiBmaWxl
TmFtZSwgYm9vbCBzeW5jRGlyKQoraW50IENocm9taXVtQnJpZGdlOjpkYXRhYmFzZURlbGV0ZUZp
bGUoY29uc3QgU3RyaW5nJiB2ZnNGaWxlTmFtZSwgYm9vbCBzeW5jRGlyKQogewotICAgIHJldHVy
biB3ZWJLaXRDbGllbnQoKS0+ZGF0YWJhc2VEZWxldGVGaWxlKFdlYlN0cmluZyhmaWxlTmFtZSks
IHN5bmNEaXIpOworICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZGF0YWJhc2VEZWxldGVGaWxl
KFdlYlN0cmluZyh2ZnNGaWxlTmFtZSksIHN5bmNEaXIpOwogfQogCi1sb25nIENocm9taXVtQnJp
ZGdlOjpkYXRhYmFzZUdldEZpbGVBdHRyaWJ1dGVzKGNvbnN0IFN0cmluZyYgZmlsZU5hbWUpCits
b25nIENocm9taXVtQnJpZGdlOjpkYXRhYmFzZUdldEZpbGVBdHRyaWJ1dGVzKGNvbnN0IFN0cmlu
ZyYgdmZzRmlsZU5hbWUpCiB7Ci0gICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5kYXRhYmFzZUdl
dEZpbGVBdHRyaWJ1dGVzKFdlYlN0cmluZyhmaWxlTmFtZSkpOworICAgIHJldHVybiB3ZWJLaXRD
bGllbnQoKS0+ZGF0YWJhc2VHZXRGaWxlQXR0cmlidXRlcyhXZWJTdHJpbmcodmZzRmlsZU5hbWUp
KTsKIH0KIAotbG9uZyBsb25nIENocm9taXVtQnJpZGdlOjpkYXRhYmFzZUdldEZpbGVTaXplKGNv
bnN0IFN0cmluZyYgZmlsZU5hbWUpCitsb25nIGxvbmcgQ2hyb21pdW1CcmlkZ2U6OmRhdGFiYXNl
R2V0RmlsZVNpemUoY29uc3QgU3RyaW5nJiB2ZnNGaWxlTmFtZSkKIHsKLSAgICByZXR1cm4gd2Vi
S2l0Q2xpZW50KCktPmRhdGFiYXNlR2V0RmlsZVNpemUoV2ViU3RyaW5nKGZpbGVOYW1lKSk7Cisg
ICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5kYXRhYmFzZUdldEZpbGVTaXplKFdlYlN0cmluZyh2
ZnNGaWxlTmFtZSkpOwogfQogI2VuZGlmCiAK
</data>
<flag name="review"
          id="24806"
          type_id="1"
          status="+"
          setter="dglazkov"
    />
    <flag name="commit-queue"
          id="24807"
          type_id="3"
          status="-"
          setter="dumi"
    />
          </attachment>
      

    </bug>

</bugzilla>