31448 2009-11-12 16:45:37 -0800 Menu button shows wrong content in Chromium 2009-11-18 15:11:23 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 estade webkit-unassigned abarth commit-queue oldest_to_newest 163112 0 estade 2009-11-12 16:45:37 -0800 behavior on IE8: if a node (such as a link) has focus, the menu button shows a context menu in the top left of the screen. The contents of the menu are relevant to the focused node. behavior on firefox 3 win and linux: if a node (such as a link) has focus, the menu button shows a context menu at the node's location. The contents of the menu are relevant to the focused node. behavior on chrome windows and linux: if a node (such as a link) has focus, the menu button shows a context menu in the top left of the screen. The contents of the menu are relevant to whatever node is at the top left of the screen. (Note that if a text area has focus, the context menu will be relevant to the text---this patch doesn't change that behavior.) behavior on chrome with this patch: matches firefox p.s. there needs to be a WebKit Chromium component option in this bug tracker 163114 1 43116 estade 2009-11-12 16:47:19 -0800 Created attachment 43116 patch 163714 2 abarth 2009-11-14 22:49:29 -0800 Checking style for patch 43116 from bug 31448. Running check-webkit-style WebKit/chromium/src/WebViewImpl.cpp:605: One line control clauses should not use braces. [whitespace/braces] [4] Done processing WebKit/chromium/src/WebViewImpl.cpp Total errors found: 1 164022 3 estade 2009-11-16 10:25:32 -0800 I think that linter error is a false positive. The style guide doesn't really say but I assume that if one part of a block of if-elses uses curlies then they all should. 164023 4 43116 fishd 2009-11-16 10:28:57 -0800 Comment on attachment 43116 patch > Index: WebKit/chromium/src/WebViewImpl.cpp > + } else if (focusedNode) { > + location = focusedNode->getRect().bottomLeft(); > + } else { nit: no brackets around single line statements. otherwise, LGTM 164056 5 43320 estade 2009-11-16 13:02:30 -0800 Created attachment 43320 same, minus lint error 164746 6 43320 commit-queue 2009-11-18 15:11:07 -0800 Comment on attachment 43320 same, minus lint error Clearing flags on attachment: 43320 Committed r51142: <http://trac.webkit.org/changeset/51142> 164747 7 commit-queue 2009-11-18 15:11:23 -0800 All reviewed patches have been landed. Closing bug. 43116 2009-11-12 16:47:19 -0800 2009-11-16 13:02:30 -0800 patch cm.diff text/plain 2515 estade SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTA5MTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTIgIEV2YW4g U3RhZGUgIDxlc3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1lbnUgYnV0dG9uIHNob3dzIHdyb25nIGNvbnRlbnQgaW4g Q2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNDQ4CisKKyAgICAgICAgTWFrZSBjb250ZXh0IG1lbnUgYnV0dG9uIChWS19BUFBTKSBzaG93 IGNvbnRleHQgbWVudSBmb3Igbm9kZSB0aGF0IGhhcworICAgICAgICBrZXlib2FyZCBmb2N1cy4g VGhpcyBhZmZlY3RzIGJvdGggdGhlIGNvbnRlbnQgYW5kIHRoZSBwb3NpdGlvbmluZy4KKworICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs OjpzZW5kQ29udGV4dE1lbnVFdmVudCk6CisKIDIwMDktMTEtMTIgIEFkYW0gQmFydGggIDxhYmFy dGg+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDUwOTE2KQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4NywxMSArNTg3LDEw IEBAIGJvb2wgV2ViVmlld0ltcGw6OnNlbmRDb250ZXh0TWVudUV2ZW50KGMKICAgICBQb3NpdGlv biBzdGFydCA9IG1haW5GcmFtZUltcGwtPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS5zdGFydCgp OwogICAgIFBvc2l0aW9uIGVuZCA9IG1haW5GcmFtZUltcGwtPnNlbGVjdGlvbigpLT5zZWxlY3Rp b24oKS5lbmQoKTsKIAotICAgIGlmICghc3RhcnQubm9kZSgpIHx8ICFlbmQubm9kZSgpKSB7Ci0g ICAgICAgIGxvY2F0aW9uID0gSW50UG9pbnQoCi0gICAgICAgICAgICByaWdodEFsaWduZWQgPyB2 aWV3LT5jb250ZW50c1dpZHRoKCkgLSBrQ29udGV4dE1lbnVNYXJnaW4gOiBrQ29udGV4dE1lbnVN YXJnaW4sCi0gICAgICAgICAgICBrQ29udGV4dE1lbnVNYXJnaW4pOwotICAgIH0gZWxzZSB7Cisg ICAgRnJhbWUqIGZvY3VzZWRGcmFtZSA9IHBhZ2UoKS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3Vz ZWRPck1haW5GcmFtZSgpOworICAgIE5vZGUqIGZvY3VzZWROb2RlID0gZm9jdXNlZEZyYW1lLT5k b2N1bWVudCgpLT5mb2N1c2VkTm9kZSgpOworCisgICAgaWYgKHN0YXJ0Lm5vZGUoKSAmJiBlbmQu bm9kZSgpKSB7CiAgICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBzdGFydC5ub2RlKCkt PnJlbmRlcmVyKCk7CiAgICAgICAgIGlmICghcmVuZGVyZXIpCiAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CkBAIC02MDEsNiArNjAwLDEyIEBAIGJvb2wgV2ViVmlld0ltcGw6OnNlbmRDb250ZXh0 TWVudUV2ZW50KGMKIAogICAgICAgICBpbnQgeCA9IHJpZ2h0QWxpZ25lZCA/IGZpcnN0UmVjdC5y aWdodCgpIDogZmlyc3RSZWN0LngoKTsKICAgICAgICAgbG9jYXRpb24gPSBJbnRQb2ludCh4LCBm aXJzdFJlY3QuYm90dG9tKCkpOworICAgIH0gZWxzZSBpZiAoZm9jdXNlZE5vZGUpIHsKKyAgICAg ICAgbG9jYXRpb24gPSBmb2N1c2VkTm9kZS0+Z2V0UmVjdCgpLmJvdHRvbUxlZnQoKTsKKyAgICB9 IGVsc2UgeworICAgICAgICBsb2NhdGlvbiA9IEludFBvaW50KAorICAgICAgICAgICAgcmlnaHRB bGlnbmVkID8gdmlldy0+Y29udGVudHNXaWR0aCgpIC0ga0NvbnRleHRNZW51TWFyZ2luIDoga0Nv bnRleHRNZW51TWFyZ2luLAorICAgICAgICAgICAga0NvbnRleHRNZW51TWFyZ2luKTsKICAgICB9 CiAKICAgICBsb2NhdGlvbiA9IHZpZXctPmNvbnRlbnRzVG9XaW5kb3cobG9jYXRpb24pOwpAQCAt NjE3LDcgKzYyMiw2IEBAIGJvb2wgV2ViVmlld0ltcGw6OnNlbmRDb250ZXh0TWVudUV2ZW50KGMK ICAgICAvLyBub3QgcnVuLgogICAgIHBhZ2UoKS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCktPmNs ZWFyQ29udGV4dE1lbnUoKTsKIAotICAgIEZyYW1lKiBmb2N1c2VkRnJhbWUgPSBwYWdlKCktPmZv Y3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKICAgICBmb2N1c2VkRnJhbWUt PnZpZXcoKS0+c2V0Q3Vyc29yKHBvaW50ZXJDdXJzb3IoKSk7CiAgICAgV2ViTW91c2VFdmVudCBt b3VzZUV2ZW50OwogICAgIG1vdXNlRXZlbnQuYnV0dG9uID0gV2ViTW91c2VFdmVudDo6QnV0dG9u UmlnaHQ7Cg== 43320 2009-11-16 13:02:30 -0800 2009-11-18 15:11:06 -0800 same, minus lint error context2.diff text/plain 2511 estade SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTA5MTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTIgIEV2YW4g U3RhZGUgIDxlc3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1lbnUgYnV0dG9uIHNob3dzIHdyb25nIGNvbnRlbnQgaW4g Q2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxNDQ4CisKKyAgICAgICAgTWFrZSBjb250ZXh0IG1lbnUgYnV0dG9uIChWS19BUFBTKSBzaG93 IGNvbnRleHQgbWVudSBmb3Igbm9kZSB0aGF0IGhhcworICAgICAgICBrZXlib2FyZCBmb2N1cy4g VGhpcyBhZmZlY3RzIGJvdGggdGhlIGNvbnRlbnQgYW5kIHRoZSBwb3NpdGlvbmluZy4KKworICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs OjpzZW5kQ29udGV4dE1lbnVFdmVudCk6CisKIDIwMDktMTEtMTIgIEFkYW0gQmFydGggIDxhYmFy dGg+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDUwOTE2KQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4NywxMSArNTg3LDEw IEBAIGJvb2wgV2ViVmlld0ltcGw6OnNlbmRDb250ZXh0TWVudUV2ZW50KGMKICAgICBQb3NpdGlv biBzdGFydCA9IG1haW5GcmFtZUltcGwtPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS5zdGFydCgp OwogICAgIFBvc2l0aW9uIGVuZCA9IG1haW5GcmFtZUltcGwtPnNlbGVjdGlvbigpLT5zZWxlY3Rp b24oKS5lbmQoKTsKIAotICAgIGlmICghc3RhcnQubm9kZSgpIHx8ICFlbmQubm9kZSgpKSB7Ci0g ICAgICAgIGxvY2F0aW9uID0gSW50UG9pbnQoCi0gICAgICAgICAgICByaWdodEFsaWduZWQgPyB2 aWV3LT5jb250ZW50c1dpZHRoKCkgLSBrQ29udGV4dE1lbnVNYXJnaW4gOiBrQ29udGV4dE1lbnVN YXJnaW4sCi0gICAgICAgICAgICBrQ29udGV4dE1lbnVNYXJnaW4pOwotICAgIH0gZWxzZSB7Cisg ICAgRnJhbWUqIGZvY3VzZWRGcmFtZSA9IHBhZ2UoKS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3Vz ZWRPck1haW5GcmFtZSgpOworICAgIE5vZGUqIGZvY3VzZWROb2RlID0gZm9jdXNlZEZyYW1lLT5k b2N1bWVudCgpLT5mb2N1c2VkTm9kZSgpOworCisgICAgaWYgKHN0YXJ0Lm5vZGUoKSAmJiBlbmQu bm9kZSgpKSB7CiAgICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBzdGFydC5ub2RlKCkt PnJlbmRlcmVyKCk7CiAgICAgICAgIGlmICghcmVuZGVyZXIpCiAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CkBAIC02MDEsNiArNjAwLDEyIEBAIGJvb2wgV2ViVmlld0ltcGw6OnNlbmRDb250ZXh0 TWVudUV2ZW50KGMKIAogICAgICAgICBpbnQgeCA9IHJpZ2h0QWxpZ25lZCA/IGZpcnN0UmVjdC5y aWdodCgpIDogZmlyc3RSZWN0LngoKTsKICAgICAgICAgbG9jYXRpb24gPSBJbnRQb2ludCh4LCBm aXJzdFJlY3QuYm90dG9tKCkpOworICAgIH0gZWxzZSBpZiAoZm9jdXNlZE5vZGUpCisgICAgICAg IGxvY2F0aW9uID0gZm9jdXNlZE5vZGUtPmdldFJlY3QoKS5ib3R0b21MZWZ0KCk7CisgICAgZWxz ZSB7CisgICAgICAgIGxvY2F0aW9uID0gSW50UG9pbnQoCisgICAgICAgICAgICByaWdodEFsaWdu ZWQgPyB2aWV3LT5jb250ZW50c1dpZHRoKCkgLSBrQ29udGV4dE1lbnVNYXJnaW4gOiBrQ29udGV4 dE1lbnVNYXJnaW4sCisgICAgICAgICAgICBrQ29udGV4dE1lbnVNYXJnaW4pOwogICAgIH0KIAog ICAgIGxvY2F0aW9uID0gdmlldy0+Y29udGVudHNUb1dpbmRvdyhsb2NhdGlvbik7CkBAIC02MTcs NyArNjIyLDYgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2VuZENvbnRleHRNZW51RXZlbnQoYwogICAg IC8vIG5vdCBydW4uCiAgICAgcGFnZSgpLT5jb250ZXh0TWVudUNvbnRyb2xsZXIoKS0+Y2xlYXJD b250ZXh0TWVudSgpOwogCi0gICAgRnJhbWUqIGZvY3VzZWRGcmFtZSA9IHBhZ2UoKS0+Zm9jdXND b250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOwogICAgIGZvY3VzZWRGcmFtZS0+dmll dygpLT5zZXRDdXJzb3IocG9pbnRlckN1cnNvcigpKTsKICAgICBXZWJNb3VzZUV2ZW50IG1vdXNl RXZlbnQ7CiAgICAgbW91c2VFdmVudC5idXR0b24gPSBXZWJNb3VzZUV2ZW50OjpCdXR0b25SaWdo dDsK