31439 2009-11-12 14:17:27 -0800 Web Inspector: preload status bar button glyphs in order to prevent them from flickering. 2009-11-13 09:27:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 163049 0 pfeldman 2009-11-12 14:17:27 -0800 I am going to put them into inspector.html. 163050 1 43098 pfeldman 2009-11-12 14:19:17 -0800 Created attachment 43098 [PATCH] proposed fix 163065 2 43098 timothy 2009-11-12 14:46:36 -0800 Comment on attachment 43098 [PATCH] proposed fix I prefer preloading from JS doing: (new Image()).src = "Images/clearConsoleButtonGlyph.png"; That way the DOM isn't involved and polluted. 163071 3 43104 pfeldman 2009-11-12 15:00:22 -0800 Created attachment 43104 [PATCH] addressed comments 163073 4 pfeldman 2009-11-12 15:04:35 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50908 163272 5 pfeldman 2009-11-13 02:46:11 -0800 I had to revert this due to tests timing out. Need to find a way of telling frontend that it is within tests, that way it would be able to skip this step. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50935 163341 6 timothy 2009-11-13 09:21:43 -0800 How did this cause a timeout? 163342 7 pfeldman 2009-11-13 09:27:12 -0800 (In reply to comment #6) > How did this cause a timeout? I am not sure, I noticed Tiger being flaky after that commit. It did not stop being so after I rolled back though. So re-applying. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50947 43098 2009-11-12 14:19:17 -0800 2009-11-12 15:00:22 -0800 [PATCH] proposed fix flicker text/plain 2282 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDdjZjMxNy4uZDdiNjg0OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcmVsb2FkIHN0YXR1cyBi YXIgYnV0dG9uIGdseXBocyBpbgorICAgICAgICBvcmRlciB0byBwcmV2ZW50IHRoZW0gZnJvbSBm bGlja2VyaW5nLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTQzOQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuaHRt bDoKKworMjAwOS0xMS0xMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCisKICAgICAgICAgV2ViIElu c3BlY3RvcjogcHJvZmlsZSB0aW1lbGluZSBwYW5lbCwgZml4IG9idmlvdXMgcHJvYmxlbXMuCiAK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDMyCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmh0bWwgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmh0bWwKaW5kZXggYTYwOWY4OS4u ZmUzYzE5ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5odG1sCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuaHRtbApA QCAtMTE0LDUgKzExNCwyNCBAQCBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICAgICAgICA8ZGl2IGlkPSJjb25zb2xlLXZp ZXciPjxkaXYgaWQ9ImNvbnNvbGUtbWVzc2FnZXMiPjxkaXYgaWQ9ImNvbnNvbGUtcHJvbXB0IiBz cGVsbGNoZWNrPSJmYWxzZSI+PGJyPjwvZGl2PjwvZGl2PjwvZGl2PgogICAgICAgICA8ZGl2IGlk PSJkcmF3ZXItc3RhdHVzLWJhciIgY2xhc3M9InN0YXR1cy1iYXIiPjxkaXYgaWQ9Im90aGVyLWRy YXdlci1zdGF0dXMtYmFyLWl0ZW1zIj48YnV0dG9uIGlkPSJjbGVhci1jb25zb2xlLXN0YXR1cy1i YXItaXRlbSIgY2xhc3M9InN0YXR1cy1iYXItaXRlbSI+PGRpdiBjbGFzcz0iZ2x5cGgiPjwvZGl2 PjxkaXYgY2xhc3M9ImdseXBoIHNoYWRvdyI+PC9kaXY+PC9idXR0b24+PGRpdiBpZD0iY29uc29s ZS1maWx0ZXIiIGNsYXNzPSJzY29wZS1iYXIgc3RhdHVzLWJhci1pdGVtIj48L2Rpdj48L2Rpdj48 L2Rpdj4KICAgICA8L2Rpdj4KKworICAgIDwhLS0gUHJlbG9hZCBnbHlwaHMgLS0+CisgICAgPGRp diBzdHlsZT0idmlzaWJpbGl0eTpoaWRkZW4iPgorICAgICAgICA8aW1nIHNyYz0iSW1hZ2VzL2Ns ZWFyQ29uc29sZUJ1dHRvbkdseXBoLnBuZyI+CisgICAgICAgIDxpbWcgc3JjPSJJbWFnZXMvY29u c29sZUJ1dHRvbkdseXBoLnBuZyI+CisgICAgICAgIDxpbWcgc3JjPSJJbWFnZXMvZG9ja0J1dHRv bkdseXBoLnBuZyI+CisgICAgICAgIDxpbWcgc3JjPSJJbWFnZXMvZW5hYmxlT3V0bGluZUJ1dHRv bkdseXBoLnBuZyI+CisgICAgICAgIDxpbWcgc3JjPSJJbWFnZXMvZW5hYmxlU29saWRCdXR0b25H bHlwaC5wbmciPgorICAgICAgICA8aW1nIHNyYz0iSW1hZ2VzL2V4Y2x1ZGVCdXR0b25HbHlwaC5w bmciPgorICAgICAgICA8aW1nIHNyYz0iSW1hZ2VzL2ZvY3VzQnV0dG9uR2x5cGgucG5nIj4KKyAg ICAgICAgPGltZyBzcmM9IkltYWdlcy9sYXJnZXJSZXNvdXJjZXNCdXR0b25HbHlwaC5wbmciPgor ICAgICAgICA8aW1nIHNyYz0iSW1hZ2VzL25vZGVTZWFyY2hCdXR0b25HbHlwaC5wbmciPgorICAg ICAgICA8aW1nIHNyYz0iSW1hZ2VzL3BhdXNlT25FeGNlcHRpb25CdXR0b25HbHlwaC5wbmciPgor ICAgICAgICA8aW1nIHNyYz0iSW1hZ2VzL3BlcmNlbnRCdXR0b25HbHlwaC5wbmciPgorICAgICAg ICA8aW1nIHNyYz0iSW1hZ2VzL3JlY29yZEJ1dHRvbkdseXBoLnBuZyI+CisgICAgICAgIDxpbWcg c3JjPSJJbWFnZXMvcmVjb3JkVG9nZ2xlZEJ1dHRvbkdseXBoLnBuZyI+CisgICAgICAgIDxpbWcg c3JjPSJJbWFnZXMvcmVsb2FkQnV0dG9uR2x5cGgucG5nIj4KKyAgICAgICAgPGltZyBzcmM9Iklt YWdlcy91bmRvY2tCdXR0b25HbHlwaC5wbmciPgorICAgIDwvZGl2PgogPC9ib2R5PgogPC9odG1s Pgo= 43104 2009-11-12 15:00:22 -0800 2009-11-13 02:46:29 -0800 [PATCH] addressed comments flicker text/plain 1890 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjgzNzgzMC4uOTUwN2RkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMS0xMiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcHJlbG9hZCBzdGF0dXMgYmFyIGJ1 dHRvbiBnbHlwaHMKKyAgICAgICAgaW4gb3JkZXIgdG8gcHJldmVudCB0aGVtIGZyb20gZmxpY2tl cmluZy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzE0MzkKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAg ICAgICAocHJlbG9hZEltYWdlcyk6CisKIDIwMDktMTEtMTIgIEFkYW0gUm9iZW4gIDxhcm9iZW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJlcGxhY2Ugd29ybGRJRHMgd2l0aCB3b3JsZCBvYmplY3Rz CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCBmOWUzODAyLi4w MmRhOGI1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9y LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTQ2 LDYgKzQ2LDI3IEBAIHZhciBQcmVmZXJlbmNlcyA9IHsKICAgICByZXNvdXJjZXNMYXJnZVJvd3M6 IHRydWUKIH0KIAorZnVuY3Rpb24gcHJlbG9hZEltYWdlcygpCit7CisgICAgKG5ldyBJbWFnZSgp KS5zcmMgPSAiSW1hZ2VzL2NsZWFyQ29uc29sZUJ1dHRvbkdseXBoLnBuZyI7CisgICAgKG5ldyBJ bWFnZSgpKS5zcmMgPSAiSW1hZ2VzL2NvbnNvbGVCdXR0b25HbHlwaC5wbmciOworICAgIChuZXcg SW1hZ2UoKSkuc3JjID0gIkltYWdlcy9kb2NrQnV0dG9uR2x5cGgucG5nIjsKKyAgICAobmV3IElt YWdlKCkpLnNyYyA9ICJJbWFnZXMvZW5hYmxlT3V0bGluZUJ1dHRvbkdseXBoLnBuZyI7CisgICAg KG5ldyBJbWFnZSgpKS5zcmMgPSAiSW1hZ2VzL2VuYWJsZVNvbGlkQnV0dG9uR2x5cGgucG5nIjsK KyAgICAobmV3IEltYWdlKCkpLnNyYyA9ICJJbWFnZXMvZXhjbHVkZUJ1dHRvbkdseXBoLnBuZyI7 CisgICAgKG5ldyBJbWFnZSgpKS5zcmMgPSAiSW1hZ2VzL2ZvY3VzQnV0dG9uR2x5cGgucG5nIjsK KyAgICAobmV3IEltYWdlKCkpLnNyYyA9ICJJbWFnZXMvbGFyZ2VyUmVzb3VyY2VzQnV0dG9uR2x5 cGgucG5nIjsKKyAgICAobmV3IEltYWdlKCkpLnNyYyA9ICJJbWFnZXMvbm9kZVNlYXJjaEJ1dHRv bkdseXBoLnBuZyI7CisgICAgKG5ldyBJbWFnZSgpKS5zcmMgPSAiSW1hZ2VzL3BhdXNlT25FeGNl cHRpb25CdXR0b25HbHlwaC5wbmciOworICAgIChuZXcgSW1hZ2UoKSkuc3JjID0gIkltYWdlcy9w ZXJjZW50QnV0dG9uR2x5cGgucG5nIjsKKyAgICAobmV3IEltYWdlKCkpLnNyYyA9ICJJbWFnZXMv cmVjb3JkQnV0dG9uR2x5cGgucG5nIjsKKyAgICAobmV3IEltYWdlKCkpLnNyYyA9ICJJbWFnZXMv cmVjb3JkVG9nZ2xlZEJ1dHRvbkdseXBoLnBuZyI7CisgICAgKG5ldyBJbWFnZSgpKS5zcmMgPSAi SW1hZ2VzL3JlbG9hZEJ1dHRvbkdseXBoLnBuZyI7CisgICAgKG5ldyBJbWFnZSgpKS5zcmMgPSAi SW1hZ2VzL3VuZG9ja0J1dHRvbkdseXBoLnBuZyI7Cit9CisKK3ByZWxvYWRJbWFnZXMoKTsKKwog dmFyIFdlYkluc3BlY3RvciA9IHsKICAgICByZXNvdXJjZXM6IHt9LAogICAgIHJlc291cmNlVVJM TWFwOiB7fSwK