31427 2009-11-12 12:13:17 -0800 Add postTaskToMainThread to ScriptExecutionContext 2009-11-18 00:41:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 31317 1 dimich dimich eric oldest_to_newest 163003 0 dimich 2009-11-12 12:13:17 -0800 Moving the code from Document to the protected member of the base class. It can be used as helper for the derived contexts that live on the main thread. In preparation for GlobalScript (bug 31317) 163009 1 43090 dimich 2009-11-12 12:21:43 -0800 Created attachment 43090 Proposed patch. 163120 2 dimich 2009-11-12 17:18:11 -0800 Landed: http://trac.webkit.org/changeset/50919 164441 3 eric 2009-11-17 21:26:16 -0800 There was a style error in this patch, btw. Guess we need Adam Barth's style bot. :) 164442 4 eric 2009-11-17 21:26:48 -0800 {} around single line if was the style error: 62 } else { 263 callOnMainThread(PerformTaskData::performTask, new PerformTaskData(this, task)); 264 } 164485 5 dimich 2009-11-18 00:41:26 -0800 > {} around single line if was the style error: Thanks! Will fix while landing a patch for regression (bug 31615) 43090 2009-11-12 12:21:43 -0800 2009-11-12 16:21:47 -0800 Proposed patch. patch.txt text/plain 5317 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2FjZDI4Zi4uOTk3MmNiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOS0xMS0xMiAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgcG9zdFRhc2tUb01haW5UaHJlYWQgdG8gU2NyaXB0RXhlY3V0 aW9uQ29udGV4dC4KKyAgICAgICAgTW92ZSB0aGUgY29kZSB0byBwb3N0IHRhc2sgdG8gdGhlIG1h aW4gdGhyZWFkIGludG8gYSBuZXcgbWV0aG9kIG9uIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCisg ICAgICAgIHRvIHVzZSBhcyBhIGhlbHBlciBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgdmlydHVhbCBT Y3JpcHRFeGVjdXRpb25Db250ZXh0Ojpwb3N0VGFzayhUYXNrKSBpbgorICAgICAgICBjb250ZXh0 cyB0aGF0IGxpdmUgb24gdGhlIG1haW4gdGhyZWFkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0MjcKKworICAgICAgICBObyBuZXcgdGVzdHMgLSBz aW1wbHkgbW92aW5nIHRoZSBjb2RlLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpwb3N0VGFzayk6CisgICAgICAgICogZG9tL1Njcmlw dEV4ZWN1dGlvbkNvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RXhlY3V0aW9u Q29udGV4dFRhc2tUaW1lcjo6U2NyaXB0RXhlY3V0aW9uQ29udGV4dFRhc2tUaW1lcik6CisgICAg ICAgIChXZWJDb3JlOjpTY3JpcHRFeGVjdXRpb25Db250ZXh0VGFza1RpbWVyOjpmaXJlZCk6Cisg ICAgICAgIChXZWJDb3JlOjpQZXJmb3JtVGFza0RhdGE6OlBlcmZvcm1UYXNrRGF0YSk6CisgICAg ICAgIChXZWJDb3JlOjpQZXJmb3JtVGFza0RhdGE6OnBlcmZvcm1UYXNrKToKKyAgICAgICAgKFdl YkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnBvc3RUYXNrVG9NYWluVGhyZWFkKToKKyAg ICAgICAgKiBkb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oOgorCiAyMDA5LTExLTAzICBFcmlj IFouIEF5ZXJzICA8enVuZGVsQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGlt b3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDRmMTg3YzUuLjg1NDFiMjEgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK QEAgLTQ1MzcsNTEgKzQ1MzcsOSBAQCB2b2lkIERvY3VtZW50OjpzY3JpcHRJbXBvcnRlZCh1bnNp Z25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgc291cmNlU3RyaQogI2VuZGlmCiB9 CiAKLWNsYXNzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHRUYXNrVGltZXIgOiBwdWJsaWMgVGltZXJC YXNlIHsKLXB1YmxpYzoKLSAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0VGFza1RpbWVyKFBhc3NS ZWZQdHI8RG9jdW1lbnQ+IGNvbnRleHQsIFBhc3NPd25QdHI8U2NyaXB0RXhlY3V0aW9uQ29udGV4 dDo6VGFzaz4gdGFzaykKLSAgICAgICAgOiBtX2NvbnRleHQoY29udGV4dCkKLSAgICAgICAgLCBt X3Rhc2sodGFzaykKLSAgICB7Ci0gICAgfQotCi1wcml2YXRlOgotICAgIHZpcnR1YWwgdm9pZCBm aXJlZCgpCi0gICAgewotICAgICAgICBtX3Rhc2stPnBlcmZvcm1UYXNrKG1fY29udGV4dC5nZXQo KSk7Ci0gICAgICAgIGRlbGV0ZSB0aGlzOwotICAgIH0KLQotICAgIFJlZlB0cjxEb2N1bWVudD4g bV9jb250ZXh0OwotICAgIE93blB0cjxTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpUYXNrPiBtX3Rh c2s7Ci19OwotCi1zdHJ1Y3QgUGVyZm9ybVRhc2tDb250ZXh0IDogTm9uY29weWFibGUgewotICAg IFBlcmZvcm1UYXNrQ29udGV4dChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBzY3JpcHRFeGVjdXRp b25Db250ZXh0LCBQYXNzT3duUHRyPFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2s+IHRhc2sp Ci0gICAgICAgIDogc2NyaXB0RXhlY3V0aW9uQ29udGV4dChzY3JpcHRFeGVjdXRpb25Db250ZXh0 KQotICAgICAgICAsIHRhc2sodGFzaykKLSAgICB7Ci0gICAgfQotCi0gICAgU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dDsgLy8gVGhlIGNvbnRleHQgc2hvdWxk IGV4aXN0IHVudGlsIHRhc2sgZXhlY3V0aW9uLgotICAgIE93blB0cjxTY3JpcHRFeGVjdXRpb25D b250ZXh0OjpUYXNrPiB0YXNrOwotfTsKLQotc3RhdGljIHZvaWQgcGVyZm9ybVRhc2sodm9pZCog Y3R4KQotewotICAgIFBlcmZvcm1UYXNrQ29udGV4dCogcHRjdHggPSByZWludGVycHJldF9jYXN0 PFBlcmZvcm1UYXNrQ29udGV4dCo+KGN0eCk7Ci0gICAgcHRjdHgtPnRhc2stPnBlcmZvcm1UYXNr KHB0Y3R4LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKLSAgICBkZWxldGUgcHRjdHg7Ci19Ci0K IHZvaWQgRG9jdW1lbnQ6OnBvc3RUYXNrKFBhc3NPd25QdHI8VGFzaz4gdGFzaykKIHsKLSAgICBp ZiAoaXNNYWluVGhyZWFkKCkpIHsKLSAgICAgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dFRhc2tU aW1lciogdGltZXIgPSBuZXcgU2NyaXB0RXhlY3V0aW9uQ29udGV4dFRhc2tUaW1lcihzdGF0aWNf Y2FzdDxEb2N1bWVudCo+KHRoaXMpLCB0YXNrKTsKLSAgICAgICAgdGltZXItPnN0YXJ0T25lU2hv dCgwKTsKLSAgICB9IGVsc2UgewotICAgICAgICBjYWxsT25NYWluVGhyZWFkKHBlcmZvcm1UYXNr LCBuZXcgUGVyZm9ybVRhc2tDb250ZXh0KHRoaXMsIHRhc2spKTsKLSAgICB9CisgICAgcG9zdFRh c2tUb01haW5UaHJlYWQodGFzayk7CiB9CiAKIEVsZW1lbnQqIERvY3VtZW50OjpmaW5kQW5jaG9y KGNvbnN0IFN0cmluZyYgbmFtZSkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1 dGlvbkNvbnRleHQuY3BwIGIvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAK aW5kZXggYmM3MTA4NC4uYzhkMWIzNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vU2NyaXB0RXhl Y3V0aW9uQ29udGV4dC5jcHAKKysrIGIvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4 dC5jcHAKQEAgLTIxNSw0ICsyMTUsNTMgQEAgSlNDOjpKU0dsb2JhbERhdGEqIFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQ6Omdsb2JhbERhdGEoKQogfQogI2VuZGlmCiAKK2NsYXNzIFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHRUYXNrVGltZXIgOiBwdWJsaWMgVGltZXJCYXNlIHsKK3B1YmxpYzoKKyAgICBT Y3JpcHRFeGVjdXRpb25Db250ZXh0VGFza1RpbWVyKFBhc3NSZWZQdHI8U2NyaXB0RXhlY3V0aW9u Q29udGV4dD4gY29udGV4dCwgUGFzc093blB0cjxTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpUYXNr PiB0YXNrKQorICAgICAgICA6IG1fY29udGV4dChjb250ZXh0KQorICAgICAgICAsIG1fdGFzayh0 YXNrKQorICAgIHsKKyAgICB9CisKK3ByaXZhdGU6CisgICAgdmlydHVhbCB2b2lkIGZpcmVkKCkK KyAgICB7CisgICAgICAgIG1fdGFzay0+cGVyZm9ybVRhc2sobV9jb250ZXh0LmdldCgpKTsKKyAg ICAgICAgZGVsZXRlIHRoaXM7CisgICAgfQorCisgICAgUmVmUHRyPFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQ+IG1fY29udGV4dDsKKyAgICBPd25QdHI8U2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFz az4gbV90YXNrOworfTsKKworY2xhc3MgUGVyZm9ybVRhc2tEYXRhIHsKK3B1YmxpYzoKKyAgICBQ ZXJmb3JtVGFza0RhdGEoUGFzc1JlZlB0cjxTY3JpcHRFeGVjdXRpb25Db250ZXh0PiBjb250ZXh0 LCBQYXNzT3duUHRyPFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2s+IHRhc2spCisgICAgICAg IDogbV9jb250ZXh0KGNvbnRleHQpCisgICAgICAgICwgbV90YXNrKHRhc2spCisgICAgeworICAg IH0KKworICAgIHN0YXRpYyB2b2lkIHBlcmZvcm1UYXNrKHZvaWQqIGRhdGEpCisgICAgeworICAg ICAgICBQZXJmb3JtVGFza0RhdGEqIHRhc2tEYXRhID0gc3RhdGljX2Nhc3Q8UGVyZm9ybVRhc2tE YXRhKj4oZGF0YSk7CisgICAgICAgIHRhc2tEYXRhLT5tX3Rhc2stPnBlcmZvcm1UYXNrKHRhc2tE YXRhLT5tX2NvbnRleHQuZ2V0KCkpOworICAgICAgICBkZWxldGUgdGFza0RhdGE7CisgICAgfQor Citwcml2YXRlOgorICAgIFJlZlB0cjxTY3JpcHRFeGVjdXRpb25Db250ZXh0PiBtX2NvbnRleHQ7 CisgICAgT3duUHRyPFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2s+IG1fdGFzazsKK307CisK K3ZvaWQgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6cG9zdFRhc2tUb01haW5UaHJlYWQoUGFzc093 blB0cjxUYXNrPiB0YXNrKQoreworICAgIGlmIChpc01haW5UaHJlYWQoKSkgeworICAgICAgICBT Y3JpcHRFeGVjdXRpb25Db250ZXh0VGFza1RpbWVyKiB0aW1lciA9IG5ldyBTY3JpcHRFeGVjdXRp b25Db250ZXh0VGFza1RpbWVyKHRoaXMsIHRhc2spOworICAgICAgICB0aW1lci0+c3RhcnRPbmVT aG90KDApOworICAgIH0gZWxzZSB7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoUGVyZm9ybVRh c2tEYXRhOjpwZXJmb3JtVGFzaywgbmV3IFBlcmZvcm1UYXNrRGF0YSh0aGlzLCB0YXNrKSk7Cisg ICAgfQorfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Rv bS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmggYi9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25D b250ZXh0LmgKaW5kZXggMTQxNDEyNS4uMGU1NTIxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20v U2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oCisrKyBiL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlv bkNvbnRleHQuaApAQCAtMTE0LDYgKzExNCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgLy8gICAgICAgdGhhdCBhbHJlYWR5IGNvbnRhaW5zIGNvbnRlbnQuCiAgICAgICAgIHZvaWQg c2V0U2VjdXJpdHlPcmlnaW4oUGFzc1JlZlB0cjxTZWN1cml0eU9yaWdpbj4pOwogCisgICAgICAg IC8vIEhlbHBlciBmb3IgY29udGV4dHMgdGhhdCBsaXZlIG9uIHRoZSBtYWluIHRocmVhZC4KKyAg ICAgICAgdm9pZCBwb3N0VGFza1RvTWFpblRocmVhZChQYXNzT3duUHRyPFRhc2s+KTsKKwogICAg IHByaXZhdGU6CiAgICAgICAgIHZpcnR1YWwgY29uc3QgS1VSTCYgdmlydHVhbFVSTCgpIGNvbnN0 ID0gMDsKICAgICAgICAgdmlydHVhbCBLVVJMIHZpcnR1YWxDb21wbGV0ZVVSTChjb25zdCBTdHJp bmcmKSBjb25zdCA9IDA7Cg==