31426 2009-11-12 11:43:50 -0800 Some WebSocket tests don't properly listen to close event 2009-11-12 12:17:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap ukai yuzo oldest_to_newest 162986 0 ap 2009-11-12 11:43:50 -0800 It should be "ws.onclose", not "ws.close". As a result, tests take longer (there are 2 or 3 second timers meant to make them end), and lack some of the output. 162987 1 43085 ap 2009-11-12 11:48:31 -0800 Created attachment 43085 proposed patch 162994 2 43085 levin 2009-11-12 11:56:37 -0800 Comment on attachment 43085 proposed patch Thanks. 163008 3 ap 2009-11-12 12:17:17 -0800 Committed r50892. 43085 2009-11-12 11:48:31 -0800 2009-11-12 11:56:37 -0800 proposed patch WebSocketTests.txt text/plain 6491 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwODg5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMDktMTEtMTIgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDI2 CisgICAgICAgIFNvbWUgV2ViU29ja2V0IHRlc3RzIGRvbid0IHByb3Blcmx5IGxpc3RlbiB0byBj bG9zZSBldmVudAorCisgICAgICAgICogd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9oYW5k c2hha2UtZXJyb3IuanM6CisgICAgICAgICogd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9z aW1wbGUuanM6CisgICAgICAgIE1hZGUgdGhlIHRlc3RzIGNsZWFyIHNlY29uZC1jaGFuY2UgdGlt ZXIgb24gZmluaXNoLCBhdm9pZGluZyBjb25mdXNpbmcgb3V0cHV0IHdoZW4gcnVubmluZworICAg ICAgICB0aGVtIGluIFNhZmFyaS4KKworICAgICAgICAqIHdlYnNvY2tldC90ZXN0cy9zY3JpcHQt dGVzdHMvZnJhbWUtbGVuZ3RoLWxvbmdlci10aGFuLWJ1ZmZlci5qczoKKyAgICAgICAgKiB3ZWJz b2NrZXQvdGVzdHMvc2NyaXB0LXRlc3RzL2ZyYW1lLWxlbmd0aC1za2lwLmpzOgorICAgICAgICAq IHdlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtbG9uZ2VyLXRoYW4tYnVmZmVyLWV4cGVjdGVk LnR4dDoKKyAgICAgICAgKiB3ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXAtZXhwZWN0 ZWQudHh0OgorICAgICAgICBUaGVzZSB0ZXN0cyBub3cgZmluaXNoIHByb3Blcmx5LgorCisgICAg ICAgICogd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1lcnJvci1leHBlY3RlZC50eHQ6CisgICAg ICAgICogd2Vic29ja2V0L3Rlc3RzL3NpbXBsZS1leHBlY3RlZC50eHQ6CisgICAgICAgIEknbSBn ZXR0aW5nIGFuIGV4dHJhIGVtcHR5IGxpbmUgZm9yIHRoZXNlIHRlc3RzLCB3aGljaCBpcyBzdXJw cmlzaW5nLiBCdXQgc2luY2UgSSBkaWRuJ3QKKyAgICAgICAgY2hhbmdlIGFueXRoaW5nLCBJIGFz c3VtZSB0aGF0IGl0IHNob3VsZCBiZSB0aGVyZS4KKwogMjAwOS0xMS0xMiAgRGFuaWVsIEJhdGVz ICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CkluZGV4OiBMYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLWxvbmdlci10 aGFuLWJ1ZmZlci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvd2Vic29j a2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1sb25nZXItdGhhbi1idWZmZXItZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiA1MDg4NCkKKysrIExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5n dGgtbG9uZ2VyLXRoYW4tYnVmZmVyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNCw2 ICs0LDcgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQQogCiBXZWJT b2NrZXQgaXMgb3BlbgogcmVjZWl2ZWQ6aGVsbG8KK1dlYlNvY2tldCBpcyBjbG9zZWQKIDEKIFBB U1MgYXJlQXJyYXlzRXF1YWwocmVjZWl2ZWRfbWVzc2FnZXMsIGV4cGVjdGVkX21lc3NhZ2VzKSBp cyB0cnVlCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCkluZGV4OiBMYXlvdXRUZXN0 cy93ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXAtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtc2tpcC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDUwODg0KQorKysgTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2ZyYW1lLWxlbmd0aC1za2lwLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNSw2ICs1 LDcgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQQogV2ViU29ja2V0 IGlzIG9wZW4KIHJlY2VpdmVkOmhlbGxvCiByZWNlaXZlZDp3b3JsZAorV2ViU29ja2V0IGlzIGNs b3NlZAogMgogUEFTUyBhcmVBcnJheXNFcXVhbChyZWNlaXZlZF9tZXNzYWdlcywgZXhwZWN0ZWRf bWVzc2FnZXMpIGlzIHRydWUKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKSW5kZXg6 IExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZXJyb3ItZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZXJy b3ItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1MDg4NCkKKysrIExheW91dFRlc3RzL3dlYnNvY2tl dC90ZXN0cy9oYW5kc2hha2UtZXJyb3ItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC03 LDMgKzcsNCBAQCBQQVNTIHdzLnJlYWR5U3RhdGUgaXMgMgogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL3dlYnNvY2tl dC90ZXN0cy9zaW1wbGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3dl YnNvY2tldC90ZXN0cy9zaW1wbGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1MDg4NCkKKysrIExh eW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9zaW1wbGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC04LDMgKzgsNCBAQCBDbG9zZWQuCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0 cnVlCiAKIFRFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3Rz L3NjcmlwdC10ZXN0cy9mcmFtZS1sZW5ndGgtbG9uZ2VyLXRoYW4tYnVmZmVyLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9zY3JpcHQtdGVzdHMvZnJhbWUtbGVu Z3RoLWxvbmdlci10aGFuLWJ1ZmZlci5qcwkocmV2aXNpb24gNTA4ODQpCisrKyBMYXlvdXRUZXN0 cy93ZWJzb2NrZXQvdGVzdHMvc2NyaXB0LXRlc3RzL2ZyYW1lLWxlbmd0aC1sb25nZXItdGhhbi1i dWZmZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTUsNiArNSw3IEBAIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCiB2YXIgcmVjZWl2ZWRfbWVzc2FnZXMgPSBbXTsKIHZhciBleHBlY3Rl ZF9tZXNzYWdlcyA9IFsiaGVsbG8iXTsKIGZ1bmN0aW9uIGZpbmlzaCgpIHsKKyAgICBjbGVhclRp bWVvdXQodGltZW91dElEKTsKICAgICBkZWJ1ZyhyZWNlaXZlZF9tZXNzYWdlcy5sZW5ndGgpOwog ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVjZWl2ZWRfbWVzc2FnZXM7IGkrKykgewogICAgICAg ICBkZWJ1ZygicmVjZWl2ZWRbIiArIGkgKyAiXT0iICsgcmVjZWl2ZWRfbWVzc2FnZXNbaV0pOwpA QCAtMjUsMTAgKzI2LDEwIEBAIHdzLm9ubWVzc2FnZSA9IGZ1bmN0aW9uIChldnQpIHsKICAgICBk ZWJ1ZygicmVjZWl2ZWQ6IiArIGV2dC5kYXRhKTsKICAgICByZWNlaXZlZF9tZXNzYWdlcy5wdXNo KGV2dC5kYXRhKTsKIH07Ci13cy5jbG9zZSA9IGZ1bmN0aW9uICgpIHsKK3dzLm9uY2xvc2UgPSBm dW5jdGlvbiAoKSB7CiAgICAgZGVidWcoIldlYlNvY2tldCBpcyBjbG9zZWQiKTsKICAgICBmaW5p c2goKTsKIH07Ci1zZXRUaW1lb3V0KCJmaW5pc2goKSIsIDIwMDApOwordmFyIHRpbWVvdXRJRCA9 IHNldFRpbWVvdXQoImZpbmlzaCgpIiwgMjAwMCk7CiAKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOwpJbmRleDogTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9m cmFtZS1sZW5ndGgtc2tpcC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy93ZWJzb2NrZXQv dGVzdHMvc2NyaXB0LXRlc3RzL2ZyYW1lLWxlbmd0aC1za2lwLmpzCShyZXZpc2lvbiA1MDg4NCkK KysrIExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9zY3JpcHQtdGVzdHMvZnJhbWUtbGVuZ3Ro LXNraXAuanMJKHdvcmtpbmcgY29weSkKQEAgLTUsNiArNSw3IEBAIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCiB2YXIgcmVjZWl2ZWRfbWVzc2FnZXMgPSBbXTsKIHZhciBleHBlY3Rl ZF9tZXNzYWdlcyA9IFsiaGVsbG8iLCAid29ybGQiXTsKIGZ1bmN0aW9uIGZpbmlzaCgpIHsKKyAg ICBjbGVhclRpbWVvdXQodGltZW91dElEKTsKICAgICBkZWJ1ZyhyZWNlaXZlZF9tZXNzYWdlcy5s ZW5ndGgpOwogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVjZWl2ZWRfbWVzc2FnZXM7IGkrKykg ewogICAgICAgICBkZWJ1ZygicmVjZWl2ZWRbIiArIGkgKyAiXT0iICsgcmVjZWl2ZWRfbWVzc2Fn ZXNbaV0pOwpAQCAtMjUsMTAgKzI2LDEwIEBAIHdzLm9ubWVzc2FnZSA9IGZ1bmN0aW9uIChldnQp IHsKICAgICBkZWJ1ZygicmVjZWl2ZWQ6IiArIGV2dC5kYXRhKTsKICAgICByZWNlaXZlZF9tZXNz YWdlcy5wdXNoKGV2dC5kYXRhKTsKIH07Ci13cy5jbG9zZSA9IGZ1bmN0aW9uICgpIHsKK3dzLm9u Y2xvc2UgPSBmdW5jdGlvbiAoKSB7CiAgICAgZGVidWcoIldlYlNvY2tldCBpcyBjbG9zZWQiKTsK ICAgICBmaW5pc2goKTsKIH07Ci1zZXRUaW1lb3V0KCJmaW5pc2goKSIsIDIwMDApOwordmFyIHRp bWVvdXRJRCA9IHNldFRpbWVvdXQoImZpbmlzaCgpIiwgMjAwMCk7CiAKIHZhciBzdWNjZXNzZnVs bHlQYXJzZWQgPSB0cnVlOwpJbmRleDogTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL3Njcmlw dC10ZXN0cy9oYW5kc2hha2UtZXJyb3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvd2Vi c29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9oYW5kc2hha2UtZXJyb3IuanMJKHJldmlzaW9uIDUw ODg0KQorKysgTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9oYW5kc2hh a2UtZXJyb3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTcsNiArNyw3IEBAIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKIGZ1bmN0aW9uIGVuZFRlc3QoKQogewogICAgIGlzU3VjY2Vz c2Z1bGx5UGFyc2VkKCk7CisgICAgY2xlYXJUaW1lb3V0KHRpbWVvdXRJRCk7CiAgICAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5ub3RpZnlEb25lKCk7CiAgICAgfQpAQCAtMzcsNiArMzgsNiBAQCBmdW5jdGlvbiB0aW1lT3V0 Q2FsbGJhY2soKQogICAgIGVuZFRlc3QoKTsKIH0KIAotd2luZG93LnNldFRpbWVvdXQodGltZU91 dENhbGxiYWNrLCAzMDAwKTsKK3ZhciB0aW1lb3V0SUQgPSBzZXRUaW1lb3V0KHRpbWVPdXRDYWxs YmFjaywgMzAwMCk7CiAKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpJbmRleDogTGF5 b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9zaW1wbGUuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10ZXN0cy9zaW1wbGUuanMJ KHJldmlzaW9uIDUwODg0KQorKysgTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL3NjcmlwdC10 ZXN0cy9zaW1wbGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTcsNiArNyw3IEBAIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKIGZ1bmN0aW9uIGVuZFRlc3QoKQogewogICAgIGlzU3Vj Y2Vzc2Z1bGx5UGFyc2VkKCk7CisgICAgY2xlYXJUaW1lb3V0KHRpbWVvdXRJRCk7CiAgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7CiAgICAgfQpAQCAtMzYsNiArMzcsNiBAQCBmdW5jdGlvbiB0aW1l T3V0Q2FsbGJhY2soKQogICAgIGVuZFRlc3QoKTsKIH0KIAotd2luZG93LnNldFRpbWVvdXQodGlt ZU91dENhbGxiYWNrLCAzMDAwKTsKK3ZhciB0aW1lb3V0SUQgPSBzZXRUaW1lb3V0KHRpbWVPdXRD YWxsYmFjaywgMzAwMCk7CiAKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=