31417 2009-11-12 10:08:17 -0800 Web Inspector: Minor timeline fixes. 2009-11-12 14:11:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 162937 0 pfeldman 2009-11-12 10:08:17 -0800 This fixes undefined map element access and caches record details to get some speed-up. 162939 1 43072 pfeldman 2009-11-12 10:12:32 -0800 Created attachment 43072 [PATCH] fixes 162945 2 pfeldman 2009-11-12 10:27:23 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js Committed r50885 163041 3 joepeck 2009-11-12 14:03:36 -0800 > _updateDetails: function() { Style glitch (brace should be on a new line). Keep it in mind for an update if you do more work in the area. 163043 4 pfeldman 2009-11-12 14:11:03 -0800 thnx. fixing in subsequent patch. 43072 2009-11-12 10:12:32 -0800 2009-11-12 10:15:08 -0800 [PATCH] fixes time_fixes text/plain 2851 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjAxNzBiNS4uNDY1NDM2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0xMiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWlub3IgdGltZWxpbmUgZml4ZXMu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDE3 CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUuX2dldFJlY29yZERldGFp bHMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkVHJlZUVsZW1lbnQucHJv dG90eXBlLm9uYXR0YWNoKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZFRy ZWVFbGVtZW50LnByb3RvdHlwZS5fdXBkYXRlRGV0YWlscyk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGltZWxpbmVSZWNvcmRUcmVlRWxlbWVudC5wcm90b3R5cGUucmVmcmVzaCk6CisKIDIwMDkt MTEtMTEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVQYW5lbC5qcwppbmRleCA1MjdjYWM2Li45MTVhMzgwIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwpAQCAtMjEwLDcgKzIxMCw4IEBA IFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJl dHVybiBXZWJJbnNwZWN0b3IuZGlzcGxheU5hbWVGb3JVUkwocmVjb3JkLmRhdGEudXJsKTsKICAg ICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuVGltZWxpbmVBZ2VudC5SZWNvcmRUeXBlLlJlc291cmNl UmVjZWl2ZVJlc3BvbnNlOgogICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZUFnZW50 LlJlY29yZFR5cGUuUmVzb3VyY2VGaW5pc2g6Ci0gICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVj dG9yLmRpc3BsYXlOYW1lRm9yVVJMKHRoaXMuX3NlbmRSZXF1ZXN0UmVjb3Jkc1tyZWNvcmQuZGF0 YS5pZGVudGlmaWVyXS5kYXRhLnVybCk7CisgICAgICAgICAgICB2YXIgc2VuZFJlcXVlc3RSZWNv cmQgPSB0aGlzLl9zZW5kUmVxdWVzdFJlY29yZHNbcmVjb3JkLmRhdGEuaWRlbnRpZmllcl07Cisg ICAgICAgICAgICByZXR1cm4gc2VuZFJlcXVlc3RSZWNvcmQgPyBXZWJJbnNwZWN0b3IuZGlzcGxh eU5hbWVGb3JVUkwoc2VuZFJlcXVlc3RSZWNvcmQuZGF0YS51cmwpIDogIiI7CiAgICAgICAgIGNh c2UgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQWdlbnQuUmVjb3JkVHlwZS5NYXJrVGltZWxpbmU6CiAg ICAgICAgICAgICByZXR1cm4gcmVjb3JkLmRhdGEubWVzc2FnZTsKICAgICAgICAgZGVmYXVsdDoK QEAgLTUzMiwyMCArNTMzLDI0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZFRyZWVFbGVt ZW50LnByb3RvdHlwZSA9IHsKIAogICAgICAgICAgICAgdGhpcy5kYXRhRWxlbWVudCA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICAgICAgICAgIHRoaXMuZGF0YUVsZW1lbnQu Y2xhc3NOYW1lID0gImRhdGEgZGltbWVkIjsKLSAgICAgICAgICAgIHRoaXMuZGF0YUVsZW1lbnQu dGV4dENvbnRlbnQgPSAiKCIgKyB0aGlzLl9yZWNvcmQuZGV0YWlscyArICIpIjsKLSAgICAgICAg ICAgIHRoaXMuZGF0YUVsZW1lbnQudGl0bGUgPSB0aGlzLl9yZWNvcmQuZGV0YWlsczsKKyAgICAg ICAgICAgIHRoaXMuX3VwZGF0ZURldGFpbHMoKTsKIAogICAgICAgICAgICAgdGhpcy5saXN0SXRl bUVsZW1lbnQuYXBwZW5kQ2hpbGQoc2VwYXJhdG9yRWxlbWVudCk7CiAgICAgICAgICAgICB0aGlz Lmxpc3RJdGVtRWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLmRhdGFFbGVtZW50KTsKICAgICAgICAg fQogICAgIH0sCiAKKyAgICBfdXBkYXRlRGV0YWlsczogZnVuY3Rpb24oKSB7CisgICAgICAgIGlm ICh0aGlzLmRhdGFFbGVtZW50ICYmIHRoaXMuX3JlY29yZC5kZXRhaWxzICE9PSB0aGlzLl9kZXRh aWxzKSB7CisgICAgICAgICAgICB0aGlzLl9kZXRhaWxzID0gdGhpcy5fcmVjb3JkLmRldGFpbHM7 CisgICAgICAgICAgICB0aGlzLmRhdGFFbGVtZW50LnRleHRDb250ZW50ID0gIigiICsgdGhpcy5f ZGV0YWlscyArICIpIjsKKyAgICAgICAgICAgIHRoaXMuZGF0YUVsZW1lbnQudGl0bGUgPSB0aGlz Ll9kZXRhaWxzOworICAgICAgICB9CisgICAgfSwKKwogICAgIHJlZnJlc2g6IGZ1bmN0aW9uKCkK ICAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9yZWNvcmQuZGV0YWlscykgewotICAgICAgICAgICAg dGhpcy5kYXRhRWxlbWVudC50ZXh0Q29udGVudCA9ICIoIiArIHRoaXMuX3JlY29yZC5kZXRhaWxz ICsgIikiOwotICAgICAgICAgICAgdGhpcy5kYXRhRWxlbWVudC50aXRsZSA9IHRoaXMuX3JlY29y ZC5kZXRhaWxzOwotICAgICAgICB9CisgICAgICAgIHRoaXMuX3VwZGF0ZURldGFpbHMoKTsKIAog ICAgICAgICBpZiAodGhpcy5fcmVjb3JkLmNvdW50IDw9IDEpCiAgICAgICAgICAgICByZXR1cm47 Cg==