31416 2009-11-12 10:03:46 -0800 Fail early in parseDateFromNullTerminatedCharacters 2009-11-12 21:08:12 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 vandebo webkit-unassigned commit-queue ggaren oldest_to_newest 162934 0 vandebo 2009-11-12 10:03:46 -0800 When parseDateFromNullTerminatedCharacters() is unable to parse the passed string, it still calculates the timezone and DST offset to apply to the result. This causes an unnecessary IPC in chromium. The attached patch changes the code to only calculate the offsets if parsing was successful. 162935 1 43071 vandebo 2009-11-12 10:05:20 -0800 Created attachment 43071 Only calculate time offsets for valid dates. 162950 2 43071 levin 2009-11-12 10:34:09 -0800 Comment on attachment 43071 Only calculate time offsets for valid dates. Thanks for fixing this. > Index: JavaScriptCore/ChangeLog > +2009-11-11 Steve VanDeBogart <vandebo@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Calculate the time offset only if we were able to parse > + the date string. This saves an IPC in Chromium for > + invalid date strings. Please add a bug link. > Index: JavaScriptCore/wtf/DateMath.cpp > @@ -825,7 +825,7 @@ double parseDateFromNullTerminatedCharac > int offset; > double ms = parseDateFromNullTerminatedCharacters(dateString, haveTZ, offset); > // fall back to local timezone Just do if (isnan(ms)) return NaN; > - if (!haveTZ) { > + if (!haveTZ && ms != NaN) { Also there is another instance to fix in "double parseDateFromNullTerminatedCharacters(ExecState* exec, const char* dateString)" 162969 3 43079 vandebo 2009-11-12 11:06:17 -0800 Created attachment 43079 Other case and early exit 162973 4 43079 vandebo 2009-11-12 11:11:19 -0800 Comment on attachment 43079 Other case and early exit spacing 162974 5 43081 vandebo 2009-11-12 11:12:06 -0800 Created attachment 43081 Fix spacing 163198 6 43081 abarth 2009-11-12 20:49:50 -0800 Comment on attachment 43081 Fix spacing Thanks! 163206 7 43081 commit-queue 2009-11-12 21:08:07 -0800 Comment on attachment 43081 Fix spacing Clearing flags on attachment: 43081 Committed r50927: <http://trac.webkit.org/changeset/50927> 163208 8 commit-queue 2009-11-12 21:08:12 -0800 All reviewed patches have been landed. Closing bug. 43071 2009-11-12 10:05:20 -0800 2009-11-12 11:06:17 -0800 Only calculate time offsets for valid dates. invalid-date-opt.patch text/plain 1297 vandebo SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwODUyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTEgIFN0ZXZlIFZh bkRlQm9nYXJ0ICA8dmFuZGVib0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsY3VsYXRlIHRoZSB0aW1lIG9mZnNldCBvbmx5 IGlmIHdlIHdlcmUgYWJsZSB0byBwYXJzZQorICAgICAgICB0aGUgZGF0ZSBzdHJpbmcuIFRoaXMg c2F2ZXMgYW4gSVBDIGluIENocm9taXVtIGZvcgorICAgICAgICBpbnZhbGlkIGRhdGUgc3RyaW5n cy4KKworICAgICAgICAqIHd0Zi9EYXRlTWF0aC5jcHA6CisgICAgICAgIChXVEY6OnBhcnNlRGF0 ZUZyb21OdWxsVGVybWluYXRlZENoYXJhY3RlcnMpOgorCiAyMDA5LTExLTExICBMYXN6bG8gR29t Ym9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bGV4ZXkgUHJvc2t1cnlha292LgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRoLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwCShyZXZpc2lv biA1MDg1MCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9EYXRlTWF0aC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTgyNSw3ICs4MjUsNyBAQCBkb3VibGUgcGFyc2VEYXRlRnJvbU51bGxUZXJtaW5hdGVk Q2hhcmFjCiAgICAgaW50IG9mZnNldDsKICAgICBkb3VibGUgbXMgPSBwYXJzZURhdGVGcm9tTnVs bFRlcm1pbmF0ZWRDaGFyYWN0ZXJzKGRhdGVTdHJpbmcsIGhhdmVUWiwgb2Zmc2V0KTsKICAgICAv LyBmYWxsIGJhY2sgdG8gbG9jYWwgdGltZXpvbmUKLSAgICBpZiAoIWhhdmVUWikgeworICAgIGlm ICghaGF2ZVRaICYmIG1zICE9IE5hTikgewogICAgICAgICBkb3VibGUgdXRjT2Zmc2V0ID0gY2Fs Y3VsYXRlVVRDT2Zmc2V0KCk7CiAgICAgICAgIGRvdWJsZSBkc3RPZmZzZXQgPSBjYWxjdWxhdGVE U1RPZmZzZXQobXMsIHV0Y09mZnNldCk7CiAgICAgICAgIG9mZnNldCA9IHN0YXRpY19jYXN0PGlu dD4oKHV0Y09mZnNldCArIGRzdE9mZnNldCkgLyBtc1Blck1pbnV0ZSk7Cg== 43079 2009-11-12 11:06:17 -0800 2009-11-12 11:12:06 -0800 Other case and early exit invalid-date-opt-2.patch text/plain 1642 vandebo SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwODg2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTIgIFN0ZXZlIFZh bkRlQm9nYXJ0ICA8dmFuZGVib0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsY3VsYXRlIHRoZSB0aW1lIG9mZnNldCBvbmx5 IGlmIHdlIHdlcmUgYWJsZSB0byBwYXJzZQorICAgICAgICB0aGUgZGF0ZSBzdHJpbmcuIFRoaXMg c2F2ZXMgYW4gSVBDIGluIENocm9taXVtIGZvcgorICAgICAgICBpbnZhbGlkIGRhdGUgc3RyaW5n cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDE2 CisKKyAgICAgICAgKiB3dGYvRGF0ZU1hdGguY3BwOgorICAgICAgICAoV1RGOjpwYXJzZURhdGVG cm9tTnVsbFRlcm1pbmF0ZWRDaGFyYWN0ZXJzKToKKyAgICAgICAgKEpTQzo6cGFyc2VEYXRlRnJv bU51bGxUZXJtaW5hdGVkQ2hhcmFjdGVycyk6CisKIDIwMDktMTEtMTIgIFJpY2hhcmQgTW9lIEd1 c3RhdnNlbiAgPHJpY2hhcmQuZ3VzdGF2c2VuQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0 Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRo LmNwcAkocmV2aXNpb24gNTA4ODYpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04MjQsNiArODI0LDkgQEAgZG91YmxlIHBhcnNlRGF0ZUZyb21O dWxsVGVybWluYXRlZENoYXJhYwogICAgIGJvb2wgaGF2ZVRaOwogICAgIGludCBvZmZzZXQ7CiAg ICAgZG91YmxlIG1zID0gcGFyc2VEYXRlRnJvbU51bGxUZXJtaW5hdGVkQ2hhcmFjdGVycyhkYXRl U3RyaW5nLCBoYXZlVFosIG9mZnNldCk7CisgICAgaWYgKGlzbmFuKG1zKSkKKyAgICAgIHJldHVy biBOYU47CisKICAgICAvLyBmYWxsIGJhY2sgdG8gbG9jYWwgdGltZXpvbmUKICAgICBpZiAoIWhh dmVUWikgewogICAgICAgICBkb3VibGUgdXRjT2Zmc2V0ID0gY2FsY3VsYXRlVVRDT2Zmc2V0KCk7 CkBAIC05NjcsNiArOTcwLDkgQEAgZG91YmxlIHBhcnNlRGF0ZUZyb21OdWxsVGVybWluYXRlZENo YXJhYwogICAgIGJvb2wgaGF2ZVRaOwogICAgIGludCBvZmZzZXQ7CiAgICAgZG91YmxlIG1zID0g V1RGOjpwYXJzZURhdGVGcm9tTnVsbFRlcm1pbmF0ZWRDaGFyYWN0ZXJzKGRhdGVTdHJpbmcsIGhh dmVUWiwgb2Zmc2V0KTsKKyAgICBpZiAoaXNuYW4obXMpKQorICAgICAgcmV0dXJuIE5hTjsKKwog ICAgIC8vIGZhbGwgYmFjayB0byBsb2NhbCB0aW1lem9uZQogICAgIGlmICghaGF2ZVRaKSB7CiAg ICAgICAgIGRvdWJsZSB1dGNPZmZzZXQgPSBnZXRVVENPZmZzZXQoZXhlYyk7Cg== 43081 2009-11-12 11:12:06 -0800 2009-11-12 21:08:07 -0800 Fix spacing invalid-date-opt-3.patch text/plain 1646 vandebo SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwODg2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTIgIFN0ZXZlIFZh bkRlQm9nYXJ0ICA8dmFuZGVib0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsY3VsYXRlIHRoZSB0aW1lIG9mZnNldCBvbmx5 IGlmIHdlIHdlcmUgYWJsZSB0byBwYXJzZQorICAgICAgICB0aGUgZGF0ZSBzdHJpbmcuIFRoaXMg c2F2ZXMgYW4gSVBDIGluIENocm9taXVtIGZvcgorICAgICAgICBpbnZhbGlkIGRhdGUgc3RyaW5n cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDE2 CisKKyAgICAgICAgKiB3dGYvRGF0ZU1hdGguY3BwOgorICAgICAgICAoV1RGOjpwYXJzZURhdGVG cm9tTnVsbFRlcm1pbmF0ZWRDaGFyYWN0ZXJzKToKKyAgICAgICAgKEpTQzo6cGFyc2VEYXRlRnJv bU51bGxUZXJtaW5hdGVkQ2hhcmFjdGVycyk6CisKIDIwMDktMTEtMTIgIFJpY2hhcmQgTW9lIEd1 c3RhdnNlbiAgPHJpY2hhcmQuZ3VzdGF2c2VuQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0 Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRo LmNwcAkocmV2aXNpb24gNTA4ODYpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04MjQsNiArODI0LDkgQEAgZG91YmxlIHBhcnNlRGF0ZUZyb21O dWxsVGVybWluYXRlZENoYXJhYwogICAgIGJvb2wgaGF2ZVRaOwogICAgIGludCBvZmZzZXQ7CiAg ICAgZG91YmxlIG1zID0gcGFyc2VEYXRlRnJvbU51bGxUZXJtaW5hdGVkQ2hhcmFjdGVycyhkYXRl U3RyaW5nLCBoYXZlVFosIG9mZnNldCk7CisgICAgaWYgKGlzbmFuKG1zKSkKKyAgICAgICAgcmV0 dXJuIE5hTjsKKwogICAgIC8vIGZhbGwgYmFjayB0byBsb2NhbCB0aW1lem9uZQogICAgIGlmICgh aGF2ZVRaKSB7CiAgICAgICAgIGRvdWJsZSB1dGNPZmZzZXQgPSBjYWxjdWxhdGVVVENPZmZzZXQo KTsKQEAgLTk2Nyw2ICs5NzAsOSBAQCBkb3VibGUgcGFyc2VEYXRlRnJvbU51bGxUZXJtaW5hdGVk Q2hhcmFjCiAgICAgYm9vbCBoYXZlVFo7CiAgICAgaW50IG9mZnNldDsKICAgICBkb3VibGUgbXMg PSBXVEY6OnBhcnNlRGF0ZUZyb21OdWxsVGVybWluYXRlZENoYXJhY3RlcnMoZGF0ZVN0cmluZywg aGF2ZVRaLCBvZmZzZXQpOworICAgIGlmIChpc25hbihtcykpCisgICAgICAgIHJldHVybiBOYU47 CisKICAgICAvLyBmYWxsIGJhY2sgdG8gbG9jYWwgdGltZXpvbmUKICAgICBpZiAoIWhhdmVUWikg ewogICAgICAgICBkb3VibGUgdXRjT2Zmc2V0ID0gZ2V0VVRDT2Zmc2V0KGV4ZWMpOwo=