31411 2009-11-12 08:08:12 -0800 Web Inspector: breakpoint sidebar entries should allow click over entire list item 2009-11-12 09:08:13 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pmuellr webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 162908 0 pmuellr 2009-11-12 08:08:12 -0800 Currently, the breakpoint sidebar list only allows you to click on the first line of breakpoint entry to "switch to" the source of that breakpoint. It would be nicer if the entire list item, which includes the source text, was also "clickable" to be able to switch to the source of the entry. 162909 1 43064 pmuellr 2009-11-12 08:16:50 -0800 Created attachment 43064 proposed patch 2009/11/12 - a For a breakpoint list item in the breakpoints sidebar: - change the label/link, which contained the sourceURL and line number, to just a text node, and remove the click event - add a click event to the breakpointElement itself - change the name of the labelClicked handler to breakpointClicked - change the checkboxClicked handler to stop propogation, otherwise breakpointClick will be inadvertently invoked as well 162918 2 43064 commit-queue 2009-11-12 09:08:09 -0800 Comment on attachment 43064 proposed patch 2009/11/12 - a Clearing flags on attachment: 43064 Committed r50881: <http://trac.webkit.org/changeset/50881> 162919 3 commit-queue 2009-11-12 09:08:13 -0800 All reviewed patches have been landed. Closing bug. 43064 2009-11-12 08:16:50 -0800 2009-11-12 09:08:08 -0800 proposed patch 2009/11/12 - a 31411.patch text/plain 2755 pmuellr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDg3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTIgIFBhdHJpY2sgTXVlbGxlciAgPFBhdHJpY2tfTXVl bGxlckB1cy5pYm0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGJyZWFrcG9pbnQgc2lkZWJhciBlbnRyaWVzIHNob3Vs ZCBhbGxvdyBjbGljayBvdmVyIGVudGlyZSBsaXN0IGl0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDExCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz OyBubyBuZXcgZnVuY3Rpb25hbGl0eSwgc21hbGwgdXNhYmlsaXR5IGNoYW5nZS4gCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5wcm90b3R5cGUuX2FwcGVu ZEJyZWFrcG9pbnRFbGVtZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVha3BvaW50c1Np ZGViYXJQYW5lLnByb3RvdHlwZS5fYXBwZW5kQnJlYWtwb2ludEVsZW1lbnQuYnJlYWtwb2ludENs aWNrZWQpOgorCiAyMDA5LTExLTEyICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFp bkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4uCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludHNTaWRl YmFyUGFuZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJl YWtwb2ludHNTaWRlYmFyUGFuZS5qcwkocmV2aXNpb24gNTA4NDApCisrKyBXZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5qcwkod29ya2luZyBjb3B5KQpA QCAtNjcsMTIgKzY3LDE1IEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50c1NpZGViYXJQYW5lLnBy b3QKIAogICAgIF9hcHBlbmRCcmVha3BvaW50RWxlbWVudDogZnVuY3Rpb24oYnJlYWtwb2ludCkK ICAgICB7Ci0gICAgICAgIGZ1bmN0aW9uIGNoZWNrYm94Q2xpY2tlZCgpCisgICAgICAgIGZ1bmN0 aW9uIGNoZWNrYm94Q2xpY2tlZChldmVudCkKICAgICAgICAgewogICAgICAgICAgICAgYnJlYWtw b2ludC5lbmFibGVkID0gIWJyZWFrcG9pbnQuZW5hYmxlZDsKKworICAgICAgICAgICAgLy8gd2l0 aG91dCB0aGlzLCB3ZSdkIHN3aXRjaCB0byB0aGUgc291cmNlIG9mIHRoZSBjbGlja2VkIGJyZWFr cG9pbnQKKyAgICAgICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOwogICAgICAgICB9CiAK LSAgICAgICAgZnVuY3Rpb24gbGFiZWxDbGlja2VkKCkKKyAgICAgICAgZnVuY3Rpb24gYnJlYWtw b2ludENsaWNrZWQoKQogICAgICAgICB7CiAgICAgICAgICAgICB2YXIgc2NyaXB0ID0gV2ViSW5z cGVjdG9yLnBhbmVscy5zY3JpcHRzLnNjcmlwdE9yUmVzb3VyY2VGb3JJRChicmVha3BvaW50LnNv dXJjZUlEKTsKICAgICAgICAgICAgIGlmIChzY3JpcHQpCkBAIC04Miw2ICs4NSw3IEBAIFdlYklu c3BlY3Rvci5CcmVha3BvaW50c1NpZGViYXJQYW5lLnByb3QKICAgICAgICAgdmFyIGJyZWFrcG9p bnRFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGkiKTsKICAgICAgICAgYnJlYWtw b2ludC5fYnJlYWtwb2ludExpc3RFbGVtZW50ID0gYnJlYWtwb2ludEVsZW1lbnQ7CiAgICAgICAg IGJyZWFrcG9pbnRFbGVtZW50Ll9icmVha3BvaW50T2JqZWN0ID0gYnJlYWtwb2ludDsKKyAgICAg ICAgYnJlYWtwb2ludEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBicmVha3BvaW50 Q2xpY2tlZCwgZmFsc2UpOwogCiAgICAgICAgIHZhciBjaGVja2JveEVsZW1lbnQgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJpbnB1dCIpOwogICAgICAgICBjaGVja2JveEVsZW1lbnQuY2xhc3NO YW1lID0gImNoZWNrYm94LWVsZW0iOwpAQCAtOTAsOSArOTQsNyBAQCBXZWJJbnNwZWN0b3IuQnJl YWtwb2ludHNTaWRlYmFyUGFuZS5wcm90CiAgICAgICAgIGNoZWNrYm94RWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJjbGljayIsIGNoZWNrYm94Q2xpY2tlZCwgZmFsc2UpOwogICAgICAgICBicmVh a3BvaW50RWxlbWVudC5hcHBlbmRDaGlsZChjaGVja2JveEVsZW1lbnQpOwogCi0gICAgICAgIHZh ciBsYWJlbEVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJhIik7Ci0gICAgICAgIGxh YmVsRWxlbWVudC50ZXh0Q29udGVudCA9IGJyZWFrcG9pbnQubGFiZWw7Ci0gICAgICAgIGxhYmVs RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGxhYmVsQ2xpY2tlZCwgZmFsc2UpOwor ICAgICAgICB2YXIgbGFiZWxFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoYnJlYWtw b2ludC5sYWJlbCk7CiAgICAgICAgIGJyZWFrcG9pbnRFbGVtZW50LmFwcGVuZENoaWxkKGxhYmVs RWxlbWVudCk7CiAKICAgICAgICAgdmFyIHNvdXJjZVRleHRFbGVtZW50ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiZGl2Iik7Cg==