<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31406</bug_id>
          
          <creation_ts>2009-11-12 05:51:46 -0800</creation_ts>
          <short_desc>[Qt] Fix typo ce_time.cpp -&gt; ce_time.c</short_desc>
          <delta_ts>2009-11-13 12:30:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Ismail Donmez">ismail</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>162882</commentid>
    <comment_count>0</comment_count>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2009-11-12 05:51:46 -0800</bug_when>
    <thetext>There is no file named ce_time.cpp, it should be ce_time.c . Patch attached.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>162883</commentid>
    <comment_count>1</comment_count>
      <attachid>43062</attachid>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2009-11-12 05:52:14 -0800</bug_when>
    <thetext>Created attachment 43062
Fix typo</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>162933</commentid>
    <comment_count>2</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2009-11-12 09:53:33 -0800</bug_when>
    <thetext>rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163026</commentid>
    <comment_count>3</comment_count>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2009-11-12 13:15:43 -0800</bug_when>
    <thetext>How do I get this committed ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163028</commentid>
    <comment_count>4</comment_count>
      <attachid>43062</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-12 13:19:51 -0800</bug_when>
    <thetext>Comment on attachment 43062
Fix typo

Rejecting patch 43062 from commit-queue.

ismail@namtrac.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163147</commentid>
    <comment_count>5</comment_count>
      <attachid>43062</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-12 18:28:17 -0800</bug_when>
    <thetext>Comment on attachment 43062
Fix typo

Rejecting patch 43062 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163299</commentid>
    <comment_count>6</comment_count>
      <attachid>43154</attachid>
    <who name="Ismail Donmez">ismail</who>
    <bug_when>2009-11-13 06:48:29 -0800</bug_when>
    <thetext>Created attachment 43154
Provide a changelog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163397</commentid>
    <comment_count>7</comment_count>
      <attachid>43154</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-13 11:48:30 -0800</bug_when>
    <thetext>Comment on attachment 43154
Provide a changelog

Rejecting patch 43154 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--quiet&apos;, &apos;--exit-after-n-failures=1&apos;]&quot; exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11621 test cases.
http/tests/xmlhttprequest/access-control-and-redirects.html -&gt; crashed

Exiting early after 1 failures. 9148 tests run.
435.34s total testing time

9147 test cases (99%) succeeded
1 test case (&lt;1%) crashed
5 test cases (&lt;1%) had stderr output</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163409</commentid>
    <comment_count>8</comment_count>
      <attachid>43154</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 11:57:09 -0800</bug_when>
    <thetext>Comment on attachment 43154
Provide a changelog

Filed bug 31461.  Not your fault. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163426</commentid>
    <comment_count>9</comment_count>
      <attachid>43154</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-13 12:11:27 -0800</bug_when>
    <thetext>Comment on attachment 43154
Provide a changelog

Rejecting patch 43154 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--quiet&apos;, &apos;--exit-after-n-failures=1&apos;]&quot; exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11621 test cases.
inspector/console-dir.html -&gt; crashed

Exiting early after 1 failures. 9312 tests run.
486.83s total testing time

9311 test cases (99%) succeeded
1 test case (&lt;1%) crashed
5 test cases (&lt;1%) had stderr output</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163428</commentid>
    <comment_count>10</comment_count>
      <attachid>43154</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 12:13:44 -0800</bug_when>
    <thetext>Comment on attachment 43154
Provide a changelog

Sorry, the build is in very bad shape right now.  Added the crash report to bug 30835.  Let&apos;s try again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163442</commentid>
    <comment_count>11</comment_count>
      <attachid>43154</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-13 12:30:03 -0800</bug_when>
    <thetext>Comment on attachment 43154
Provide a changelog

Clearing flags on attachment: 43154

Committed r50962: &lt;http://trac.webkit.org/changeset/50962&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163443</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-13 12:30:08 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43062</attachid>
            <date>2009-11-12 05:52:14 -0800</date>
            <delta_ts>2009-11-13 06:48:29 -0800</delta_ts>
            <desc>Fix typo</desc>
            <filename>cetime.patch</filename>
            <type>text/plain</type>
            <size>402</size>
            <attacher name="Ismail Donmez">ismail</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaSBiL0phdmFTY3Jp
cHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQppbmRleCBlYjI2NjY0Li4yOTVlZTJjIDEwMDY0NAot
LS0gYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKKysrIGIvSmF2YVNjcmlwdENv
cmUvSmF2YVNjcmlwdENvcmUucHJpCkBAIC02MSw3ICs2MSw3IEBAIHdpbjMyLSogewogfQogCiB3
aW5jZSogewotICAgIFNPVVJDRVMgKz0gJCRRVF9TT1VSQ0VfVFJFRS9zcmMvM3JkcGFydHkvY2Ut
Y29tcGF0L2NlX3RpbWUuY3BwCisgICAgU09VUkNFUyArPSAkJFFUX1NPVVJDRV9UUkVFL3NyYy8z
cmRwYXJ0eS9jZS1jb21wYXQvY2VfdGltZS5jCiAgICAgREVGSU5FUyArPSBXSU5DRUJBU0lDCiB9
CiAK
</data>
<flag name="review"
          id="24716"
          type_id="1"
          status="+"
          setter="koivisto"
    />
    <flag name="commit-queue"
          id="24750"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43154</attachid>
            <date>2009-11-13 06:48:29 -0800</date>
            <delta_ts>2009-11-13 12:30:03 -0800</delta_ts>
            <desc>Provide a changelog</desc>
            <filename>cetime2.patch</filename>
            <type>text/plain</type>
            <size>841</size>
            <attacher name="Ismail Donmez">ismail</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCBlNmFiMDczLi43NDE1OWQ0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEg
QEAKKzIwMDktMTEtMTMgIMSwc21haWwgRMO2bm1leiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KKworICAgICAgICBGaXggdHlwbywg
Y2VfdGltZS5jcHAgc2hvdWxkIGJlIGNlX3RpbWUuYworCisgICAgICAgICogSmF2YVNjcmlwdENv
cmUucHJpOgorCiAyMDA5LTEwLTI5ICBHYWJvciBMb2tpICA8bG9raUBpbmYudS1zemVnZWQuaHU+
CgogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL0ph
dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaSBiL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp
cHRDb3JlLnByaQppbmRleCBlYjI2NjY0Li4yOTVlZTJjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0
Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKKysrIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv
cmUucHJpCkBAIC02MSw3ICs2MSw3IEBAIHdpbjMyLSogewogfQoKIHdpbmNlKiB7Ci0gICAgU09V
UkNFUyArPSAkJFFUX1NPVVJDRV9UUkVFL3NyYy8zcmRwYXJ0eS9jZS1jb21wYXQvY2VfdGltZS5j
cHAKKyAgICBTT1VSQ0VTICs9ICQkUVRfU09VUkNFX1RSRUUvc3JjLzNyZHBhcnR5L2NlLWNvbXBh
dC9jZV90aW1lLmMKICAgICBERUZJTkVTICs9IFdJTkNFQkFTSUMKIH0KCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>