31403 2009-11-12 04:52:38 -0800 [Qt] Disable pthread_setname_np. 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED Qt P2 Normal --- 1 jturcotte webkit-qt-unassigned commit-queue hausmann kenneth kent.hansen mrowe vestbo oldest_to_newest 162869 0 jturcotte 2009-11-12 04:52:38 -0800 Comment from original commit in Qt's 3rdparty: BT: JavaScriptCore makes applications crash on leopard JavaScriptCore checks the Mac OS version when building, and uses symbols only defined in i e.g.snow leopard when building on snow leopard. This means that if you build Qt on snow leopard and later move it to leopard, applications will crash looking for a missing symbol (pthread_setname_np in particular). In Qt, we garuantee that you can run your applications on 10.4 and up for Carbon, and 10.5 and up for Cocoa. So using compile time checks this way is not a proper soulution. Result: In Qt, never use symbols not defined on all supported OS versions, or at least implement run-time checks. Rev-By: Simon Hausmann Rev-By: Tor Arne Rev-By: MortenS 162872 1 43057 jturcotte 2009-11-12 05:06:54 -0800 Created attachment 43057 Patch from Qt src/3rdparty 162886 2 43057 commit-queue 2009-11-12 06:06:07 -0800 Comment on attachment 43057 Patch from Qt src/3rdparty Clearing flags on attachment: 43057 Committed r50877: <http://trac.webkit.org/changeset/50877> 162887 3 commit-queue 2009-11-12 06:06:11 -0800 All reviewed patches have been landed. Closing bug. 162888 4 43057 mrowe 2009-11-12 06:08:22 -0800 Comment on attachment 43057 Patch from Qt src/3rdparty This isn’t really the right way to address this. I don’t know anything about how the Qt build process works but we have TARGETING_TIGER / TARGETING_LEOPARD macros that can be used to exclude code based on the minimum supported Mac OS X version that the binary will run on (rather than the BUILDING_ON macros which are about the maximum version). 162889 5 mrowe 2009-11-12 06:09:35 -0800 I’m reopening this so it can be fixed in a more appropriate manner. 162892 6 kenneth 2009-11-12 06:35:17 -0800 Apparently the original code using BUILDING_ON_TIGER/LEOPARD could be replaced with TARGETING_TIGER/LEOPARD instead, depending on how the Qt build system works. Quote from Mark Rowe: i'm not sure how the Qt build system works but I would imagine that if it builds on 10.6 but deploys on 10.5 it would be setting the so-called Mac OS X deployment target so that the right platform headers are exposed. Tor Arne, can you look into this? 198118 7 kent.hansen 2010-03-10 07:03:05 -0800 (In reply to comment #6) > Apparently the original code using BUILDING_ON_TIGER/LEOPARD could be replaced > with TARGETING_TIGER/LEOPARD instead, depending on how the Qt build system > works. > > Quote from Mark Rowe: > > i'm not sure how the Qt build system works but I would imagine that if it > builds on 10.6 but deploys on 10.5 it would be setting the so-called Mac OS X > deployment target so that the right platform headers are exposed. > > Tor Arne, can you look into this? Maybe Platform.h should be using TARGETING rather than BUILDING_ON for that stuff? The TARGETING macros were added not that long ago. I have a patch in the queue that switches from BUILDING_ON to TARGETING for similar reasons (https://bugs.webkit.org/show_bug.cgi?id=34888). 221080 8 55117 benjamin 2010-05-05 06:33:59 -0700 Created attachment 55117 Use TARGETING instead of BUILDING_ON Uptate with the comments of Mark and Kent. 234777 9 55117 hausmann 2010-06-07 04:20:12 -0700 Comment on attachment 55117 Use TARGETING instead of BUILDING_ON r=me, but the ChangeLog needs to be a bit more verbose on what the problem is. I'll try to do that when landing it. 234800 10 hausmann 2010-06-07 05:16:08 -0700 Committed r60773: <http://trac.webkit.org/changeset/60773> 234809 11 hausmann 2010-06-07 05:50:07 -0700 Revision r60773 cherry-picked into qtwebkit-2.0 with commit f943ead2759537527faa7f3cb057d995291663b9 43057 2009-11-12 05:06:54 -0800 2009-11-12 06:08:22 -0800 Patch from Qt src/3rdparty disable_pthreadsetnamenp.patch text/plain 1174 jturcotte ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxMzNjZDZkLi5jYjg3MzlkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDktMTEtMTIgIFJpY2hhcmQgTW9lIEd1c3RhdnNlbiAgPHJpY2hhcmQuZ3VzdGF2c2Vu QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIERpc2FibGUgcHRocmVhZF9zZXRuYW1lX25wLgorCisgICAgICAgIFRoaXMgYWxs b3dzIFF0IGJ1aWxkcyBvbiBNYWMgZnJvbSAxMC42IHRvIHJ1biBvbiBlYXJsaWVyIHZlcnNpb24K KyAgICAgICAgd2hlcmUgdGhpcyBzeW1ib2wgaXMgbm90IHByZXNlbnQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQwMworCisgICAgICAgICogd3Rm L1BsYXRmb3JtLmg6CisKIDIwMDktMTEtMTIgIFRoaWFnbyBNYWNpZWlyYSA8dGhpYWdvLm1hY2ll aXJhQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlz dGlhbnNlbi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2 YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5kZXggM2UwY2I1OC4uZjRiNzQ5NSAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgKQEAgLTU2NSw3ICs1NjUsNyBAQAogI2RlZmluZSBIQVZFX1NZU19USU1F X0ggMQogI2RlZmluZSBIQVZFX1NZU19USU1FQl9IIDEKIAotI2lmICFkZWZpbmVkKEJVSUxESU5H X09OX1RJR0VSKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhUExBVEZPUk0o SVBIT05FKQorI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKSAmJiAhZGVmaW5lZChCVUlM RElOR19PTl9MRU9QQVJEKSAmJiAhUExBVEZPUk0oSVBIT05FKSAmJiAhUExBVEZPUk0oUVQpCiAj ZGVmaW5lIEhBVkVfTUFEVl9GUkVFX1JFVVNFIDEKICNkZWZpbmUgSEFWRV9NQURWX0ZSRUUgMQog I2RlZmluZSBIQVZFX1BUSFJFQURfU0VUTkFNRV9OUCAxCg== 55117 2010-05-05 06:33:59 -0700 2010-06-07 04:20:11 -0700 Use TARGETING instead of BUILDING_ON 31403.patch text/plain 1194 benjamin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjNjFjODgzLi5hMjkzMTdhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMDUtMDUgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIERpc2FibGUgcHRocmVhZF9zZXRuYW1lX25wLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0MDMKKworICAgICAgICBVc2UgdGhlIGRlZmluZXMg VEFSR0VUSU5HX1hYIGluc3RlYWQgb2YgQlVJTERJTkdfT05fWFggCisgICAgICAgIGZvciBmZWF0 dXJlcyB0aGF0IGNhbm5vdCBiZSB1c2VkIGJlZm9yZSBTbm93IExlb3BhcmQuCisKKyAgICAgICAg KiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxMC0wNS0wNCAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5f emhhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0Q29yZS93 dGYvUGxhdGZvcm0uaAppbmRleCA5YmUyY2NkLi44ZDViMjExIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0u aApAQCAtNzA4LDExICs3MDgsMTEgQEAKICNkZWZpbmUgSEFWRV9TWVNfVElNRV9IIDEKICNkZWZp bmUgSEFWRV9TWVNfVElNRUJfSCAxCiAKLSNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikg JiYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVPUEFSRCkKKyNpZiAhZGVmaW5lZChUQVJHRVRJTkdf VElHRVIpICYmICFkZWZpbmVkKFRBUkdFVElOR19MRU9QQVJEKQogCiAjZGVmaW5lIEhBVkVfRElT UEFUQ0hfSCAxCiAKLSNpZiAhUExBVEZPUk0oSVBIT05FKSAmJiAhUExBVEZPUk0oUVQpCisjaWYg IVBMQVRGT1JNKElQSE9ORSkKICNkZWZpbmUgSEFWRV9NQURWX0ZSRUVfUkVVU0UgMQogI2RlZmlu ZSBIQVZFX01BRFZfRlJFRSAxCiAjZGVmaW5lIEhBVkVfUFRIUkVBRF9TRVROQU1FX05QIDEK