31393 2009-11-11 23:57:15 -0800 externalRepresentation should take Frame as the argument 2009-11-12 18:49:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned darin oldest_to_newest 162814 0 hamaji 2009-11-11 23:57:15 -0800 As suggested in Bug 30555, WebCore::externalRepresentation should take Frame* instead of RenderObject*. 162817 1 43036 hamaji 2009-11-12 00:00:41 -0800 Created attachment 43036 Patch v1 162923 2 43036 darin 2009-11-12 09:22:44 -0800 Comment on attachment 43036 Patch v1 This is a good change. But you're missing an opportunity to fix a major bug in externalRepresentation. The layout needs to be moved to the top of the function, before the SVG call to writeRenderResources. And the RenderObject should be fetched only after the call to layout. I'll say r=me assuming that you'll do those fixes in a subsequent patch, because those are really the motivation for making this change. 163152 3 43036 hamaji 2009-11-12 18:37:27 -0800 Comment on attachment 43036 Patch v1 Clearing flags on attachment: 43036 Committed r50923: <http://trac.webkit.org/changeset/50923> 163153 4 hamaji 2009-11-12 18:37:36 -0800 All reviewed patches have been landed. Closing bug. 163160 5 hamaji 2009-11-12 18:49:22 -0800 Yeah, I'll fix it, but I wanted to avoid changing both WebCore interface and WebCore implementation in one patch. An interface change requires change of multiple platform code, which has the risk of build breakage. So, I want to keep the risk as possible. I'll post another patch after I confirm this change doesn't break anything in build bots. I think I should have described this plan, sorry. Thanks for the review. 43036 2009-11-12 00:00:41 -0800 2009-11-12 18:37:27 -0800 Patch v1 bug-31393-20091112170038.patch text/plain 6976 hamaji ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDM0YTFhZS4uNzUyZmU4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0xMSAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGV4dGVybmFsUmVwcmVzZW50YXRpb24gc2hvdWxkIHRha2Ug RnJhbWUgYXMgdGhlIGFyZ3VtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMTM5MworCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGlzIGp1 c3QgYSByZWZhY3RvcmluZy4KKworICAgICAgICAqIFdlYkNvcmUuYmFzZS5leHA6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZXh0 ZXJuYWxSZXByZXNlbnRhdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRyZWVBc1Rl eHQuaDoKKwogMjAwOS0xMS0xMSAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwIGIvV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwCmluZGV4 IDk3NjlmNDYuLjVjOWE2NTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5iYXNlLmV4cAor KysgYi9XZWJDb3JlL1dlYkNvcmUuYmFzZS5leHAKQEAgLTQyNyw3ICs0MjcsNyBAQCBfX1pON1dl YkNvcmUyMlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQyNmNhblN1c3BlbmRBY3RpdmVET01PYmplY3Rz RXYKIF9fWk43V2ViQ29yZTIyYXBwbGljYXRpb25Jc0FwcGxlTWFpbEV2CiBfX1pON1dlYkNvcmUy MmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRFUE5TXzdFbGVtZW50RQogX19aTjdXZWJDb3JlMjJjcmVh dGVGcmFnbWVudEZyb21UZXh0RVBOU181UmFuZ2VFUktOU182U3RyaW5nRQotX19aTjdXZWJDb3Jl MjJleHRlcm5hbFJlcHJlc2VudGF0aW9uRVBOU18xMlJlbmRlck9iamVjdEUKK19fWk43V2ViQ29y ZTIyZXh0ZXJuYWxSZXByZXNlbnRhdGlvbkVQTlNfNUZyYW1lRQogX19aTjdXZWJDb3JlMjNBcHBs aWNhdGlvbkNhY2hlU3RvcmFnZTE0c2V0TWF4aW11bVNpemVFeAogX19aTjdXZWJDb3JlMjNBcHBs aWNhdGlvbkNhY2hlU3RvcmFnZTE2c3RvcmVDb3B5T2ZDYWNoZUVSS05TXzZTdHJpbmdFUE5TXzIw QXBwbGljYXRpb25DYWNoZUhvc3RFCiBfX1pON1dlYkNvcmUyM0FwcGxpY2F0aW9uQ2FjaGVTdG9y YWdlMTdzZXRDYWNoZURpcmVjdG9yeUVSS05TXzZTdHJpbmdFCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRyZWVBc1RleHQuY3BwCmluZGV4IDEyMGRlYjQuLmFmMGQ4MjUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRyZWVBc1RleHQuY3BwCkBAIC01MzksOCArNTM5LDkgQEAgc3RhdGljIHZvaWQgd3Jp dGVTZWxlY3Rpb24oVGV4dFN0cmVhbSYgdHMsIGNvbnN0IFJlbmRlck9iamVjdCogbykKICAgICAg ICAgICAgPDwgInNlbGVjdGlvbiBlbmQ6ICAgcG9zaXRpb24gIiA8PCBzZWxlY3Rpb24uZW5kKCku ZGVwcmVjYXRlZEVkaXRpbmdPZmZzZXQoKSA8PCAiIG9mICIgPDwgbm9kZVBvc2l0aW9uKHNlbGVj dGlvbi5lbmQoKS5ub2RlKCkpIDw8ICJcbiI7CiB9CiAKLVN0cmluZyBleHRlcm5hbFJlcHJlc2Vu dGF0aW9uKFJlbmRlck9iamVjdCogbykKK1N0cmluZyBleHRlcm5hbFJlcHJlc2VudGF0aW9uKEZy YW1lKiBmcmFtZSkKIHsKKyAgICBSZW5kZXJPYmplY3QqIG8gPSBmcmFtZS0+Y29udGVudFJlbmRl cmVyKCk7CiAgICAgaWYgKCFvKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKZGlmZiAtLWdp dCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuaCBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRyZWVBc1RleHQuaAppbmRleCAzMjVmMTA5Li5iMDBmN2M5IDEwMDY0NAotLS0g YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmgKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5oCkBAIC0yOSwxMSArMjksMTIgQEAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogY2xhc3MgRWxlbWVudDsKK2NsYXNzIEZyYW1lOwogY2xhc3MgUmVuZGVyT2Jq ZWN0OwogY2xhc3MgU3RyaW5nOwogY2xhc3MgVGV4dFN0cmVhbTsKIAotU3RyaW5nIGV4dGVybmFs UmVwcmVzZW50YXRpb24oUmVuZGVyT2JqZWN0Kik7CitTdHJpbmcgZXh0ZXJuYWxSZXByZXNlbnRh dGlvbihGcmFtZSopOwogdm9pZCB3cml0ZShUZXh0U3RyZWFtJiwgY29uc3QgUmVuZGVyT2JqZWN0 JiwgaW50IGluZGVudCA9IDApOwogCiAvLyBIZWxwZXIgZnVuY3Rpb24gc2hhcmVkIHdpdGggU1ZH UmVuZGVyVHJlZUFzVGV4dApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJL aXQvZ3RrL0NoYW5nZUxvZwppbmRleCA3OTFjMzQyLi40NjRlMzJhIDEwMDY0NAotLS0gYS9XZWJL aXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDA5LTExLTExICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZXh0ZXJu YWxSZXByZXNlbnRhdGlvbiBzaG91bGQgdGFrZSBGcmFtZSBhcyB0aGUgYXJndW1lbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMzkzCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgaXMganVzdCBhIHJlZmFjdG9yaW5nLgorCisgICAgICAg ICogd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfZnJhbWVf ZHVtcF9yZW5kZXJfdHJlZSk6CisKIDIwMDktMTEtMTEgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAg PGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg SG9sZ2VyIEZyZXl0aGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi ZnJhbWUuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCmluZGV4IDg0 M2Y5MjMuLjMzMWU1ZTggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZy YW1lLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKQEAgLTc5 NCw3ICs3OTQsNyBAQCBnY2hhciogd2Via2l0X3dlYl9mcmFtZV9kdW1wX3JlbmRlcl90cmVlKFdl YktpdFdlYkZyYW1lKiBmcmFtZSkKICAgICBpZiAodmlldyAmJiB2aWV3LT5sYXlvdXRQZW5kaW5n KCkpCiAgICAgICAgIHZpZXctPmxheW91dCgpOwogCi0gICAgU3RyaW5nIHN0cmluZyA9IGV4dGVy bmFsUmVwcmVzZW50YXRpb24oY29yZUZyYW1lLT5jb250ZW50UmVuZGVyZXIoKSk7CisgICAgU3Ry aW5nIHN0cmluZyA9IGV4dGVybmFsUmVwcmVzZW50YXRpb24oY29yZUZyYW1lKTsKICAgICByZXR1 cm4gZ19zdHJkdXAoc3RyaW5nLnV0ZjgoKS5kYXRhKCkpOwogfQogCmRpZmYgLS1naXQgYS9XZWJL aXQvbWFjL0NoYW5nZUxvZyBiL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4IGY0NDc4NDkuLjU4 NzI0NTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9tYWMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTEgIFNoaW5pY2hpcm8gSGFtYWpp ICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBleHRlcm5hbFJlcHJlc2VudGF0aW9uIHNob3VsZCB0YWtlIEZyYW1l IGFzIHRoZSBhcmd1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzEzOTMKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBpcyBqdXN0IGEg cmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBNaXNjL1dlYkNvcmVTdGF0aXN0aWNzLm1tOgorICAg ICAgICAoLVtXZWJGcmFtZSByZW5kZXJUcmVlQXNFeHRlcm5hbFJlcHJlc2VudGF0aW9uXSk6CisK IDIwMDktMTEtMTAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9NaXNjL1dl YkNvcmVTdGF0aXN0aWNzLm1tIGIvV2ViS2l0L21hYy9NaXNjL1dlYkNvcmVTdGF0aXN0aWNzLm1t CmluZGV4IDZiYWM0NmUuLmYyMDRkZGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvTWlzYy9XZWJD b3JlU3RhdGlzdGljcy5tbQorKysgYi9XZWJLaXQvbWFjL01pc2MvV2ViQ29yZVN0YXRpc3RpY3Mu bW0KQEAgLTI0Miw3ICsyNDIsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogLSAoTlNT dHJpbmcgKilyZW5kZXJUcmVlQXNFeHRlcm5hbFJlcHJlc2VudGF0aW9uCiB7Ci0gICAgcmV0dXJu IGV4dGVybmFsUmVwcmVzZW50YXRpb24oX3ByaXZhdGUtPmNvcmVGcmFtZS0+Y29udGVudFJlbmRl cmVyKCkpOworICAgIHJldHVybiBleHRlcm5hbFJlcHJlc2VudGF0aW9uKF9wcml2YXRlLT5jb3Jl RnJhbWUpOwogfQogCiAtIChOU1N0cmluZyAqKWNvdW50ZXJWYWx1ZUZvckVsZW1lbnQ6KERPTUVs ZW1lbnQqKWVsZW1lbnQKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBi L1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcAppbmRleCBjODVkZTZiLi40YzdjNGZjIDEwMDY0 NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9x d2ViZnJhbWUuY3BwCkBAIC00OTAsNyArNDkwLDcgQEAgUVN0cmluZyBRV2ViRnJhbWU6OnJlbmRl clRyZWVEdW1wKCkgY29uc3QKICAgICBpZiAoZC0+ZnJhbWUtPnZpZXcoKSAmJiBkLT5mcmFtZS0+ dmlldygpLT5sYXlvdXRQZW5kaW5nKCkpCiAgICAgICAgIGQtPmZyYW1lLT52aWV3KCktPmxheW91 dCgpOwogCi0gICAgcmV0dXJuIGV4dGVybmFsUmVwcmVzZW50YXRpb24oZC0+ZnJhbWUtPmNvbnRl bnRSZW5kZXJlcigpKTsKKyAgICByZXR1cm4gZXh0ZXJuYWxSZXByZXNlbnRhdGlvbihkLT5mcmFt ZSk7CiB9CiAKIC8qIQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYmQ4YzRhZC4uODdmM2EyYyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MDktMTEtMTEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBleHRlcm5hbFJlcHJl c2VudGF0aW9uIHNob3VsZCB0YWtlIEZyYW1lIGFzIHRoZSBhcmd1bWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEzOTMKKworICAgICAgICBObyBu ZXcgdGVzdHMgYXMgdGhpcyBpcyBqdXN0IGEgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBBcGkv cXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKFFXZWJGcmFtZTo6cmVuZGVyVHJlZUR1bXApOgorCiAy MDA5LTExLTExICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJLaXQv d2luL0NoYW5nZUxvZyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCmluZGV4IDE0Y2QwNTMuLjllNTdh YWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC93aW4vQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTEgIFNoaW5pY2hpcm8gSGFtYWppICA8 aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBleHRlcm5hbFJlcHJlc2VudGF0aW9uIHNob3VsZCB0YWtlIEZyYW1lIGFz IHRoZSBhcmd1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzEzOTMKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBpcyBqdXN0IGEgcmVm YWN0b3JpbmcuCisKKyAgICAgICAgKiBXZWJGcmFtZS5jcHA6CisgICAgICAgIChXZWJGcmFtZTo6 cmVuZGVyVHJlZUFzRXh0ZXJuYWxSZXByZXNlbnRhdGlvbik6CisKIDIwMDktMTEtMTEgIEJldGgg RGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4gTm8gcmV2aWV3 IG5lZWRlZC4KZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vV2ViRnJhbWUuY3BwIGIvV2ViS2l0L3dp bi9XZWJGcmFtZS5jcHAKaW5kZXggMWU2NGQxYS4uNmZiOGZkZiAxMDA2NDQKLS0tIGEvV2ViS2l0 L3dpbi9XZWJGcmFtZS5jcHAKKysrIGIvV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAKQEAgLTgyMCw3 ICs4MjAsNyBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjpyZW5kZXJUcmVl QXNFeHRlcm5hbFJlcHJlc2VudGF0aW9uKAogICAgIGlmICghY29yZUZyYW1lKQogICAgICAgICBy ZXR1cm4gRV9GQUlMOwogCi0gICAgKnJlc3VsdCA9IEJTdHJpbmcoZXh0ZXJuYWxSZXByZXNlbnRh dGlvbihjb3JlRnJhbWUtPmNvbnRlbnRSZW5kZXJlcigpKSkucmVsZWFzZSgpOworICAgICpyZXN1 bHQgPSBCU3RyaW5nKGV4dGVybmFsUmVwcmVzZW50YXRpb24oY29yZUZyYW1lKSkucmVsZWFzZSgp OwogICAgIHJldHVybiBTX09LOwogfQ==