31391 2009-11-11 20:27:23 -0800 SVNTest.test_svn_apply may fail in different timezone 2013-01-21 19:36:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 65877 P2 Normal --- 1 hamaji webkit-unassigned eric mithro oldest_to_newest 162780 0 hamaji 2009-11-11 20:27:23 -0800 svn-apply sets TZ=PST8PDT but SVNTest.test_svn_apply doesn't change this. This can cause unittest failure. 162781 1 43028 hamaji 2009-11-11 20:28:14 -0800 Created attachment 43028 Patch v1 163481 2 43028 eric 2009-11-13 13:43:32 -0800 Comment on attachment 43028 Patch v1 Isn't there a cleaner fix w/o using os.environ? I would think Date would have some sort of timezone adjustment methods... 163911 3 hamaji 2009-11-16 02:41:20 -0800 If nothing changed after I did similar stuff with Python (and as far as I searched webs now), I think there are no easy way to do this. If I understand correctly, Python provides a framework to convert datetime object among different timezones, but it doesn't provide information of actual timezones. Like following blog post, we need to provide information of each timezone by ourselves. http://uswaretech.com/blog/2009/02/understanding-datetime-tzinfo-timedelta-timezone-conversions-python/ There seems to be a library which provides information of timezones, but it seems not to be the standard library. http://pytz.sourceforge.net/ I think my patch would be OK as prepare-ChangeLog is doing the same thing after all and it's just a test. Another idea to fix this is adding an --date flag into prepare-ChangeLog and use this flag in this unittest. If you prefer this approach, I'll do the fix. Of course, if I'm missing something and there is a better way, I'd like to use the way. 812538 4 mithro 2013-01-21 19:36:15 -0800 This bug was fixed by jochen@chromium.org in r93257 http://trac.webkit.org/changeset/93257 *** This bug has been marked as a duplicate of bug 65877 *** 43028 2009-11-11 20:28:14 -0800 2010-06-10 19:38:51 -0700 Patch v1 bug-31391-20091112132812.patch text/plain 1327 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwYmFjNzc5Li41ZDE5ODM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTEt MTEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVk5UZXN0LnRlc3Rfc3ZuX2Fw cGx5IG1heSBmYWlsIGluIGRpZmZlcmVudCB0aW1lem9uZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEzOTEKKworICAgICAgICAqIFNjcmlwdHMvbW9k dWxlcy9zY21fdW5pdHRlc3QucHk6CisKIDIwMDktMTEtMTEgIERtaXRyeSBUaXRvdiAgPGRpbWlj aEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkLCByZW1vdmluZyBkdXBsaWNh dGUgZW50cnkgZm9yIG15c2VsZiBpbiBjb21taXR0ZXJzLnB5LgpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbV91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHkKaW5kZXggYTZhM2I3MS4uM2RhNGUwYiAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbV91bml0dGVzdC5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtX3VuaXR0ZXN0LnB5CkBAIC0yMTAsNyArMjEw LDggQEAgY2xhc3MgU1ZOVGVzdChTQ01UZXN0KToKICAgICBkZWYgX3NldF9kYXRlX2FuZF9yZXZp ZXdlcihjaGFuZ2Vsb2dfZW50cnkpOgogICAgICAgICAjIEpvZSBDb29sIG1hdGNoZXMgdGhlIHJl dmlld2VyIHNldCBpbiBTQ01UZXN0Ll9jcmVhdGVfcGF0Y2gKICAgICAgICAgY2hhbmdlbG9nX2Vu dHJ5ID0gY2hhbmdlbG9nX2VudHJ5LnJlcGxhY2UoJ1JFVklFV0VSX0hFUkUnLCAnSm9lIENvb2wn KQotICAgICAgICAjIHN2bi1hcHBseSB3aWxsIHVwZGF0ZSBDaGFuZ2VMb2cgZW50cmllcyB3aXRo IHRvZGF5J3MgZGF0ZS4KKyAgICAgICAgIyBzdm4tYXBwbHkgd2lsbCB1cGRhdGUgQ2hhbmdlTG9n IGVudHJpZXMgd2l0aCB0b2RheSdzIGRhdGUgdXNpbmcgUERULgorICAgICAgICBvcy5lbnZpcm9u WydUWiddID0gJ1BTVDhQRFQnCiAgICAgICAgIHJldHVybiBjaGFuZ2Vsb2dfZW50cnkucmVwbGFj ZSgnREFURV9IRVJFJywgZGF0ZS50b2RheSgpLmlzb2Zvcm1hdCgpKQogCiAgICAgZGVmIHRlc3Rf c3ZuX2FwcGx5KHNlbGYpOg==