31380 2009-11-11 15:31:03 -0800 DOM Wrappers for some nodes may not be marked. 2009-11-11 17:00:39 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned aroben oldest_to_newest 162704 0 barraclough 2009-11-11 15:31:03 -0800 Some markChildren methods are calling getCachedDOMNodeWrapper, which will find the wrapper for the current world only. This means that wrappers may be GC'ed prematurely, and properties lost. Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds. 162710 1 43014 barraclough 2009-11-11 15:52:34 -0800 Created attachment 43014 The patch 162732 2 barraclough 2009-11-11 17:00:39 -0800 Sending WebCore/ChangeLog Sending WebCore/bindings/js/JSAttrCustom.cpp Sending WebCore/bindings/js/JSDOMBinding.cpp Sending WebCore/bindings/js/JSDOMBinding.h Sending WebCore/bindings/js/JSNamedNodeMapCustom.cpp Sending WebCore/bindings/js/JSNodeCustom.cpp Sending WebCore/bindings/js/JSSVGElementInstanceCustom.cpp Sending WebCore/bindings/js/JSStyleSheetCustom.cpp Transmitting file data ........ Committed revision 50850. 43014 2009-11-11 15:52:34 -0800 2009-11-11 16:30:06 -0800 The patch patch.marknodes.txt text/plain 7327 barraclough SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDg0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjggQEAKKzIwMDktMTEtMTEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91 Z2hAYXBwbGUuY29tPgorCisgICAgICAgIERPTSBXcmFwcGVycyBmb3Igc29tZSBub2RlcyBtYXkg bm90IGJlIG1hcmtlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMxMzgwCisKKyAgICAgICAgU29tZSBtYXJrQ2hpbGRyZW4gbWV0aG9kcyBhcmUgY2Fs bGluZyBnZXRDYWNoZWRET01Ob2RlV3JhcHBlciwgd2hpY2ggd2lsbCBmaW5kCisgICAgICAgIHRo ZSB3cmFwcGVyIGZvciB0aGUgY3VycmVudCB3b3JsZCBvbmx5LiAgVGhpcyBtZWFucyB0aGF0IHdy YXBwZXJzIG1heSBiZSBHQydlZAorICAgICAgICBwcmVtYXR1cmVseSwgYW5kIHByb3BlcnRpZXMg bG9zdC4KKworICAgICAgICBNb3ZlIHRvIGEgbW9kZWwgbW9yZSBsaWtlIG1hcmtET01PYmplY3RX cmFwcGVyLCBtYXJrIHdyYXBwZXJzIGZvciBhbGwgd29ybGRzLgorCisgICAgICAgICogYmluZGlu Z3MvanMvSlNBdHRyQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTQXR0cjo6bWFya0No aWxkcmVuKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6bWFya0RPTU5vZGVXcmFwcGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9K U0RPTUJpbmRpbmcuaDoKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU05hbWVkTm9kZU1hcEN1c3Rv bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU05hbWVkTm9kZU1hcDo6bWFya0NoaWxkcmVuKToK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SlNOb2RlOjptYXJrQ2hpbGRyZW4pOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTU1ZHRWxl bWVudEluc3RhbmNlQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTU1ZHRWxlbWVudElu c3RhbmNlOjptYXJrQ2hpbGRyZW4pOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTU3R5bGVTaGVl dEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1N0eWxlU2hlZXQ6Om1hcmtDaGlsZHJl bik6CisKIDIwMDktMTEtMTEgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdz L2pzL0pTQXR0ckN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0F0dHJDdXN0b20uY3BwCShyZXZpc2lvbiA1MDc5MikKKysrIFdlYkNvcmUvYmluZGluZ3MvanMv SlNBdHRyQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjUsMTAgKzY1LDggQEAgdm9pZCBK U0F0dHI6Om1hcmtDaGlsZHJlbihNYXJrU3RhY2smIG1hcgogCiAgICAgLy8gTWFyayB0aGUgZWxl bWVudCBzbyB0aGF0IHRoaXMgd2lsbCB3b3JrIHRvIGFjY2VzcyB0aGUgYXR0cmlidXRlIGV2ZW4g aWYgdGhlIGxhc3QKICAgICAvLyBvdGhlciByZWZlcmVuY2UgZ29lcyBhd2F5LgotICAgIGlmIChF bGVtZW50KiBlbGVtZW50ID0gaW1wbCgpLT5vd25lckVsZW1lbnQoKSkgewotICAgICAgICBpZiAo SlNOb2RlKiB3cmFwcGVyID0gZ2V0Q2FjaGVkRE9NTm9kZVdyYXBwZXIoZWxlbWVudC0+ZG9jdW1l bnQoKSwgZWxlbWVudCkpCi0gICAgICAgICAgICBtYXJrU3RhY2suYXBwZW5kKHdyYXBwZXIpOwot ICAgIH0KKyAgICBpZiAoRWxlbWVudCogZWxlbWVudCA9IGltcGwoKS0+b3duZXJFbGVtZW50KCkp CisgICAgICAgIG1hcmtET01Ob2RlV3JhcHBlcihtYXJrU3RhY2ssIGVsZW1lbnQtPmRvY3VtZW50 KCksIGVsZW1lbnQpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTUJpbmRpbmcuY3BwCShyZXZpc2lvbiA1MDc5MikKKysrIFdlYkNvcmUvYmlu ZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTM2LDYgKzUzNiwy MyBAQCB2b2lkIG1hcmtET01PYmplY3RXcmFwcGVyKE1hcmtTdGFjayYgbWFyCiAgICAgfQogfQog Cit2b2lkIG1hcmtET01Ob2RlV3JhcHBlcihNYXJrU3RhY2smIG1hcmtTdGFjaywgRG9jdW1lbnQq IGRvY3VtZW50LCBOb2RlKiBub2RlKQoreworICAgIGlmIChkb2N1bWVudCkgeworICAgICAgICBK U1dyYXBwZXJDYWNoZU1hcCYgd3JhcHBlckNhY2hlTWFwID0gZG9jdW1lbnQtPndyYXBwZXJDYWNo ZU1hcCgpOworICAgICAgICBmb3IgKEpTV3JhcHBlckNhY2hlTWFwOjppdGVyYXRvciBpdGVyID0g d3JhcHBlckNhY2hlTWFwLmJlZ2luKCk7IGl0ZXIgIT0gd3JhcHBlckNhY2hlTWFwLmVuZCgpOyAr K2l0ZXIpIHsKKyAgICAgICAgICAgIGlmIChKU05vZGUqIHdyYXBwZXIgPSBpdGVyLT5zZWNvbmQt PmdldChub2RlKSkKKyAgICAgICAgICAgICAgICBtYXJrU3RhY2suYXBwZW5kKHdyYXBwZXIpOwor ICAgICAgICB9CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBmb3IgKEpTR2xvYmFsRGF0 YVdvcmxkSXRlcmF0b3Igd29ybGRJdGVyKEpTRE9NV2luZG93Ojpjb21tb25KU0dsb2JhbERhdGEo KSk7IHdvcmxkSXRlcjsgKyt3b3JsZEl0ZXIpIHsKKyAgICAgICAgaWYgKERPTU9iamVjdCogd3Jh cHBlciA9IHdvcmxkSXRlci0+bV93cmFwcGVycy5nZXQobm9kZSkpCisgICAgICAgICAgICBtYXJr U3RhY2suYXBwZW5kKHdyYXBwZXIpOworICAgIH0KK30KKwogSlNWYWx1ZSBqc1N0cmluZ09yTnVs bChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IFN0cmluZyYgcykKIHsKICAgICBpZiAocy5pc051bGwo KSkKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaAkocmV2aXNpb24gNTA3OTIpCisr KyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0y MzgsNiArMjM4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHZvaWQgbWFya0RPTU5vZGVz Rm9yRG9jdW1lbnQoSlNDOjpNYXJrU3RhY2smLCBEb2N1bWVudCopOwogICAgIHZvaWQgbWFya0Fj dGl2ZU9iamVjdHNGb3JDb250ZXh0KEpTQzo6TWFya1N0YWNrJiwgSlNDOjpKU0dsb2JhbERhdGEm LCBTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CiAgICAgdm9pZCBtYXJrRE9NT2JqZWN0V3JhcHBl cihKU0M6Ok1hcmtTdGFjayYsIEpTQzo6SlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCB2b2lkKiBv YmplY3QpOworICAgIHZvaWQgbWFya0RPTU5vZGVXcmFwcGVyKEpTQzo6TWFya1N0YWNrJiBtYXJr U3RhY2ssIERvY3VtZW50KiBkb2N1bWVudCwgTm9kZSogbm9kZSk7CiAKICAgICBKU0M6OlN0cnVj dHVyZSogZ2V0Q2FjaGVkRE9NU3RydWN0dXJlKEpTRE9NR2xvYmFsT2JqZWN0KiwgY29uc3QgSlND OjpDbGFzc0luZm8qKTsKICAgICBKU0M6OlN0cnVjdHVyZSogY2FjaGVET01TdHJ1Y3R1cmUoSlNE T01HbG9iYWxPYmplY3QqLCBOb25OdWxsUGFzc1JlZlB0cjxKU0M6OlN0cnVjdHVyZT4sIGNvbnN0 IEpTQzo6Q2xhc3NJbmZvKik7CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmFtZWROb2Rl TWFwQ3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmFtZWRO b2RlTWFwQ3VzdG9tLmNwcAkocmV2aXNpb24gNTA3OTIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pz L0pTTmFtZWROb2RlTWFwQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIsMTAgKzUyLDgg QEAgdm9pZCBKU05hbWVkTm9kZU1hcDo6bWFya0NoaWxkcmVuKE1hcmtTdAogCiAgICAgLy8gTWFy ayB0aGUgZWxlbWVudCBzbyB0aGF0IHRoaXMgd2lsbCB3b3JrIHRvIGFjY2VzcyB0aGUgYXR0cmli dXRlIGV2ZW4gaWYgdGhlIGxhc3QKICAgICAvLyBvdGhlciByZWZlcmVuY2UgZ29lcyBhd2F5Lgot ICAgIGlmIChFbGVtZW50KiBlbGVtZW50ID0gaW1wbCgpLT5lbGVtZW50KCkpIHsKLSAgICAgICAg aWYgKEpTTm9kZSogd3JhcHBlciA9IGdldENhY2hlZERPTU5vZGVXcmFwcGVyKGVsZW1lbnQtPmRv Y3VtZW50KCksIGVsZW1lbnQpKQotICAgICAgICAgICAgbWFya1N0YWNrLmFwcGVuZCh3cmFwcGVy KTsKLSAgICB9CisgICAgaWYgKEVsZW1lbnQqIGVsZW1lbnQgPSBpbXBsKCktPmVsZW1lbnQoKSkK KyAgICAgICAgbWFya0RPTU5vZGVXcmFwcGVyKG1hcmtTdGFjaywgZWxlbWVudC0+ZG9jdW1lbnQo KSwgZWxlbWVudCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUv YmluZGluZ3MvanMvSlNOb2RlQ3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRp bmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAJKHJldmlzaW9uIDUwNzkyKQorKysgV2ViQ29yZS9iaW5k aW5ncy9qcy9KU05vZGVDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjEsMTEgKzE2MSw4 IEBAIHZvaWQgSlNOb2RlOjptYXJrQ2hpbGRyZW4oTWFya1N0YWNrJiBtYXIKIAogICAgIC8vIE1h cmsgdGhlIHdob2xlIHRyZWUgc3VidHJlZS4KICAgICByb290LT5zZXRJblN1YnRyZWVNYXJrKHRy dWUpOwotICAgIGZvciAoTm9kZSogbm9kZVRvTWFyayA9IHJvb3Q7IG5vZGVUb01hcms7IG5vZGVU b01hcmsgPSBub2RlVG9NYXJrLT50cmF2ZXJzZU5leHROb2RlKCkpIHsKLSAgICAgICAgSlNOb2Rl KiB3cmFwcGVyID0gZ2V0Q2FjaGVkRE9NTm9kZVdyYXBwZXIobV9pbXBsLT5kb2N1bWVudCgpLCBu b2RlVG9NYXJrKTsKLSAgICAgICAgaWYgKHdyYXBwZXIpCi0gICAgICAgICAgICBtYXJrU3RhY2su YXBwZW5kKHdyYXBwZXIpOwotICAgIH0KKyAgICBmb3IgKE5vZGUqIG5vZGVUb01hcmsgPSByb290 OyBub2RlVG9NYXJrOyBub2RlVG9NYXJrID0gbm9kZVRvTWFyay0+dHJhdmVyc2VOZXh0Tm9kZSgp KQorICAgICAgICBtYXJrRE9NTm9kZVdyYXBwZXIobWFya1N0YWNrLCBtX2ltcGwtPmRvY3VtZW50 KCksIG5vZGVUb01hcmspOwogICAgIHJvb3QtPnNldEluU3VidHJlZU1hcmsoZmFsc2UpOwogfQog CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZHRWxlbWVudEluc3RhbmNlQ3VzdG9tLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZHRWxlbWVudEluc3RhbmNl Q3VzdG9tLmNwcAkocmV2aXNpb24gNTA3OTIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZH RWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMsOSArNDMsNyBA QCB2b2lkIEpTU1ZHRWxlbWVudEluc3RhbmNlOjptYXJrQ2hpbGRyZW4oCiAgICAgQmFzZTo6bWFy a0NoaWxkcmVuKG1hcmtTdGFjayk7CiAKICAgICAvLyBNYXJrIHRoZSB3cmFwcGVyIGZvciBvdXIg Y29ycmVzcG9uZGluZyBlbGVtZW50LCBzbyBpdCBjYW4gbWFyayBpdHMgZXZlbnQgaGFuZGxlcnMu Ci0gICAgSlNOb2RlKiBjb3JyZXNwb25kaW5nV3JhcHBlciA9IGdldENhY2hlZERPTU5vZGVXcmFw cGVyKGltcGwoKS0+Y29ycmVzcG9uZGluZ0VsZW1lbnQoKS0+ZG9jdW1lbnQoKSwgaW1wbCgpLT5j b3JyZXNwb25kaW5nRWxlbWVudCgpKTsKLSAgICBpZiAoY29ycmVzcG9uZGluZ1dyYXBwZXIpCi0g ICAgICAgIG1hcmtTdGFjay5hcHBlbmQoY29ycmVzcG9uZGluZ1dyYXBwZXIpOworICAgIG1hcmtE T01Ob2RlV3JhcHBlcihtYXJrU3RhY2ssIGltcGwoKS0+Y29ycmVzcG9uZGluZ0VsZW1lbnQoKS0+ ZG9jdW1lbnQoKSwgaW1wbCgpLT5jb3JyZXNwb25kaW5nRWxlbWVudCgpKTsKIH0KIAogSlNWYWx1 ZSBKU1NWR0VsZW1lbnRJbnN0YW5jZTo6YWRkRXZlbnRMaXN0ZW5lcihFeGVjU3RhdGUqIGV4ZWMs IGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTU3R5bGVT aGVldEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1N0eWxl U2hlZXRDdXN0b20uY3BwCShyZXZpc2lvbiA1MDc5MikKKysrIFdlYkNvcmUvYmluZGluZ3MvanMv SlNTdHlsZVNoZWV0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjgsMTAgKzY4LDggQEAg dm9pZCBKU1N0eWxlU2hlZXQ6Om1hcmtDaGlsZHJlbihNYXJrU3RhYwogICAgIC8vIGlzIGtlcHQg YXJvdW5kLCB0aGVuIHdlIHdhbnQgdGhlIG5vZGUgdG8gc3RheSBhcm91bmQgdG9vLiBPbmUgcG9z c2liaWxpdHkgd291bGQKICAgICAvLyBiZSB0byBtYWtlIHJlZi9kZXJlZiBvbiB0aGUgc3R5bGUg c2hlZXQgcmVmL2RlcmVmIHRoZSBub2RlIGluc3RlYWQsIGJ1dCB0aGVyZSdzCiAgICAgLy8gYSBs b3Qgb2YgZGlzZW50YW5nbGluZyBvZiB0aGUgQ1NTIERPTSBvYmplY3RzIHRoYXQgd291bGQgbmVl ZCB0byBoYXBwZW4gZmlyc3QuCi0gICAgaWYgKE5vZGUqIG93bmVyTm9kZSA9IHNoZWV0LT5vd25l ck5vZGUoKSkgewotICAgICAgICBpZiAoSlNOb2RlKiBvd25lck5vZGVXcmFwcGVyID0gZ2V0Q2Fj aGVkRE9NTm9kZVdyYXBwZXIob3duZXJOb2RlLT5kb2N1bWVudCgpLCBvd25lck5vZGUpKQotICAg ICAgICAgICAgbWFya1N0YWNrLmFwcGVuZChvd25lck5vZGVXcmFwcGVyKTsKLSAgICB9CisgICAg aWYgKE5vZGUqIG93bmVyTm9kZSA9IHNoZWV0LT5vd25lck5vZGUoKSkKKyAgICAgICAgbWFya0RP TU5vZGVXcmFwcGVyKG1hcmtTdGFjaywgb3duZXJOb2RlLT5kb2N1bWVudCgpLCBvd25lck5vZGUp OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==