31377 2009-11-11 14:41:31 -0800 [V8] De-inline boilerplate in every event-listener setter method 2009-11-11 14:54:53 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Enhancement --- 1 jens jens oldest_to_newest 162686 0 jens 2009-11-11 14:41:31 -0800 Every generated V8 event-listener setter method contains a bunch of boilerplate code to transfer a "hidden dependency" from the old to the new listener. I've abstracted this out into a helper function in V8Utilities. 162691 1 43008 jens 2009-11-11 14:47:02 -0800 Created attachment 43008 patch 162692 2 43008 dglazkov 2009-11-11 14:48:17 -0800 Comment on attachment 43008 patch grand! 162697 3 jens 2009-11-11 14:54:53 -0800 Committed revision 50844. 43008 2009-11-11 14:47:02 -0800 2009-11-11 14:48:17 -0800 patch transferDependency.patch text/plain 5405 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDg0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTEgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3Jl IFY4IGRlLWlubGluaW5nIChvdXRsaW5pbmc/KSBBYnN0cmFjdGVkIGEgY2h1bmsgb2YgYm9pbGVy cGxhdGUgY29kZSBmcm9tIGV2ZXJ5CisgICAgICAgIGV2ZW50LWxpc3RlbmVyIHNldHRlciBpbnRv IGEgbmV3IHN1YnJvdXRpbmUgdHJhbnNmZXJIaWRkZW5EZXBlbmRlbmN5KCkuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTM3NworCisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06ICBSZXBsYWNlIGJvaWxlcnBsYXRl IHdpdGggY2FsbCB0byB0cmFuc2ZlckhpZGRlbkRlcGVuZGVuY3koKS4KKyAgICAgICAgKiBiaW5k aW5ncy92OC9WOFV0aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0cmFuc2ZlckhpZGRl bkRlcGVuZGVuY3kpOiAgTmV3LgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmg6 ICBEZWNsYXJhdGlvbiBvZiB0cmFuc2ZlckhpZGRlbkRlcGVuZGVuY3kuCisKIDIwMDktMTEtMTEg IFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtCShyZXZpc2lvbiA1MDg0MikKKysrIFdlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHdvcmtpbmcgY29weSkKQEAgLTcyNCw3ICs3MjQs NiBAQCBFTkQKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgaWYgKCFp bXAtPmRvY3VtZW50KCkpXG4iKTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMs ICIgICAgICByZXR1cm47XG4iKTsKICAgICAgICAgfQotICAgICAgICBwdXNoKEBpbXBsQ29udGVu dERlY2xzLCAiICAgICRuYXRpdmVUeXBlIHYgPSBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlzdGVu ZXIoaW1wLCB2YWx1ZSwgdHJ1ZSwgTGlzdGVuZXJGaW5kT3JDcmVhdGUpO1xuIik7CiAgICAgfSBl bHNlIHsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICAkbmF0aXZlVHlwZSB2 ID0gIiAuIEpTVmFsdWVUb05hdGl2ZSgkYXR0cmlidXRlLT5zaWduYXR1cmUsICJ2YWx1ZSIpIC4g IjtcbiIpOwogICAgIH0KQEAgLTc2NCwxOCArNzYzLDEwIEBAIEVORAogICAgICAgICAgICAgJGlt cGxJbmNsdWRlc3siVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuaCJ9ID0gMTsKICAgICAgICAgICAg ICRpbXBsSW5jbHVkZXN7IlY4Q3VzdG9tQmluZGluZy5oIn0gPSAxOwogICAgICAgICAgICAgJGNh Y2hlSW5kZXggPSBHZXRIaWRkZW5EZXBlbmRlbmN5SW5kZXgoJGRhdGFOb2RlLCAkYXR0ck5hbWUp OwotICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICAkbmF0aXZlVHlwZSBv bGQgPSBpbXAtPiRhdHRyTmFtZSgpO1xuIik7Ci0gICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVu dERlY2xzLCAiICAgIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyKiBvbGRMaXN0ZW5lciA9IG9sZCA/ IFY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjpjYXN0KG9sZC5nZXQoKSkgOiAwO1xuIik7Ci0gICAg ICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIGlmIChvbGRMaXN0ZW5lcikge1xu Iik7Ci0gICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgICAgdjg6OkxvY2Fs PHY4OjpPYmplY3Q+IG9sZExpc3RlbmVyT2JqZWN0ID0gb2xkTGlzdGVuZXItPmdldEV4aXN0aW5n TGlzdGVuZXJPYmplY3QoKTtcbiIpOwotICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNs cywgIiAgICAgIGlmICghb2xkTGlzdGVuZXJPYmplY3QuSXNFbXB0eSgpKVxuIik7Ci0gICAgICAg ICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgICAgICByZW1vdmVIaWRkZW5EZXBlbmRl bmN5KGhvbGRlciwgb2xkTGlzdGVuZXJPYmplY3QsICRjYWNoZUluZGV4KTtcbiIpOwotICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICB9XG4iKTsKLSAgICAgICAgICAgIHB1 c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgaW1wLT5zZXQkaW1wbFNldHRlckZ1bmN0aW9uTmFt ZSgkcmVzdWx0KTtcbiIpOwotICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAg ICBpZiAoJHJlc3VsdClcbiIpOwotICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiAgICAgIGNyZWF0ZUhpZGRlbkRlcGVuZGVuY3koaG9sZGVyLCB2YWx1ZSwgJGNhY2hlSW5kZXgi KTsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgdHJhbnNmZXJIaWRk ZW5EZXBlbmRlbmN5KGhvbGRlciwgaW1wLT4kYXR0ck5hbWUoKSwgdmFsdWUsICRjYWNoZUluZGV4 KTtcbiIpOworICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICBpbXAtPnNl dCRpbXBsU2V0dGVyRnVuY3Rpb25OYW1lKFY4RE9NV3JhcHBlcjo6Z2V0RXZlbnRMaXN0ZW5lcihp bXAsIHZhbHVlLCB0cnVlLCBMaXN0ZW5lckZpbmRPckNyZWF0ZSkiKTsKICAgICAgICAgfSBlbHNl IHsKLSAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgaW1wLT5zZXQkaW1w bFNldHRlckZ1bmN0aW9uTmFtZSgiIC4gJHJlc3VsdCk7CisgICAgICAgICAgICBwdXNoKEBpbXBs Q29udGVudERlY2xzLCAiICAgIGltcC0+c2V0JGltcGxTZXR0ZXJGdW5jdGlvbk5hbWUoJHJlc3Vs dCIpOwogICAgICAgICB9CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIsIGVjIikg aWYgJHVzZUV4Y2VwdGlvbnM7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIpO1xu Iik7CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAkocmV2aXNpb24gNTA3NTYp CisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzYsNiArNzYsMjQgQEAgdm9pZCByZW1vdmVIaWRkZW5EZXBlbmRlbmN5KHY4OjpIYW5kbGU8 dgogICAgICAgICB9CiAgICAgfQogfQorICAgIAordm9pZCB0cmFuc2ZlckhpZGRlbkRlcGVuZGVu Y3kodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmplY3QsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBFdmVudExpc3RlbmVyKiBvbGRWYWx1ZSwgCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiBuZXdWYWx1ZSwgCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpbnQgY2FjaGVJbmRleCkKK3sKKyAgICBpZiAob2xkVmFsdWUpIHsKKyAg ICAgICAgVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIqIG9sZExpc3RlbmVyID0gVjhBYnN0cmFjdEV2 ZW50TGlzdGVuZXI6OmNhc3Qob2xkVmFsdWUpOworICAgICAgICBpZiAob2xkTGlzdGVuZXIpIHsK KyAgICAgICAgICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBvbGRMaXN0ZW5lck9iamVjdCA9IG9s ZExpc3RlbmVyLT5nZXRFeGlzdGluZ0xpc3RlbmVyT2JqZWN0KCk7CisgICAgICAgICAgICBpZiAo IW9sZExpc3RlbmVyT2JqZWN0LklzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICByZW1vdmVIaWRk ZW5EZXBlbmRlbmN5KG9iamVjdCwgb2xkTGlzdGVuZXJPYmplY3QsIGNhY2hlSW5kZXgpOworICAg ICAgICB9CisgICAgfQorICAgIGlmICghbmV3VmFsdWUtPklzTnVsbCgpICYmICFuZXdWYWx1ZS0+ SXNVbmRlZmluZWQoKSkKKyAgICAgICAgY3JlYXRlSGlkZGVuRGVwZW5kZW5jeShvYmplY3QsIG5l d1ZhbHVlLCBjYWNoZUluZGV4KTsKK30KKyAgICAKIAogYm9vbCBwcm9jZXNzaW5nVXNlckdlc3R1 cmUoKQogewpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuaAkocmV2aXNpb24gNTA3NTYp CisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmgJKHdvcmtpbmcgY29weSkKQEAg LTM1LDYgKzM1LDcgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCisgICAgY2xhc3MgRXZlbnRM aXN0ZW5lcjsKICAgICBjbGFzcyBGcmFtZTsKICAgICBjbGFzcyBLVVJMOwogICAgIGNsYXNzIFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQ7CkBAIC00NCw3ICs0NSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgLy8gVXNlIGFuIGFycmF5IHRvIGhvbGQgZGVwZW5kZW50cy4gSXQgd29ya3MgbGlr ZSBhIHJlZi1jb3VudGVkIHNjaGVtZS4gQSB2YWx1ZSBjYW4gYmUgYWRkZWQgbW9yZSB0aGFuIG9u Y2UgdG8gdGhlIERPTSBvYmplY3QuCiAgICAgdm9pZCBjcmVhdGVIaWRkZW5EZXBlbmRlbmN5KHY4 OjpIYW5kbGU8djg6Ok9iamVjdD4sIHY4OjpMb2NhbDx2ODo6VmFsdWU+LCBpbnQgY2FjaGVJbmRl eCk7CiAgICAgdm9pZCByZW1vdmVIaWRkZW5EZXBlbmRlbmN5KHY4OjpIYW5kbGU8djg6Ok9iamVj dD4sIHY4OjpMb2NhbDx2ODo6VmFsdWU+LCBpbnQgY2FjaGVJbmRleCk7Ci0KKyAgICAKKyAgICAv LyBDb21ibyBjcmVhdGUvcmVtb3ZlLCBmb3IgZ2VuZXJhdGVkIGV2ZW50LWhhbmRsZXItc2V0dGVy IGJpbmRpbmdzOgorICAgIHZvaWQgdHJhbnNmZXJIaWRkZW5EZXBlbmRlbmN5KHY4OjpIYW5kbGU8 djg6Ok9iamVjdD4sIEV2ZW50TGlzdGVuZXIqIG9sZFZhbHVlLCB2ODo6TG9jYWw8djg6OlZhbHVl PiBuZXdWYWx1ZSwgaW50IGNhY2hlSW5kZXgpOworICAgIAogICAgIGJvb2wgcHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlKCk7CiAgICAgYm9vbCBzaG91bGRBbGxvd05hdmlnYXRpb24oRnJhbWUqKTsKICAg ICBLVVJMIGNvbXBsZXRlVVJMKGNvbnN0IFN0cmluZyYgcmVsYXRpdmVVUkwpOwo=