313737 2026-04-30 05:56:59 -0700 Digital Credentials: align CredentialRequestCoordinator method names with spec algorithm names 2026-05-03 23:30:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 marcosc marcosc webkit-bug-importer oldest_to_newest 2206217 0 marcosc 2026-04-30 05:56:59 -0700 The CredentialRequestCoordinator's method names and state machine terminology don't match the spec's algorithm names, making it harder to trace spec compliance. Current → Spec: - PickerState enum → InteractionState (spec: "interaction states") - PickerState::Presenting → InteractionState::Requesting (spec: "requesting") - prepareCredentialRequest() → prepareCredentialRequests() (spec: "prepare credential requests") - abortPicker() → abortTheCredentialRequest() (spec: "abort the credential request") - dismissPickerAndSettle() → rejectTheCredentialRequestWith() (spec: "reject the credential request with") - handleDigitalCredentialsPickerResult() → initiateTheCredentialRequest() (spec: "initiate the credential request") - showDigitalCredentialsPicker() → showDigitalCredentialsChooser() (spec: "digital credential chooser") - dismissDigitalCredentialsPicker() → dismissDigitalCredentialsChooser() (spec: "digital credential chooser") This is a pure mechanical rename with no behavioral changes. Aligning names makes it trivial to cross-reference between spec and implementation and reduces review burden for future spec changes. Files affected: CredentialRequestCoordinator.h/.cpp, CredentialRequestCoordinatorClient.h, DigitalCredential.cpp, DummyCredentialRequestCoordinatorClient.h/.cpp, DigitalCredentialsCoordinator.h/.cpp/.messages.in, WKDigitalCredentialsPicker.h/.mm, WebPageProxy.h/.cpp, PageClient.h, PageClientImplIOS.h/.mm, PageClientImplMac.h/.mm Depends on: Meta bug 268516 2207004 1 webkit-bug-importer 2026-05-03 07:29:30 -0700 <rdar://problem/176128667> 2207098 2 marcosc 2026-05-03 23:30:08 -0700 Pull request: https://github.com/WebKit/WebKit/pull/64148