31371 2009-11-11 13:05:03 -0800 SharedWorkerRepository.connect() does not call WebSharedWorkerRepository 2009-11-11 13:23:12 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue oldest_to_newest 162636 0 atwilson 2009-11-11 13:05:03 -0800 In a recent refactoring, we changed how the chromium version of SharedWorkerRepository.connect() works, but left out a call to WebKitSharedWorkerRepository.addSharedWorker(). This causes SharedWorkers to not get shutdown properly when the document exits. 162641 1 42994 atwilson 2009-11-11 13:10:06 -0800 Created attachment 42994 proposed patch This is the upstreamed version of the change to SharedWorkerRepository from http://codereview.chromium.org/390017. 162650 2 42994 commit-queue 2009-11-11 13:23:09 -0800 Comment on attachment 42994 proposed patch Clearing flags on attachment: 42994 Committed r50838: <http://trac.webkit.org/changeset/50838> 162651 3 commit-queue 2009-11-11 13:23:12 -0800 All reviewed patches have been landed. Closing bug. 42994 2009-11-11 13:10:06 -0800 2009-11-11 13:23:09 -0800 proposed patch x text/plain 1512 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDViNGYxMzEuLjQxNmRkM2MgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDA5LTExLTExICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaGFyZWRX b3JrZXJSZXBvc2l0b3J5LmNvbm5lY3QoKSBkb2VzIG5vdCBjYWxsIFdlYlNoYXJlZFdvcmtlclJl cG9zaXRvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMxMzcxCisKKyAgICAgICAgVGVzdDogVW5pdCB0ZXN0cyBjYW4gYmUgZW5hYmxlZCBkb3duc3Ry ZWFtIHdoZW4gdGhpcyBsYW5kcy4KKworICAgICAgICAqIHNyYy9TaGFyZWRXb3JrZXJSZXBvc2l0 b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZFdvcmtlclJlcG9zaXRvcnk6OmNvbm5l Y3QpOgorICAgICAgICBBZGRlZCBtaXNzaW5nIGNhbGwgdG8gV2ViU2hhcmVkV29ya2VyUmVwb3Np dG9yeS5hZGRTaGFyZWRXb3JrZXIoKS4KKwogMjAwOS0xMS0xMSAgTmF0ZSBDaGFwaW4gIDxqYXBo ZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5j cHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1NoYXJlZFdvcmtlclJlcG9zaXRvcnkuY3BwCmluZGV4 IGY2N2E3ZGQuLjVlNWJjNDYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVk V29ya2VyUmVwb3NpdG9yeS5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9TaGFyZWRXb3Jr ZXJSZXBvc2l0b3J5LmNwcApAQCAtMTcxLDYgKzE3MSw5IEBAIHZvaWQgU2hhcmVkV29ya2VyUmVw b3NpdG9yeTo6Y29ubmVjdChQYXNzUmVmUHRyPFNoYXJlZFdvcmtlcj4gd29ya2VyLCBQYXNzT3du UHRyCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBXZWJLaXQ6OndlYktpdENsaWVudCgp LT5zaGFyZWRXb3JrZXJSZXBvc2l0b3J5KCktPmFkZFNoYXJlZFdvcmtlcigKKyAgICAgICAgd2Vi V29ya2VyLmdldCgpLCBnZXRJZChkb2N1bWVudCkpOworCiAgICAgLy8gVGhlIGxvYWRlciBvYmpl Y3QgbWFuYWdlcyBpdHMgb3duIGxpZmVjeWNsZSAoYW5kIHRoZSBsaWZlY3ljbGVzIG9mIHRoZSB0 d28gd29ya2VyIG9iamVjdHMpLgogICAgIC8vIEl0IHdpbGwgZnJlZSBpdHNlbGYgb25jZSBsb2Fk aW5nIGlzIGNvbXBsZXRlZC4KICAgICBTaGFyZWRXb3JrZXJTY3JpcHRMb2FkZXIqIGxvYWRlciA9 IG5ldyBTaGFyZWRXb3JrZXJTY3JpcHRMb2FkZXIod29ya2VyLCB1cmwsIG5hbWUsIHBvcnQucmVs ZWFzZSgpLCB3ZWJXb3JrZXIucmVsZWFzZSgpKTsK