31368 2009-11-11 12:27:36 -0800 [V8] De-inline large method convertNodeToV8Object 2009-11-12 16:25:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Enhancement --- 31217 1 jens jens oldest_to_newest 162614 0 jens 2009-11-11 12:27:36 -0800 The method V8DOMWrapper::convertNodeToV8Object is declared as inline, and there are 136 calls to it in the generated V8 bindings. It's a fairly complex piece of code that expands to a lot of machine instructions. De-inlining it helps shrink the bindings. 162627 1 42991 yaar 2009-11-11 12:50:30 -0800 Created attachment 42991 path fix 162628 2 42991 yaar 2009-11-11 12:52:11 -0800 Comment on attachment 42991 path fix Please ignore. 162633 3 42993 jens 2009-11-11 13:02:55 -0800 Created attachment 42993 patch 162635 4 42993 dglazkov 2009-11-11 13:04:24 -0800 Comment on attachment 42993 patch awesome. 162642 5 jens 2009-11-11 13:10:10 -0800 Committed revision 50835. 42991 2009-11-11 12:50:30 -0800 2009-11-11 12:52:10 -0800 path fix bug-31368-20091111125029.patch text/plain 1524 yaar ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDViNGYxMzEuLmJhYzY5OTggMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDA5LTExLTExICBZYWFyIFNjaG5pdG1hbiAgPHlhYXJAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRpbnkgcGF0 aCBmaXhlcyBpbiBDaHJvbWl1bSBBUEkgaW5jbHVkZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMzY5CisKKyAgICAgICAgKiBwdWJsaWMvbGlu dXgvV2ViU2FuZGJveFN1cHBvcnQuaDogRml4ZWQgcGF0aC4KKyAgICAgICAgKiBzcmMvV2ViQmlu ZGluZ3MuY3BwOiBGaXhlZCBwYXRoLgorCiAyMDA5LTExLTExICBOYXRlIENoYXBpbiAgPGphcGhl dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292Lgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9saW51eC9XZWJTYW5kYm94U3VwcG9y dC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9saW51eC9XZWJTYW5kYm94U3VwcG9ydC5oCmlu ZGV4IDE2MTI2MjYuLjVlZGNlYjIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv bGludXgvV2ViU2FuZGJveFN1cHBvcnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL2xp bnV4L1dlYlNhbmRib3hTdXBwb3J0LmgKQEAgLTMxLDggKzMxLDggQEAKICNpZm5kZWYgV2ViU2Fu ZGJveFN1cHBvcnRfaAogI2RlZmluZSBXZWJTYW5kYm94U3VwcG9ydF9oCiAKLSNpbmNsdWRlICJ3 ZWJraXQvYXBpL3B1YmxpYy9XZWJDb21tb24uaCIKLSNpbmNsdWRlICJ3ZWJraXQvYXBpL3B1Ymxp Yy9XZWJTdHJpbmcuaCIKKyNpbmNsdWRlICIuLi9XZWJDb21tb24uaCIKKyNpbmNsdWRlICIuLi9X ZWJTdHJpbmcuaCIKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViQmluZGluZ3MuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJCaW5k aW5ncy5jcHAKaW5kZXggNzM5OTNiNi4uNWI5ZjU3YyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJCaW5kaW5ncy5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJCaW5k aW5ncy5jcHAKQEAgLTMzLDggKzMzLDkgQEAKIAogI2luY2x1ZGUgIm5wcnVudGltZV9pbXBsLmgi CiAjaW5jbHVkZSAibnBydW50aW1lX3ByaXYuaCIKLSNpbmNsdWRlICJ3ZWJraXQvYXBpL3B1Ymxp Yy9XZWJEcmFnRGF0YS5oIgotI2luY2x1ZGUgIndlYmtpdC9hcGkvcHVibGljL1dlYlJhbmdlLmgi CisKKyNpbmNsdWRlICJXZWJEcmFnRGF0YS5oIgorI2luY2x1ZGUgIldlYlJhbmdlLmgiCiAKICNp ZiBVU0UoVjgpCiAjaW5jbHVkZSAiQ2hyb21pdW1EYXRhT2JqZWN0Lmgi 42993 2009-11-11 13:02:55 -0800 2009-11-11 13:04:24 -0800 patch convertNodeToV8Object.patch text/plain 2857 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDgzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMTYgQEAKIDIwMDktMTEtMTEgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZS1p bmxpbmUgY29udmVydE5vZGVUb1Y4T2JqZWN0KCksIHdoaWNoIGV4cGFuZHMgdG8gYSBsb3Qgb2Yg YXNtIGNvZGUgYW5kIGlzIGlubGluZWQgMTM2CisgICAgICAgIHRpbWVzIGluIHRoZSBnZW5lcmF0 ZWQgVjggYmluZGluZ3MuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpjb252ZXJ0Tm9kZVRvVjhPYmplY3Qp OiAgTW92ZWQgYm9keSBoZXJlIGZyb20gLmggZmlsZQorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 RE9NV3JhcHBlci5oOiAgUmVtb3ZlZCBpbmxpbmUgbWV0aG9kIGJvZHkuCisKKzIwMDktMTEtMTEg IEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBE aW1pdHJpIEdsYXprb3YuCiAKICAgICAgICAgTWFrZSBWOCBiaW5kaW5ncyByZXR1cm4gTlVMTCBo YW5kbGVzIGluc3RlYWQgb2YgY2FsbGluZyB2ODo6VW5kZWZpbmVkKCkuIFRoaXMgaGFzIGVxdWl2 YWxlbnQKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAJKHJldmlzaW9uIDUw NzU2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMzA1LDYgKzEzMDUsMjMgQEAKICAgICByZXR1cm4gd3JhcHBlcjsKIH0KIAordjg6 OkhhbmRsZTx2ODo6VmFsdWU+IFY4RE9NV3JhcHBlcjo6Y29udmVydE5vZGVUb1Y4T2JqZWN0KE5v ZGUqIG5vZGUpCit7CisgICAgaWYgKCFub2RlKQorICAgICAgICByZXR1cm4gdjg6Ok51bGwoKTsK KyAgICAKKyAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBub2RlLT5kb2N1bWVudCgpOworICAgIGlm IChub2RlID09IGRvY3VtZW50KQorICAgICAgICByZXR1cm4gY29udmVydERvY3VtZW50VG9WOE9i amVjdChkb2N1bWVudCk7CisgICAgCisgICAgRE9NV3JhcHBlck1hcDxOb2RlPiYgZG9tTm9kZU1h cCA9IGdldERPTU5vZGVNYXAoKTsKKyAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdyYXBwZXIg PSBkb21Ob2RlTWFwLmdldChub2RlKTsKKyAgICBpZiAod3JhcHBlci5Jc0VtcHR5KCkpCisgICAg ICAgIHJldHVybiBjb252ZXJ0TmV3Tm9kZVRvVjhPYmplY3Qobm9kZSwgMCwgZG9tTm9kZU1hcCk7 CisgICAgCisgICAgcmV0dXJuIHdyYXBwZXI7Cit9CisgICAgCiAvLyBDYWxsZXIgY2hlY2tzIG5v ZGUgaXMgbm90IG51bGwuCiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XcmFwcGVyOjpjb252 ZXJ0TmV3Tm9kZVRvVjhPYmplY3QoTm9kZSogbm9kZSwgVjhQcm94eSogcHJveHksIERPTVdyYXBw ZXJNYXA8Tm9kZT4mIGRvbU5vZGVNYXApCiB7CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 RE9NV3JhcHBlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFw cGVyLmgJKHJldmlzaW9uIDUwNzU2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBw ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTQ3LDIzICsxNDcsOCBAQAogICAgICAgICAgICAgcmV0 dXJuIGNvbnZlcnROb2RlVG9WOE9iamVjdChub2RlLmdldCgpKTsKICAgICAgICAgfQogCi0gICAg ICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29udmVydE5vZGVUb1Y4T2JqZWN0KE5v ZGUqIG5vZGUpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGlmICghbm9kZSkKLSAgICAgICAgICAg ICAgICByZXR1cm4gdjg6Ok51bGwoKTsKKyAgICAgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZh bHVlPiBjb252ZXJ0Tm9kZVRvVjhPYmplY3QoTm9kZSopOwogCi0gICAgICAgICAgICBEb2N1bWVu dCogZG9jdW1lbnQgPSBub2RlLT5kb2N1bWVudCgpOwotICAgICAgICAgICAgaWYgKG5vZGUgPT0g ZG9jdW1lbnQpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGNvbnZlcnREb2N1bWVudFRvVjhPYmpl Y3QoZG9jdW1lbnQpOwotCi0gICAgICAgICAgICBET01XcmFwcGVyTWFwPE5vZGU+JiBkb21Ob2Rl TWFwID0gZ2V0RE9NTm9kZU1hcCgpOwotICAgICAgICAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0 PiB3cmFwcGVyID0gZG9tTm9kZU1hcC5nZXQobm9kZSk7Ci0gICAgICAgICAgICBpZiAod3JhcHBl ci5Jc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGNvbnZlcnROZXdOb2RlVG9WOE9i amVjdChub2RlLCAwLCBkb21Ob2RlTWFwKTsKLQotICAgICAgICAgICAgcmV0dXJuIHdyYXBwZXI7 Ci0gICAgICAgIH0KLQogICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNvbnZl cnREb2N1bWVudFRvVjhPYmplY3QoRG9jdW1lbnQqKTsKIAogICAgICAgICBzdGF0aWMgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IGNvbnZlcnROZXdOb2RlVG9WOE9iamVjdChQYXNzUmVmUHRyPE5vZGU+ IG5vZGUpCg==