<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31357</bug_id>
          
          <creation_ts>2009-11-11 09:11:11 -0800</creation_ts>
          <short_desc>[Chromium] Add hasPort(), removePort() and protcolIsValid() to KURLGoogle implementation</short_desc>
          <delta_ts>2009-11-12 18:52:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nate Chapin">japhet</reporter>
          <assigned_to name="Nate Chapin">japhet</assigned_to>
          <cc>brettw</cc>
    
    <cc>dglazkov</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>162508</commentid>
    <comment_count>0</comment_count>
    <who name="Nate Chapin">japhet</who>
    <bug_when>2009-11-11 09:11:11 -0800</bug_when>
    <thetext>These methods were added in http://trac.webkit.org/changeset/50784, but are not defined in KURLGoogle.cpp.  Chromium port won&apos;t link after this revision without them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>162533</commentid>
    <comment_count>1</comment_count>
      <attachid>42974</attachid>
    <who name="Nate Chapin">japhet</who>
    <bug_when>2009-11-11 10:04:06 -0800</bug_when>
    <thetext>Created attachment 42974
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>162543</commentid>
    <comment_count>2</comment_count>
      <attachid>42974</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-11-11 10:25:06 -0800</bug_when>
    <thetext>Comment on attachment 42974
patch

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163165</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-11-12 18:52:46 -0800</bug_when>
    <thetext>landed as http://trac.webkit.org/changeset/50819.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>42974</attachid>
            <date>2009-11-11 10:04:06 -0800</date>
            <delta_ts>2009-11-12 18:52:29 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>2491</size>
            <attacher name="Nate Chapin">japhet</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MDgxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMTEgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt
Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB
ZGQgbWV0aG9kcyB0byBLVVJMR29vZ2xlLmNwcCBkZWNsYXJlZCBpbiBodHRwOi8vdHJhYy53ZWJr
aXQub3JnL2NoYW5nZXNldC81MDc4NCBidXQgbm90IGRlZmluZWQgd2hlbiB1c2luZyBLVVJMR29v
Z2xlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z
MTM1NworCisgICAgICAgICogcGxhdGZvcm0vS1VSTEdvb2dsZS5jcHA6CisgICAgICAgIChXZWJD
b3JlOjppc1NjaGVtZUZpcnN0Q2hhcik6CisgICAgICAgIChXZWJDb3JlOjppc1NjaGVtZUNoYXIp
OgorICAgICAgICAoV2ViQ29yZTo6S1VSTDo6aGFzUG9ydCk6CisgICAgICAgIChXZWJDb3JlOjpL
VVJMOjpyZW1vdmVQb3J0KToKKyAgICAgICAgKFdlYkNvcmU6OnByb3RvY29sSXNWYWxpZCk6CisK
IDIwMDktMTEtMTAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vS1VSTEdv
b2dsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9LVVJMR29vZ2xlLmNwcAko
cmV2aXNpb24gNTA4MTMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL0tVUkxHb29nbGUuY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDE3IEBACiAgICAgcmV0dXJuIGJlZ2luID09IGVuZCAm
JiAhKnN0cjsKIH0KIAorc3RhdGljIGlubGluZSBib29sIGlzU2NoZW1lRmlyc3RDaGFyKGNoYXIg
YykKK3sKKyAgICByZXR1cm4gKGMgPj0gJ2EnICYmIGMgPD0gJ3onKSB8fCAoYyA+PSAnQScgJiYg
YyA8PSAnWicpOworfQogCitzdGF0aWMgaW5saW5lIGJvb2wgaXNTY2hlbWVDaGFyKGNoYXIgYykK
K3sKKyAgICByZXR1cm4gaXNTY2hlbWVGaXJzdENoYXIoYykgfHwgKGMgPj0gJzAnICYmIGMgPD0g
JzknKSB8fCBjID09ICcuJyB8fCBjID09ICctJyB8fCBjID09ICcqJzsKK30KKworCiAvLyBLVVJM
R29vZ2xlUHJpdmF0ZSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLQogCiBLVVJMR29vZ2xlUHJpdmF0ZTo6S1VSTEdvb2dsZVByaXZhdGUo
KQpAQCAtNDI2LDYgKzQzNiwxMSBAQAogICAgIHJldHVybiBtX3VybC5tX2lzVmFsaWQ7CiB9CiAK
K2Jvb2wgS1VSTDo6aGFzUG9ydCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGhvc3RFbmQoKSA8IHBh
dGhTdGFydCgpOworfQorCiBib29sIEtVUkw6OnByb3RvY29sSW5IVFRQRmFtaWx5KCkgY29uc3QK
IHsKICAgICByZXR1cm4gbV91cmwubV9wcm90b2NvbEluSFRUUEZhbWlseTsKQEAgLTU4MCw2ICs1
OTUsMTQgQEAKICAgICBtX3VybC5yZXBsYWNlQ29tcG9uZW50cyhyZXBsYWNlbWVudHMpOwogfQog
Cit2b2lkIEtVUkw6OnJlbW92ZVBvcnQoKQoreworICAgIGlmIChoYXNQb3J0KCkpIHsKKyAgICAg
ICAgU3RyaW5nIHVybFdpdGhvdXRQb3J0ID0gbV91cmwuc3RyaW5nKCkubGVmdChob3N0RW5kKCkp
ICsgbV91cmwuc3RyaW5nKCkuc3Vic3RyaW5nKHBhdGhTdGFydCgpKTsKKyAgICAgICAgbV91cmwu
c2V0VXRmOCh1cmxXaXRob3V0UG9ydC51dGY4KCkpOworICAgIH0KK30KKwogdm9pZCBLVVJMOjpz
ZXRQb3J0KHVuc2lnbmVkIHNob3J0IGkpCiB7CiAgICAgS1VSTEdvb2dsZVByaXZhdGU6OlJlcGxh
Y2VtZW50cyByZXBsYWNlbWVudHM7CkBAIC02OTgsNiArNzIxLDE4IEBACiAgICAgcmV0dXJuIHBy
b3RvY29sSXModXJsLCAiamF2YXNjcmlwdCIpOwogfQogCitib29sIHByb3RvY29sSXNWYWxpZChj
b25zdCBTdHJpbmcmIHByb3RvY29sKQoreworICAgIGlmICghaXNTY2hlbWVGaXJzdENoYXIocHJv
dG9jb2xbMF0pKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgdW5zaWduZWQgcHJvdG9jb2xM
ZW5ndGggPSBwcm90b2NvbC5sZW5ndGgoKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAxOyBpIDwg
cHJvdG9jb2xMZW5ndGg7IGkrKykgeworICAgICAgICBpZiAoIWlzU2NoZW1lQ2hhcihwcm90b2Nv
bFtpXSkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorICAgIHJldHVybiB0cnVl
OworfQorCiAvLyBXZSBjb3BpZWQgdGhlIEtVUkwgdmVyc2lvbiBoZXJlIG9uIFNlcHQgMTIsIDIw
MDggd2hpbGUgZG9pbmcgYSBXZWJLaXQKIC8vIG1lcmdlLgogLy8gCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>