31354 2009-11-11 08:45:40 -0800 [Chromium] Remove WebViewImpl::dragSourceMovedTo() 2009-11-13 09:16:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet oldest_to_newest 162495 0 japhet 2009-11-11 08:45:40 -0800 http://trac.webkit.org/changeset/50786 removed EventHandler::dragSourceMovedTo(), which WebViewImpl in the Chormium API uses. Should just be a straight delete. 162496 1 42964 japhet 2009-11-11 08:47:45 -0800 Created attachment 42964 patch 162499 2 42964 dglazkov 2009-11-11 08:48:57 -0800 Comment on attachment 42964 patch r=me, but you should really mention the changeset that removed it in the ChangeLog. 162505 3 japhet 2009-11-11 09:07:05 -0800 http://trac.webkit.org/changeset/50808 162528 4 42973 japhet 2009-11-11 09:56:11 -0800 Created attachment 42973 patch2 Missed a couple of references... 162529 5 japhet 2009-11-11 09:56:38 -0800 Missed some references, new patch attached. 162532 6 42973 eric 2009-11-11 10:01:31 -0800 Comment on attachment 42973 patch2 LGTM. 163162 7 42964 abarth 2009-11-12 18:50:07 -0800 Comment on attachment 42964 patch This claims to have been landed. 163178 8 42973 commit-queue 2009-11-12 19:07:07 -0800 Comment on attachment 42973 patch2 Rejecting patch 42973 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/chromium/src/WebViewImpl.h Hunk #1 FAILED at 127. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebViewImpl.h.rej patching file WebKit/chromium/public/WebView.h Hunk #1 FAILED at 167. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebView.h.rej 163339 9 japhet 2009-11-13 09:16:22 -0800 Sorry about that. I forgot that I hadn't closed this bug :-( 42964 2009-11-11 08:47:45 -0800 2009-11-12 18:50:07 -0800 patch patch.txt text/plain 1411 japhet SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTA4MDcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMTEgIE5hdGUg Q2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgV2ViVmlld0ltcGw6OmRyYWdTb3VyY2VNb3Zl ZFRvKCksIGFzIGl0IGlzIG5vIGxvbmdlciBuZWVkZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMzU0CisKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuY3BwOgorCiAyMDA5LTExLTEwICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgQ2hyb21pdW0gYnVpbGQgZml4IGZvciBodHRwOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81MDc2MC4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCShyZXZpc2lvbiA1MDgwNykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzM3LDE3ICsxMzM3LDYgQEAKICAgICAg ICAgc3RhdGljX2Nhc3Q8RHJhZ09wZXJhdGlvbj4ob3BlcmF0aW9uKSk7CiB9CiAKLXZvaWQgV2Vi Vmlld0ltcGw6OmRyYWdTb3VyY2VNb3ZlZFRvKAotICAgIGNvbnN0IFdlYlBvaW50JiBjbGllbnRQ b2ludCwKLSAgICBjb25zdCBXZWJQb2ludCYgc2NyZWVuUG9pbnQpCi17Ci0gICAgUGxhdGZvcm1N b3VzZUV2ZW50IHBtZShjbGllbnRQb2ludCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIHNj cmVlblBvaW50LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgTGVmdEJ1dHRvbiwgTW91c2VF dmVudE1vdmVkLCAwLCBmYWxzZSwgZmFsc2UsIGZhbHNlLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgZmFsc2UsIDApOwotICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigp LT5kcmFnU291cmNlTW92ZWRUbyhwbWUpOwotfQotCiB2b2lkIFdlYlZpZXdJbXBsOjpkcmFnU291 cmNlU3lzdGVtRHJhZ0VuZGVkKCkKIHsKICAgICAvLyBJdCdzIHBvc3NpYmxlIGZvciB1cyB0byBn ZXQgdGhpcyBjYWxsYmFjayB3aGlsZSBub3QgZG9pbmcgYSBkcmFnIGlmCg== 42973 2009-11-11 09:56:11 -0800 2009-11-12 19:07:06 -0800 patch2 patch.txt text/plain 2033 japhet SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTA4MTMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMTEtMTEgIE5hdGUg Q2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgc29tZSBhZGRpdGlvbmFsIHJlZmVyZW5jZXMg dG8gZHJhZ1NvdXJjZU1vdmVkVG8oKSBub3QKKyAgICAgICAgbmVlZGVkIGFmdGVyIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzUwNzg2LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTM1NAorCisgICAgICAgICogcHVibGljL1dlYlZp ZXcuaDoKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKworMjAwOS0xMS0xMSAgTmF0ZSBD aGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0 cmkgR2xhemtvdi4KIAogICAgICAgICBSZW1vdmUgV2ViVmlld0ltcGw6OmRyYWdTb3VyY2VNb3Zl ZFRvKCksIGFzIGl0IGlzIG5vIGxvbmdlcgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu aAkocmV2aXNpb24gNTA4MDcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEyNyw5ICsxMjcsNiBAQAogICAgICAgICBjb25zdCBXZWJQb2lu dCYgY2xpZW50UG9pbnQsCiAgICAgICAgIGNvbnN0IFdlYlBvaW50JiBzY3JlZW5Qb2ludCwKICAg ICAgICAgV2ViRHJhZ09wZXJhdGlvbiBvcGVyYXRpb24pOwotICAgIHZpcnR1YWwgdm9pZCBkcmFn U291cmNlTW92ZWRUbygKLSAgICAgICAgY29uc3QgV2ViUG9pbnQmIGNsaWVudFBvaW50LAotICAg ICAgICBjb25zdCBXZWJQb2ludCYgc2NyZWVuUG9pbnQpOwogICAgIHZpcnR1YWwgdm9pZCBkcmFn U291cmNlU3lzdGVtRHJhZ0VuZGVkKCk7CiAgICAgdmlydHVhbCBXZWJEcmFnT3BlcmF0aW9uIGRy YWdUYXJnZXREcmFnRW50ZXIoCiAgICAgICAgIGNvbnN0IFdlYkRyYWdEYXRhJiBkcmFnRGF0YSwg aW50IGlkZW50aXR5LApJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgJKHJldmlzaW9uIDUw ODA3KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgJKHdvcmtpbmcgY29weSkK QEAgLTE2NywxMSArMTY3LDYgQEAKICAgICAgICAgY29uc3QgV2ViUG9pbnQmIGNsaWVudFBvaW50 LCBjb25zdCBXZWJQb2ludCYgc2NyZWVuUG9pbnQsCiAgICAgICAgIFdlYkRyYWdPcGVyYXRpb24g b3BlcmF0aW9uKSA9IDA7CiAKLSAgICAvLyBOb3RpZmllcyB0aGUgV2ViVmlldyB0aGF0IGEgZHJh ZyBhbmQgZHJvcCBvcGVyYXRpb24gaXMgaW4gcHJvZ3Jlc3MsIHdpdGgKLSAgICAvLyBkcm9wYWJs ZSBpdGVtcyBvdmVyIHRoZSB2aWV3LgotICAgIHZpcnR1YWwgdm9pZCBkcmFnU291cmNlTW92ZWRU bygKLSAgICAgICAgY29uc3QgV2ViUG9pbnQmIGNsaWVudFBvaW50LCBjb25zdCBXZWJQb2ludCYg c2NyZWVuUG9pbnQpID0gMDsKLQogICAgIC8vIE5vdGZpZXMgdGhlIFdlYlZpZXcgdGhhdCB0aGUg c3lzdGVtIGRyYWcgYW5kIGRyb3Agb3BlcmF0aW9uIGhhcyBlbmRlZC4KICAgICB2aXJ0dWFsIHZv aWQgZHJhZ1NvdXJjZVN5c3RlbURyYWdFbmRlZCgpID0gMDsKIAo=