31350 2009-11-11 05:37:59 -0800 Allow custom memory allocation control for the part of page directory in WebCore 2009-11-11 09:08:36 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned oldest_to_newest 162455 0 zoltan 2009-11-11 05:37:59 -0800 Inherits the following classes from Noncopyable because these are instantiated by 'new' and these are no need to be copyable: class DragController - instantiated at: WebCore/page/Page.cpp:107 class FocusController - instantiated at: WebCore/page/Page.cpp:109 class Settings - instantiated at: WebCore/page/Page.cpp:116 class PluginHalter - instantiated at: WebCore/page/Page.cpp:160 struct ScheduledEvent - instantiated at: WebCore/page/FrameView.cpp:1275 class UserScript - instantiated at: WebCore/page/PageGroup.cpp:208 struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182 class XSSAuditor - instantiated at: WebCore/bindings/js/ScriptController.cpp:70 class UserStyleSheet - instantiated at: WebCore/page/PageGroup.cpp:222 Inherits PropertyWrapperBase class from Noncopyable because (its child class) PropertyWrapper is instantiated by 'new' in WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable. 162456 1 42956 zoltan 2009-11-11 05:39:56 -0800 Created attachment 42956 proposed patch 162492 2 42956 eric 2009-11-11 08:39:41 -0800 Comment on attachment 42956 proposed patch Looks sane. 162507 3 zoltan 2009-11-11 09:08:36 -0800 Landed in 50810. http://trac.webkit.org/changeset/50810 42956 2009-11-11 05:39:56 -0800 2009-11-11 08:39:41 -0800 proposed patch page.patch text/plain 6924 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDgwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzggQEAKKzIwMDktMTEtMTEgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIHRoZSBwYXJ0IG9mIHBh Z2UgZGlyZWN0b3J5IGluIFdlYkNvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxMzUwCisKKyAgICAgICAgSW5oZXJpdHMgdGhlIGZvbGxvd2luZyBj bGFzc2VzIGZyb20gTm9uY29weWFibGUgYmVjYXVzZSB0aGVzZSBhcmUgaW5zdGFudGlhdGVkCisg ICAgICAgIGJ5ICduZXcnIGFuZCB0aGVzZSBhcmUgbm8gbmVlZCB0byBiZSBjb3B5YWJsZToKKwor ICAgICAgICBjbGFzcyBEcmFnQ29udHJvbGxlciAgICAgICAgIC0gaW5zdGFudGlhdGVkIGF0OiBX ZWJDb3JlL3BhZ2UvUGFnZS5jcHA6MTA3CisgICAgICAgIGNsYXNzIEZvY3VzQ29udHJvbGxlciAg ICAgICAgLSBpbnN0YW50aWF0ZWQgYXQ6IFdlYkNvcmUvcGFnZS9QYWdlLmNwcDoxMDkKKyAgICAg ICAgY2xhc3MgU2V0dGluZ3MgICAgICAgICAgICAgICAtIGluc3RhbnRpYXRlZCBhdDogV2ViQ29y ZS9wYWdlL1BhZ2UuY3BwOjExNgorICAgICAgICBjbGFzcyBQbHVnaW5IYWx0ZXIgICAgICAgICAg IC0gaW5zdGFudGlhdGVkIGF0OiBXZWJDb3JlL3BhZ2UvUGFnZS5jcHA6MTYwCisgICAgICAgIHN0 cnVjdCBTY2hlZHVsZWRFdmVudCAgICAgICAgLSBpbnN0YW50aWF0ZWQgYXQ6IFdlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwOjEyNzUKKyAgICAgICAgY2xhc3MgVXNlclNjcmlwdCAgICAgICAgICAg ICAtIGluc3RhbnRpYXRlZCBhdDogV2ViQ29yZS9wYWdlL1BhZ2VHcm91cC5jcHA6MjA4CisgICAg ICAgIHN0cnVjdCBFdmVudEhhbmRsZXJEcmFnU3RhdGUgLSBpbnN0YW50aWF0ZWQgYXQ6IFdlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwOjE4MgorICAgICAgICBjbGFzcyBYU1NBdWRpdG9yICAg ICAgICAgICAgIC0gaW5zdGFudGlhdGVkIGF0OiBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENv bnRyb2xsZXIuY3BwOjcwCisgICAgICAgIGNsYXNzIFVzZXJTdHlsZVNoZWV0ICAgICAgICAgLSBp bnN0YW50aWF0ZWQgYXQ6IFdlYkNvcmUvcGFnZS9QYWdlR3JvdXAuY3BwOjIyMgorCisgICAgICAg IEluaGVyaXRzIFByb3BlcnR5V3JhcHBlckJhc2UgY2xhc3MgZnJvbSBOb25jb3B5YWJsZSBiZWNh dXNlIChpdHMgY2hpbGQgY2xhc3MpIAorICAgICAgICBQcm9wZXJ0eVdyYXBwZXIgaXMgaW5zdGFu dGlhdGVkIGJ5ICduZXcnIGluIAorICAgICAgICBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1h dGlvbkJhc2UuY3BwOjU2NCBpdCBpcyBubyBuZWVkIHRvIGJlIGNvcHlhYmxlLgorCisgICAgICAg ICogcGFnZS9EcmFnQ29udHJvbGxlci5oOgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6 CisgICAgICAgICogcGFnZS9Gb2N1c0NvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBwYWdlL0ZyYW1l Vmlldy5jcHA6CisgICAgICAgICogcGFnZS9QbHVnaW5IYWx0ZXIuaDoKKyAgICAgICAgKiBwYWdl L1NldHRpbmdzLmg6CisgICAgICAgICogcGFnZS9Vc2VyU2NyaXB0Lmg6CisgICAgICAgICogcGFn ZS9Vc2VyU3R5bGVTaGVldC5oOgorICAgICAgICAqIHBhZ2UvWFNTQXVkaXRvci5oOgorICAgICAg ICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwOgorCiAyMDA5LTExLTExICBCZW5q YW1pbiBPdHRlICA8b3R0ZUBnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFuIEFs b256by4KSW5kZXg6IFdlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5oCShyZXZpc2lvbiA1MDc5MSkKKysrIFdlYkNv cmUvcGFnZS9EcmFnQ29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw3IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBSYW5nZTsKICAgICBjbGFzcyBTZWxlY3Rp b25Db250cm9sbGVyOwogICAgIAotICAgIGNsYXNzIERyYWdDb250cm9sbGVyIHsKKyAgICBjbGFz cyBEcmFnQ29udHJvbGxlciA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CiAgICAgcHVibGljOgogICAg ICAgICBEcmFnQ29udHJvbGxlcihQYWdlKiwgRHJhZ0NsaWVudCopOwogICAgICAgICB+RHJhZ0Nv bnRyb2xsZXIoKTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgJKHJldmlzaW9uIDUwNzkxKQorKysgV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xOTksNyArMTk5LDcg QEAgcHJpdmF0ZToKICAgICAgICAgUGVyZm9ybURyYWdBbmREcm9wCiAgICAgfTsKIAotICAgIHN0 cnVjdCBFdmVudEhhbmRsZXJEcmFnU3RhdGUgeworICAgIHN0cnVjdCBFdmVudEhhbmRsZXJEcmFn U3RhdGUgOiBOb25jb3B5YWJsZSB7CiAgICAgICAgIFJlZlB0cjxOb2RlPiBtX2RyYWdTcmM7IC8v IGVsZW1lbnQgdGhhdCBtYXkgYmUgYSBkcmFnIHNvdXJjZSwgZm9yIHRoZSBjdXJyZW50IG1vdXNl IGdlc3R1cmUKICAgICAgICAgYm9vbCBtX2RyYWdTcmNJc0xpbms7CiAgICAgICAgIGJvb2wgbV9k cmFnU3JjSXNJbWFnZTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmgJKHJldmlzaW9uIDUwNzkx KQorKysgV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0y OCw2ICsyOCw3IEBACiAKICNpbmNsdWRlICJGb2N1c0RpcmVjdGlvbi5oIgogI2luY2x1ZGUgPHd0 Zi9Gb3J3YXJkLmg+CisjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3Rm L1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zNyw3ICszOCw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBOb2RlOwogICAgIGNsYXNzIFBhZ2U7CiAKLSAgICBj bGFzcyBGb2N1c0NvbnRyb2xsZXIgeworICAgIGNsYXNzIEZvY3VzQ29udHJvbGxlciA6IHB1Ymxp YyBOb25jb3B5YWJsZSB7CiAgICAgcHVibGljOgogICAgICAgICBGb2N1c0NvbnRyb2xsZXIoUGFn ZSopOwogCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkocmV2aXNpb24gNTA3OTEpCisrKyBXZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTgsNyArOTgsNyBAQCBzdGF0aWMg Y29uc3QgZG91YmxlIGRlZmVycmVkUmVwYWludERlbGF5CiAvLyBUaGUgbWF4aW11bSBudW1iZXIg b2YgdXBkYXRlV2lkZ2V0cyBpdGVyYXRpb25zIHRoYXQgc2hvdWxkIGJlIGRvbmUgYmVmb3JlIHJl dHVybmluZy4KIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBtYXhVcGRhdGVXaWRnZXRzSXRlcmF0aW9u cyA9IDI7CiAKLXN0cnVjdCBTY2hlZHVsZWRFdmVudCB7CitzdHJ1Y3QgU2NoZWR1bGVkRXZlbnQg OiBOb25jb3B5YWJsZSB7CiAgICAgUmVmUHRyPEV2ZW50PiBtX2V2ZW50OwogICAgIFJlZlB0cjxO b2RlPiBtX2V2ZW50VGFyZ2V0OwogfTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9QbHVnaW5IYWx0ZXIu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvUGx1Z2luSGFsdGVyLmgJKHJldmlzaW9uIDUw NzkxKQorKysgV2ViQ29yZS9wYWdlL1BsdWdpbkhhbHRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0z NSw3ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgSGFsdGFibGVQbHVnaW47 CiAKLWNsYXNzIFBsdWdpbkhhbHRlciB7CitjbGFzcyBQbHVnaW5IYWx0ZXIgOiBwdWJsaWMgTm9u Y29weWFibGUgewogcHVibGljOgogICAgIFBsdWdpbkhhbHRlcihQbHVnaW5IYWx0ZXJDbGllbnQq KTsKIApJbmRleDogV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wYWdlL1NldHRpbmdzLmgJKHJldmlzaW9uIDUwNzkxKQorKysgV2ViQ29yZS9wYWdlL1NldHRp bmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTY0LDcgKzY0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgIC8vIGlmIHBvc3NpYmxlIGluIHRoZSBmdXR1cmUuCiAgICAgZW51bSBFZGl0aW5nQmVo YXZpb3IgeyBFZGl0aW5nTWFjQmVoYXZpb3IsIEVkaXRpbmdXaW5kb3dzQmVoYXZpb3IgfTsKIAot ICAgIGNsYXNzIFNldHRpbmdzIHsKKyAgICBjbGFzcyBTZXR0aW5ncyA6IHB1YmxpYyBOb25jb3B5 YWJsZSB7CiAgICAgcHVibGljOgogICAgICAgICBTZXR0aW5ncyhQYWdlKik7CiAKSW5kZXg6IFdl YkNvcmUvcGFnZS9Vc2VyU2NyaXB0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL1VzZXJT Y3JpcHQuaAkocmV2aXNpb24gNTA3OTEpCisrKyBXZWJDb3JlL3BhZ2UvVXNlclNjcmlwdC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zNCw3ICszNCw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAot Y2xhc3MgVXNlclNjcmlwdCB7CitjbGFzcyBVc2VyU2NyaXB0IDogcHVibGljIE5vbmNvcHlhYmxl IHsKIHB1YmxpYzoKICAgICBVc2VyU2NyaXB0KGNvbnN0IFN0cmluZyYgc291cmNlLCBjb25zdCBL VVJMJiB1cmwsCiAgICAgICAgICAgICAgICBQYXNzT3duUHRyPFZlY3RvcjxTdHJpbmc+ID4gd2hp dGVsaXN0LCBQYXNzT3duUHRyPFZlY3RvcjxTdHJpbmc+ID4gYmxhY2tsaXN0LApJbmRleDogV2Vi Q29yZS9wYWdlL1VzZXJTdHlsZVNoZWV0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL1Vz ZXJTdHlsZVNoZWV0LmgJKHJldmlzaW9uIDUwNzkxKQorKysgV2ViQ29yZS9wYWdlL1VzZXJTdHls ZVNoZWV0LmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDcgQEAKIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCi1jbGFzcyBVc2VyU3R5bGVTaGVldCB7CitjbGFzcyBVc2VyU3R5bGVTaGVldCA6 IHB1YmxpYyBOb25jb3B5YWJsZSB7CiBwdWJsaWM6CiAgICAgVXNlclN0eWxlU2hlZXQoY29uc3Qg U3RyaW5nJiBzb3VyY2UsIGNvbnN0IEtVUkwmIHVybCwKICAgICAgICAgICAgICAgICAgICBQYXNz T3duUHRyPFZlY3RvcjxTdHJpbmc+ID4gd2hpdGVsaXN0LCBQYXNzT3duUHRyPFZlY3RvcjxTdHJp bmc+ID4gYmxhY2tsaXN0LApJbmRleDogV2ViQ29yZS9wYWdlL1hTU0F1ZGl0b3IuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvWFNTQXVkaXRvci5oCShyZXZpc2lvbiA1MDc5MSkKKysrIFdl YkNvcmUvcGFnZS9YU1NBdWRpdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgIC8vICogU2NyaXB0Q29udHJvbGxlcjo6Y3JlYXRlSW5s aW5lRXZlbnRMaXN0ZW5lciAtIHVzZWQgdG8gY3JlYXRlIEphdmFTY3JpcHQgZXZlbnQgaGFuZGxl cnMuCiAgICAgLy8gKiBIVE1MVG9rZW5pemVyOjpzY3JpcHRIYW5kbGVyIC0gdXNlZCB0byBsb2Fk IGV4dGVybmFsIEphdmFTY3JpcHQgc2NyaXB0cy4KICAgICAvLwotICAgIGNsYXNzIFhTU0F1ZGl0 b3IgeworICAgIGNsYXNzIFhTU0F1ZGl0b3IgOiBwdWJsaWMgTm9uY29weWFibGUgewogICAgIHB1 YmxpYzoKICAgICAgICAgWFNTQXVkaXRvcihGcmFtZSopOwogICAgICAgICB+WFNTQXVkaXRvcigp OwpJbmRleDogV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCShyZXZpc2lv biA1MDc5MSkKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE5MCw3ICsxOTAsNyBAQCBjbGFzcyBQcm9wZXJ0eVdyYXBwZXJCYXNl Owogc3RhdGljIHZvaWQgYWRkU2hvcnRoYW5kUHJvcGVydGllcygpOwogc3RhdGljIFByb3BlcnR5 V3JhcHBlckJhc2UqIHdyYXBwZXJGb3JQcm9wZXJ0eShpbnQgcHJvcGVydHlJRCk7CiAKLWNsYXNz IFByb3BlcnR5V3JhcHBlckJhc2UgeworY2xhc3MgUHJvcGVydHlXcmFwcGVyQmFzZSA6IHB1Ymxp YyBOb25jb3B5YWJsZSB7CiBwdWJsaWM6CiAgICAgUHJvcGVydHlXcmFwcGVyQmFzZShpbnQgcHJv cCkKICAgICAgICAgOiBtX3Byb3AocHJvcCkK