31347 2009-11-11 04:18:33 -0800 Need to also show/hide the inspector window to avoid having problems with code assuming it is realized 2009-11-11 13:12:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned xan.lopez oldest_to_newest 162441 0 gustavo 2009-11-11 04:18:33 -0800 Some inspector tests sometimes crash because of code assuming we displayed the window when we should. Discussing this with Xan, we decided to simply show the inspector window. 162500 1 42966 gustavo 2009-11-11 08:58:42 -0800 Created attachment 42966 show window for the inspector Here it goes. 162570 2 42966 jmalonzo 2009-11-11 11:08:34 -0800 Comment on attachment 42966 show window for the inspector r=me. 162647 3 gustavo 2009-11-11 13:12:21 -0800 Landed as r50837, thanks! 42966 2009-11-11 08:58:42 -0800 2009-11-11 11:08:33 -0800 show window for the inspector 0001-Create-and-display-a-window-for-the-inspector-for-in.patch text/plain 3415 gustavo RnJvbSA1YWZlYzk1NDQwM2YxNzBjMjBkN2E0NGFkZDc4ZjI2ZTVkOWZmMjg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFR1ZSwgMyBOb3YgMjAwOSAyMToxMzozNSAtMDIwMApT dWJqZWN0OiBbUEFUQ0hdIENyZWF0ZSwgYW5kIGRpc3BsYXkgYSB3aW5kb3cgZm9yIHRoZSBpbnNw ZWN0b3IsIGZvciBpbnNwZWN0b3IgdGVzdHMuCgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKwogV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCB8ICAgMjkgKysrKysrKysr KysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9D aGFuZ2VMb2cKaW5kZXggOTU3OGJkYy4uNDU4YWEzNSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisy MDA5LTExLTExICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFi b3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENyZWF0ZSwgYW5kIGRpc3BsYXkgYSB3aW5kb3cgZm9yIHRoZSBpbnNwZWN0b3IsIGZvciBp bnNwZWN0b3IKKyAgICAgICAgdGVzdHMuCisKKyAgICAgICAgTmVlZCB0byBhbHNvIHNob3cvaGlk ZSB0aGUgaW5zcGVjdG9yIHdpbmRvdyB0byBhdm9pZCBoYXZpbmcKKyAgICAgICAgcHJvYmxlbXMg d2l0aCBjb2RlIGFzc3VtaW5nIGl0IGlzIHJlYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTM0NworCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHdlYkluc3BlY3RvclNob3dXaW5k b3cpOgorICAgICAgICAod2ViSW5zcGVjdG9yQ2xvc2VXaW5kb3cpOgorICAgICAgICAod2ViSW5z cGVjdG9ySW5zcGVjdFdlYlZpZXcpOgorICAgICAgICAoY3JlYXRlV2ViVmlldyk6CisKIDIwMDkt MTEtMTAgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1w UmVuZGVyVHJlZS5jcHAKaW5kZXggOTYwZTlkMC4uNTQwOGJhMSAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC04Miw2ICs4Miw3 IEBAIHN0YXRpYyBHQ0NvbnRyb2xsZXIqIGdjQ29udHJvbGxlciA9IDA7CiBzdGF0aWMgV2ViS2l0 V2ViVmlldyogd2ViVmlldzsKIHN0YXRpYyBHdGtXaWRnZXQqIHdpbmRvdzsKIHN0YXRpYyBHdGtX aWRnZXQqIGNvbnRhaW5lcjsKK3N0YXRpYyBHdGtXaWRnZXQqIHdlYkluc3BlY3RvcldpbmRvdzsK IFdlYktpdFdlYkZyYW1lKiBtYWluRnJhbWUgPSAwOwogV2ViS2l0V2ViRnJhbWUqIHRvcExvYWRp bmdGcmFtZSA9IDA7CiBndWludCB3YWl0VG9EdW1wV2F0Y2hkb2cgPSAwOwpAQCAtNzA2LDkgKzcw NywyOSBAQCBzdGF0aWMgdm9pZCBkYXRhYmFzZVF1b3RhRXhjZWVkZWQoV2ViS2l0V2ViVmlldyog dmlldywgV2ViS2l0V2ViRnJhbWUqIGZyYW1lLCBXZQogCiBzdGF0aWMgV2ViS2l0V2ViVmlldyog d2ViVmlld0NyZWF0ZShXZWJLaXRXZWJWaWV3KiwgV2ViS2l0V2ViRnJhbWUqKTsKIAorc3RhdGlj IGdib29sZWFuIHdlYkluc3BlY3RvclNob3dXaW5kb3coV2ViS2l0V2ViSW5zcGVjdG9yKiwgZ3Bv aW50ZXIgZGF0YSkKK3sKKyAgICBndGtfd2luZG93X3NldF9kZWZhdWx0X3NpemUoR1RLX1dJTkRP Vyh3ZWJJbnNwZWN0b3JXaW5kb3cpLCA4MDAsIDYwMCk7CisgICAgZ3RrX3dpZGdldF9zaG93X2Fs bCh3ZWJJbnNwZWN0b3JXaW5kb3cpOworICAgIHJldHVybiBUUlVFOworfQorCitzdGF0aWMgZ2Jv b2xlYW4gd2ViSW5zcGVjdG9yQ2xvc2VXaW5kb3coV2ViS2l0V2ViSW5zcGVjdG9yKiwgZ3BvaW50 ZXIgZGF0YSkKK3sKKyAgICBndGtfd2lkZ2V0X2Rlc3Ryb3kod2ViSW5zcGVjdG9yV2luZG93KTsK KyAgICB3ZWJJbnNwZWN0b3JXaW5kb3cgPSAwOworICAgIHJldHVybiBUUlVFOworfQorCiBzdGF0 aWMgV2ViS2l0V2ViVmlldyogd2ViSW5zcGVjdG9ySW5zcGVjdFdlYlZpZXcoV2ViS2l0V2ViSW5z cGVjdG9yKiwgZ3BvaW50ZXIgZGF0YSkKIHsKLSAgICByZXR1cm4gV0VCS0lUX1dFQl9WSUVXKHdl YmtpdF93ZWJfdmlld19uZXcoKSk7CisgICAgd2ViSW5zcGVjdG9yV2luZG93ID0gZ3RrX3dpbmRv d19uZXcoR1RLX1dJTkRPV19UT1BMRVZFTCk7CisKKyAgICBHdGtXaWRnZXQqIHdlYlZpZXcgPSB3 ZWJraXRfd2ViX3ZpZXdfbmV3KCk7CisgICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5F Uih3ZWJJbnNwZWN0b3JXaW5kb3cpLAorICAgICAgICAgICAgICAgICAgICAgIHdlYlZpZXcpOwor CisgICAgcmV0dXJuIFdFQktJVF9XRUJfVklFVyh3ZWJWaWV3KTsKIH0KIAogc3RhdGljIFdlYktp dFdlYlZpZXcqIGNyZWF0ZVdlYlZpZXcoKQpAQCAtNzM2LDcgKzc1NywxMSBAQCBzdGF0aWMgV2Vi S2l0V2ViVmlldyogY3JlYXRlV2ViVmlldygpCiAgICAgICAgICAgICAgICAgICAgICBOVUxMKTsK IAogICAgIFdlYktpdFdlYkluc3BlY3RvciogaW5zcGVjdG9yID0gd2Via2l0X3dlYl92aWV3X2dl dF9pbnNwZWN0b3Iodmlldyk7Ci0gICAgZ19zaWduYWxfY29ubmVjdChpbnNwZWN0b3IsICJpbnNw ZWN0LXdlYi12aWV3IiwgR19DQUxMQkFDSyh3ZWJJbnNwZWN0b3JJbnNwZWN0V2ViVmlldyksIDAp OworICAgIGdfb2JqZWN0X2Nvbm5lY3QoR19PQkpFQ1QoaW5zcGVjdG9yKSwKKyAgICAgICAgICAg ICAgICAgICAgICJzaWduYWw6Omluc3BlY3Qtd2ViLXZpZXciLCB3ZWJJbnNwZWN0b3JJbnNwZWN0 V2ViVmlldywgMCwKKyAgICAgICAgICAgICAgICAgICAgICJzaWduYWw6OnNob3ctd2luZG93Iiwg d2ViSW5zcGVjdG9yU2hvd1dpbmRvdywgMCwKKyAgICAgICAgICAgICAgICAgICAgICJzaWduYWw6 OmNsb3NlLXdpbmRvdyIsIHdlYkluc3BlY3RvckNsb3NlV2luZG93LCAwLAorICAgICAgICAgICAg ICAgICAgICAgTlVMTCk7CiAKICAgICByZXR1cm4gdmlldzsKIH0KLS0gCjEuNi41LjIKCg==