31346 2009-11-11 03:58:46 -0800 Should not print javascript console messages to stdout 2009-11-11 04:46:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 162435 0 gustavo 2009-11-11 03:58:46 -0800 Currently javascript console messages are printed to stdout using g_print. This is not a good idea. stderr should be used, at least. 162436 1 42948 gustavo 2009-11-11 04:02:57 -0800 Created attachment 42948 print console messages with g_warning This helps some tests fail from time to time. Javascript console messages show up on the test results. 162437 2 gustavo 2009-11-11 04:03:29 -0800 (In reply to comment #1) > This helps some tests fail from time to time. Javascript console messages show > up on the test results. To be clear, 'This' here means the problem this patch fixes, not the fix =). 162438 3 42949 gustavo 2009-11-11 04:12:06 -0800 Created attachment 42949 print console messages to stderr Use g_message instead of g_warning, following suggestion by Benjamin Otte. 162444 4 gustavo 2009-11-11 04:46:39 -0800 Landed as r50799. 42948 2009-11-11 04:02:57 -0800 2009-11-11 04:12:06 -0800 print console messages with g_warning 0001-Print-javascript-console-messages-to-stderr-instead.patch text/plain 1707 gustavo RnJvbSA5ZjE5YjE5OTdlMzFkZjg5N2FhODg4Y2VjMWU3NTQ4MmNlMzZhYTUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFdlZCwgMTEgTm92IDIwMDkgMTA6MDE6NDAgLTAyMDAK U3ViamVjdDogW1BBVENIXSBQcmludCBqYXZhc2NyaXB0IGNvbnNvbGUgbWVzc2FnZXMgdG8gc3Rk ZXJyIGluc3RlYWQKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAg IDExICsrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CmluZGV4IDY4YzFjZDIuLjk5NmIwYjQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTEg IEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hvdWxk IG5vdCBwcmludCBqYXZhc2NyaXB0IGNvbnNvbGUgbWVzc2FnZXMgdG8gc3Rkb3V0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTM0NgorCisgICAgICAg ICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X3Jl YWxfY29uc29sZV9tZXNzYWdlKTogUHJpbnQgY29uc29sZSBtZXNzYWdlcyB0bworICAgICAgICBz dGRlcnIgaW5zdGVhZCwgdXNpbmcgdGhlIHJlY29tbWVuZGVkIG1ldGhvZCAoYSBnX2xvZyB2YXJp YW50KS4KKwogMjAwOS0xMS0xMCAgTWFydGluIFJvYmluc29uICA8bWFydGluLmphbWVzLnJvYmlu c29uQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAwMDkxYzdiLi5mNGI2ZGVjIDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtODY3LDcgKzg2Nyw3IEBAIHN0YXRpYyBnYm9vbGVh biB3ZWJraXRfd2ViX3ZpZXdfcmVhbF9zY3JpcHRfcHJvbXB0KFdlYktpdFdlYlZpZXcqIHdlYlZp ZXcsIFdlYktpCiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfcmVhbF9jb25zb2xl X21lc3NhZ2UoV2ViS2l0V2ViVmlldyogd2ViVmlldywgY29uc3QgZ2NoYXIqIG1lc3NhZ2UsIHVu c2lnbmVkIGludCBsaW5lLCBjb25zdCBnY2hhciogc291cmNlSWQpCiB7Ci0gICAgZ19wcmludCgi Y29uc29sZSBtZXNzYWdlOiAlcyBAJWQ6ICVzXG4iLCBzb3VyY2VJZCwgbGluZSwgbWVzc2FnZSk7 CisgICAgZ193YXJuaW5nKCJjb25zb2xlIG1lc3NhZ2U6ICVzIEAlZDogJXNcbiIsIHNvdXJjZUlk LCBsaW5lLCBtZXNzYWdlKTsKICAgICByZXR1cm4gVFJVRTsKIH0KIAotLSAKMS42LjUuMgoK 42949 2009-11-11 04:12:06 -0800 2009-11-11 04:15:44 -0800 print console messages to stderr 0001-Print-javascript-console-messages-to-stderr-instead.patch text/plain 1707 gustavo RnJvbSA0ZDJjMzA4YWQ5ZjM2MGE0N2ViNjI5NWQzZTY3MDc2NzE2YzE4NDA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFdlZCwgMTEgTm92IDIwMDkgMTA6MDE6NDAgLTAyMDAK U3ViamVjdDogW1BBVENIXSBQcmludCBqYXZhc2NyaXB0IGNvbnNvbGUgbWVzc2FnZXMgdG8gc3Rk ZXJyIGluc3RlYWQKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAg IDExICsrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CmluZGV4IDY4YzFjZDIuLjk5NmIwYjQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMTEg IEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hvdWxk IG5vdCBwcmludCBqYXZhc2NyaXB0IGNvbnNvbGUgbWVzc2FnZXMgdG8gc3Rkb3V0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTM0NgorCisgICAgICAg ICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X3Jl YWxfY29uc29sZV9tZXNzYWdlKTogUHJpbnQgY29uc29sZSBtZXNzYWdlcyB0bworICAgICAgICBz dGRlcnIgaW5zdGVhZCwgdXNpbmcgdGhlIHJlY29tbWVuZGVkIG1ldGhvZCAoYSBnX2xvZyB2YXJp YW50KS4KKwogMjAwOS0xMS0xMCAgTWFydGluIFJvYmluc29uICA8bWFydGluLmphbWVzLnJvYmlu c29uQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAwMDkxYzdiLi5iODA0OGUzIDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtODY3LDcgKzg2Nyw3IEBAIHN0YXRpYyBnYm9vbGVh biB3ZWJraXRfd2ViX3ZpZXdfcmVhbF9zY3JpcHRfcHJvbXB0KFdlYktpdFdlYlZpZXcqIHdlYlZp ZXcsIFdlYktpCiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfcmVhbF9jb25zb2xl X21lc3NhZ2UoV2ViS2l0V2ViVmlldyogd2ViVmlldywgY29uc3QgZ2NoYXIqIG1lc3NhZ2UsIHVu c2lnbmVkIGludCBsaW5lLCBjb25zdCBnY2hhciogc291cmNlSWQpCiB7Ci0gICAgZ19wcmludCgi Y29uc29sZSBtZXNzYWdlOiAlcyBAJWQ6ICVzXG4iLCBzb3VyY2VJZCwgbGluZSwgbWVzc2FnZSk7 CisgICAgZ19tZXNzYWdlKCJjb25zb2xlIG1lc3NhZ2U6ICVzIEAlZDogJXNcbiIsIHNvdXJjZUlk LCBsaW5lLCBtZXNzYWdlKTsKICAgICByZXR1cm4gVFJVRTsKIH0KIAotLSAKMS42LjUuMgoK