31343 2009-11-11 03:19:37 -0800 Check if Storage panel exists before calling its methods 2009-11-12 00:03:44 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys pfeldman jorlow michaeln pfeldman timothy oldest_to_newest 162429 0 yurys 2009-11-11 03:19:37 -0800 Storage panel is diabled by defaut in Chromium and it may lead to exceptions in the frontend if localStorage is accessed in the inspected page and the frontend gets notified about the storage. 162439 1 42950 yurys 2009-11-11 04:14:54 -0800 Created attachment 42950 patch 162569 2 42950 pfeldman 2009-11-11 11:08:14 -0800 Comment on attachment 42950 patch There is a handful of panel.storage usages overall. Why are you fixing only one? 162587 3 42983 pfeldman 2009-11-11 11:25:16 -0800 Created attachment 42983 [PATCH] fix Otherwise things crash when Storage is one of the hidden panels on the sites that use stores.... 162659 4 pfeldman 2009-11-11 13:37:53 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50840 162818 5 yurys 2009-11-12 00:03:44 -0800 updateDOMStorage should never be called if the panel is hidden because IC will send updates only after DOM storage entries have been requested. (In reply to comment #2) > (From update of attachment 42950 [details]) > There is a handful of panel.storage usages overall. Why are you fixing only > one? 42950 2009-11-11 04:14:54 -0800 2009-11-11 11:25:16 -0800 patch check-storage-panel.patch text/plain 1038 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTEzNWNjMS4uMjgwMmMzYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMS0xMSAgWXVyeSBTZW1pa2hh dHNreSA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoZWNrIGlmIHN0b3JhZ2UgcGFuZWwgZXhpc3RzIGJlZm9yZSBh ZGRpbmcgRE9NIHN0b3JhZ2UgdG8gaXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMxMzQzCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L2luc3BlY3Rvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5hZGRET01TdG9yYWdlKToKKwog MjAwOS0xMS0xMSAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuanMKaW5kZXggZmRhNWIyOC4uYWZiNzk2OSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0xMDc4LDYgKzEwNzgsOCBAQCBXZWJJ bnNwZWN0b3IuYWRkQ29va2llRG9tYWluID0gZnVuY3Rpb24oZG9tYWluKQogCiBXZWJJbnNwZWN0 b3IuYWRkRE9NU3RvcmFnZSA9IGZ1bmN0aW9uKHBheWxvYWQpCiB7CisgICAgaWYgKCF0aGlzLnBh bmVscy5zdG9yYWdlKQorICAgICAgICByZXR1cm47CiAgICAgdmFyIGRvbVN0b3JhZ2UgPSBuZXcg V2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2UoCiAgICAgICAgIHBheWxvYWQuaWQsCiAgICAgICAgIHBh eWxvYWQuaG9zdCwK 42983 2009-11-11 11:25:16 -0800 2009-11-11 12:31:26 -0800 [PATCH] fix storage text/plain 1888 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDM0Y2IyYS4uZTFhZTY2MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0xMSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgQ2hlY2sgdGhhdCBpZiBTdG9yYWdlIHBhbmVsIGV4aXN0cyBi ZWZvcmUgY2FsbGluZyBpdHMgbWV0aG9kcworCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTM0MworCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuYWRkRGF0YWJhc2UpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLmFkZENvb2tpZURvbWFpbik6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuYWRkRE9NU3RvcmFnZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IudXBkYXRlRE9NU3RvcmFn ZSk6CisKIDIwMDktMTEtMTEgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCBmZGE1YjI4Li5mOWUzODAyIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTEwNjIsNiArMTA2Miw4IEBAIFdlYklu c3BlY3Rvci5yZW1vdmVSZXNvdXJjZSA9IGZ1bmN0aW9uKGlkZW50aWZpZXIpCiAKIFdlYkluc3Bl Y3Rvci5hZGREYXRhYmFzZSA9IGZ1bmN0aW9uKHBheWxvYWQpCiB7CisgICAgaWYgKCF0aGlzLnBh bmVscy5zdG9yYWdlKQorICAgICAgICByZXR1cm47CiAgICAgdmFyIGRhdGFiYXNlID0gbmV3IFdl Ykluc3BlY3Rvci5EYXRhYmFzZSgKICAgICAgICAgcGF5bG9hZC5pZCwKICAgICAgICAgcGF5bG9h ZC5kb21haW4sCkBAIC0xMDcyLDEyICsxMDc0LDE1IEBAIFdlYkluc3BlY3Rvci5hZGREYXRhYmFz ZSA9IGZ1bmN0aW9uKHBheWxvYWQpCiAKIFdlYkluc3BlY3Rvci5hZGRDb29raWVEb21haW4gPSBm dW5jdGlvbihkb21haW4pCiB7Ci0gICAgaWYgKHRoaXMucGFuZWxzLnN0b3JhZ2UpCi0gICAgICAg IHRoaXMucGFuZWxzLnN0b3JhZ2UuYWRkQ29va2llRG9tYWluKGRvbWFpbik7CisgICAgaWYgKCF0 aGlzLnBhbmVscy5zdG9yYWdlKQorICAgICAgICByZXR1cm47CisgICAgdGhpcy5wYW5lbHMuc3Rv cmFnZS5hZGRDb29raWVEb21haW4oZG9tYWluKTsKIH0KIAogV2ViSW5zcGVjdG9yLmFkZERPTVN0 b3JhZ2UgPSBmdW5jdGlvbihwYXlsb2FkKQogeworICAgIGlmICghdGhpcy5wYW5lbHMuc3RvcmFn ZSkKKyAgICAgICAgcmV0dXJuOwogICAgIHZhciBkb21TdG9yYWdlID0gbmV3IFdlYkluc3BlY3Rv ci5ET01TdG9yYWdlKAogICAgICAgICBwYXlsb2FkLmlkLAogICAgICAgICBwYXlsb2FkLmhvc3Qs CkBAIC0xMDg3LDYgKzEwOTIsOCBAQCBXZWJJbnNwZWN0b3IuYWRkRE9NU3RvcmFnZSA9IGZ1bmN0 aW9uKHBheWxvYWQpCiAKIFdlYkluc3BlY3Rvci51cGRhdGVET01TdG9yYWdlID0gZnVuY3Rpb24o c3RvcmFnZUlkKQogeworICAgIGlmICghdGhpcy5wYW5lbHMuc3RvcmFnZSkKKyAgICAgICAgcmV0 dXJuOwogICAgIHRoaXMucGFuZWxzLnN0b3JhZ2UudXBkYXRlRE9NU3RvcmFnZShzdG9yYWdlSWQp OwogfQogCg==