31339 2009-11-11 01:58:54 -0800 Fix incorrect white-space in WebGLRenderingContext.idl 2010-04-07 09:53:49 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P5 Normal --- 1 skylined skylined commit-queue joepeck oliver oldest_to_newest 162407 0 42939 skylined 2009-11-11 01:58:54 -0800 Created attachment 42939 Patch that removes the offending white-space. WebGLRenderingContext.idl declares "drawElements" incorrectly: there is additional white-space after the method name. void drawElements (in unsigned long mode, in long count, in unsigned long type, in unsigned long offset); ^^^ This can cause an IDL parser to see it as an unnamed method that returns "void drawElements", which is incorrect. Oliver, can you apply this patch for me? 162494 1 42939 eric 2009-11-11 08:43:22 -0800 Comment on attachment 42939 Patch that removes the offending white-space. This needs a ChangeLog, but otherwise looks fine. prepare-ChangeLog -b 31339 should generate what you want. 209461 2 joepeck 2010-04-06 23:13:45 -0700 SkyLined, the space still exists. Did you want to redo this patch? Like Eric mentions, you just need a ChangeLog. Or, if you would rather I attach a patch for you, let me know. 209522 3 skylined 2010-04-07 01:12:27 -0700 If you could create a patch for me, that would be great! I'm prioritizing a bunch of other things, so I won't get to do this myself anytime soon. But it would make my life easier later on, so I would really like to see the change. Thanks! 209648 4 52740 joepeck 2010-04-07 08:45:26 -0700 Created attachment 52740 [PATCH] Remove Whitespace 209651 5 joepeck 2010-04-07 08:45:58 -0700 (In reply to comment #3) > If you could create a patch for me, that would be great! I'm prioritizing a > bunch of other things, so I won't get to do this myself anytime soon. But it > would make my life easier later on, so I would really like to see the change. Let me know if there are any other issues that you find! 209684 6 52740 commit-queue 2010-04-07 09:53:45 -0700 Comment on attachment 52740 [PATCH] Remove Whitespace Clearing flags on attachment: 52740 Committed r57214: <http://trac.webkit.org/changeset/57214> 209685 7 commit-queue 2010-04-07 09:53:49 -0700 All reviewed patches have been landed. Closing bug. 42939 2009-11-11 01:58:54 -0800 2010-04-07 08:45:26 -0700 Patch that removes the offending white-space. fix_whitespace.patch text/plain 809 skylined SW5kZXg6IFdlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJHTFJl bmRlcmluZ0NvbnRleHQuaWRsCShyZXZpc2lvbiA1MDc5NikNCisrKyBXZWJHTFJlbmRlcmluZ0Nv bnRleHQuaWRsCSh3b3JraW5nIGNvcHkpDQpAQCAtNTE4LDcgKzUxOCw3IEBADQogICAgICAgICB2 b2lkICAgICAgICAgZGlzYWJsZShpbiB1bnNpZ25lZCBsb25nIGNhcCk7CiAgICAgICAgIHZvaWQg ICAgICAgICBkaXNhYmxlVmVydGV4QXR0cmliQXJyYXkoaW4gdW5zaWduZWQgbG9uZyBpbmRleCk7 CiAgICAgICAgIHZvaWQgICAgICAgICBkcmF3QXJyYXlzKGluIHVuc2lnbmVkIGxvbmcgbW9kZSwg aW4gbG9uZyBmaXJzdCwgaW4gdW5zaWduZWQgbG9uZyBjb3VudCk7Ci0gICAgICAgIHZvaWQgICAg ICAgICBkcmF3RWxlbWVudHMgKGluIHVuc2lnbmVkIGxvbmcgbW9kZSwgaW4gbG9uZyBjb3VudCwg aW4gdW5zaWduZWQgbG9uZyB0eXBlLCBpbiB1bnNpZ25lZCBsb25nIG9mZnNldCk7CisgICAgICAg IHZvaWQgICAgICAgICBkcmF3RWxlbWVudHMoaW4gdW5zaWduZWQgbG9uZyBtb2RlLCBpbiBsb25n IGNvdW50LCBpbiB1bnNpZ25lZCBsb25nIHR5cGUsIGluIHVuc2lnbmVkIGxvbmcgb2Zmc2V0KTsK IAogICAgICAgICB2b2lkICAgICAgICAgZW5hYmxlKGluIHVuc2lnbmVkIGxvbmcgY2FwKTsKICAg ICAgICAgdm9pZCAgICAgICAgIGVuYWJsZVZlcnRleEF0dHJpYkFycmF5KGluIHVuc2lnbmVkIGxv bmcgaW5kZXgpOwo= 52740 2010-04-07 08:45:26 -0700 2010-04-07 09:53:45 -0700 [PATCH] Remove Whitespace idl-fix text/plain 1503 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDhkNzA1NS4uNTkzMTJjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNC0wNyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBpbmNvcnJlY3Qgd2hpdGUtc3BhY2UgaW4gV2ViR0xSZW5k ZXJpbmdDb250ZXh0LmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzEzMzkKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dC5pZGw6IFJlbW92ZSBvZmZlbmRpbmcgZXh0cmEgd2hpdGVzcGFjZS4KKwogMjAxMC0wNC0w NyAgRGF3aXQgQWxlbWF5ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5pZGwgYi9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5pZGwKaW5kZXggNzg1ZGE1MS4uYTI1NzQ1MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsCisrKyBiL1dlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbApAQCAtNTIwLDcgKzUyMCw3IEBAIG1vZHVs ZSBodG1sIHsKICAgICAgICAgdm9pZCAgICAgICAgIGRpc2FibGUoaW4gdW5zaWduZWQgbG9uZyBj YXApOwogICAgICAgICB2b2lkICAgICAgICAgZGlzYWJsZVZlcnRleEF0dHJpYkFycmF5KGluIHVu c2lnbmVkIGxvbmcgaW5kZXgpIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgICAgICB2b2lkICAg ICAgICAgZHJhd0FycmF5cyhpbiB1bnNpZ25lZCBsb25nIG1vZGUsIGluIGxvbmcgZmlyc3QsIGlu IHVuc2lnbmVkIGxvbmcgY291bnQpIHJhaXNlcyhET01FeGNlcHRpb24pOwotICAgICAgICB2b2lk ICAgICAgICAgZHJhd0VsZW1lbnRzIChpbiB1bnNpZ25lZCBsb25nIG1vZGUsIGluIGxvbmcgY291 bnQsIGluIHVuc2lnbmVkIGxvbmcgdHlwZSwgaW4gdW5zaWduZWQgbG9uZyBvZmZzZXQpIHJhaXNl cyhET01FeGNlcHRpb24pOworICAgICAgICB2b2lkICAgICAgICAgZHJhd0VsZW1lbnRzKGluIHVu c2lnbmVkIGxvbmcgbW9kZSwgaW4gbG9uZyBjb3VudCwgaW4gdW5zaWduZWQgbG9uZyB0eXBlLCBp biB1bnNpZ25lZCBsb25nIG9mZnNldCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAKICAgICAgICAg dm9pZCAgICAgICAgIGVuYWJsZShpbiB1bnNpZ25lZCBsb25nIGNhcCk7CiAgICAgICAgIHZvaWQg ICAgICAgICBlbmFibGVWZXJ0ZXhBdHRyaWJBcnJheShpbiB1bnNpZ25lZCBsb25nIGluZGV4KSBy YWlzZXMoRE9NRXhjZXB0aW9uKTsK