31328 2009-11-10 17:01:00 -0800 Remove unused DWORD id member from Windows PlatformThread 2009-11-11 12:00:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned ap commit-queue eric ggaren oldest_to_newest 162293 0 laszlo.gombos 2009-11-10 17:01:00 -0800 id (DWORD type) field from the PlatformThread structure is not used in Collector.cpp; I propose to remove the field and simplify the code. This is the first proposed step in a larger refactoring effort to make the multiple JavaScriptCore Threads implementation more portable so that is is available for more ports. As a secondary target we might be able to remove the pthread library dependency for WIN_OS. 162299 1 42912 laszlo.gombos 2009-11-10 17:08:55 -0800 Created attachment 42912 proposed patch 162516 2 eric 2009-11-11 09:45:40 -0800 This code was last touched in http://trac.webkit.org/changeset/35440. CCing the authors of that change. 162530 3 42912 ap 2009-11-11 09:57:22 -0800 Comment on attachment 42912 proposed patch r=me 162602 4 42912 commit-queue 2009-11-11 12:00:17 -0800 Comment on attachment 42912 proposed patch Clearing flags on attachment: 42912 Committed r50833: <http://trac.webkit.org/changeset/50833> 162603 5 commit-queue 2009-11-11 12:00:25 -0800 All reviewed patches have been landed. Closing bug. 42912 2009-11-10 17:08:55 -0800 2009-11-11 12:00:17 -0800 proposed patch 31328.patch text/plain 2665 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUwNzgwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMTAgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yIG11bHRpcGxlIEphdmFTY3JpcHRD b3JlIHRocmVhZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxMzI4CisKKyAgICAgICAgUmVtb3ZlIHRoZSBpZCBmaWVsZCBmcm9tIHRoZSBQbGF0Zm9y bVRocmVhZCBzdHJ1Y3R1cmUgCisgICAgICAgIGFzIGl0IGlzIG5vdCB1c2VkLgorCisgICAgICAg ICogcnVudGltZS9Db2xsZWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpnZXRDdXJyZW50UGxhdGZv cm1UaHJlYWQpOgorICAgICAgICAoSlNDOjpzdXNwZW5kVGhyZWFkKToKKyAgICAgICAgKEpTQzo6 cmVzdW1lVGhyZWFkKToKKyAgICAgICAgKEpTQzo6Z2V0UGxhdGZvcm1UaHJlYWRSZWdpc3RlcnMp OgorCiAyMDA5LTExLTA5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbGxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9D b2xsZWN0b3IuY3BwCShyZXZpc2lvbiA1MDc3OCkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q29sbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE4LDExICsxMTgsNyBAQCBzdGF0aWMg UkhlYXAqIHVzZXJDaHVuayA9IDA7CiAjaWYgUExBVEZPUk0oREFSV0lOKQogdHlwZWRlZiBtYWNo X3BvcnRfdCBQbGF0Zm9ybVRocmVhZDsKICNlbGlmIFBMQVRGT1JNKFdJTl9PUykKLXN0cnVjdCBQ bGF0Zm9ybVRocmVhZCB7Ci0gICAgUGxhdGZvcm1UaHJlYWQoRFdPUkQgX2lkLCBIQU5ETEUgX2hh bmRsZSkgOiBpZChfaWQpLCBoYW5kbGUoX2hhbmRsZSkge30KLSAgICBEV09SRCBpZDsKLSAgICBI QU5ETEUgaGFuZGxlOwotfTsKK3R5cGVkZWYgSEFORExFIFBsYXRmb3JtVGhyZWFkOwogI2VuZGlm CiAKIGNsYXNzIEhlYXA6OlRocmVhZCB7CkBAIC02NDYsOCArNjQyLDcgQEAgc3RhdGljIGlubGlu ZSBQbGF0Zm9ybVRocmVhZCBnZXRDdXJyZW50UAogI2lmIFBMQVRGT1JNKERBUldJTikKICAgICBy ZXR1cm4gcHRocmVhZF9tYWNoX3RocmVhZF9ucChwdGhyZWFkX3NlbGYoKSk7CiAjZWxpZiBQTEFU Rk9STShXSU5fT1MpCi0gICAgSEFORExFIHRocmVhZEhhbmRsZSA9IHB0aHJlYWRfZ2V0dzMydGhy ZWFkaGFuZGxlX25wKHB0aHJlYWRfc2VsZigpKTsKLSAgICByZXR1cm4gUGxhdGZvcm1UaHJlYWQo R2V0Q3VycmVudFRocmVhZElkKCksIHRocmVhZEhhbmRsZSk7CisgICAgcmV0dXJuIHB0aHJlYWRf Z2V0dzMydGhyZWFkaGFuZGxlX25wKHB0aHJlYWRfc2VsZigpKTsKICNlbmRpZgogfQogCkBAIC04 MTEsNyArODA2LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIHN1c3BlbmRUaHJlYWQoY29uc3QgUAog I2lmIFBMQVRGT1JNKERBUldJTikKICAgICB0aHJlYWRfc3VzcGVuZChwbGF0Zm9ybVRocmVhZCk7 CiAjZWxpZiBQTEFURk9STShXSU5fT1MpCi0gICAgU3VzcGVuZFRocmVhZChwbGF0Zm9ybVRocmVh ZC5oYW5kbGUpOworICAgIFN1c3BlbmRUaHJlYWQocGxhdGZvcm1UaHJlYWQpOwogI2Vsc2UKICNl cnJvciBOZWVkIGEgd2F5IHRvIHN1c3BlbmQgdGhyZWFkcyBvbiB0aGlzIHBsYXRmb3JtCiAjZW5k aWYKQEAgLTgyMiw3ICs4MTcsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgcmVzdW1lVGhyZWFkKGNv bnN0IFBsCiAjaWYgUExBVEZPUk0oREFSV0lOKQogICAgIHRocmVhZF9yZXN1bWUocGxhdGZvcm1U aHJlYWQpOwogI2VsaWYgUExBVEZPUk0oV0lOX09TKQotICAgIFJlc3VtZVRocmVhZChwbGF0Zm9y bVRocmVhZC5oYW5kbGUpOworICAgIFJlc3VtZVRocmVhZChwbGF0Zm9ybVRocmVhZCk7CiAjZWxz ZQogI2Vycm9yIE5lZWQgYSB3YXkgdG8gcmVzdW1lIHRocmVhZHMgb24gdGhpcyBwbGF0Zm9ybQog I2VuZGlmCkBAIC04ODYsNyArODgxLDcgQEAgc3RhdGljIHNpemVfdCBnZXRQbGF0Zm9ybVRocmVh ZFJlZ2lzdGVycwogCiAjZWxpZiBQTEFURk9STShXSU5fT1MpICYmIFBMQVRGT1JNKFg4NikKICAg ICByZWdzLkNvbnRleHRGbGFncyA9IENPTlRFWFRfSU5URUdFUiB8IENPTlRFWFRfQ09OVFJPTCB8 IENPTlRFWFRfU0VHTUVOVFM7Ci0gICAgR2V0VGhyZWFkQ29udGV4dChwbGF0Zm9ybVRocmVhZC5o YW5kbGUsICZyZWdzKTsKKyAgICBHZXRUaHJlYWRDb250ZXh0KHBsYXRmb3JtVGhyZWFkLCAmcmVn cyk7CiAgICAgcmV0dXJuIHNpemVvZihDT05URVhUKTsKICNlbHNlCiAjZXJyb3IgTmVlZCBhIHdh eSB0byBnZXQgdGhyZWFkIHJlZ2lzdGVycyBvbiB0aGlzIHBsYXRmb3JtCg==