31326 2009-11-10 16:32:49 -0800 Make the output prettier for test /fast/events/drag-and-drop.html 2009-11-11 21:47:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 30291 1 dbates dbates aroben arv darin eric jens oldest_to_newest 162279 0 dbates 2009-11-10 16:32:49 -0800 Following up an a suggestion made by Darin on bug #30291, we should make the output of the test /fast/events/drag-and-drop.html pretty and easy to read by a human. 162280 1 42908 dbates 2009-11-10 16:35:43 -0800 Created attachment 42908 Patch Changed one line in test case from shouldEvaluateTo('event.dataTransfer.dropEffect',...) to shouldBeEqualToString('event.dataTransfer.dropEffect', ...). Rebased the results. 162281 2 42908 eric 2009-11-10 16:36:53 -0800 Comment on attachment 42908 Patch LGTM. 162793 3 42908 dbates 2009-11-11 21:47:02 -0800 Comment on attachment 42908 Patch Clearing flags on attachment: 42908 Committed r50866: <http://trac.webkit.org/changeset/50866> 162794 4 dbates 2009-11-11 21:47:10 -0800 All reviewed patches have been landed. Closing bug. 42908 2009-11-10 16:35:43 -0800 2009-11-11 21:47:01 -0800 Patch Bug31326.patch text/plain 6664 dbates SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwNzc4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTAgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTMyNgor CisgICAgICAgIE1ha2VzIHRoZSBvdXRwdXQgZm9yIHRlc3QgZmFzdC9ldmVudHMvZHJhZy1hbmQt ZHJvcC5odG1sIHByZXR0eS4KKyAgICAgICAgTm93LCBpdCBpcyBlYXNpZXIgdG8gcmVhZCBmb3Ig YSBodW1hbiB0byByZWFkIHVuZGVyc3RhbmQgdGhlIHJlc3VsdHMuCisKKyAgICAgICAgKiBmYXN0 L2V2ZW50cy9kcmFnLWFuZC1kcm9wLWV4cGVjdGVkLnR4dDogUmViYXNlZCByZXN1bHQuCisgICAg ICAgICogZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC5odG1sOiBNb2RpZmllZCB0byBtYWtlIHRo ZSBvdXRwdXQgcHJldHR5LgorCiAyMDA5LTExLTEwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDUwNjM2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTksNyArOSw3IEBAIE9uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEEKIAogV2hlbiBlZmZlY3RBbGxvd2VkID09ICJ1bmlu aXRpYWxpemVkIgogCi1QQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BF ZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUKK1BB U1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgIm5vbmUiCiBGQUlMIGV2ZW50LmRh dGFUcmFuc2Zlci5kcm9wRWZmZWN0IHNob3VsZCBiZSBjb3B5LiBXYXMgbm9uZS4KIEZBSUwgZXZl bnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3Qgc2hvdWxkIGJlIG1vdmUuIFdhcyBub25lLgogRkFJ TCBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBzaG91bGQgYmUgbGluay4gV2FzIG5vbmUu CkBAIC0xNyw3ICsxNyw3IEBAIFBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMg Im4KIAogV2hlbiBlZmZlY3RBbGxvd2VkID09ICJub25lIgogCi1QQVNTIGV2ZW50LmRhdGFUcmFu c2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0u c2VsZWN0ZWRJbmRleF0udmFsdWUKK1BBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3Qg aXMgIm5vbmUiCiBQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJub25lIgog UEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKIFBBU1MgZXZlbnQu ZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgIm5vbmUiCkBAIC0yNSw2MyArMjUsNjMgQEAgUEFT UyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibgogCiBXaGVuIGVmZmVjdEFsbG93 ZWQgPT0gImFsbCIKIAotUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyBkcm9w RWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlCi1Q QVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BFZmZlY3RFbGVtLm9wdGlv bnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUKLVBBU1MgZXZlbnQuZGF0YVRy YW5zZmVyLmRyb3BFZmZlY3QgaXMgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxl bS5zZWxlY3RlZEluZGV4XS52YWx1ZQotUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVj dCBpcyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhd LnZhbHVlCitQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJub25lIgorUEFT UyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAiY29weSIKK1BBU1MgZXZlbnQuZGF0 YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgIm1vdmUiCitQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5k cm9wRWZmZWN0IGlzICJsaW5rIgogUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBp cyAibm9uZSIKIAogV2hlbiBlZmZlY3RBbGxvd2VkID09ICJjb3B5IgogCi1QQVNTIGV2ZW50LmRh dGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVj dEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUKLVBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BF ZmZlY3QgaXMgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZElu ZGV4XS52YWx1ZQorUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIK K1BBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgImNvcHkiCiBQQVNTIGV2ZW50 LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJub25lIgogUEFTUyBldmVudC5kYXRhVHJhbnNm ZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKIFBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZl Y3QgaXMgIm5vbmUiCiAKIFdoZW4gZWZmZWN0QWxsb3dlZCA9PSAibW92ZSIKIAotUEFTUyBldmVu dC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BF ZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlCiBQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5k cm9wRWZmZWN0IGlzICJub25lIgotUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBp cyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZh bHVlCitQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJub25lIgorUEFTUyBl dmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibW92ZSIKIFBBU1MgZXZlbnQuZGF0YVRy YW5zZmVyLmRyb3BFZmZlY3QgaXMgIm5vbmUiCiBQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9w RWZmZWN0IGlzICJub25lIgogCiBXaGVuIGVmZmVjdEFsbG93ZWQgPT0gImxpbmsiCiAKLVBBU1Mg ZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tk cm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZQogUEFTUyBldmVudC5kYXRhVHJhbnNm ZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKIFBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZl Y3QgaXMgIm5vbmUiCi1QQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BF ZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUKK1BB U1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgIm5vbmUiCitQQVNTIGV2ZW50LmRh dGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJsaW5rIgogUEFTUyBldmVudC5kYXRhVHJhbnNmZXIu ZHJvcEVmZmVjdCBpcyAibm9uZSIKIAogV2hlbiBlZmZlY3RBbGxvd2VkID09ICJjb3B5TW92ZSIK IAotUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyBkcm9wRWZmZWN0RWxlbS5v cHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlCi1QQVNTIGV2ZW50LmRh dGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVj dEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUKLVBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BF ZmZlY3QgaXMgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZElu ZGV4XS52YWx1ZQorUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIK K1BBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgImNvcHkiCitQQVNTIGV2ZW50 LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJtb3ZlIgogUEFTUyBldmVudC5kYXRhVHJhbnNm ZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKIFBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZl Y3QgaXMgIm5vbmUiCiAKIFdoZW4gZWZmZWN0QWxsb3dlZCA9PSAiY29weUxpbmsiCiAKLVBBU1Mg ZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tk cm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZQotUEFTUyBldmVudC5kYXRhVHJhbnNm ZXIuZHJvcEVmZmVjdCBpcyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNl bGVjdGVkSW5kZXhdLnZhbHVlCiBQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlz ICJub25lIgotUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyBkcm9wRWZmZWN0 RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlCitQQVNTIGV2 ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJjb3B5IgorUEFTUyBldmVudC5kYXRhVHJh bnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKK1BBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BF ZmZlY3QgaXMgImxpbmsiCiBQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJu b25lIgogCiBXaGVuIGVmZmVjdEFsbG93ZWQgPT0gImxpbmtNb3ZlIgogCi1QQVNTIGV2ZW50LmRh dGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVj dEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUKIFBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BF ZmZlY3QgaXMgIm5vbmUiCi1QQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzIGRy b3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUK LVBBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgZHJvcEVmZmVjdEVsZW0ub3B0 aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZQorUEFTUyBldmVudC5kYXRh VHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKK1BBU1MgZXZlbnQuZGF0YVRyYW5zZmVyLmRy b3BFZmZlY3QgaXMgIm1vdmUiCitQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlz ICJsaW5rIgogUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKIAog V2hlbiBlZmZlY3RBbGxvd2VkID09ICJkdW1teSIKIAotUEFTUyBldmVudC5kYXRhVHJhbnNmZXIu ZHJvcEVmZmVjdCBpcyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVj dGVkSW5kZXhdLnZhbHVlCitQQVNTIGV2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0IGlzICJu b25lIgogUEFTUyBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCBpcyAibm9uZSIKIFBBU1Mg ZXZlbnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QgaXMgIm5vbmUiCiBQQVNTIGV2ZW50LmRhdGFU cmFuc2Zlci5kcm9wRWZmZWN0IGlzICJub25lIgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvZHJhZy1hbmQtZHJvcC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZl bnRzL2RyYWctYW5kLWRyb3AuaHRtbAkocmV2aXNpb24gNTA3NzgpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9kcmFnLWFuZC1kcm9wLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTg5LDcgKzg5 LDcgQEAKICAgICAgICAgdmFyIGFjdHVhbERyb3BFZmZlY3QgPSBlLmRhdGFUcmFuc2Zlci5kcm9w RWZmZWN0OwogICAgICAgICAKICAgICAgICAgaWYgKGlzRHJvcEVmZmVjdEFsbG93ZWQoY2hvc2Vu RHJvcEVmZmVjdCwgY2hvc2VuRWZmZWN0QWxsb3dlZCkpCi0gICAgICAgICAgICBzaG91bGRFdmFs dWF0ZVRvKCdldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCcsICdkcm9wRWZmZWN0RWxlbS5v cHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlJyk7CisgICAgICAgICAg ICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2V2ZW50LmRhdGFUcmFuc2Zlci5kcm9wRWZmZWN0Jywg ZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1 ZSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnZXZl bnQuZGF0YVRyYW5zZmVyLmRyb3BFZmZlY3QnLCAnbm9uZScpOwogICAgICAgICAgICAgCg==