31322 2009-11-10 15:15:45 -0800 REGRESSION (r50587): Repro crash saving pcmag.com article as a webarchive 2009-11-10 15:37:59 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.pcmag.com/article2/0,2817,2354369,00.asp InRadar P1 Critical --- 1 beidson beidson oldest_to_newest 162247 0 beidson 2009-11-10 15:15:45 -0800 Go to http://www.pcmag.com/article2/0,2817,2354369,00.asp then save the page as a webarchive. Crash! Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000101ba29fc WTF::RefPtr<WebCore::StyleList>::operator WebCore::StyleList* WTF::RefPtr<WebCore::StyleList>::*() const + 12 (RefPtr.h:72) 1 com.apple.WebCore 0x0000000101ba23e3 WebCore::CSSRuleList::length() const + 25 (CSSRuleList.cpp:54) 2 com.apple.WebCore 0x0000000101bee366 WebCore::CSSStyleSheet::addSubresourceStyleURLs(WTF::ListHashSet<WebCore::KURL, WebCore::KURLHash>&) + 254 (CSSStyleSheet.cpp:235) 3 com.apple.WebCore 0x0000000101e72e69 WebCore::HTMLLinkElement::addSubresourceAttributeURLs(WTF::ListHashSet<WebCore::KURL, WebCore::KURLHash>&) const + 143 (HTMLLinkElement.cpp:424) 4 com.apple.WebCore 0x00000001021b9152 WebCore::Node::getSubresourceURLs(WTF::ListHashSet<WebCore::KURL, WebCore::KURLHash>&) const + 42 (Node.cpp:2282) 5 com.apple.WebCore 0x0000000102172490 WebCore::LegacyWebArchive::create(WebCore::String const&, WebCore::Frame*, WTF::Vector<WebCore::Node*, 0ul> const&) + 882 (LegacyWebArchive.cpp:516) 6 com.apple.WebCore 0x00000001021730d1 WebCore::LegacyWebArchive::create(WebCore::Node*) + 315 (LegacyWebArchive.cpp:430) 7 com.apple.WebKit 0x00000001015828c9 -[DOMNode(WebDOMNodeOperations) webArchive] + 70 (WebDOMOperations.mm:53) ... We're walking a CSSStyleSheet looking for subresource URLs. The CSSRuleList we get is null do to a failed security origin check. We should just walk the stylesheet directly. 162249 1 beidson 2009-11-10 15:19:48 -0800 <rdar://problem/7381219> 162251 2 42904 beidson 2009-11-10 15:28:37 -0800 Created attachment 42904 Fix + layout test 162252 3 beidson 2009-11-10 15:32:10 -0800 http://trac.webkit.org/changeset/50587 162255 4 beidson 2009-11-10 15:37:59 -0800 http://trac.webkit.org/changeset/50778 42904 2009-11-10 15:28:37 -0800 2009-11-10 15:34:27 -0800 Fix + layout test patch.txt text/plain 7054 beidson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDc3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl cHJvIGNyYXNoIHNhdmluZyBwY21hZy5jb20gYXJ0aWNsZSBhcyBhIHdlYmFyY2hpdmUuCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83MzgxMjE5PiBhbmQgaHR0cHM6Ly93ZWJraXQub3JnL2IvMzEz MjIKKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL3dlYmFyY2hpdmUvY3Jvc3Mtb3JpZ2luLXN0 eWxlc2hlZXQtY3Jhc2guaHRtbAorCisgICAgICAgICogY3NzL0NTU1N0eWxlU2hlZXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTaGVldDo6YWRkU3VicmVzb3VyY2VTdHlsZVVSTHMp OiBXYWxrIHRoZSBzdHlsZXNoZWV0IGl0c2VsZiBpbnN0ZWFkCisgICAgICAgICAgb2YgY3JlYXRp bmcgYSBDU1NSdWxlTGlzdCAoYW5kIHN1YmplY3Rpbmcgb3Vyc2VsdmVzIHRvIHRoZSBzZWN1cml0 eSBvcmlnaW4gY2hlY2spCisKIDIwMDktMTEtMTAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgUXQgYnVpbGQgZml4LgpJbmRleDogV2ViQ29yZS9jc3MvQ1NT U3R5bGVTaGVldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVldC5j cHAJKHJldmlzaW9uIDUwNzcwKQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVldC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTIzMCwxMCArMjMwLDEyIEBAIHZvaWQgQ1NTU3R5bGVTaGVldDo6YWRk U3VicmVzb3VyY2VTdHlsZVUKICAgICAgICAgQ1NTU3R5bGVTaGVldCogc3R5bGVTaGVldCA9IHN0 eWxlU2hlZXRRdWV1ZS5maXJzdCgpOwogICAgICAgICBzdHlsZVNoZWV0UXVldWUucmVtb3ZlRmly c3QoKTsKIAotICAgICAgICBSZWZQdHI8Q1NTUnVsZUxpc3Q+IHJ1bGVMaXN0ID0gc3R5bGVTaGVl dC0+Y3NzUnVsZXMoKTsKLQotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcnVsZUxp c3QtPmxlbmd0aCgpOyArK2kpIHsKLSAgICAgICAgICAgIENTU1J1bGUqIHJ1bGUgPSBydWxlTGlz dC0+aXRlbShpKTsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHN0eWxlU2hlZXQt Pmxlbmd0aCgpOyArK2kpIHsKKyAgICAgICAgICAgIFN0eWxlQmFzZSogc3R5bGVCYXNlID0gc3R5 bGVTaGVldC0+aXRlbShpKTsKKyAgICAgICAgICAgIGlmICghc3R5bGVCYXNlLT5pc1J1bGUoKSkK KyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgQ1NT UnVsZSogcnVsZSA9IHN0YXRpY19jYXN0PENTU1J1bGUqPihzdHlsZUJhc2UpOwogICAgICAgICAg ICAgaWYgKHJ1bGUtPmlzSW1wb3J0UnVsZSgpKSB7CiAgICAgICAgICAgICAgICAgaWYgKENTU1N0 eWxlU2hlZXQqIHJ1bGVTdHlsZVNoZWV0ID0gc3RhdGljX2Nhc3Q8Q1NTSW1wb3J0UnVsZSo+KHJ1 bGUpLT5zdHlsZVNoZWV0KCkpCiAgICAgICAgICAgICAgICAgICAgIHN0eWxlU2hlZXRRdWV1ZS5h cHBlbmQocnVsZVN0eWxlU2hlZXQpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTA3NzQpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0x MS0xMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwcm8gY3Jhc2ggc2F2aW5nIHBjbWFn LmNvbSBhcnRpY2xlIGFzIGEgd2ViYXJjaGl2ZS4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcz ODEyMTk+IGFuZCBodHRwczovL3dlYmtpdC5vcmcvYi8zMTMyMgorCisgICAgICAgICogaHR0cC90 ZXN0cy93ZWJhcmNoaXZlL2Nyb3NzLW9yaWdpbi1zdHlsZXNoZWV0LWNyYXNoLmh0bWw6IEFkZGVk LgorICAgICAgICAqIGh0dHAvdGVzdHMvd2ViYXJjaGl2ZS9jcm9zcy1vcmlnaW4tc3R5bGVzaGVl dC1jcmFzaC1leHBlY3RlZC53ZWJhcmNoaXZlOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3Rz L3dlYmFyY2hpdmUvcmVzb3VyY2VzL2xvY2FsaG9zdC1zdHlsZXNoZWV0LmNzczogQWRkZWQuCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IEFkZCB0aGlzIHRlc3QgdG8gdGhlIGd0ayBT a2lwcGVkIGxpc3Qgd2hpY2ggdHJhY2tzIGFsbCBpbmRpdmlkdWFsIHNraXBwZWQgdGVzdHMKKyAg ICAgICAgICBpbnN0ZWFkIG9mIGRpcmVjdG9yaWVzLgorCiAyMDA5LTExLTEwICBCcmlhbiBXZWlu c3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBi eSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYmFyY2hp dmUvY3Jvc3Mtb3JpZ2luLXN0eWxlc2hlZXQtY3Jhc2gtZXhwZWN0ZWQud2ViYXJjaGl2ZQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYmFyY2hpdmUvY3Jvc3Mtb3JpZ2lu LXN0eWxlc2hlZXQtY3Jhc2gtZXhwZWN0ZWQud2ViYXJjaGl2ZQkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvd2ViYXJjaGl2ZS9jcm9zcy1vcmlnaW4tc3R5bGVzaGVldC1j cmFzaC1leHBlY3RlZC53ZWJhcmNoaXZlCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDY5IEBACis8 P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJVVEYtOCI/PgorPCFET0NUWVBFIHBsaXN0IFBV QkxJQyAiLS8vQXBwbGUvL0RURCBQTElTVCAxLjAvL0VOIiAiaHR0cDovL3d3dy5hcHBsZS5jb20v RFREcy9Qcm9wZXJ0eUxpc3QtMS4wLmR0ZCI+Cis8cGxpc3QgdmVyc2lvbj0iMS4wIj4KKzxkaWN0 PgorCTxrZXk+V2ViTWFpblJlc291cmNlPC9rZXk+CisJPGRpY3Q+CisJCTxrZXk+V2ViUmVzb3Vy Y2VEYXRhPC9rZXk+CisJCTxzdHJpbmc+Jmx0O2h0bWwmZ3Q7Jmx0O2hlYWQmZ3Q7CismbHQ7c2Ny aXB0Jmd0OworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wRE9NQXNXZWJBcmNoaXZlKCk7CismbHQ7L3NjcmlwdCZndDsKKyZsdDts aW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iaHR0cDovL2xvY2FsaG9zdDo4MDAwL3dlYmFyY2hp dmUvcmVzb3VyY2VzL2xvY2FsaG9zdC1zdHlsZXNoZWV0LmNzcyIgdHlwZT0idGV4dC9jc3MiJmd0 OworJmx0Oy9oZWFkJmd0OyZsdDtib2R5Jmd0OworVGhpcyBIVE1MIGxpbmtzIHRvIGFuIGV4dGVy bmFsIHN0eWxlc2hlZXQgZnJvbSBhIGRpZmZlcmVudCBzZWN1cml0eSBvcmlnaW4uJmx0O2JyJmd0 OworTWFraW5nIGEgd2ViYXJjaGl2ZSBvZiB0aGlzIHBhZ2Ugc2hvdWxkIG5vdCBjcmFzaC4KKwor CismbHQ7L2JvZHkmZ3Q7Jmx0Oy9odG1sJmd0Ozwvc3RyaW5nPgorCQk8a2V5PldlYlJlc291cmNl RnJhbWVOYW1lPC9rZXk+CisJCTxzdHJpbmc+PC9zdHJpbmc+CisJCTxrZXk+V2ViUmVzb3VyY2VN SU1FVHlwZTwva2V5PgorCQk8c3RyaW5nPnRleHQvaHRtbDwvc3RyaW5nPgorCQk8a2V5PldlYlJl c291cmNlVGV4dEVuY29kaW5nTmFtZTwva2V5PgorCQk8c3RyaW5nPlVURi04PC9zdHJpbmc+CisJ CTxrZXk+V2ViUmVzb3VyY2VVUkw8L2tleT4KKwkJPHN0cmluZz5odHRwOi8vMTI3LjAuMC4xOjgw MDAvd2ViYXJjaGl2ZS9jcm9zcy1vcmlnaW4tc3R5bGVzaGVldC1jcmFzaC5odG1sPC9zdHJpbmc+ CisJPC9kaWN0PgorCTxrZXk+V2ViU3VicmVzb3VyY2VzPC9rZXk+CisJPGFycmF5PgorCQk8ZGlj dD4KKwkJCTxrZXk+V2ViUmVzb3VyY2VEYXRhPC9rZXk+CisJCQk8c3RyaW5nPiA8L3N0cmluZz4K KwkJCTxrZXk+V2ViUmVzb3VyY2VNSU1FVHlwZTwva2V5PgorCQkJPHN0cmluZz50ZXh0L2Nzczwv c3RyaW5nPgorCQkJPGtleT5XZWJSZXNvdXJjZVJlc3BvbnNlPC9rZXk+CisJCQk8ZGljdD4KKwkJ CQk8a2V5Pk1JTUVUeXBlPC9rZXk+CisJCQkJPHN0cmluZz50ZXh0L2Nzczwvc3RyaW5nPgorCQkJ CTxrZXk+VVJMPC9rZXk+CisJCQkJPHN0cmluZz5odHRwOi8vbG9jYWxob3N0OjgwMDAvd2ViYXJj aGl2ZS9yZXNvdXJjZXMvbG9jYWxob3N0LXN0eWxlc2hlZXQuY3NzPC9zdHJpbmc+CisJCQkJPGtl eT5hbGxIZWFkZXJGaWVsZHM8L2tleT4KKwkJCQk8ZGljdD4KKwkJCQkJPGtleT5BY2NlcHQtUmFu Z2VzPC9rZXk+CisJCQkJCTxzdHJpbmc+Ynl0ZXM8L3N0cmluZz4KKwkJCQkJPGtleT5Db250ZW50 LUxlbmd0aDwva2V5PgorCQkJCQk8c3RyaW5nPjE8L3N0cmluZz4KKwkJCQkJPGtleT5Db250ZW50 LVR5cGU8L2tleT4KKwkJCQkJPHN0cmluZz50ZXh0L2Nzczwvc3RyaW5nPgorCQkJCQk8a2V5PkRh dGU8L2tleT4KKwkJCQkJPHN0cmluZz5TdW4sIDE2IE5vdiAyMDA4IDE3OjAwOjAwIEdNVDwvc3Ry aW5nPgorCQkJCQk8a2V5PkV0YWc8L2tleT4KKwkJCQkJPHN0cmluZz4iMzAxOTI1LTIxLTQ1Yzdk NzJkM2U3ODAiPC9zdHJpbmc+CisJCQkJCTxrZXk+TGFzdC1Nb2RpZmllZDwva2V5PgorCQkJCQk8 c3RyaW5nPlN1biwgMTYgTm92IDIwMDggMTY6NTU6MDAgR01UPC9zdHJpbmc+CisJCQkJCTxrZXk+ U2VydmVyPC9rZXk+CisJCQkJCTxzdHJpbmc+QXBhY2hlLzIuMi45IChVbml4KSBtb2Rfc3NsLzIu Mi45IE9wZW5TU0wvMC45LjdsIFBIUC81LjIuNjwvc3RyaW5nPgorCQkJCTwvZGljdD4KKwkJCQk8 a2V5PmV4cGVjdGVkQ29udGVudExlbmd0aDwva2V5PgorCQkJCTxpbnRlZ2VyPjE8L2ludGVnZXI+ CisJCQkJPGtleT5zdGF0dXNDb2RlPC9rZXk+CisJCQkJPGludGVnZXI+MjAwPC9pbnRlZ2VyPgor CQkJPC9kaWN0PgorCQkJPGtleT5XZWJSZXNvdXJjZVVSTDwva2V5PgorCQkJPHN0cmluZz5odHRw Oi8vbG9jYWxob3N0OjgwMDAvd2ViYXJjaGl2ZS9yZXNvdXJjZXMvbG9jYWxob3N0LXN0eWxlc2hl ZXQuY3NzPC9zdHJpbmc+CisJCTwvZGljdD4KKwk8L2FycmF5PgorPC9kaWN0PgorPC9wbGlzdD4K SW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvd2ViYXJjaGl2ZS9jcm9zcy1vcmlnaW4tc3R5 bGVzaGVldC1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMv d2ViYXJjaGl2ZS9jcm9zcy1vcmlnaW4tc3R5bGVzaGVldC1jcmFzaC5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJhcmNoaXZlL2Nyb3NzLW9yaWdpbi1zdHls ZXNoZWV0LWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzxodG1sPgor PGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wRE9NQXNXZWJBcmNoaXZlKCk7Cis8L3NjcmlwdD4KKzxs aW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iaHR0cDovL2xvY2FsaG9zdDo4MDAwL3dlYmFyY2hp dmUvcmVzb3VyY2VzL2xvY2FsaG9zdC1zdHlsZXNoZWV0LmNzcyIgdHlwZT0idGV4dC9jc3MiPgor PC9oZWFkPgorPGJvZHk+CitUaGlzIEhUTUwgbGlua3MgdG8gYW4gZXh0ZXJuYWwgc3R5bGVzaGVl dCBmcm9tIGEgZGlmZmVyZW50IHNlY3VyaXR5IG9yaWdpbi48YnI+CitNYWtpbmcgYSB3ZWJhcmNo aXZlIG9mIHRoaXMgcGFnZSBzaG91bGQgbm90IGNyYXNoLgorPC9ib2R5PgorPC9odG1sPgpJbmRl eDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJhcmNoaXZlL3Jlc291cmNlcy9sb2NhbGhvc3Qt c3R5bGVzaGVldC5jc3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJh cmNoaXZlL3Jlc291cmNlcy9sb2NhbGhvc3Qtc3R5bGVzaGVldC5jc3MJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYmFyY2hpdmUvcmVzb3VyY2VzL2xvY2FsaG9zdC1z dHlsZXNoZWV0LmNzcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvU2tpcHBlZAkocmV2aXNpb24gNTA3NzApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtMzU2Nyw2ICszNTY3LDcgQEAgaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3Bvc3RyZWRpcmVjdC1iYXNpYwogaHR0cC90ZXN0cy9uYXZpZ2F0aW9u L3Bvc3RyZWRpcmVjdC1mcmFtZXMuaHRtbAogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3RyZWRp cmVjdC1nb2JhY2sxLmh0bWwKIGh0dHAvdGVzdHMvdXJpL2Nzcy1ocmVmLnBocAoraHR0cC90ZXN0 cy93ZWJhcmNoaXZlL2Nyb3NzLW9yaWdpbi1zdHlsZXNoZWV0LWNyYXNoLmh0bWwKIGh0dHAvdGVz dHMvd2ViYXJjaGl2ZS90ZXN0LWNzcy11cmwtZW5jb2Rpbmctc2hpZnQtamlzLmh0bWwKIGh0dHAv dGVzdHMvd2ViYXJjaGl2ZS90ZXN0LWNzcy11cmwtZW5jb2RpbmctdXRmLTguaHRtbAogaHR0cC90 ZXN0cy93ZWJhcmNoaXZlL3Rlc3QtY3NzLXVybC1lbmNvZGluZy5odG1sCg==