31313 2009-11-10 14:17:20 -0800 Make 80 patches a formal requirement for reviewership 2009-11-18 16:18:23 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned commit-queue darin hyatt mjs oldest_to_newest 162208 0 42895 eric 2009-11-10 14:17:20 -0800 Created attachment 42895 Patch After discussion on webkit-reviewers, make 80 patches a formal requirement for reviewers. 162212 1 42896 eric 2009-11-10 14:19:11 -0800 Created attachment 42896 Patch 162334 2 darin 2009-11-10 20:50:21 -0800 I have mixed feelings about this, and would like to at least hear from Maciej before we make this change. 163483 3 eric 2009-11-13 13:47:34 -0800 CCing Maciej per Darin's request. 164358 4 42896 levin 2009-11-17 15:22:01 -0800 Comment on attachment 42896 Patch No one objected on webkit-reviewers. Also, this seems reasonable and in alignment with the curretly accepted practice. 164805 5 42896 commit-queue 2009-11-18 16:18:13 -0800 Comment on attachment 42896 Patch Clearing flags on attachment: 42896 Committed r51152: <http://trac.webkit.org/changeset/51152> 164806 6 commit-queue 2009-11-18 16:18:23 -0800 All reviewed patches have been landed. Closing bug. 42895 2009-11-10 14:17:20 -0800 2009-11-10 14:19:05 -0800 Patch 20091110141717.patch text/plain 1156 eric ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWwg Yi9XZWJLaXRTaXRlL2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCmluZGV4IDFjMGE1 ZGUuLjFkMTg2ODggMTAwNjQ0Ci0tLSBhL1dlYktpdFNpdGUvY29kaW5nL2NvbW1pdC1yZXZpZXct cG9saWN5Lmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3ku aHRtbApAQCAtODAsMTMgKzgwLDEwIEBAIHRoZWlyIGJlc3QgdG8gY2hlY2sgZm9yIGJ1Z3Mgb3Ig b3RoZXIgcHJvYmxlbXMgd2l0aCB0aGUgcGF0Y2guIFRoZXkKIGFyZSBhbHNvIGV4cGVjdGVkIHRv IHNob3cgZ29vZCBqdWRnbWVudCBpbiB3aGV0aGVyIG9yIG5vdCB0aGV5IHJldmlldwogYSBwYXRj aCBhdCBhbGwsIG9yIGRlZmVyIHRvIGFub3RoZXIgcmV2aWV3ZXIuPC9wPgogCi08cD5UeXBpY2Fs bHkgYSBwb3RlbnRpYWwgUmV2aWV3ZXIgd291bGQgYmUgbm9taW5hdGVkIG9uY2UgdGhleSBoYXZl Ci1zdWJtaXR0ZWQgYXJvdW5kIDgwLTEyMCBnb29kIHBhdGNoZXMuIFRoZXkgc2hvdWxkIGFsc28g YmUgaW4gdG91Y2gKKzxwPkEgcG90ZW50aWFsIFJldmlld2VyIG1heSBiZSBub21pbmF0ZWQgb25j ZSB0aGV5IGhhdmUKK3N1Ym1pdHRlZCBhIG1pbmltdW0gb2YgODAgZ29vZCBwYXRjaGVzLiBUaGV5 IHNob3VsZCBhbHNvIGJlIGluIHRvdWNoCiB3aXRoIG90aGVyIHJldmlld2VycyBhbmQgYXdhcmUg b2Ygd2hvIGFyZSB0aGUgZXhwZXJ0cyBpbiB2YXJpb3VzCi1hcmVhcy4gSWYgc29tZW9uZSBzdWJt aXRzIGZld2VyIHBhdGNoZXMgdGhhbiB0aGlzLCBidXQgaGFzIGV4cGVyaWVuY2UKLXdvcmtpbmcg aW4gYW5vdGhlciBXZWJLaXQtYmFzZWQgb3Iga2h0bWwtYmFzZWQgZW5naW5lIGFuZCBoYXMgYSB0 cmFjawotcmVjb3JkIG9mIGV4Y2VsbGVudCBjb2xsYWJvcmF0aW9uIHdpdGggdGhlIFdlYktpdCBw cm9qZWN0LCB0aGV5IG1heSBiZQotbm9taW5hdGVkIHNvb25lci48L3A+CithcmVhcy48L3A+CiAK IDxwPkEgcGVyc29uIHdobyBzdWJtaXRzIG1hbnkgcGF0Y2hlcyBidXQgZG9lcyBub3Qgc2hvdyBn b29kCiBjb2xsYWJvcmF0aW9uIHNraWxscywgY29kZSB1bmRlcnN0YW5kaW5nIG9yIHVuZGVyc3Rh bmRpbmcgb2YgcHJvamVjdA== 42896 2009-11-10 14:19:11 -0800 2009-11-18 16:18:13 -0800 Patch bug-31313-20091110141910.patch text/plain 1803 eric ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggOWYyZTRlNy4uODIyNTAwNyAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMS0xMCAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSA4MCBwYXRjaGVzIGEgZm9ybWFsIHJlcXVpcmVt ZW50IGZvciByZXZpZXdlcnNoaXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMxMzEzCisgICAgICAgIFBlciBkaXNjdXNzaW9uIG9uIHRoZSB3ZWJraXQt cmV2aWV3ZXJzIGxpc3Q6CisgICAgICAgIGh0dHA6Ly9saXN0cy53ZWJraXQub3JnL21haWxtYW4v cHJpdmF0ZS5jZ2kvd2Via2l0LXJldmlld2Vycy8yMDA5LU5vdmVtYmVyLzAwMDc5NS5odG1sCisK KyAgICAgICAgKiBjb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbDoKKwogMjAwOS0xMS0w NiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlciBzdGFt cGVkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29tbWl0 LXJldmlldy1wb2xpY3kuaHRtbCBiL1dlYktpdFNpdGUvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9s aWN5Lmh0bWwKaW5kZXggMWMwYTVkZS4uMWQxODY4OCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9j b2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJLaXRTaXRlL2NvZGluZy9j b21taXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC04MCwxMyArODAsMTAgQEAgdGhlaXIgYmVzdCB0 byBjaGVjayBmb3IgYnVncyBvciBvdGhlciBwcm9ibGVtcyB3aXRoIHRoZSBwYXRjaC4gVGhleQog YXJlIGFsc28gZXhwZWN0ZWQgdG8gc2hvdyBnb29kIGp1ZGdtZW50IGluIHdoZXRoZXIgb3Igbm90 IHRoZXkgcmV2aWV3CiBhIHBhdGNoIGF0IGFsbCwgb3IgZGVmZXIgdG8gYW5vdGhlciByZXZpZXdl ci48L3A+CiAKLTxwPlR5cGljYWxseSBhIHBvdGVudGlhbCBSZXZpZXdlciB3b3VsZCBiZSBub21p bmF0ZWQgb25jZSB0aGV5IGhhdmUKLXN1Ym1pdHRlZCBhcm91bmQgODAtMTIwIGdvb2QgcGF0Y2hl cy4gVGhleSBzaG91bGQgYWxzbyBiZSBpbiB0b3VjaAorPHA+QSBwb3RlbnRpYWwgUmV2aWV3ZXIg bWF5IGJlIG5vbWluYXRlZCBvbmNlIHRoZXkgaGF2ZQorc3VibWl0dGVkIGEgbWluaW11bSBvZiA4 MCBnb29kIHBhdGNoZXMuIFRoZXkgc2hvdWxkIGFsc28gYmUgaW4gdG91Y2gKIHdpdGggb3RoZXIg cmV2aWV3ZXJzIGFuZCBhd2FyZSBvZiB3aG8gYXJlIHRoZSBleHBlcnRzIGluIHZhcmlvdXMKLWFy ZWFzLiBJZiBzb21lb25lIHN1Ym1pdHMgZmV3ZXIgcGF0Y2hlcyB0aGFuIHRoaXMsIGJ1dCBoYXMg ZXhwZXJpZW5jZQotd29ya2luZyBpbiBhbm90aGVyIFdlYktpdC1iYXNlZCBvciBraHRtbC1iYXNl ZCBlbmdpbmUgYW5kIGhhcyBhIHRyYWNrCi1yZWNvcmQgb2YgZXhjZWxsZW50IGNvbGxhYm9yYXRp b24gd2l0aCB0aGUgV2ViS2l0IHByb2plY3QsIHRoZXkgbWF5IGJlCi1ub21pbmF0ZWQgc29vbmVy LjwvcD4KK2FyZWFzLjwvcD4KIAogPHA+QSBwZXJzb24gd2hvIHN1Ym1pdHMgbWFueSBwYXRjaGVz IGJ1dCBkb2VzIG5vdCBzaG93IGdvb2QKIGNvbGxhYm9yYXRpb24gc2tpbGxzLCBjb2RlIHVuZGVy c3RhbmRpbmcgb3IgdW5kZXJzdGFuZGluZyBvZiBwcm9qZWN0