31292 2009-11-10 07:11:32 -0800 [Chromium][Linux] Support Gtk scrollwheel behavior on Linux Chromium 2009-11-12 01:03:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 kinuko webkit-unassigned agl commit-queue eric evan oldest_to_newest 162039 0 kinuko 2009-11-10 07:11:32 -0800 Scrollwheel on horizontal scrollbars should slide horizontally on Linux Chromium too. The change for Gtk has been made in r48735 (bug 29348), but it does not cover Linux Chromium. Chromium side's bug is: http://code.google.com/p/chromium/issues/detail?id=24175 162042 1 42863 kinuko 2009-11-10 07:19:03 -0800 Created attachment 42863 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium 162169 2 agl 2009-11-10 12:45:59 -0800 In general: LGTM. Note that I am not a WebKit reviewer and you need a real review first. However, your patch is lacking ChangeLog entry which is required for WebKit patches: http://webkit.org/coding/contributing.html If you don't wish to deal with ChangeLogs etc you can also ask someone to take up the patch and carry it to landing, but thanks for the code! 162185 3 evan 2009-11-10 13:05:57 -0800 These complicated ifdefs always make me a little scared. Eric, what's the precedent on WebKit for adding more detailed names for features? E.g. should we instead #define HORIZONAL_MOUSEWHEEL somewhere? 162186 4 42863 eric 2009-11-10 13:10:47 -0800 Comment on attachment 42863 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium Every change requires a ChangeLog. See http://webkit.org/coding/contributing.html Otherwise looks fine. the code comes 160 // from gtk/EventHandlerGtk.cpp. Sad we can't share more code with EventHanderGtk... r- for lack of ChangeLog. 162322 5 kinuko 2009-11-10 19:39:40 -0800 (In reply to comment #4) > (From update of attachment 42863 [details]) > Every change requires a ChangeLog. See > http://webkit.org/coding/contributing.html > > Otherwise looks fine. > > the code comes > 160 // from gtk/EventHandlerGtk.cpp. > > Sad we can't share more code with EventHanderGtk... > > r- for lack of ChangeLog. Sorry forgot to include the ChangeLog changes. Attaching a new patch... 162323 6 42917 kinuko 2009-11-10 19:41:34 -0800 Created attachment 42917 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.2) 162327 7 42917 eric 2009-11-10 20:15:08 -0800 Comment on attachment 42917 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.2) horizontall is misspelled. horizontal is what you meant. 162329 8 42920 kinuko 2009-11-10 20:28:04 -0800 Created attachment 42920 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.3) 162333 9 kinuko 2009-11-10 20:46:21 -0800 (In reply to comment #7) > (From update of attachment 42917 [details]) > horizontall is misspelled. horizontal is what you meant. Hmm, good catch, I updated the patch. Thanks! 162730 10 42920 levin 2009-11-11 16:47:04 -0800 Comment on attachment 42920 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.3) > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > +2009-11-10 Kinuko Yasuda <kinuko@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Support Gtk scrollwheel behavior for horizontal scrollbars on Linux > + Chromium too. Please include a link to the bug here. (Perhaps you can get another committer another you to land this and fix this one issue.) 162773 11 43027 kinuko 2009-11-11 20:04:59 -0800 Created attachment 43027 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.4, added a link to the bug) 162831 12 43027 commit-queue 2009-11-12 01:03:40 -0800 Comment on attachment 43027 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.4, added a link to the bug) Clearing flags on attachment: 43027 Committed r50871: <http://trac.webkit.org/changeset/50871> 162832 13 commit-queue 2009-11-12 01:03:46 -0800 All reviewed patches have been landed. Closing bug. 42863 2009-11-10 07:19:03 -0800 2009-11-10 19:41:27 -0800 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium bug-31292-20091111001901.patch text/plain 1249 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvV2ViQ29yZS9wYWdl L0V2ZW50SGFuZGxlci5jcHAKaW5kZXggYmRhNTVhOS4uM2ZjMWUzNyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKQEAgLTE3NjEsNyArMTc2MSw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpkaXNwYXRjaE1v dXNlRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIE5vZGUqIHRhcmdlCiAgICAg cmV0dXJuIHN3YWxsb3dFdmVudDsKIH0KIAotI2lmICFQTEFURk9STShHVEspCisjaWYgIVBMQVRG T1JNKEdUSykgJiYgIShQTEFURk9STShDSFJPTUlVTSkgJiYgUExBVEZPUk0oTElOVVgpKQogYm9v bCBFdmVudEhhbmRsZXI6OnNob3VsZFR1cm5WZXJ0aWNhbFRpY2tzSW50b0hvcml6b250YWwoY29u c3QgSGl0VGVzdFJlc3VsdCYpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNocm9taXVtLmNwcCBiL1dlYkNv cmUvcGFnZS9jaHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5jcHAKaW5kZXggNDY3Zjk0ZS4u MDdkYWUwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNo cm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRXZlbnRIYW5kbGVyQ2hyb21p dW0uY3BwCkBAIC0xNTQsNCArMTU0LDE0IEBAIHVuc2lnbmVkIEV2ZW50SGFuZGxlcjo6YWNjZXNz S2V5TW9kaWZpZXJzKCkKICNlbmRpZgogfQogCisjaWYgUExBVEZPUk0oTElOVVgpCisvLyBHVEsr IG11c3Qgc2Nyb2xsIGhvcml6b250YWxseSBpZiB0aGUgbW91c2UgcG9pbnRlciBpcyBvbiB0b3Ag b2YgdGhlCisvLyBob3Jpem9udGFsIHNjcm9sbGJhciB3aGlsZSBzY3JvbGxpbmcgd2l0aCB0aGUg d2hlZWw7IHRoZSBjb2RlIGNvbWVzCisvLyBmcm9tIGd0ay9FdmVudEhhbmRsZXJHdGsuY3BwLgor Ym9vbCBFdmVudEhhbmRsZXI6OnNob3VsZFR1cm5WZXJ0aWNhbFRpY2tzSW50b0hvcml6b250YWwo Y29uc3QgSGl0VGVzdFJlc3VsdCYgcmVzdWx0KSBjb25zdAoreworICAgIHJldHVybiByZXN1bHQu c2Nyb2xsYmFyKCkgJiYgcmVzdWx0LnNjcm9sbGJhcigpLT5vcmllbnRhdGlvbigpID09IEhvcml6 b250YWxTY3JvbGxiYXI7Cit9CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQ== 42917 2009-11-10 19:41:34 -0800 2009-11-10 20:27:58 -0800 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.2) bug-31292-20091111124132.patch text/plain 1895 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjQ0MGU4MC4uNjUxZGE4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0xMCAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFN1cHBvcnQgR3RrIHNjcm9sbHdoZWVsIGJlaGF2aW9yIGZvciBob3Jp em9udGFsbCBzY3JvbGxiYXJzIG9uIExpbnV4CisgICAgICAgIENocm9taXVtIHRvby4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIChDb3JyZXNwb25kaW5nIHRlc3QgZm9yIEd0aysgaXMKKyAgICAg ICAgcGxhdGZvcm0vZ3RrL3Njcm9sbGJhcnMvb3ZlcmZsb3ctc2Nyb2xsYmFyLWhvcml6b250YWwt d2hlZWwtc2Nyb2xsLmh0bWwpCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6Cisg ICAgICAgICogcGFnZS9jaHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5jcHA6CisKIDIwMDkt MTEtMDkgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwIGIvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggYmRhNTVhOS4uM2ZjMWUz NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTE3NjEsNyArMTc2MSw3IEBAIGJvb2wgRXZlbnRI YW5kbGVyOjpkaXNwYXRjaE1vdXNlRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUs IE5vZGUqIHRhcmdlCiAgICAgcmV0dXJuIHN3YWxsb3dFdmVudDsKIH0KIAotI2lmICFQTEFURk9S TShHVEspCisjaWYgIVBMQVRGT1JNKEdUSykgJiYgIShQTEFURk9STShDSFJPTUlVTSkgJiYgUExB VEZPUk0oTElOVVgpKQogYm9vbCBFdmVudEhhbmRsZXI6OnNob3VsZFR1cm5WZXJ0aWNhbFRpY2tz SW50b0hvcml6b250YWwoY29uc3QgSGl0VGVzdFJlc3VsdCYpIGNvbnN0CiB7CiAgICAgcmV0dXJu IGZhbHNlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNo cm9taXVtLmNwcCBiL1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5j cHAKaW5kZXggNDY3Zjk0ZS4uYWM3NmEyOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2Nocm9t aXVtL0V2ZW50SGFuZGxlckNocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0v RXZlbnRIYW5kbGVyQ2hyb21pdW0uY3BwCkBAIC0xNTQsNCArMTU0LDE0IEBAIHVuc2lnbmVkIEV2 ZW50SGFuZGxlcjo6YWNjZXNzS2V5TW9kaWZpZXJzKCkKICNlbmRpZgogfQogCisjaWYgUExBVEZP Uk0oTElOVVgpCisvLyBHVEsrIG11c3Qgc2Nyb2xsIGhvcml6b250YWxseSBpZiB0aGUgbW91c2Ug cG9pbnRlciBpcyBvbiB0b3Agb2YgdGhlCisvLyBob3Jpem9udGFsIHNjcm9sbGJhciB3aGlsZSBz Y3JvbGxpbmcgd2l0aCB0aGUgd2hlZWwuCisvLyBUaGlzIGNvZGUgY29tZXMgZnJvbSBndGsvRXZl bnRIYW5kbGVyR3RrLmNwcC4KK2Jvb2wgRXZlbnRIYW5kbGVyOjpzaG91bGRUdXJuVmVydGljYWxU aWNrc0ludG9Ib3Jpem9udGFsKGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkgY29uc3QKK3sK KyAgICByZXR1cm4gcmVzdWx0LnNjcm9sbGJhcigpICYmIHJlc3VsdC5zY3JvbGxiYXIoKS0+b3Jp ZW50YXRpb24oKSA9PSBIb3Jpem9udGFsU2Nyb2xsYmFyOworfQorI2VuZGlmCisKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmU= 42920 2009-11-10 20:28:04 -0800 2009-11-11 20:04:53 -0800 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.3) bug-31292-20091111132802.patch text/plain 1894 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjQ0MGU4MC4uOGE0MzExMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0xMCAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFN1cHBvcnQgR3RrIHNjcm9sbHdoZWVsIGJlaGF2aW9yIGZvciBob3Jp em9udGFsIHNjcm9sbGJhcnMgb24gTGludXgKKyAgICAgICAgQ2hyb21pdW0gdG9vLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gKENvcnJlc3BvbmRpbmcgdGVzdCBmb3IgR3RrKyBpcworICAgICAg ICBwbGF0Zm9ybS9ndGsvc2Nyb2xsYmFycy9vdmVyZmxvdy1zY3JvbGxiYXItaG9yaXpvbnRhbC13 aGVlbC1zY3JvbGwuaHRtbCkKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAg ICAgICAgKiBwYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNocm9taXVtLmNwcDoKKwogMjAwOS0x MS0wOSAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAgYi9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBiZGE1NWE5Li4zZmMxZTM3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTc2MSw3ICsxNzYxLDcgQEAgYm9vbCBFdmVudEhh bmRsZXI6OmRpc3BhdGNoTW91c2VFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwg Tm9kZSogdGFyZ2UKICAgICByZXR1cm4gc3dhbGxvd0V2ZW50OwogfQogCi0jaWYgIVBMQVRGT1JN KEdUSykKKyNpZiAhUExBVEZPUk0oR1RLKSAmJiAhKFBMQVRGT1JNKENIUk9NSVVNKSAmJiBQTEFU Rk9STShMSU5VWCkpCiBib29sIEV2ZW50SGFuZGxlcjo6c2hvdWxkVHVyblZlcnRpY2FsVGlja3NJ bnRvSG9yaXpvbnRhbChjb25zdCBIaXRUZXN0UmVzdWx0JikgY29uc3QKIHsKICAgICByZXR1cm4g ZmFsc2U7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRXZlbnRIYW5kbGVyQ2hy b21pdW0uY3BwIGIvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNocm9taXVtLmNw cAppbmRleCA0NjdmOTRlLi5hYzc2YTI5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvY2hyb21p dW0vRXZlbnRIYW5kbGVyQ2hyb21pdW0uY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9F dmVudEhhbmRsZXJDaHJvbWl1bS5jcHAKQEAgLTE1NCw0ICsxNTQsMTQgQEAgdW5zaWduZWQgRXZl bnRIYW5kbGVyOjphY2Nlc3NLZXlNb2RpZmllcnMoKQogI2VuZGlmCiB9CiAKKyNpZiBQTEFURk9S TShMSU5VWCkKKy8vIEdUSysgbXVzdCBzY3JvbGwgaG9yaXpvbnRhbGx5IGlmIHRoZSBtb3VzZSBw b2ludGVyIGlzIG9uIHRvcCBvZiB0aGUKKy8vIGhvcml6b250YWwgc2Nyb2xsYmFyIHdoaWxlIHNj cm9sbGluZyB3aXRoIHRoZSB3aGVlbC4KKy8vIFRoaXMgY29kZSBjb21lcyBmcm9tIGd0ay9FdmVu dEhhbmRsZXJHdGsuY3BwLgorYm9vbCBFdmVudEhhbmRsZXI6OnNob3VsZFR1cm5WZXJ0aWNhbFRp Y2tzSW50b0hvcml6b250YWwoY29uc3QgSGl0VGVzdFJlc3VsdCYgcmVzdWx0KSBjb25zdAorewor ICAgIHJldHVybiByZXN1bHQuc2Nyb2xsYmFyKCkgJiYgcmVzdWx0LnNjcm9sbGJhcigpLT5vcmll bnRhdGlvbigpID09IEhvcml6b250YWxTY3JvbGxiYXI7Cit9CisjZW5kaWYKKwogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQ== 43027 2009-11-11 20:04:59 -0800 2009-11-12 01:03:40 -0800 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium (Rev.4, added a link to the bug) bug-31292-20091112130457.patch text/plain 1949 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjQ0MGU4MC4uNDJkMGJmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMS0xMCAgS2ludWtvIFlhc3Vk YSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFN1cHBvcnQgR3RrIHNjcm9sbHdoZWVsIGJlaGF2aW9yIGZvciBob3Jp em9udGFsIHNjcm9sbGJhcnMgb24gTGludXgKKyAgICAgICAgQ2hyb21pdW0gdG9vLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEyOTIKKworICAgICAg ICBObyBuZXcgdGVzdHMuIChDb3JyZXNwb25kaW5nIHRlc3QgZm9yIEd0aysgaXMKKyAgICAgICAg cGxhdGZvcm0vZ3RrL3Njcm9sbGJhcnMvb3ZlcmZsb3ctc2Nyb2xsYmFyLWhvcml6b250YWwtd2hl ZWwtc2Nyb2xsLmh0bWwpCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAg ICAgICogcGFnZS9jaHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5jcHA6CisKIDIwMDktMTEt MDkgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw IGIvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggYmRhNTVhOS4uM2ZjMWUzNyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTE3NjEsNyArMTc2MSw3IEBAIGJvb2wgRXZlbnRIYW5k bGVyOjpkaXNwYXRjaE1vdXNlRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIE5v ZGUqIHRhcmdlCiAgICAgcmV0dXJuIHN3YWxsb3dFdmVudDsKIH0KIAotI2lmICFQTEFURk9STShH VEspCisjaWYgIVBMQVRGT1JNKEdUSykgJiYgIShQTEFURk9STShDSFJPTUlVTSkgJiYgUExBVEZP Uk0oTElOVVgpKQogYm9vbCBFdmVudEhhbmRsZXI6OnNob3VsZFR1cm5WZXJ0aWNhbFRpY2tzSW50 b0hvcml6b250YWwoY29uc3QgSGl0VGVzdFJlc3VsdCYpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGZh bHNlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNocm9t aXVtLmNwcCBiL1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5jcHAK aW5kZXggNDY3Zjk0ZS4uYWM3NmEyOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2Nocm9taXVt L0V2ZW50SGFuZGxlckNocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRXZl bnRIYW5kbGVyQ2hyb21pdW0uY3BwCkBAIC0xNTQsNCArMTU0LDE0IEBAIHVuc2lnbmVkIEV2ZW50 SGFuZGxlcjo6YWNjZXNzS2V5TW9kaWZpZXJzKCkKICNlbmRpZgogfQogCisjaWYgUExBVEZPUk0o TElOVVgpCisvLyBHVEsrIG11c3Qgc2Nyb2xsIGhvcml6b250YWxseSBpZiB0aGUgbW91c2UgcG9p bnRlciBpcyBvbiB0b3Agb2YgdGhlCisvLyBob3Jpem9udGFsIHNjcm9sbGJhciB3aGlsZSBzY3Jv bGxpbmcgd2l0aCB0aGUgd2hlZWwuCisvLyBUaGlzIGNvZGUgY29tZXMgZnJvbSBndGsvRXZlbnRI YW5kbGVyR3RrLmNwcC4KK2Jvb2wgRXZlbnRIYW5kbGVyOjpzaG91bGRUdXJuVmVydGljYWxUaWNr c0ludG9Ib3Jpem9udGFsKGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkgY29uc3QKK3sKKyAg ICByZXR1cm4gcmVzdWx0LnNjcm9sbGJhcigpICYmIHJlc3VsdC5zY3JvbGxiYXIoKS0+b3JpZW50 YXRpb24oKSA9PSBIb3Jpem9udGFsU2Nyb2xsYmFyOworfQorI2VuZGlmCisKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmU=