31279 2009-11-09 16:45:27 -0800 Remove session storage setting 2009-11-10 12:53:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jorlow jorlow oldest_to_newest 161831 0 jorlow 2009-11-09 16:45:27 -0800 Remove session storage from Settings. It was added temporarily so we could disable it by default at runtime in Chromium. We now disable these things in a different way, so it's time to remove it. Qt also depended on this setting for a short period of time, but after talking to them we agreed that it should be removed. This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602 161834 1 42812 jorlow 2009-11-09 16:48:48 -0800 Created attachment 42812 Patch 161861 2 42812 eric 2009-11-09 17:43:34 -0800 Comment on attachment 42812 Patch How is it disabled now? Are none of the WebKit ports affected by this change? (i.e. this call was only used within WebCore itself?) 161884 3 jorlow 2009-11-09 18:06:34 -0800 QT and Chromium were the only ones that ever depended on it and they no longer do. There's really no good reason why anyone would want to disable this feature when embedding WebKit and it's always been on by default anyway. The flag was originally added because it was the best way to hide features from web pages while we were still getting them stable within Chromium and it mirrored how we LocalStorage is disabled (even though it's clear that setting is somewhat of an abuse since it can only half be disabled once a page uses LocalStorage and all pages in the page group need to share the same path and such). It's also worth noting that we no longer use this method for adding features behind a runtime flag. 162177 4 jorlow 2009-11-10 12:53:36 -0800 Committed r50754: <http://trac.webkit.org/changeset/50754> 42812 2009-11-09 16:48:48 -0800 2009-11-09 17:43:34 -0800 Patch bug-31279-20091109164847.patch text/plain 3497 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDY5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDktMTEtMDkgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIHNlc3Npb24gc3RvcmFnZSBzZXR0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTI3OQorCisgICAgICAgIFJlbW92ZSBzZXNzaW9uIHN0 b3JhZ2UgZnJvbSBTZXR0aW5ncy4gIEl0IHdhcyBhZGRlZCB0ZW1wb3JhcmlseSBzbyB3ZSBjb3Vs ZAorICAgICAgICBkaXNhYmxlIGl0IGJ5IGRlZmF1bHQgYXQgcnVudGltZSBpbiBDaHJvbWl1bS4g IFdlIG5vdyBkaXNhYmxlIHRoZXNlIHRoaW5ncyBpbiBhCisgICAgICAgIGRpZmZlcmVudCB3YXks IHNvIGl0J3MgdGltZSB0byByZW1vdmUgaXQuICBRdCBhbHNvIGRlcGVuZGVkIG9uIHRoaXMgc2V0 dGluZyBmb3IKKyAgICAgICAgYSBzaG9ydCBwZXJpb2Qgb2YgdGltZSwgYnV0IGFmdGVyIHRhbGtp bmcgdG8gdGhlbSB3ZSBhZ3JlZWQgdGhhdCBpdCBzaG91bGQgYmUKKyAgICAgICAgcmVtb3ZlZC4K KworICAgICAgICBUaGlzIGJ1ZyBpcyB0aGUgc2Vjb25kIGhhbGYgb2YgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjAyCisKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRv dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnNlc3Npb25TdG9yYWdlKToKKyAg ICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpT ZXR0aW5ncyk6CisgICAgICAgICogcGFnZS9TZXR0aW5ncy5oOgorCiAyMDA5LTExLTA5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIgYW5kIERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2aXNp b24gNTA2OTgpCisrKyBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTc0LDkgKzU3NCw2IEBAIFN0b3JhZ2UqIERPTVdpbmRvdzo6c2Vzc2lvblN0b3JhZ2UoKSBj b24KICAgICBpZiAoIXBhZ2UpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgaWYgKCFwYWdlLT5z ZXR0aW5ncygpLT5zZXNzaW9uU3RvcmFnZUVuYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0K ICAgICBSZWZQdHI8U3RvcmFnZUFyZWE+IHN0b3JhZ2VBcmVhID0gcGFnZS0+c2Vzc2lvblN0b3Jh Z2UoKS0+c3RvcmFnZUFyZWEoZG9jdW1lbnQtPnNlY3VyaXR5T3JpZ2luKCkpOwogI2lmIEVOQUJM RShJTlNQRUNUT1IpCiAgICAgcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5kaWRVc2VET01T dG9yYWdlKHN0b3JhZ2VBcmVhLmdldCgpLCBmYWxzZSwgbV9mcmFtZSk7CkluZGV4OiBXZWJDb3Jl L3BhZ2UvU2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5j cHAJKHJldmlzaW9uIDUwNjk4KQorKysgV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNzIsNyArNzIsNiBAQCBTZXR0aW5nczo6U2V0dGluZ3MoUGFnZSogcGFnZSkK ICAgICAsIG1fYXJlUGx1Z2luc0VuYWJsZWQoZmFsc2UpCiAgICAgLCBtX2RhdGFiYXNlc0VuYWJs ZWQoZmFsc2UpCiAgICAgLCBtX2xvY2FsU3RvcmFnZUVuYWJsZWQoZmFsc2UpCi0gICAgLCBtX3Nl c3Npb25TdG9yYWdlRW5hYmxlZCh0cnVlKQogICAgICwgbV9pc0phdmFTY3JpcHRFbmFibGVkKGZh bHNlKQogICAgICwgbV9pc1dlYlNlY3VyaXR5RW5hYmxlZCh0cnVlKQogICAgICwgbV9hbGxvd1Vu aXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyh0cnVlKQpAQCAtMjU2LDExICsyNTUsNiBAQCB2b2lk IFNldHRpbmdzOjpzZXRMb2NhbFN0b3JhZ2VFbmFibGVkKGJvCiAgICAgbV9sb2NhbFN0b3JhZ2VF bmFibGVkID0gbG9jYWxTdG9yYWdlRW5hYmxlZDsKIH0KIAotdm9pZCBTZXR0aW5nczo6c2V0U2Vz c2lvblN0b3JhZ2VFbmFibGVkKGJvb2wgc2Vzc2lvblN0b3JhZ2VFbmFibGVkKQotewotICAgIG1f c2Vzc2lvblN0b3JhZ2VFbmFibGVkID0gc2Vzc2lvblN0b3JhZ2VFbmFibGVkOwotfQotCiB2b2lk IFNldHRpbmdzOjpzZXRMb2NhbFN0b3JhZ2VRdW90YSh1bnNpZ25lZCBsb2NhbFN0b3JhZ2VRdW90 YSkKIHsKICAgICBtX2xvY2FsU3RvcmFnZVF1b3RhID0gbG9jYWxTdG9yYWdlUXVvdGE7CkluZGV4 OiBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuaAkocmV2aXNpb24gNTA2OTgpCisrKyBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAkod29y a2luZyBjb3B5KQpAQCAtMTI1LDkgKzEyNSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgdm9pZCBzZXRMb2NhbFN0b3JhZ2VFbmFibGVkKGJvb2wpOwogICAgICAgICBib29sIGxvY2Fs U3RvcmFnZUVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX2xvY2FsU3RvcmFnZUVuYWJsZWQ7IH0K IAotICAgICAgICB2b2lkIHNldFNlc3Npb25TdG9yYWdlRW5hYmxlZChib29sKTsKLSAgICAgICAg Ym9vbCBzZXNzaW9uU3RvcmFnZUVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX3Nlc3Npb25TdG9y YWdlRW5hYmxlZDsgfQotCiAgICAgICAgIHZvaWQgc2V0TG9jYWxTdG9yYWdlUXVvdGEodW5zaWdu ZWQpOwogICAgICAgICB1bnNpZ25lZCBsb2NhbFN0b3JhZ2VRdW90YSgpIGNvbnN0IHsgcmV0dXJu IG1fbG9jYWxTdG9yYWdlUXVvdGE7IH0KIApAQCAtMzA3LDcgKzMwNCw2IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgYm9vbCBtX2FyZVBsdWdpbnNFbmFibGVkIDogMTsKICAgICAgICAg Ym9vbCBtX2RhdGFiYXNlc0VuYWJsZWQgOiAxOwogICAgICAgICBib29sIG1fbG9jYWxTdG9yYWdl RW5hYmxlZCA6IDE7Ci0gICAgICAgIGJvb2wgbV9zZXNzaW9uU3RvcmFnZUVuYWJsZWQgOiAxOwog ICAgICAgICBib29sIG1faXNKYXZhU2NyaXB0RW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV9p c1dlYlNlY3VyaXR5RW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV9hbGxvd1VuaXZlcnNhbEFj Y2Vzc0Zyb21GaWxlVVJMczogMTs=