31274 2009-11-09 13:13:23 -0800 Prepended $$PWD to GENERATED_SOURCES_DIR 2010-02-22 15:27:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED WONTFIX P2 Normal --- 27065 0 norbert.leser webkit-unassigned commit-queue eric hausmann laszlo.gombos s.mathur yongjun.zhang oldest_to_newest 161741 0 42791 norbert.leser 2009-11-09 13:13:23 -0800 Created attachment 42791 Patch for USERINCLUDE paths for symbian Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro. Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore), and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/). 161745 1 42793 norbert.leser 2009-11-09 13:16:39 -0800 Created attachment 42793 Patch for prepending PWD to GENERATED_SOURCES_DIR Corrected description of previous patch. 161798 2 42793 commit-queue 2009-11-09 14:35:06 -0800 Comment on attachment 42793 Patch for prepending PWD to GENERATED_SOURCES_DIR Clearing flags on attachment: 42793 Committed r50695: <http://trac.webkit.org/changeset/50695> 161799 3 commit-queue 2009-11-09 14:35:12 -0800 All reviewed patches have been landed. Closing bug. 161870 4 laszlo.gombos 2009-11-09 17:47:57 -0800 Bug needs to be REOPENED as the landed fix had to be reverted because it broke clean build. Here is the error (breaks when it tries to compile standalone JSC). ../../../JavaScriptCore/pcre/pcre_tables.cpp:72:24: error: chartables.c: No such file or directory make[1]: *** [obj/debug/pcre_tables.o] Error 1 make: *** [sub-JavaScriptCore-jsc-pro-make_default-ordered] Error 2 For some reason I can not change the status to REOPEN. 161876 5 eric 2009-11-09 17:51:59 -0800 You look to have 3 separate bugzilla accounts. :( I've added edit bugs permissions to a second one. 161877 6 eric 2009-11-09 17:52:46 -0800 Starting a rollout per laszlo's request. 161878 7 eric 2009-11-09 17:55:15 -0800 Nevermind. Laszlo already rolled it out in r50701. Please make sure you update the bug with the revision number if you do a rollout. 161879 8 norbert.leser 2009-11-09 17:57:19 -0800 Sorry, to hear that it broke another build. Laszlo, can you specify what your build target was so I can try to reproduce it and work on a potential fix. 161905 9 laszlo.gombos 2009-11-09 18:36:41 -0800 (In reply to comment #8) > Sorry, to hear that it broke another build. Laszlo, can you specify what your > build target was so I can try to reproduce it and work on a potential fix. I saw the build break first on Mac (build-webkit --qt --no-svg --debug) and reproduced on Linux as well (build-webkit --qt --no--svg --release). QtWebKit library builds Ok, but standalone jsc failed. 192672 10 laszlo.gombos 2010-02-22 15:27:07 -0800 Does not seems to be an issue any more (especially after pre-generation step). 42791 2009-11-09 13:13:23 -0800 2009-11-09 13:16:39 -0800 Patch for USERINCLUDE paths for symbian jsc_GENERATED_SOURCES_DIR.patch text/plain 1228 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTA2NzkpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0wOSAgTm9yYmVy dCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXBlbmRlZCAkJFBXRCB0byBHRU5FUkFURURf U09VUkNFU19ESVIgdG8gYXZvaWQgcG90ZW50aWFsIGFtYmlndWl0aWVzIHdoZW4gaW5jbHVkZWQg ZnJvbSBXZWJDb3JlLnByby4KKyAgICAgICAgU29tZSBwcmVwcm9jZXNzb3JzIGNvbnNpZGVyIHRo aXMgR0VORVJBVEVEX1NPVVJDRVNfRElSIHJlbGF0aXZlIHRvIGN1cnJlbnQgaW52b2tpbmcgZGly IChlLmcuLCAuL1dlYkNvcmUpLAorICAgICAgICBhbmQgbm90IHRoZSB3b3JraW5nIGRpciBvZiBK YXZhQ3JpcHRDb3JlLnByaSAoaS5lLiwgLi4vSmF2YVNjcmlwdENvcmUvKS4KKworICAgICAgICAq IEphdmFTY3JpcHRDb3JlLnByaToKKwogMjAwOS0xMS0wOSAgTGFzemxvIEdvbWJvcyAgPGxhc3ps by4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkJKHJldmlz aW9uIDUwNjc5KQorKysgSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCSh3b3JraW5n IGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBAIElOQ0xVREVQQVRIID0gXAogICAgICQkUFdEL3lhcnIg XAogICAgICQkUFdEL0FQSSBcCiAgICAgJCRQV0QvRm9yd2FyZGluZ0hlYWRlcnMgXAotICAgICQk R0VORVJBVEVEX1NPVVJDRVNfRElSIFwKKyAgICAkJFBXRC8kJEdFTkVSQVRFRF9TT1VSQ0VTX0RJ UiBcCiAgICAgJCRJTkNMVURFUEFUSAogCiBERUZJTkVTICs9IEJVSUxESU5HX1FUX18gQlVJTERJ TkdfSmF2YVNjcmlwdENvcmUgQlVJTERJTkdfV1RGCg== 42793 2009-11-09 13:16:39 -0800 2009-11-09 14:35:06 -0800 Patch for prepending PWD to GENERATED_SOURCES_DIR jsc_GENERATED_SOURCES_DIR.patch text/plain 1228 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTA2NzkpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0wOSAgTm9yYmVy dCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXBlbmRlZCAkJFBXRCB0byBHRU5FUkFURURf U09VUkNFU19ESVIgdG8gYXZvaWQgcG90ZW50aWFsIGFtYmlndWl0aWVzIHdoZW4gaW5jbHVkZWQg ZnJvbSBXZWJDb3JlLnByby4KKyAgICAgICAgU29tZSBwcmVwcm9jZXNzb3JzIGNvbnNpZGVyIHRo aXMgR0VORVJBVEVEX1NPVVJDRVNfRElSIHJlbGF0aXZlIHRvIGN1cnJlbnQgaW52b2tpbmcgZGly IChlLmcuLCAuL1dlYkNvcmUpLAorICAgICAgICBhbmQgbm90IHRoZSB3b3JraW5nIGRpciBvZiBK YXZhQ3JpcHRDb3JlLnByaSAoaS5lLiwgLi4vSmF2YVNjcmlwdENvcmUvKS4KKworICAgICAgICAq IEphdmFTY3JpcHRDb3JlLnByaToKKwogMjAwOS0xMS0wOSAgTGFzemxvIEdvbWJvcyAgPGxhc3ps by4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkJKHJldmlz aW9uIDUwNjc5KQorKysgSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCSh3b3JraW5n IGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBAIElOQ0xVREVQQVRIID0gXAogICAgICQkUFdEL3lhcnIg XAogICAgICQkUFdEL0FQSSBcCiAgICAgJCRQV0QvRm9yd2FyZGluZ0hlYWRlcnMgXAotICAgICQk R0VORVJBVEVEX1NPVVJDRVNfRElSIFwKKyAgICAkJFBXRC8kJEdFTkVSQVRFRF9TT1VSQ0VTX0RJ UiBcCiAgICAgJCRJTkNMVURFUEFUSAogCiBERUZJTkVTICs9IEJVSUxESU5HX1FUX18gQlVJTERJ TkdfSmF2YVNjcmlwdENvcmUgQlVJTERJTkdfV1RGCg==