31269 2009-11-09 12:51:15 -0800 [Qt] Few classes have virtual functions but non-virtual destructor 2009-11-09 13:27:22 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue kenneth oldest_to_newest 161719 0 laszlo.gombos 2009-11-09 12:51:15 -0800 QtWebKit builds with the following compiler warnings: WebCore/platform/qt/QWebPageClient.h:31: warning: 'class QWebPageClient' has virtual functions but non-virtual destructor WebKit/qt/Api/qgraphicswebview.cpp:37: warning: 'class QGraphicsWebViewPrivate' has virtual functions but non-virtual destructor Patch will follow to address the warnings. 161720 1 kenneth 2009-11-09 12:53:18 -0800 Really good that you got the warnings turned on! Really good catching errors like these. 161722 2 42786 laszlo.gombos 2009-11-09 12:54:54 -0800 Created attachment 42786 proposed patch 161756 3 42786 commit-queue 2009-11-09 13:27:16 -0800 Comment on attachment 42786 proposed patch Clearing flags on attachment: 42786 Committed r50684: <http://trac.webkit.org/changeset/50684> 161757 4 commit-queue 2009-11-09 13:27:22 -0800 All reviewed patches have been landed. Closing bug. 42786 2009-11-09 12:54:54 -0800 2009-11-09 13:27:16 -0800 proposed patch 31269.patch text/plain 2565 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDY3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRmV3IGNsYXNzZXMgaGF2ZSB2aXJ0dWFsIGZ1bmN0aW9ucyBidXQgbm9uLXZp cnR1YWwgZGVzdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzEyNjkKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gZnVu Y3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9RV2ViUGFnZUNsaWVudC5o OgorICAgICAgICAoUVdlYlBhZ2VDbGllbnQ6On5RV2ViUGFnZUNsaWVudCk6IEFkZCB2aXJ0dWFs IGRlc3RydWN0b3IuCisKIDIwMDktMTEtMDkgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2Vu LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9RV2ViUGFnZUNsaWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvUVdlYlBhZ2VDbGllbnQuaAkocmV2aXNpb24gNTA2NzAp CisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L1FXZWJQYWdlQ2xpZW50LmgJKHdvcmtpbmcgY29weSkK QEAgLTMwLDYgKzMwLDggQEAKIAogY2xhc3MgUVdlYlBhZ2VDbGllbnQgewogcHVibGljOgorICAg IHZpcnR1YWwgflFXZWJQYWdlQ2xpZW50KCkgeyB9CisgICAgICAgIAogICAgIHZpcnR1YWwgdm9p ZCBzY3JvbGwoaW50IGR4LCBpbnQgZHksIGNvbnN0IFFSZWN0JikgPSAwOwogICAgIHZpcnR1YWwg dm9pZCB1cGRhdGUoY29uc3QgUVJlY3QmKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldElucHV0 TWV0aG9kRW5hYmxlZChib29sIGVuYWJsZSkgPSAwOwpJbmRleDogV2ViS2l0L3F0L0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MDY3OSkKKysr IFdlYktpdC9xdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAw OS0xMS0wOSAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGZXcgY2xh c3NlcyBoYXZlIHZpcnR1YWwgZnVuY3Rpb25zIGJ1dCBub24tdmlydHVhbCBkZXN0cnVjdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTI2OQorCisg ICAgICAgICogQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwOgorICAgICAgICAoUUdyYXBoaWNzV2Vi Vmlld1ByaXZhdGU6On5RR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZSk6IEFkZCB2aXJ0dWFsCisgICAg ICAgIGRlc3RydWN0b3IuCisKIDIwMDktMTEtMDkgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1p bi5wb3VsYWluQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRl IENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAkocmV2aXNp b24gNTA2NzApCisrKyBXZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00MSw2ICs0MSw3IEBAIHB1YmxpYzoKICAgICAgICAgLCBwYWdlKDApCiAgICAg e30KIAorICAgIHZpcnR1YWwgflFHcmFwaGljc1dlYlZpZXdQcml2YXRlKCk7CiAgICAgdmlydHVh bCB2b2lkIHNjcm9sbChpbnQgZHgsIGludCBkeSwgY29uc3QgUVJlY3QmKTsKICAgICB2aXJ0dWFs IHZvaWQgdXBkYXRlKGNvbnN0IFFSZWN0JiBkaXJ0eVJlY3QpOwogICAgIHZpcnR1YWwgdm9pZCBz ZXRJbnB1dE1ldGhvZEVuYWJsZWQoYm9vbCBlbmFibGUpOwpAQCAtNjUsNiArNjYsMTAgQEAgcHVi bGljOgogICAgIFFXZWJQYWdlKiBwYWdlOwogfTsKIAorUUdyYXBoaWNzV2ViVmlld1ByaXZhdGU6 On5RR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZSgpCit7Cit9CisKIHZvaWQgUUdyYXBoaWNzV2ViVmll d1ByaXZhdGU6Ol9xX2RvTG9hZEZpbmlzaGVkKGJvb2wgc3VjY2VzcykKIHsKICAgICAvLyBJZiB0 aGUgcGFnZSBoYWQgbm8gdGl0bGUsIHN0aWxsIG1ha2Ugc3VyZSBpdCBnZXRzIHRoZSBzaWduYWwK