31267 2009-11-09 12:45:51 -0800 :nth-child(-2n) should match no element 2010-05-17 21:49:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 jan webkit-unassigned hamaji yhayashi yuzo oldest_to_newest 161713 0 jan 2009-11-09 12:45:51 -0800 :nth-child(-an) matches the a-th element, but should not match anything. This applies to querySelectorAll and CSS rules. NOTE: :nth-child(-n) correctly matches nothing. 167218 1 44015 jan 2009-11-30 04:52:30 -0800 Created attachment 44015 testcase A simple manual testcase. 226628 2 56213 yuzo 2010-05-16 23:06:22 -0700 Created attachment 56213 Add tests for Bug 31267 - :nth-child(-2n) should match no element. 226629 3 yuzo 2010-05-16 23:10:06 -0700 The proposed patch just adds tests because this bug has been already fixed by http://trac.webkit.org/changeset/58300 . 226816 4 56213 darin 2010-05-17 10:52:17 -0700 Comment on attachment 56213 Add tests for Bug 31267 - :nth-child(-2n) should match no element. Good to add a test case. A test that replaces "Test didn't run" with "PASS" or "FAIL" isn't quite as good as a test that explains what it's testing. It's better when possible to have the test explain itself and write out specifics of the unwanted result. r=me 227104 5 yuzo 2010-05-17 21:46:40 -0700 Committed r59649: <http://trac.webkit.org/changeset/59649> 227105 6 yuzo 2010-05-17 21:49:22 -0700 Thank you for the review. Landed the patch after making the tests more descriptive. 44015 2009-11-30 04:52:30 -0800 2009-11-30 04:52:30 -0800 testcase webkit-nth-child.html text/html 787 jan PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPCFET0NUWVBFIGh0bWwgUFVC TElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIgoJImh0dHA6Ly93d3cudzMub3JnL1RSL3ho dG1sMTEvRFREL3hodG1sMTEuZHRkIj4KCjxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8x OTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iPgo8aGVhZD4KCTx0aXRsZT51bnRpdGxlZDwvdGl0bGU+ Cgk8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgoJCWxpIHsKCQkJYmFja2dy b3VuZC1jb2xvcjogZ3JlZW47CgkJfQoJCWxpOm50aC1jaGlsZCgtMm4pIHsKCQkJYmFja2dyb3Vu ZC1jb2xvcjogcmVkOwoJCX0KCTwvc3R5bGU+Cgk8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCIgY2hhcnNldD0idXRmLTgiPgoJCXdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZnVu Y3Rpb24oKXsKCQkJdmFyIG5vZGVzID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnbGk6bnRo LWNoaWxkKC0zbiknKTsKCQkJZm9yICh2YXIgaT0wOyBpIDwgbm9kZXMubGVuZ3RoOyBpKyspIHsK CQkJCW5vZGVzW2ldLnN0eWxlLmJhY2tncm91bmRDb2xvciA9ICdyZWQnOwoJCQl9OwoJCX0sIHRy dWUpOwoJPC9zY3JpcHQ+CjwvaGVhZD4KCjxib2R5PgoKPHA+QWxsIGxpc3QgaXRlbXMgc2hvdWxk IGJlIGdyZWVuLjwvcD4KPHVsPgoJPGxpPjE8L2xpPgoJPGxpPjI8L2xpPgoJPGxpPjM8L2xpPgoJ PGxpPjQ8L2xpPgoJPGxpPjU8L2xpPgo8L3VsPgoKPC9ib2R5Pgo8L2h0bWw+Cg== 56213 2010-05-16 23:06:22 -0700 2010-05-17 10:52:17 -0700 Add tests for Bug 31267 - :nth-child(-2n) should match no element. bug-31267-20100516230620.patch text/plain 2269 yuzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NmY0OTMzYzBlNDFiZmZjODMzOTA0OTM0YzAyZWFiNTIyOWM1YmQwLi5mODRkNGNj M2QyYjgzMjFkNzc0NjBjZmFkOGVhMzEwMTMwMjhlODM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDUtMTYgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0cyBmb3IgQnVn IDMxMjY3IC0gOm50aC1jaGlsZCgtMm4pIHNob3VsZCBtYXRjaCBubyBlbGVtZW50LgorICAgICAg ICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81ODMwMCBoYXMgZml4ZWQgdGhpcyBh bHJlYWR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzEyNjcKKworICAgICAgICAqIGZhc3QvY3NzL250aC1jaGlsZC1uZWdhdGl2ZS1hLXBhcmFtLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvbnRoLWNoaWxkLW5lZ2F0aXZl LWEtcGFyYW0uaHRtbDogQWRkZWQuCisKIDIwMTAtMDUtMTMgIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL250aC1jaGlsZC1uZWdhdGl2ZS1hLXBhcmFtLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL250aC1jaGlsZC1uZWdhdGl2ZS1hLXBhcmFt LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yYjI2NTdmZGUzM2E2MmZjM2QyZDM1NDI4NzMyZDNl ZTYyODA3ZTFhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbnRoLWNo aWxkLW5lZ2F0aXZlLWEtcGFyYW0tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorRmlyc3QK K1NlY29uZAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbnRoLWNoaWxk LW5lZ2F0aXZlLWEtcGFyYW0uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL250aC1jaGlsZC1u ZWdhdGl2ZS1hLXBhcmFtLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTM5YWM3MDU2YzJlZWYxZDU0MWU1MDli NGMyNjE5ZmVlYmUxMjI0OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L250aC1jaGlsZC1uZWdhdGl2ZS1hLXBhcmFtLmh0bWwKQEAgLTAsMCArMSw0MiBAQAorPCFkb2N0 eXBlIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPlRlc3QgZm9yIEJ1ZyAzMTI2NyAtIDpu dGgtY2hpbGQoLTJuKSBzaG91bGQgbWF0Y2ggbm8gZWxlbWVudDwvdGl0bGU+Cis8c3R5bGU+Cits aSB7CisgICAgY29sb3I6Z3JlZW47Cit9CitsaTpudGgtY2hpbGQoLTFuKSB7CisgICAgY29sb3I6 cmVkOworfQorbGk6bnRoLWNoaWxkKC0ybikgeworICAgIGNvbG9yOnJlZDsKK30KKzwvc3R5bGU+ Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHZh ciBtZXNzYWdlID0gIkZBSUwiOworICAgIHZhciBjb2xvciA9ICJyZWQiOworICAgIGlmIChkb2N1 bWVudC5xdWVyeVNlbGVjdG9yQWxsKCJsaTpudGgtY2hpbGQoLTFuKSIpLmxlbmd0aCA9PSAwICYm IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoImxpOm50aC1jaGlsZCgtMm4pIikubGVuZ3RoID09 IDApIHsKKyAgICAgICAgbWVzc2FnZSA9ICJQQVNTIjsKKyAgICAgICAgY29sb3IgPSAiZ3JlZW4i OworICAgIH0KKyAgICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3Vs dCIpOworICAgIHJlc3VsdC5pbm5lckhUTUwgPSBtZXNzYWdlOworICAgIHJlc3VsdC5zdHlsZS5j b2xvciA9IGNvbG9yOworfQorPC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Cis8b2w+ Cis8bGk+Rmlyc3Q8L2xpPgorPGxpPlNlY29uZDwvbGk+Cis8L29sPgorPGRpdiBpZD0icmVzdWx0 Ij4KK1Rlc3QgZGlkbid0IHJ1bgorPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==