31250 2009-11-08 20:18:06 -0800 Make XP_UNIX tests consistent 2009-11-09 11:26:32 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 161481 0 laszlo.gombos 2009-11-08 20:18:06 -0800 QtWebKit on Mac reports the following warning: WebCore/plugins/PluginView.cpp:130:7: warning: "XP_UNIX" is not defined This is because the test is testing the value of the XP_UNIX macro instead of testing weather it is defined or not. I think we should make the XP_UNIX test consistent. Patch will follow. 161482 1 42729 laszlo.gombos 2009-11-08 20:25:21 -0800 Created attachment 42729 proposed patch 161525 2 42729 jmalonzo 2009-11-09 01:20:25 -0800 Comment on attachment 42729 proposed patch r=me. 161669 3 42729 commit-queue 2009-11-09 11:26:28 -0800 Comment on attachment 42729 proposed patch Clearing flags on attachment: 42729 Committed r50670: <http://trac.webkit.org/changeset/50670> 161670 4 commit-queue 2009-11-09 11:26:32 -0800 All reviewed patches have been landed. Closing bug. 42729 2009-11-08 20:25:21 -0800 2009-11-09 11:26:28 -0800 proposed patch 31250.patch text/plain 2604 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMTEtMDggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1ha2UgWFBfVU5JWCB0ZXN0cyBjb25zaXN0ZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTI1MAorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBhcyB0aGVyZSBpcyBubyBmdW5jdGlvbmFsIGNoYW5nZS4KKworICAgICAgICAqIHBsdWdpbnMv UGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXRGcmFtZVJl Y3QpOiBUZXN0IGlmIFhQX1VOSVggaXMgZGVmaW5lZAorICAgICAgICBpbnN0ZWFkIG9mIHRoZSB2 YWx1ZSBvZiB0aGUgbWFjcm8KKworICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCk6 IFRlc3QgaWYgdGhlIFhQX1VOSVggaXMKKyAgICAgICAgZGVmaW5lZCBpbnN0ZWFkIG9mIHVzaW5n IHRoZSBQTEFURk9STSBtYWNybyB0byBiZSBjb25zaXN0ZW50CisgICAgICAgIChXZWJDb3JlOjpQ bHVnaW5WaWV3OjpnZXRWYWx1ZSk6IERpdHRvLgorCiAyMDA5LTExLTA4ICBLZW50IFRhbXVyYSAg PHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAJKHJldmlzaW9uIDUwNjI4KQorKysgV2ViQ29yZS9w bHVnaW5zL1BsdWdpblZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjcsNyArMTI3LDcgQEAg dm9pZCBQbHVnaW5WaWV3OjpzZXRGcmFtZVJlY3QoY29uc3QgSW50UgogI2lmIFBMQVRGT1JNKFdJ Tl9PUykgfHwgUExBVEZPUk0oU1lNQklBTikKICAgICAvLyBPbiBXaW5kb3dzIGFuZCBTeW1iaWFu LCBhbHdheXMgY2FsbCBwbHVnaW4gdG8gY2hhbmdlIGdlb21ldHJ5LgogICAgIHNldE5QV2luZG93 UmVjdChyZWN0KTsKLSNlbGlmIFhQX1VOSVgKKyNlbGlmIGRlZmluZWQoWFBfVU5JWCkKICAgICAv LyBPbiBVbml4LCBtdWx0aXBsZSBjYWxscyB0byBzZXROUFdpbmRvdygpIGluIHdpbmRvd2VkIG1v ZGUgY2F1c2VzIEZsYXNoIHRvIGNyYXNoCiAgICAgaWYgKG1fbW9kZSA9PSBOUF9GVUxMIHx8ICFt X2lzV2luZG93ZWQpCiAgICAgICAgIHNldE5QV2luZG93UmVjdChyZWN0KTsKSW5kZXg6IFdlYkNv cmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkocmV2aXNpb24gNTA2MjgpCisrKyBXZWJDb3Jl L3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjcsNyAr MjI3LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkKIAogICAgIEd0 a0FsbG9jYXRpb24gYWxsb2NhdGlvbiA9IHsgbV93aW5kb3dSZWN0LngoKSwgbV93aW5kb3dSZWN0 LnkoKSwgbV93aW5kb3dSZWN0LndpZHRoKCksIG1fd2luZG93UmVjdC5oZWlnaHQoKSB9OwogICAg IGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZShwbGF0Zm9ybVBsdWdpbldpZGdldCgpLCAmYWxsb2Nh dGlvbik7Ci0jaWYgUExBVEZPUk0oWFBfVU5JWCkKKyNpZiBkZWZpbmVkKFhQX1VOSVgpCiAgICAg aWYgKCFtX25lZWRzWEVtYmVkKSB7CiAgICAgICAgIGd0a194dGJpbl9zZXRfcG9zaXRpb24oR1RL X1hUQklOKHBsYXRmb3JtUGx1Z2luV2lkZ2V0KCkpLCBtX3dpbmRvd1JlY3QueCgpLCBtX3dpbmRv d1JlY3QueSgpKTsKICAgICAgICAgZ3RrX3h0YmluX3Jlc2l6ZShwbGF0Zm9ybVBsdWdpbldpZGdl dCgpLCBtX3dpbmRvd1JlY3Qud2lkdGgoKSwgbV93aW5kb3dSZWN0LmhlaWdodCgpKTsKQEAgLTMz Miw3ICszMzIsNyBAQCBOUEVycm9yIFBsdWdpblZpZXc6OmdldFZhbHVlKE5QTlZhcmlhYmxlCiAg ICAgICAgIHJldHVybiBOUEVSUl9HRU5FUklDX0VSUk9SOwogI2VuZGlmCiAKLSNpZiBQTEFURk9S TShYUF9VTklYKQorI2lmIGRlZmluZWQoWFBfVU5JWCkKICAgICBjYXNlIE5QTlZ4dEFwcENvbnRl eHQ6CiAgICAgICAgIGlmICghbV9uZWVkc1hFbWJlZCkgewogICAgICAgICAgICAgKih2b2lkICoq KXZhbHVlID0gWHREaXNwbGF5VG9BcHBsaWNhdGlvbkNvbnRleHQgKEdUS19YVEJJTihwbGF0Zm9y bVBsdWdpbldpZGdldCgpKS0+eHRjbGllbnQueHRkaXNwbGF5KTsK