31242 2009-11-08 11:10:55 -0800 Web Inspector: [REGRESSION] committing style edit clears elements panel selection. 2009-11-08 11:48:07 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 161441 0 pfeldman 2009-11-08 11:10:55 -0800 Three real regressions here: 1) Committing style edit clears selection 2) Editing selector style refreshes elements panel (should not) 3) Traversing dom tree makes styles sidebar flicker. Attaching patch shortly. 161442 1 42716 pfeldman 2009-11-08 11:19:02 -0800 Created attachment 42716 [PATCH] fixes 161448 2 pfeldman 2009-11-08 11:48:07 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/StylesSidebarPane.js Committed r50627 42716 2009-11-08 11:19:02 -0800 2009-11-08 11:34:41 -0800 [PATCH] fixes styles_regressions text/plain 2502 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDQ0MDVlYy4uZjAxMzkxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMS0wOCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0gY29tbWl0dGlu ZyBzdHlsZSBlZGl0CisgICAgICAgIGNsZWFycyBlbGVtZW50cyBwYW5lbCBzZWxlY3Rpb24uCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMjQyCisK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5cGUudXBkYXRl KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUu KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90 eXBlKToKKwogMjAwOS0xMS0wNSAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IDhkNzFmNWEu LmQyZWQyNGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50 c1RyZWVPdXRsaW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50 c1RyZWVPdXRsaW5lLmpzCkBAIC0xMDQsNiArMTA0LDggQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRz VHJlZU91dGxpbmUucHJvdG90eXBlID0gewogCiAgICAgdXBkYXRlOiBmdW5jdGlvbigpCiAgICAg eworICAgICAgICB2YXIgc2VsZWN0ZWROb2RlID0gdGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50ID8g dGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0IDogbnVsbDsKKwogICAg ICAgICB0aGlzLnJlbW92ZUNoaWxkcmVuKCk7CiAKICAgICAgICAgaWYgKCF0aGlzLnJvb3RET01O b2RlKQpAQCAtMTI1LDcgKzEyNyw4IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5l LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAgIHRoaXMu dXBkYXRlU2VsZWN0aW9uKCk7CisgICAgICAgIGlmIChzZWxlY3RlZE5vZGUpCisgICAgICAgICAg ICB0aGlzLnJldmVhbEFuZFNlbGVjdE5vZGUoc2VsZWN0ZWROb2RlKTsKICAgICB9LAogCiAgICAg dXBkYXRlU2VsZWN0aW9uOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggYTk1ZGFlMy4uY2FmM2E1MyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAt OTMsMTMgKzkzLDEyIEBAIFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICBub2RlID0gdGhpcy5ub2RlOwogCiAgICAgICAgIHZhciBib2R5ID0g dGhpcy5ib2R5RWxlbWVudDsKLSAgICAgICAgaWYgKCFyZWZyZXNoIHx8ICFub2RlKSB7CisKKyAg ICAgICAgaWYgKCFub2RlKSB7CiAgICAgICAgICAgICBib2R5LnJlbW92ZUNoaWxkcmVuKCk7CiAg ICAgICAgICAgICB0aGlzLnNlY3Rpb25zID0gW107Ci0gICAgICAgIH0KLQotICAgICAgICBpZiAo IW5vZGUpCiAgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAogICAgICAgICB2YXIgc2Vs ZiA9IHRoaXM7CiAgICAgICAgIGZ1bmN0aW9uIGNhbGxiYWNrKHN0eWxlcykKQEAgLTEzNTQsNyAr MTM1Myw3IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBl ID0gewogICAgICAgICAgICAgaWYgKHVwZGF0ZUludGVyZmFjZSkKICAgICAgICAgICAgICAgICBz ZWxmLnVwZGF0ZUFsbCh0cnVlKTsKIAotICAgICAgICAgICAgaWYgKCFzZWxmLnJ1bGUpCisgICAg ICAgICAgICBpZiAoIXNlY3Rpb24ucnVsZSkKICAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iu cGFuZWxzLmVsZW1lbnRzLnRyZWVPdXRsaW5lLnVwZGF0ZSgpOwogICAgICAgICB9CiAK