31234 2009-11-07 19:36:02 -0800 Make tests http/tests/misc/isindex-with-no-form-base-href.html and isindex-with-no-form.html work using DOM keyboard events 2023-06-03 21:31:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED WONTFIX P2 Normal --- 16735 1 dbates webkit-unassigned ahmad.saleem792 andersca ap aroben bdakin darin dbates vicki oldest_to_newest 161390 0 dbates 2009-11-07 19:36:02 -0800 Following up from bug #30491, we should make the test cases: http/tests/misc/isindex-with-no-form-base-href.html http/tests/misc/isindex-with-no-form.html work without using DRT's EventSender. Instead, we should rewrite these tests to use DOM keyboard events. 163706 1 43241 dbates 2009-11-14 21:52:12 -0800 Created attachment 43241 Example Example. Tries to programmatically fire a keypress DOM KeyboardEvent at an HTMLInputElement with keyIdentifier = "Enter" to submit the form (that is, to simulate what equivalent action when the user gives the input focus and then presses the Return/Enter key on the keyboard) 163707 2 dbates 2009-11-14 21:52:55 -0800 Using a debugger to trace the execution of DOM KeyboardEvents, we need to fix bug #16735 in order to fix this bug. Running the attachment Example <https://bugs.webkit.org/attachment.cgi?id=43241>, we see that the call flow is as follows (*): WebCore::jsNodePrototypeFunctionDispatchEvent->EventTarget::dispatchEvent->Node::dispatchEvent->Node::dispatchGenericEvent->HTMLInputElement::defaultEventHandler By line 1412 of HTMLInputElement.cpp <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLInputElement.cpp?rev=50996#L1412>, we call KeyboardEvent::charCode(). Notice, this KeyboardEvent was generated programmatically by JavaScript (as opposed to a physical key press). Hence, this KeyboardEvent has no associated PlatformKeyboardEvent (i.e. KeyboardEvent::m_keyEvent == null). And by line 138 of KeyboardEvent.cpp <http://trac.webkit.org/browser/trunk/WebCore/dom/KeyboardEvent.cpp?rev=38094#L138> method KeyboardEvent::charCode returns 0 if !KeyboardEvent::m_keyEvent. So, for this example, KeyboardEvent::charCode always returns 0. Therefore, we cannot resolve this bug until we resolve bug #16735. For completeness, before executing (*), the DOM keyboard event is first instantiated via the following call flow: WebCore::jsDocumentPrototypeFunctionCreateEvent->Document::createEvent->KeyboardEvent::create->KeyboardEvent::KeyboardEvent() Note, specifically the constructor KeyboardEvent::KeyboardEvent() is called. Hence, m_keyEvent := 0. Then, the DOM keyboard event is initialized via the call flow: WebCore::jsKeyboardEventPrototypeFunctionInitKeyboardEvent->KeyboardEvent::initKeyboardEvent 1959741 3 ahmad.saleem792 2023-06-03 21:31:16 -0700 'isindex' is removed and now historical. https://github.com/WebKit/WebKit/commit/c92f223d57abd60e7bc682985a103744f3760672 WPT test showing it as historical - http://wpt.live/html/semantics/forms/historical.html and both of these tests are now removed (in above commit). So marking this as 'RESOLVED WONTFIX'. 43241 2009-11-14 21:52:12 -0800 2009-11-14 21:52:12 -0800 Example keyeventTest.html text/html 2185 dbates PGh0bWw+CjxoZWFkPgo8Ym9keT4KPHA+T24gbG9hZGluZyB0aGlzIHBhZ2UsIHRoZSBmb3JtIChi ZWxvdykgc2hvdWxkIGJlIGF1dG9tYXRpY2FsbHkgc3VibWl0dGVkIHZpYSBhIHNpbXVsYXRlZCBr ZXkgcHJlc3Mgb2YgdGhlIGVudGVyIGtleS4gT24gc3VjY2VzcywgeW91IHNob3VsZCBzZWUgdGhl IGFsZXJ0ICJUZXN0IHBhc3NlZC4iIElmIHlvdSBkbyBub3Qgc2VlIGFuIGFsZXJ0LCB0aGVuIHRo ZSB0ZXN0IGZhaWxlZC48L3A+CjxwPkZvciBjb21wYXJpc29uLCB0cnkgbWFudWFsbHkgc3VibWl0 dGluZyB0aGlzIGZvcm0uIFRoZW4gY29tcGFyZSB0aGUgY2FwdHVyZWQga2V5IGV2ZW50IG9mIHRo aXMgc3VibWlzc2lvbiB0byB0aGUgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQgb25lLiBUaGV5IHNo b3VsZCBiZSB0aGUgc2FtZS48L3A+Cjxmb3JtIGFjdGlvbj0iamF2YXNjcmlwdDphbGVydCgnVGVz dCBwYXNzZWQuJykiPgogICAgPGlucHV0IGlkPSJxIiB0eXBlPSJ0ZXh0IiBuYW1lPSJxIiB2YWx1 ZT0iVGhpcyBpcyBhIHRlc3QiLz4KPC9mb3JtPgo8Yj5LZXlFdmVudHMgY2FwdHVyZWQ6PC9iPgo8 ZGl2IGlkPSJyZXN1bHQiPjwvZGl2Pgo8c2NyaXB0Pgp2YXIgcmV0dXJuS2V5Q29kZSA9IDEzOyAv LyBBU0NJSSBrZXkgY29kZSBmb3IgY2FycmlhZ2UgcmV0dXJuLgp2YXIgZmllbGQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgicSIpOwpmaWVsZC5hZGRFdmVudExpc3RlbmVyKCJrZXlwcmVzcyIs IGtleWV2ZW50LCB0cnVlKTsKCnZhciBrZXlQcmVzc0V2ZW50ID0gZG9jdW1lbnQuY3JlYXRlRXZl bnQoJ0tleWJvYXJkRXZlbnQnKTsKCmlmIChrZXlQcmVzc0V2ZW50LmluaXRLZXlFdmVudCkgewog ICAgLy8gVGhpcyBpcyB0aGUgTW96aWxsYS9GaXJlZm94IEFQSSwgc2VlIDxodHRwczovL2RldmVs b3Blci5tb3ppbGxhLm9yZy9lbi9ET00vZXZlbnQuaW5pdEtleUV2ZW50Pi4KICAgIGtleVByZXNz RXZlbnQuaW5pdEtleUV2ZW50KCJrZXlwcmVzcyIsIHRydWUsIHRydWUsIGRvY3VtZW50LmRlZmF1 bHRWaWV3LCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgcmV0dXJuS2V5Q29kZSwgMCk7Cn0g ZWxzZSBpZiAoa2V5UHJlc3NFdmVudC5pbml0S2V5Ym9hcmRFdmVudCkgewogICAgLy8gVGhpcyBp cyBhIHF1YXNpLVczQyBET00gTGV2ZWwgMyBBUEkuIFdoeSAicXVhc2kiPyBCZWNhdXNlIEkgY2Fu bm90IGZpbmQgdGhpcyBmdW5jdGlvbiBwcm90b3R5cGUgaW4gdGhlIFczQyBET00gTGV2ZWwgMyBz cGVjCiAgICAvLyAoaHR0cDovL3d3dy53My5vcmcvVFIvRE9NLUxldmVsLTMtRXZlbnRzLyNldmVu dHMtRXZlbnRzLUtleWJvYXJkRXZlbnQtaW5pdEtleWJvYXJkRXZlbnQpLCBzZWUgYnVnICMxMzM2 OC4gSSBmb3VuZCB0aGlzIAogICAgLy8gZnVuY3Rpb24gcHJvdG90eXBlIGluIGZpbGUgZmFzdC9m b3Jtcy9pbnB1dC10ZXh0LWVudGVyLmh0bWwuCiAgICAvLwogICAgLy8gRklYTUU6IEtleWJvYXJk RXZlbnRzIGRvIG5vdCB3b3JrIGluIFdlYktpdCwgc2VlIGJ1ZyAjMTY3MzUuIFVudGlsIHdlIGNv cnJlY3QgdGhpcyBidWcsIHRoaXMgZXZlbnQgZG9lcyBub3Qgd29yay4KICAgIGtleVByZXNzRXZl bnQuaW5pdEtleWJvYXJkRXZlbnQoImtleXByZXNzIiwgdHJ1ZSwgdHJ1ZSwgZG9jdW1lbnQuZGVm YXVsdFZpZXcsICJFbnRlciIsIDAsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSk7 Cn0KZmllbGQuZGlzcGF0Y2hFdmVudChrZXlQcmVzc0V2ZW50KTsKCmZ1bmN0aW9uIGtleWV2ZW50 KGV2ZW50KSB7CiAgICB2YXIgcCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInAiKTsKICAgIHAu YXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZXZlbnQudHlwZSArICIgLSBrZXk6 ICIgKyBldmVudC5rZXlJZGVudGlmaWVyICsgIkAiICsgZXZlbnQua2V5TG9jYXRpb24gKyAiIChr ZXlDb2RlL2NoYXJDb2RlOiAiICsgZXZlbnQua2V5Q29kZSArICIvIiArIGV2ZW50LmNoYXJDb2Rl ICsgIikiICsgIiBtb2RpZmllcnM6ICIgKyBldmVudC5jdHJsS2V5ICsgIiwiICsgZXZlbnQuYWx0 S2V5ICsgIiwiICsgZXZlbnQuc2hpZnRLZXkgKyAiLCIgKyBldmVudC5tZXRhS2V5KSk7CiAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuYXBwZW5kQ2hpbGQocCk7Cn0KPC9zY3Jp cHQ+CjwvYm9keT4KPC9odG1sPg==